summaryrefslogtreecommitdiffstats
path: root/content/browser/device_orientation
Commit message (Collapse)AuthorAgeFilesLines
* Move in_process_browser_test and ui_test_utils to chrome/test/basephajdan.jr@chromium.org2011-07-291-2/+2
| | | | | | | BUG=90905 Review URL: http://codereview.chromium.org/7532034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94720 0039d316-1c4b-4281-b951-d872f2087c98
* Updated accelerometer note.avi@chromium.org2011-07-211-1/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7471040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93434 0039d316-1c4b-4281-b951-d872f2087c98
* roll clang 131935:132017thakis@chromium.org2011-06-081-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | clang recently added a warning that warns when invoking 'delete' on a polymorphic non-final class without a virtual destructor. This finds real bugs – see the bug referenced below for a few examples. However, one common pattern where it fires is this case: class SomeInterface { public: virtual void interfaceMethod() {} // or = 0; protected: ~SomeInterface() {} } class WorkerClass : public SomeInterface { public: // many non-virtual functions, but also: virtual void interfaceMethod() override { /* do actual work */ } }; void f() { scoped_ptr<WorkerClass> c(new WorkerClass); // simplified example } (See the 2nd half of http://www.gotw.ca/publications/mill18.htm for an explanation of this pattern.) It is arguably correct to fire the warning here, since someone might make a subclass of WorkerClass and replace |new WorkerClass| with |new WorkerClassSubclass|. This would be broken since WorkerClass doesn't have a virtual destructor. The solution that the clang folks recommend is to mark WorkerClass as |final| (a c++0x keyword that clang supports as an extension in normal c++ mode – like override). But chrome's base/OWNERS deemed that as too complicated and we decided to make virtual the destructors of leaf classes that implement these interfaces and that are deleted dynamically. All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs). (For the gtk files, this is necessary because the CHROMEGTK_CALLBACK_ macros add virtual functions.) BUG=84424 TEST=none Review URL: http://codereview.chromium.org/7087028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88270 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure no chrome includes in content\common and content\ppapi_plugin. Also ↵jam@chromium.org2011-04-182-1/+7
| | | | | | | | tighten a little in device_orientation. Review URL: http://codereview.chromium.org/6883022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82001 0039d316-1c4b-4281-b951-d872f2087c98
* New Mac accelerometer data from thakis.avi@chromium.org2011-04-011-4/+5
| | | | | | | | | BUG=none TEST=test on MacBook5,1 Review URL: http://codereview.chromium.org/6788011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80170 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS file for content/browser/device_orientation.hans@chromium.org2011-03-301-0/+3
| | | | | | | | | | | hans@, bulach@, and leandro@ can review changes to device orientation. BUG=none TEST=none Review URL: http://codereview.chromium.org/6772003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79805 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-285-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Move geolocation, desktop notification, and device orientation into their ↵jam@chromium.org2011-03-191-8/+5
| | | | | | | | | own message files.Also fix a regression from my earlier change to create a plugin through the embedder API. The fix is to not to create a plugin if the embedder returns NULL, and just have the default implementation create the plugin on its own.TBR=avi R=brettw@chromium.org,johnnyg@chromium.org,darin@chromium.org,*,jam@chromium.org,ben@chromium.org Review URL: http://codereview.chromium.org/6688054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78832 0039d316-1c4b-4281-b951-d872f2087c98
* New accelerometer data from Raul Cuza.avi@chromium.org2011-03-171-2/+4
| | | | | | | | | BUG=none TEST=on a MacBookPro1,2 Review URL: http://codereview.chromium.org/6672074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78539 0039d316-1c4b-4281-b951-d872f2087c98
* New accelerometer data for MacBook5,2 from Adam Gerson.avi@chromium.org2011-03-111-1/+3
| | | | | | | | | BUG=none TEST=test on a MacBook5,2 Review URL: http://codereview.chromium.org/6682004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77828 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some coverity defects (mostly pass by value).estade@chromium.org2011-03-112-2/+3
| | | | | | | | | | CID=15414,15415,15413,15412,15402,14582,13684,12723,15407,14785,14511,13975,13647,11655,10891,9103,8402,8394,10924,8497,others BUG=none TEST=trybots Review URL: http://codereview.chromium.org/6665012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77740 0039d316-1c4b-4281-b951-d872f2087c98
* Code to distinguish the Pro3,1 17" from the Pro 3,1 15", mild cleanup.avi@chromium.org2011-03-031-48/+75
| | | | | | | | | BUG=none TEST=should still work on all machines, correctly on a Pro3,1 17" Review URL: http://codereview.chromium.org/6609020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76817 0039d316-1c4b-4281-b951-d872f2087c98
* Update accelerometer data with confirmed entries for the new MacBooks, and ↵avi@chromium.org2011-02-251-3/+11
| | | | | | | | | | | preliminary info for the 17" Pro3,1. BUG=none TEST=on the new laptops Review URL: http://codereview.chromium.org/6597007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76087 0039d316-1c4b-4281-b951-d872f2087c98
* Move appcache/file_sytem/device_orientation subdirectories of chrome\browser ↵jam@chromium.org2011-02-2412-0/+1577
to content\browser. TBR=avi Review URL: http://codereview.chromium.org/6586001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75990 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 11:42:29 +0000