summaryrefslogtreecommitdiffstats
path: root/content/browser/download
Commit message (Collapse)AuthorAgeFilesLines
* Revert 117078 - Move creation and ownership of ResourceDispatcherHost and ↵jam@chromium.org2012-01-103-17/+20
| | | | | | | | | | | | | | | | | | | PluginService to content. This gives a few benefits: -avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads) -avoid having to tell embedders about specifics of BrowserThread startup/shutdown -move ResourceDispatcherHost's getter to content where it belongs Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead. I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure. BUG=98716 Review URL: http://codereview.chromium.org/9150016 TBR=jam@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117096 0039d316-1c4b-4281-b951-d872f2087c98
* Move creation and ownership of ResourceDispatcherHost and PluginService to ↵jam@chromium.org2012-01-103-20/+17
| | | | | | | | | | | | | | | | | content. This gives a few benefits: -avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads) -avoid having to tell embedders about specifics of BrowserThread startup/shutdown -move ResourceDispatcherHost's getter to content where it belongs Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead. I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure. BUG=98716 Review URL: http://codereview.chromium.org/9150016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117078 0039d316-1c4b-4281-b951-d872f2087c98
* Make DownloadManagerImpl's destruction not tied to the UI thread.rdsmith@chromium.org2012-01-092-8/+7
| | | | | | | | | | | | | | | | | | This is intended to fix the various leaks involving the DownloadManager; if the classes destruction is tied to the UI thread and the class is destroyed at Profile destruction (which it is) it will be leaked because the UI thread no longer exists at profile destruction. BUG=100146 BUG=58449 BUG=102255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116385 Review URL: http://codereview.chromium.org/8907002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116942 0039d316-1c4b-4281-b951-d872f2087c98
* Using VLOG instead of DVLOG to display BaseFile errors.ahendrickson@chromium.org2012-01-091-3/+3
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/9109040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116930 0039d316-1c4b-4281-b951-d872f2087c98
* Facilitate disabling the debugging checks in download_database.cc and ↵benjhayden@chromium.org2012-01-091-17/+23
| | | | | | | | | | download_manager_impl.cc. Don't disable them until after the next dev cycle, when we should have some more debugging information. Disabling them will probably move them somewhere else, hopefully both yielding even more debugging information and preventing unnecessary crashes on stable/beta. Review URL: http://codereview.chromium.org/8965004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116921 0039d316-1c4b-4281-b951-d872f2087c98
* Remove task.h and finish base::Bind() migration.ajwong@chromium.org2012-01-062-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Over 341 CLs, in ~3 months, touching 3251 unique files! Top 5 most CLs: (121) jhawkins ( 45) dcheng ( 24) achuith ( 23) csilv ( 12) tfarina ( 12) groby ~1000 files touched: (918) jhawkins 100+ files touched: (486) ajwong (385) willchan (372) dcheng (126) csilv (123) fischman (112) sergeyu 49+ files touched: (65) tfarina (57) acolwell (52) adamk (49) tzik BUG=35223 TEST=existing Review URL: http://codereview.chromium.org/9114020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup parameter passing issues in content/browser/downloadasanka@chromium.org2012-01-064-12/+12
| | | | | | | | | | | | CID=102857, 102858 BUG=none TEST=none Review URL: http://codereview.chromium.org/9108024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116734 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 116385 - Make DownloadManagerImpl's destruction not tied to the UI ↵rdsmith@chromium.org2012-01-042-9/+10
| | | | | | | | | | | | | | | | | | | | | thread. This is intended to fix the various leaks involving the DownloadManager; if the classes destruction is tied to the UI thread and the class is destroyed at Profile destruction (which it is) it will be leaked because the UI thread no longer exists at profile destruction. BUG=100146 BUG=58449 BUG=102255 Review URL: http://codereview.chromium.org/8907002 TBR=rdsmith@chromium.org Review URL: http://codereview.chromium.org/9030038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116411 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of tab_contents.h includes from chrome. These are all ↵jam@chromium.org2012-01-044-5/+10
| | | | | | | | | trivial changes to use WebContents instead of TabContents. BUG=98716 Review URL: http://codereview.chromium.org/9030032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116392 0039d316-1c4b-4281-b951-d872f2087c98
* Make DownloadManagerImpl's destruction not tied to the UI thread.rdsmith@chromium.org2012-01-042-10/+9
| | | | | | | | | | | | | | | | This is intended to fix the various leaks involving the DownloadManager; if the classes destruction is tied to the UI thread and the class is destroyed at Profile destruction (which it is) it will be leaked because the UI thread no longer exists at profile destruction. BUG=100146 BUG=58449 BUG=102255 Review URL: http://codereview.chromium.org/8907002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116385 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the remaining Browser::GetSelectedTabContents() calls to ↵jam@chromium.org2012-01-039-18/+24
| | | | | | | | | | GetSelectedWebContents, and update all dependent code. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9074012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116226 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Remove ScopedRunnableMethodFactory.jhawkins@chromium.org2012-01-032-10/+5
| | | | | | | | | | BUG=none TEST=none R=groby,awong,csilv Review URL: http://codereview.chromium.org/9071001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116198 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most of Browser::GetSelectedTabContents calls into ↵jam@chromium.org2012-01-033-10/+16
| | | | | | | | | | | | Browser::GetSelectedWebContents. I've converted the easy ones, I'll do the ones with more dependencies in a separate change to keep things trivial to review. I considered taking out GetSelectedTabContents altogether and having people just use GetSelectedTabContentsWrapper()->web_contents() per the existing comment in browser.h, but there are a lot of callers and it seemed too long to type. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9015022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116122 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DeleteTask and convert remaining users.dcheng@chromium.org2012-01-021-1/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/9015021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116107 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome users of NavigationController::tab_contents() to use ↵jam@chromium.org2012-01-024-8/+8
| | | | | | | | | | GetWebContents() instead. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8986009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116086 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all of the WebContentsDelegate to use WebContents instead of ↵jam@chromium.org2011-12-281-1/+2
| | | | | | | | | | TabContents, and update all the dependent code. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9008047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115932 0039d316-1c4b-4281-b951-d872f2087c98
* Rename NavigationController to NavigationControllerImpl and put it into the ↵jam@chromium.org2011-12-281-1/+2
| | | | | | | | | | content namespace. Also make all users of content::NavigationController interface use the "using" keyword so they don't have to put content:: everywhere (similar to other Content API and WebKit API classes). BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8956059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115916 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a few methods in NavigationController to return a ↵jam@chromium.org2011-12-281-2/+2
| | | | | | | | | | content::NavigationEntry, in preparation for creating an interface around NavigationController. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9008034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115872 0039d316-1c4b-4281-b951-d872f2087c98
* Move the PageNavigator interface and GlobalRequestID struct to ↵jam@chromium.org2011-12-282-3/+2
| | | | | | | | | | content\public and put them in the content namespace. Make PageNavigator use WebContents instead of TabContents. While I'm touching all the callers, I've removed the deprecated PageNavigator function and converted users to the new one. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8991012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115858 0039d316-1c4b-4281-b951-d872f2087c98
* Move FaviconStatus and SSLStatus out of NavigationEntry into their own files ↵jam@chromium.org2011-12-271-0/+1
| | | | | | | | | in content/public and in the content namespace. I've also made them structs instead of classes. This was because I didn't want to wrap them with Content API for what were really a collection of member variables. The one exception was SSLStatus::content_status which had helper functions around it to set and get the bitfield. Each of the two setter helpers were only called in one non-test code, and read in a few places, so I just converted them to do it directly. BUG=98716 Review URL: http://codereview.chromium.org/9048002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115847 0039d316-1c4b-4281-b951-d872f2087c98
* Made MockDownloadManagerDelegate a gmock.ahendrickson@chromium.org2011-12-272-124/+37
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/9020042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115843 0039d316-1c4b-4281-b951-d872f2087c98
* Move most of the remaining users of WebContentsObserver::tab_contents() to ↵jam@chromium.org2011-12-261-12/+12
| | | | | | | | | | use web_contents(). BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9030010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115800 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch of WebContentsObservers to use web_contents() instead of ↵jam@chromium.org2011-12-252-3/+6
| | | | | | | | | | tab_contents(), as well as all the dependent code. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8982008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115777 0039d316-1c4b-4281-b951-d872f2087c98
* Create a Content API around NavigationEntry that's in ↵jam@chromium.org2011-12-251-1/+1
| | | | | | | | | | content/public/browser. NavigationEntry will be renamed to NavigationEntryImpl in a later change. It now derives from content::NavigationEntry. Most of this change is changing unix_hacker functions to CamelCase and updating callers. BUG=98716 TBR=brettw Review URL: http://codereview.chromium.org/9007043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115766 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix unchecked return valueskmadhusu@chromium.org2011-12-221-2/+4
| | | | | | | | | | | CID=102071, 101911, 101898, 101662, 101661, 101234, 101030, 100914, 100886, 100537 BUG=none TEST=none TBR=johnme@chromium.org, piman@chromium.org Review URL: http://codereview.chromium.org/9004038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115603 0039d316-1c4b-4281-b951-d872f2087c98
* Move TabContentsObserver to content/public, rename it to ↵jam@chromium.org2011-12-222-8/+7
| | | | | | | | | | WebContentsObserver, and put it into the content namespace. BUG=98716 TBR=tburkard Review URL: http://codereview.chromium.org/9026011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115599 0039d316-1c4b-4281-b951-d872f2087c98
* In order to resume a download some more information needs to be gathered.ahendrickson@chromium.org2011-12-2228-160/+467
| | | | | | | | | | | | | | | | | | This CL adds member data to classes to support this. It is the first of several CLs to implement download resumption. In addition hash information is propagated from DownloadFile to DownloadItem, because a new DownloadFile will be created when the download is resumed. It will also need to be persisted in order to resume across chrome runs. The plan is that data will be collected in DownloadResourceHandler::OnResponseStarted() and passed down to DownloadItem. On resume, it will pass the information from the resuming DownloadItem to ResourceDispatcherHost::BeginDownload(), which will set any required headers. BUG= 7648 TEST=None Review URL: http://codereview.chromium.org/8404049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115573 0039d316-1c4b-4281-b951-d872f2087c98
* Move the remaining TabContents methods to the WebContents interface, ↵jam@chromium.org2011-12-222-4/+5
| | | | | | | | | | switching unix_hacker to CamelCase as necessary. I've moved the WebContents definitions to be in the same order as the declarations. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8958003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115560 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a NULL check typo in DownloadBuffer.thestig@chromium.org2011-12-221-1/+1
| | | | | | | | | | CID=101516,101809 BUG=none TEST=none Review URL: http://codereview.chromium.org/9005019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115521 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::browser_context() to GetBrowserContext and put it into ↵jam@chromium.org2011-12-213-6/+7
| | | | | | | | | the WebContents interface. BUG=98716 Review URL: http://codereview.chromium.org/9021022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115435 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 115346. The change didn't break anything, the test was faulty. Will ↵jam@chromium.org2011-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | disable in a followup. - Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 TBR=thakis@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115428 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_teststhakis@chromium.org2011-12-211-1/+1
| | | | | | | | | | | | | | | | on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115346 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::controller() to GetController and put it into the ↵jam@chromium.org2011-12-211-1/+1
| | | | | | | | | | WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115276 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::render_view_host() to GetRenderViewHost and put it into ↵jam@chromium.org2011-12-203-3/+3
| | | | | | | | | the WebContents interface. BUG=98716 Review URL: http://codereview.chromium.org/9007026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115200 0039d316-1c4b-4281-b951-d872f2087c98
* Rename DownloadItem::BrowserContext to GetBrowserContext, to match other ↵jam@chromium.org2011-12-207-22/+11
| | | | | | | | getters in interfaces. This also comes up because without the Get, we have a redundant "content::" in the interface. Review URL: http://codereview.chromium.org/9006013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115169 0039d316-1c4b-4281-b951-d872f2087c98
* Move DownloadFile/DownloadItem/DownloadManager interfaces into ↵jam@chromium.org2011-12-2037-918/+272
| | | | | | | | | content/public/browser, and also put them into the content namespace. BUG=98716 Review URL: http://codereview.chromium.org/9004005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115137 0039d316-1c4b-4281-b951-d872f2087c98
* Compile fix for gcc 4.6, cast to pointer type.joi@chromium.org2011-12-191-2/+2
| | | | | | | | | TBR=benjhayden@chromium.org BUG=none Review URL: http://codereview.chromium.org/8968015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114977 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.experimental.downloads.pause(), cancel() and resume().asanka@chromium.org2011-12-161-4/+3
| | | | | | | | | | BUG=12133 TEST=browser_tests --gtest_filter=DownloadsApiTest.* Review URL: http://codereview.chromium.org/8517010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114734 0039d316-1c4b-4281-b951-d872f2087c98
* Trivial move of content::BrowserContext to content/public.joi@chromium.org2011-12-154-4/+4
| | | | | | | | | | | R=avi@chromium.org TBR=rlp@chromium.org BUG=98716 TEST= Review URL: http://codereview.chromium.org/8921021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114651 0039d316-1c4b-4281-b951-d872f2087c98
* DownloadQuery filters and sorts DownloadItemsbenjhayden@chromium.org2011-12-143-0/+918
| | | | | | | | | | | DownloadQuery will be used first by the DownloadsSearchFunction in download_extension_api.h/cc to implement the chrome.experimental.downloads.search() function outlined in http://goo.gl/6hO1n BUG=12133 TEST=content_unittests DownloadQueryTest Review URL: http://codereview.chromium.org/8601012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114460 0039d316-1c4b-4281-b951-d872f2087c98
* Make "Save As" control flow play better with safe browsing checks. ↵asanka@chromium.org2011-12-142-7/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When safe browsing is enabled, downloads that will be subject to content based checked will be marked as non-safe even when we are prompting the user for the download location. During filename determination |DownloadItem::suggested_path_| will be set to an intermediate filename for these downloads. For safe downloads, |suggested_path_| is the final download path. This patch: - Changes target filename determination when prompting for the download location in DownloadManagerImpl::RestartDownload() to use the |target_name| instead of |suggested_path_| for non-safe downloads. - Allows the target filename to be altered in DownloadItemImpl::OnPathDetermined after prompting. - Uses the previously determined intermediate filename for non-safe downloads if prompted in ChromeDownloadManagerDelegate::OverrideIntermediatePath. - Only uniquifies the target filename if it is a non-safe download for which no file selection prompts have been shown, in DownloadItemImpl::OnDownloadCompleting. BUG=106194 TEST=unit_tests --gtest_filter=DownloadManagerTest.* Review URL: http://codereview.chromium.org/8919019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114443 0039d316-1c4b-4281-b951-d872f2087c98
* Basic tests for DownloadUrl/DownloadUrlToFile.rdsmith@chromium.org2011-12-092-4/+2
| | | | | | Review URL: http://codereview.chromium.org/8487002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113864 0039d316-1c4b-4281-b951-d872f2087c98
* Added a download file factory to the download file manager, for testing.ahendrickson@chromium.org2011-12-082-7/+43
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/8770024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113658 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 110505 - Report ERR_CONTENT_LENGTH_MISMATCH when the count of bytes ↵cbentzel@chromium.org2011-12-081-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | received doesn't match Content-Length. This used to be reported as ERR_CONNECTION_CLOSED. Unfortunately, there are a number of misconfigured servers on the web which report a Content-Length completely divorced from reality. Other browsers display whatever data was received without reporting errors in this case, and Chrome now does the same. An earlier CL simply removed error reporting for this case. However, some uses may want to still treat this like an error (such as URLFetcher), or could eventually treat the case as an error and recover (such as downloads). Data received will be populated in the disk cache as a truncated entry, if the server advertises byte range support. WebURLLoaderImpl ignores this for all async and sync resource loads. At some point it may want to selectively do this based on content type. Downloads ignore the error, but no longer ignore ERR_CONNECTION_CLOSED. Other uses will treat this like an error. BUG=52847 TEST=Manually, go to a site that advertises a large content-length and closes the connection before writing so many bytes, and notice that the page now displays. Automatic: HttpNetworkTransactionTest.LargeContentLengthThenClose, URLRequestTestHttp.GetZippedTest Review URL: http://codereview.chromium.org/8496016 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/8863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113562 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented ExternalData interface on DownloadItem and used it for SafeBrowsing.rdsmith@chromium.org2011-12-074-0/+54
| | | | | | Review URL: http://codereview.chromium.org/8571023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113494 0039d316-1c4b-4281-b951-d872f2087c98
* DownloadManager intereface refactoring to allow cleaner DownloadItem unit tests.rdsmith@chromium.org2011-12-0610-205/+262
| | | | | | | | | | | BUG=101214 BUG=106490 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113007 Review URL: http://codereview.chromium.org/8697006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113277 0039d316-1c4b-4281-b951-d872f2087c98
* Add download server IP address to the SafeBrowsing download protection ping.noelutz@google.com2011-12-066-0/+16
| | | | | | | | | | BUG= TEST=No visible change. Review URL: http://codereview.chromium.org/8790006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113129 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 113007 - DownloadManager intereface refactoring to allow cleaner ↵kalman@chromium.org2011-12-0610-262/+205
| | | | | | | | | | | | | | DownloadItem unit tests. BUG=101214 Review URL: http://codereview.chromium.org/8697006 TBR=rdsmith@chromium.org Review URL: http://codereview.chromium.org/8817005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113084 0039d316-1c4b-4281-b951-d872f2087c98
* DownloadManager intereface refactoring to allow cleaner DownloadItem unit tests.rdsmith@chromium.org2011-12-0510-205/+262
| | | | | | | | | BUG=101214 Review URL: http://codereview.chromium.org/8697006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113007 0039d316-1c4b-4281-b951-d872f2087c98
* Get more information about types of images being downloaded.cbentzel@chromium.org2011-12-021-2/+44
| | | | | | | | | | | | | This adds a new enum Download.ContentImageType rather than adding additional entries to Download.ContentType. The downside is that there is a bit more code. The upside is that we don't have to worry about the image entries getting fragmented across the Download.ContentType enum, and there is a top-level entry for images in the Download.ContentType histogram to compare against other general media types. TEST=Download a few images, make sure Download.ContentType and Download.ContentImageType look sane. Review URL: http://codereview.chromium.org/8734006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112711 0039d316-1c4b-4281-b951-d872f2087c98