summaryrefslogtreecommitdiffstats
path: root/content/browser/download
Commit message (Collapse)AuthorAgeFilesLines
* Keep shelf item visible when extension install blocked off-store.aa@chromium.org2012-06-192-3/+3
| | | | | | | | | BUG=133025 TBR=yoz@chromium.org Review URL: https://chromiumcodereview.appspot.com/10559026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142885 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify DownloadResourceHandler constructor arguments.rdsmith@chromium.org2012-06-182-10/+5
| | | | | | | | | Also applies to some functions upstack from DownloadResourceHandler() Review URL: https://chromiumcodereview.appspot.com/10553009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142767 0039d316-1c4b-4281-b951-d872f2087c98
* Simplifiy download initiation. rdsmith@chromium.org2012-06-1812-178/+178
| | | | | | | | | | | | | | | | Now, instead of a three-way dance between DownloadResourceHandler, DownloadFileManager, and DownloadManager, DownloadResourceHandler tells DownloadManager to start the download, and it calls out (with return callback) to DownloadFileManager to create the DownloadFile. BUG=132832 TEST=Refactor; existing tests should continue to work. R=benjhayden@chromium.org Review URL: https://chromiumcodereview.appspot.com/10544161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142728 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix uninit constructor variable.kmadhusu@chromium.org2012-06-141-0/+1
| | | | | | | | | | | CID=104218 BUG=none TEST=none TBR=ahendrickson@chromium.org Review URL: https://chromiumcodereview.appspot.com/10539166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142248 0039d316-1c4b-4281-b951-d872f2087c98
* NetLogEventParameter to Callback refactoring 11. mmenke@chromium.org2012-06-146-422/+154
| | | | | | | | | | | | | Get rid of all uses of NetLog::EventParameters in all remaining locations (downloads, appcache, io thread, chrome_network_delegate. R=eroman@chromium.org,rdsmith@chromium.org,michaeln@chromium.org BUG=126243 Review URL: https://chromiumcodereview.appspot.com/10542153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142217 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the guts of ResourceDispatcherHostImpl into a new class nameddarin@chromium.org2012-06-142-9/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ResourceLoader. This class is responsible for driving the URLRequest (calling Start, Read, and servicing events). This change also generalizes ResourceThrottleController so that it can be used by ResourceHandler implementations to resume or cancel a resource load. The ResourceLoader is a ResourceController. (In a follow-up patch, the BufferedResourceHandler will also become a ResourceController. This will enable us to make the "resume" behavior sane.) The ResourceDispatcherHostImpl now keeps a set of ResourceLoader objects instead of URLRequests. The ResourceLoader owns its URLRequest as well as ResourceHandler (chain). Numerous fields from ResourceRequestInfo become member variables of ResourceLoader because they are only needed by ResourceLoader. This helps cleanup some code. ResourceDispatcherHostImpl is no longer a friend of ResourceRequestInfoImpl, and indeed RRII no longer has any private getter/setters intended for use by RDHI! The ResourceDispatcherHostImpl used to maintain a set of transferred URLRequests. This set is eliminated in favor of just storing a boolean flag on ResourceLoader (is_transferring_). When transferring a request from one RenderView to another, we still replace the ResourceHandler as before, but we keep the ResourceLoader. This means the logic for completing the transfer becomes a member function on ResourceLoader. See ResourceLoader::CompleteTransfer(). NOTE: I left it as future cleanup to improve some of the methods on ResourceLoader that are essentially just copy/pasted from RDHI. For example, I suspect that the new deferred_stage_ member variable will make called_on_response_started_, has_started_reading_, and is_paused_ obsolete. I plan to make these simplifications along with making BufferedResourceHandler implement ResourceController. For now, I'm just trying to minimize changes since this CL is already too big. R=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10501004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142108 0039d316-1c4b-4281-b951-d872f2087c98
* TabContentsWrapper -> TabContents, part 57.avi@chromium.org2012-06-132-3/+3
| | | | | | | | | | | That's really all. BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10539134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141971 0039d316-1c4b-4281-b951-d872f2087c98
* Made ownership of DownloadRequestHandles clear through scoped_ptr<>rdsmith@chromium.org2012-06-126-16/+17
| | | | | | | | | | BUG=None TEST=Memory bots pass. Review URL: https://chromiumcodereview.appspot.com/10535135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141735 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite download manager unit to be actual unit tests.rdsmith@chromium.org2012-06-125-1169/+626
| | | | | | | | | | | | Note that this isn't intended to be complete coverage; it's an attempt to preserve coverage from the old tests while making these "real" unit tests, i.e. with every class except for the main one being tested mocked. Thorough unit tests are intended for the future after we're more completely done with refactoring. BUG=107264 BUG=105200 BUG=110886 Review URL: https://chromiumcodereview.appspot.com/10344024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141674 0039d316-1c4b-4281-b951-d872f2087c98
* Power save blocker: switch to new implementation. In addition to making thingsmdm@chromium.org2012-06-115-13/+13
| | | | | | | | | | | much simpler, this will also fix bug 126591 on Windows 8 by activating the new code in r140668. BUG=126591 Review URL: https://chromiumcodereview.appspot.com/10542089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141433 0039d316-1c4b-4281-b951-d872f2087c98
* Support for drive as default download location on chromeos. achuith@chromium.org2012-06-084-13/+13
| | | | | | | | | | | | | | | | * Add SubstituteGDataDownloadPathCallback step between CheckVisitedReferrerBeforeDone and CheckIfSuggestedPathExists. * Change the signature of ChooseDownloadPath with DownloadItem* arg only. * DownloadFilePicker has an empty ctor and does most of the work in Init() now. * DownloadFilePicker::SetSuggestedPath is a virtual that is overriden by DownloadFilePickerChromeOS to suggest the gdata path instead. * GetSaveDir takes an addition skip_dir_check boolean param. We shouldn't do the directory existence check for cloud folders. BUG=127159 TEST=manual TBR=rdsmith@chromium.org,avi@chromium.org Review URL: https://chromiumcodereview.appspot.com/10501014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141318 0039d316-1c4b-4281-b951-d872f2087c98
* Support NULL DownloadManagerDelegates.jam@chromium.org2012-06-077-105/+136
| | | | | | | BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10538028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140942 0039d316-1c4b-4281-b951-d872f2087c98
* Followup comments from r140761 regarding moving DownloadManager ownership to ↵jam@chromium.org2012-06-064-16/+9
| | | | | | | | | content. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10545034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140780 0039d316-1c4b-4281-b951-d872f2087c98
* Move creation and ownership of DownloadManager from the embedder to content. ↵jam@chromium.org2012-06-066-31/+29
| | | | | | | | | | | This matches all the other objects that content depends on. In a followup change, I'll make content support NULL DownloadManagerDelegates to match the rest of the delegate interfaces. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10535026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140761 0039d316-1c4b-4281-b951-d872f2087c98
* Use ByteStream in downloads system to decouple source and sink.rdsmith@chromium.org2012-06-0422-1102/+865
| | | | | | | | | | | BUG=123192 BUG=93006 BUG=111588 Review URL: https://chromiumcodereview.appspot.com/10392111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140328 0039d316-1c4b-4281-b951-d872f2087c98
* Move test headers from content\test to content\public\test. This way we can ↵jam@chromium.org2012-06-041-3/+3
| | | | | | | | | | enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10492009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140256 0039d316-1c4b-4281-b951-d872f2087c98
* Move test_browser_thread.h from content\test to content\public\test. This ↵jam@chromium.org2012-06-042-2/+2
| | | | | | | | | | way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98
* Move mock download test headers from content\test to content\public\test. ↵jam@chromium.org2012-06-025-5/+5
| | | | | | | | | | This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10501012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140208 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 140102 - Remove old PostDelayedTask interfaces that use int ms ↵asanka@chromium.org2012-06-011-7/+14
| | | | | | | | | | | | | | | | instead of TimeDelta. Compile failed on ChromiumOS x86 and Tegra. BUG=108171 Review URL: https://chromiumcodereview.appspot.com/9703053 TBR=tedvessenes@gmail.com Review URL: https://chromiumcodereview.appspot.com/10496002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140109 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old PostDelayedTask interfaces that use int ms instead of TimeDelta.tedvessenes@gmail.com2012-06-011-14/+7
| | | | | | | | | BUG=108171 Review URL: https://chromiumcodereview.appspot.com/9703053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140102 0039d316-1c4b-4281-b951-d872f2087c98
* Move some code into the content namespace.darin@chromium.org2012-06-012-2/+2
| | | | | | | R=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10447138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139982 0039d316-1c4b-4281-b951-d872f2087c98
* Make ResourceHandler be non-refcounted. Eliminate the OnRequestCloseddarin@chromium.org2012-05-316-83/+79
| | | | | | | | | | | | | | | | method in favor of ~ResourceHandler. This required making a couple ResourceHandlers support weak pointers. The only non-trivial changes are related to DownloadResourceHandler. The StartOnUIThread method becomes a static StartDownloadOnUIThread method, and the call to SetDownloadID and CallStartedCB are now hidden behind a Callback<void(DownloadId)>, which gets posted to the IO thread. R=rdsmith@chromium.org,jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10455009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139874 0039d316-1c4b-4281-b951-d872f2087c98
* Download filename determination refactor (1/3)asanka@chromium.org2012-05-3011-833/+965
| | | | | | | | | | | | | | | | - Removes dependency on DownloadStateInfo in chrome/. - Adds unit tests for ChromeDownloadManagerDelegate. - Cleanup methods for filename determination in DownloadItem to eliminate setters. BUG=78085 TEST=unit tests Review URL: https://chromiumcodereview.appspot.com/10083010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139682 0039d316-1c4b-4281-b951-d872f2087c98
* Switch DownloadUrlParameters to use a content::Referrer instead of a GURL ↵jochen@chromium.org2012-05-302-2/+5
| | | | | | | | | | | | for the referrer BUG=124750 TEST=none Review URL: https://chromiumcodereview.appspot.com/10441090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139562 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid double calling OnResponseStarted from BufferedResourceHandlerrdsmith@chromium.org2012-05-292-1/+9
| | | | | | | | | BUG=129646 R=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/10451023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139295 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb referrer policy along with drag data informationjochen@chromium.org2012-05-252-4/+5
| | | | | | | | | | | | This allows for using the correct referrer policy when dragging a link out of a web view results in a download BUG=124750 TEST=none Review URL: https://chromiumcodereview.appspot.com/10451024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139147 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 138818 - Revert 138812 - Move render_view_host_delegate.h out of ↵danakj@chromium.org2012-05-241-1/+1
| | | | | | | | | | | | | | | content/public. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10441019 TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10450018 TBR=asargent@chromium.org Review URL: https://chromiumcodereview.appspot.com/10448010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138819 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 138812 - Move render_view_host_delegate.h out of content/public.asargent@chromium.org2012-05-241-1/+1
| | | | | | | | | | BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10441019 TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10450018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138818 0039d316-1c4b-4281-b951-d872f2087c98
* Move render_view_host_delegate.h out of content/public.jam@chromium.org2012-05-241-1/+1
| | | | | | | BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10441019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138812 0039d316-1c4b-4281-b951-d872f2087c98
* Creation of ByteStream class.rdsmith@chromium.org2012-05-233-0/+1168
| | | | | | | | | | | | | | | | | | ByteStream is an abstraction of a zero copy transfer of bytes between threads, along with an error indicator upon completion. Data is explicitly pushed into or pulled out of the stream, and source and destination may register for callbacks to be called when there is room/data in the pipe. A ByteStream object is owned in common by the source and destination of the stream, and is destroyed when both source and destination drop references to it. BUG=125250 R=willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10244001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138504 0039d316-1c4b-4281-b951-d872f2087c98
* Add defer out params to ResourceHandler's OnResponseStarteddarin@chromium.org2012-05-217-111/+162
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and OnReadCompleted methods. Use that to pause the request instead of directly calling ResourceDispatcherHostImpl's PauseRequest function. Eliminate direct calls to PauseRequest, with the exception of resource_dispatcher_host_unittest.cc and some uses internal to ResourceDispatcherHostImpl. Those should ultimately be changed to use the defer out-param approach too. This CL also changes the DownloadRequestHandle to talk back to the DownloadResourceHandler in order to pause / resume / cancel the URLRequest. The handle keeps a reference to the handler, which may extend the lifetime of the handler, but that should be OK given that the handler already supports having its lifetime extended beyond the URLRequest. Now, instead of the DownloadFileManager calling PauseRequest, we just wait for the SetDownloadID call to resume the URLRequest. This simplifies some of the logic. The Pause/ResumeRequest issued on a DownloadRequestHandle gets its own pause counter, which has nothing to do with the internal pausing that the DownloadResourceHandler does when it is waiting for a DownloadId. See DownloadResourceHandler::MaybeResumeRequest for the logic that handles the conditions for resuming the URLRequest. Review URL: https://chromiumcodereview.appspot.com/10332130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138111 0039d316-1c4b-4281-b951-d872f2087c98
* DownloadManagerDelegate::ShouldCompleteDownload(callback)benjhayden@chromium.org2012-05-185-28/+37
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10263019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137949 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded scoped_ptr.h includes from content.thestig@chromium.org2012-05-171-4/+3
| | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10389164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137637 0039d316-1c4b-4281-b951-d872f2087c98
* Add flag to specify if explicitly requested download is from web.rdsmith@chromium.org2012-05-151-0/+1
| | | | | | | | | | | | | | This allows interposing the DownloadResourceThrottle on all web downloads, not just those occuring because of navigations. BUG=127522 R=darin@chromium.org TEST=Retry example in referenced issue; look for throttling message. Review URL: https://chromiumcodereview.appspot.com/10381122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137137 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DownloadManager::in_progress_ in favor of active_downloads_ in ↵benjhayden@chromium.org2012-05-143-32/+12
| | | | | | | | | | preparation for removing active_downloads_, history_downloads_, and save_page_downloads_. BUG=126492 Review URL: https://chromiumcodereview.appspot.com/10377013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136978 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the referrer policy with the referrer for the save package code pathjochen@chromium.org2012-05-126-14/+17
| | | | | | | | | BUG=124750 TEST=none. That code path doesn't actually use referrers, it just passes empty GURL()s around. But it might one day. And then it supports referrer policies. Hurray. Review URL: https://chromiumcodereview.appspot.com/10387090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136723 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DownloadManager::DownloadUrl() to allow it to take many parameters.benjhayden@chromium.org2012-05-044-84/+55
| | | | | | Review URL: http://codereview.chromium.org/10232010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135403 0039d316-1c4b-4281-b951-d872f2087c98
* Save Page As MHTMLbenjhayden@chromium.org2012-05-046-31/+122
| | | | | | | | | | | | | | | | | | | | | | | | | | | --save-page-as-mhtml disables saving pages as html-only and complete with sub-resources in a sibling directory, and enables only saving pages as complete with sub-resources in a single MHTML (MIME-HTML) text file. The SavePackage class supports all three options, wich will allow saving complete pages to gdata, and may simplify file management for users. If few enough users need the many-files option, we may be able to remove it and most/all of the SavePackage system. The generated MHTML is viewable in Chrome on all 4 OSs and Opera (at least on windows). The generated MHTML is not viewable in chrome when loaded via http[s], only via file://. http://code.google.com/p/chromium-os/issues/detail?id=28654 Chrome recognizes both '.mht' and '.mhtml' as MHTML, however '.mhtml' is more google-able, so that is the default extension when saving MHTML files. Chrome does not sniff '.html' files to see if they are actually MHTML, so it will incorrectly render such mis-named MHTML files. It is not viewable in Firefox. Firefox tries to help you either open it in another program or download it. There are extensions that provide support for MHTML: MAFF, and UnMHT are two. It is not viewable in Safari. Safari does not recognize "mht" or "mhtml" as extensions that it can render. Changing the extension to "html" allows Safari to open it, but Safari does not seem to understand the file format so it's rendered incorrectly. A port of UnMHT is available for Safari. It is not viewable in IE: The webpage cannot be displayed. Most likely cause: •Some content or files on this webpage require a program that you don't have installed. IE supports MHTML, so it may be possible to tweak the mhtml generator to appease both Opera and IE. http://crbug.com/125477 Regarding OOMs: about:memory showed no change when I saved cnn.com as mhtml (1.4MB), so if there was a spike, it either lasted <200ms or was lost in the noise. BUG=120416 Review URL: http://codereview.chromium.org/10069014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135390 0039d316-1c4b-4281-b951-d872f2087c98
* clean 96627/85408 debugging mechanisms out of DownloadManager/DownloadDatabasebenjhayden@chromium.org2012-05-033-95/+35
| | | | | | | | | | | | OWNERS: brettw: chrome/browser/history/download_database.cc jhawkins: chrome/browser/ui/webui/downloads_dom_handler.cc James, feel free to redirect to arv/estade/csilv. Review URL: http://codereview.chromium.org/10243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135185 0039d316-1c4b-4281-b951-d872f2087c98
* RefCounted types should not have public destructors, content/browser part 1rsleevi@chromium.org2012-04-274-12/+65
| | | | | | | | | | BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10068037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134395 0039d316-1c4b-4281-b951-d872f2087c98
* Enable saving of data: urls.thakis@chromium.org2012-04-272-14/+13
| | | | | | | | | | | | | | | | | | | | 1. Add data: to the list of savable urls, for "save page as" path (used for text and html files). 2. Instead of suggesting the whole url as file name for dataurls, suggest just "dataurl". That's at least shorter. 3. Remove explicit blacklisting of data: urls from download path (used for images) BUG=97108,119129 TEST=Open |data:text/plain;charset=ascii,hello|, hit cmd-s. Should save. Open |data:image/gif;base64,R0lGODlhCwALAIAAAAAA3pn/ZiH5BAEAAAEALAAAAAALAAsAAAIUhA+hkcuO4lmNVindo7qyrIXiGBYAOw==|, hit cmd-s. Should save. TBR=avi Review URL: http://codereview.chromium.org/10241004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134314 0039d316-1c4b-4281-b951-d872f2087c98
* Move timer functionality from DownloadFileManager to DownloadFileImpl.rdsmith@chromium.org2012-04-215-35/+73
| | | | | | | | | | | Includes unit test for timer functionality. BUG=123998 Review URL: http://codereview.chromium.org/10119027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133317 0039d316-1c4b-4281-b951-d872f2087c98
* Report cases where the connection appears to close too early while ↵cbentzel@chromium.org2012-04-201-6/+7
| | | | | | | | | | | | | | transferring an HTTP body. This should not change behavior at all, but will let us see how commonly these situations happen in the wild. BUG=52847 TEST=Existing tests. Review URL: http://codereview.chromium.org/9950023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133208 0039d316-1c4b-4281-b951-d872f2087c98
* Make PowerSaveBlocker object an argument to DownloadFileImpl constructor rdsmith@chromium.org2012-04-197-21/+34
| | | | | | | | | | | | | so that we don't need to worry about it in unittests. BUG=110886 TEST=Run DownloadFileTest.* over an NX connection. R=benjhayden@chromium.org Review URL: http://codereview.chromium.org/10116027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132998 0039d316-1c4b-4281-b951-d872f2087c98
* TabContents -> WebContentsImpl, part 19.avi@chromium.org2012-04-171-4/+5
| | | | | | | | | | BUG=105875 TEST=no change Review URL: http://codereview.chromium.org/10106022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132599 0039d316-1c4b-4281-b951-d872f2087c98
* TabContents -> WebContentsImpl, part 9.avi@chromium.org2012-04-1211-58/+60
| | | | | | | | | | | | "Detab" content/browser/download. BUG=105875 TEST=no change Review URL: http://codereview.chromium.org/10069016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132060 0039d316-1c4b-4281-b951-d872f2087c98
* TabContents -> WebContentsImpl, part 7.avi@chromium.org2012-04-116-6/+6
| | | | | | | | | | | | Move the WebContentsImpl class to files in web_contents. BUG=105875 TEST=no change Review URL: http://codereview.chromium.org/10054012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131845 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid touching url_request_ in OnResponseCompletedInternalrdsmith@chromium.org2012-04-112-5/+9
| | | | | | | | | | | | (It's a potential dangling reference.) BUG=122854 TEST=Unfortunately, none; I've seen it but I don't have a reliable way to repro. Review URL: http://codereview.chromium.org/10038005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131839 0039d316-1c4b-4281-b951-d872f2087c98
* TabContents -> WebContentsImpl, part 4.avi@chromium.org2012-04-111-1/+1
| | | | | | | | | BUG=105875 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10024066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131770 0039d316-1c4b-4281-b951-d872f2087c98
* Make FileStream::Seek async and add FileStream::SeekSync for sync operationkinuko@chromium.org2012-04-111-1/+1
| | | | | | | | | BUG=75548,113300 TEST=existing tests should pass Review URL: https://chromiumcodereview.appspot.com/9949011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131732 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-24 19:00:41 +0000