summaryrefslogtreecommitdiffstats
path: root/content/browser/frame_host/interstitial_page_impl.h
Commit message (Collapse)AuthorAgeFilesLines
* Standardize usage of virtual/override/final in content/browser/dcheng2014-10-211-59/+54
| | | | | | | | | | | | This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/667943003 Cr-Commit-Position: refs/heads/master@{#300469}
* Replacing the OVERRIDE with override and FINAL with final in ↵mohan.reddy2014-10-071-37/+37
| | | | | | | | | | | | | content/browser/frame_host This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/631013003 Cr-Commit-Position: refs/heads/master@{#298392}
* Fix WeakPtrFactory member placementanujk.sharma2014-09-221-2/+2
| | | | | | | | | | | | | Changing in the intialization order of WeakPtrFactory in src/chrome/browser module such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Review URL: https://codereview.chromium.org/582633002 Cr-Commit-Position: refs/heads/master@{#296007}
* Cache the current WebPreferences on RenderViewHostImpl (try #2).chrishtr@chromium.org2014-08-081-1/+1
| | | | | | | | | | | | | | | This makes lookups of a WebPreferences field fast. In order do this, add code to listen to all preferences updates in order to recompute the cache. The first version was rolled back because some code in Blink that listened for inspector prefs updates incorrectly sent the preference update back to Chromium, causing an infinite loop. BUG=390799 Review URL: https://codereview.chromium.org/444843002 Cr-Commit-Position: refs/heads/master@{#288438} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288438 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Cache the current WebPreferences on RenderViewHostImpl. ↵erikchen@chromium.org2014-07-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/373323003/) Reason for revert: Causes DOA on 38-dev. https://code.google.com/p/chromium/issues/detail?id=398751 Original issue's description: > Cache the current WebPreferences on RenderViewHostImpl. > > This makes lookups of a WebPreferences field fast. > In order do this, add code to listen to all preferences updates in order to recompute the cache. > > BUG=390799 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284592 TBR=jam, michaelbai, chrishtr, avi NOTREECHECKS=true NOTRY=true BUG=390799 Review URL: https://codereview.chromium.org/429413003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286876 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate accessibility from RenderView to RenderFrame and RVH to RFH.dmazzoni@chromium.org2014-07-261-0/+1
| | | | | | | | | | | | | | | | In preparation for out-of-process iframes, move almost all accessibility functionality from RenderView to RenderFrame, and from RVHI and RWHI to RFHI. In addition, the accessibility mode is moved to WebContents, and changing the mode triggers changing it on all frames. BUG=368298 R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org Review URL: https://codereview.chromium.org/273423004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285767 0039d316-1c4b-4281-b951-d872f2087c98
* Cache the current WebPreferences on RenderViewHostImpl.chrishtr@chromium.org2014-07-221-1/+1
| | | | | | | | | | | This makes lookups of a WebPreferences field fast. In order do this, add code to listen to all preferences updates in order to recompute the cache. BUG=390799 Review URL: https://codereview.chromium.org/373323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284592 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 284065 "Revert of Revert of Migrate accessibility from Re..."bruening@google.com2014-07-211-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reason for revert: Use-after-free raised on MFYI waterfall. BUG=395670 > Revert of Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/407493002/) > > Reason for revert: > Reverting the revert. This didn't break the tree; it's still broken without the patch. :( > > Sorry for the noise! > > Original issue's description: > > Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/273423004/) > > > > Reason for revert: > > Speculative revert to fix XP bots. > > > > XP bots started crashing http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32011 and http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34677 > > > > This CL is the most suspicious in the range. If it doesn't fix the bots, I'll unrevert it. > > > > Original issue's description: > > > Migrate accessibility from RenderView to RenderFrame and RVH to RFH. > > > > > > In preparation for out-of-process iframes, move almost all accessibility > > > functionality from RenderView to RenderFrame, and from RVHI and RWHI > > > to RFHI. > > > > > > In addition, the accessibility mode is moved to WebContents, and changing > > > the mode triggers changing it on all frames. > > > > > > BUG=368298 > > > R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org > > > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283994 > > > > TBR=dmazzoni@chromium.org > > NOTRY=true > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284032 > > TBR=creis@chromium.org,nick@chromium.org,nasko@chromium.org,jam@chromium.org,dtseng@chromium.org,jschuh@chromium.org,tsepez@chromium.org,kenrb@chromium.org,dmazzoni@chromium.org > NOTREECHECKS=true > NOTRY=true > > Review URL: https://codereview.chromium.org/407493004 TBR=mkwst@chromium.org Review URL: https://codereview.chromium.org/408663006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284470 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Revert of Migrate accessibility from RenderView to RenderFrame. ↵mkwst@chromium.org2014-07-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/407493002/) Reason for revert: Reverting the revert. This didn't break the tree; it's still broken without the patch. :( Sorry for the noise! Original issue's description: > Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/273423004/) > > Reason for revert: > Speculative revert to fix XP bots. > > XP bots started crashing http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32011 and http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34677 > > This CL is the most suspicious in the range. If it doesn't fix the bots, I'll unrevert it. > > Original issue's description: > > Migrate accessibility from RenderView to RenderFrame and RVH to RFH. > > > > In preparation for out-of-process iframes, move almost all accessibility > > functionality from RenderView to RenderFrame, and from RVHI and RWHI > > to RFHI. > > > > In addition, the accessibility mode is moved to WebContents, and changing > > the mode triggers changing it on all frames. > > > > BUG=368298 > > R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283994 > > TBR=dmazzoni@chromium.org > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284032 TBR=creis@chromium.org,nick@chromium.org,nasko@chromium.org,jam@chromium.org,dtseng@chromium.org,jschuh@chromium.org,tsepez@chromium.org,kenrb@chromium.org,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/407493004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284065 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Migrate accessibility from RenderView to RenderFrame. ↵mkwst@chromium.org2014-07-181-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/273423004/) Reason for revert: Speculative revert to fix XP bots. XP bots started crashing http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32011 and http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34677 This CL is the most suspicious in the range. If it doesn't fix the bots, I'll unrevert it. Original issue's description: > Migrate accessibility from RenderView to RenderFrame and RVH to RFH. > > In preparation for out-of-process iframes, move almost all accessibility > functionality from RenderView to RenderFrame, and from RVHI and RWHI > to RFHI. > > In addition, the accessibility mode is moved to WebContents, and changing > the mode triggers changing it on all frames. > > BUG=368298 > R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283994 TBR=dmazzoni@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/407493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284032 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate accessibility from RenderView to RenderFrame and RVH to RFH.dmazzoni@chromium.org2014-07-181-0/+1
| | | | | | | | | | | | | | | | In preparation for out-of-process iframes, move almost all accessibility functionality from RenderView to RenderFrame, and from RVHI and RWHI to RFHI. In addition, the accessibility mode is moved to WebContents, and changing the mode triggers changing it on all frames. BUG=368298 R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org Review URL: https://codereview.chromium.org/273423004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283994 0039d316-1c4b-4281-b951-d872f2087c98
* Move didReceiveTitle and related stuff to RenderFrame.avi@chromium.org2014-05-111-4/+4
| | | | | | | | | BUG=361761 TEST=no visible change Review URL: https://codereview.chromium.org/274883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269641 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land "Pass RenderFrameHost to WebContentObservers' message handlers"mnaganov@chromium.org2014-05-101-0/+2
| | | | | | | | | | | | | | | | | | | | This patch enables WebContentsObserver::OnMessageReceived to receive a reference to RenderFrameHost that received the message. This allows passing of JavaBridgeDispatcherHostManager ownership from WebContentsImpl to ContentViewCore and removing of some redundant initialization code in JavaBridgeDispatcherHostManager, fixing a long-standing TODO. This patch also includes a fix for "Search Google for this image" discovered shorly after the original patch has been landed. BUG=371296 TBR=jam@chromium.org,benm@chromium.org,yoz@chromium.org,bauerb@chromium.org,fsamuel@chromium.org Review URL: https://codereview.chromium.org/275873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269571 0039d316-1c4b-4281-b951-d872f2087c98
* We have a problem in the process on destroying WebContentsImpl becausezverre@yandex-team.ru2014-05-091-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | each WebContentsObserver first NULLs its web_contents_ pointer and performs cleanup code after that. This could work if we guaranteed that every WebContentsObserver doesn't directly or indirectly affect any other WebContentsObserver. But actually WebContentsObservers can do anything and also affect each other. And if one WebContentsObserver already NULLed its web_contents_ pointer (e.g. ZoomController) other WebContentsObserver (e.g. InterstitialPageImpl) calls it (indirectly in this case) we have problems and result depends on ordering of WebContentsObservers in the list of observers. The solution splits that process into two phases. First we let each WebContentsObserver to perform their cleanup code and at that point they can freely call each other, we completely don't care about the ordering. We can call this phase as untrusted phase because we deal with some cleanup code that can do anything. After that we make second pass and NULL each web_contents_ pointer and this phase is trusted because we call only private implementation of WebContentsObserver that we definitely can trust. BUG=363564 Review URL: https://codereview.chromium.org/257153003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269264 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 268939 "Pass RenderFrameHost to WebContentObservers' mess..."rlp@chromium.org2014-05-081-2/+0
| | | | | | | | | | | | | | | | | | | | | | | Win and linux bots are failing. See crbug.com/371030 for more details. Reverting to see if this CL is part of the cause. > Pass RenderFrameHost to WebContentObservers' message handlers > > This patch enables WebContentsObserver::OnMessageReceived to receive > a reference to RenderFrameHost that received the message. > > This allows passing of JavaBridgeDispatcherHostManager ownership from > WebContentsImpl to ContentViewCore and removing of some redundant > initialization code in JavaBridgeDispatcherHostManager, fixing > a long-standing TODO. > > Review URL: https://codereview.chromium.org/253013002 TBR=mnaganov@chromium.org Review URL: https://codereview.chromium.org/271863005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269075 0039d316-1c4b-4281-b951-d872f2087c98
* Pass RenderFrameHost to WebContentObservers' message handlersmnaganov@chromium.org2014-05-071-0/+2
| | | | | | | | | | | | | | This patch enables WebContentsObserver::OnMessageReceived to receive a reference to RenderFrameHost that received the message. This allows passing of JavaBridgeDispatcherHostManager ownership from WebContentsImpl to ContentViewCore and removing of some redundant initialization code in JavaBridgeDispatcherHostManager, fixing a long-standing TODO. Review URL: https://codereview.chromium.org/253013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268939 0039d316-1c4b-4281-b951-d872f2087c98
* Hide WebContentsView from Chrome. This also removes WebContentsViewPort.jam@chromium.org2014-05-031-1/+0
| | | | | | | | | | | TestWebContentsView goes away since it's not needed anymore BUG=304341 R=avi@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/262823006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268072 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash when closing interstitial pages.avi@chromium.org2014-04-291-0/+4
| | | | | | | | | BUG=363564 TEST=as in bug Review URL: https://codereview.chromium.org/239393009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266759 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate addMessageToConsole API to RenderFrame.mkosiba@chromium.org2014-04-031-1/+1
| | | | | | | | | BUG=304341 NOTRY=true Review URL: https://codereview.chromium.org/217183004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261424 0039d316-1c4b-4281-b951-d872f2087c98
* Switch DomAutomationController to be a RenderFrameObserver.mkosiba@chromium.org2014-02-221-0/+10
| | | | | | | | | BUG=304341 TBR=nasko@chromium.org Review URL: https://codereview.chromium.org/157713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252764 0039d316-1c4b-4281-b951-d872f2087c98
* Move DidCommitProvisionalLoad code from RenderView to RenderFrame.nasko@chromium.org2014-02-121-3/+6
| | | | | | | | | | Another attempt at landing this. Original CL is https://codereview.chromium.org/135723003/ and patchset 1 is identical to it. BUG=304341 Review URL: https://codereview.chromium.org/132743011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250591 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 249516 "Move DidCommitProvisionalLoad code from RenderVie..."piman@chromium.org2014-02-071-6/+3
| | | | | | | | | | | | | | | | | | > Move DidCommitProvisionalLoad code from RenderView to RenderFrame. > > BUG=304341 > R=creis@chromium.org > > Review URL: https://codereview.chromium.org/135723003 Casuses a UAF on ASAN bots in SigninBrowserTest.SigninSkipForNowAndGoBack http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22688/steps/browser_tests/logs/stdio TBR=nasko@chromium.org Review URL: https://codereview.chromium.org/152143010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249583 0039d316-1c4b-4281-b951-d872f2087c98
* Move DidCommitProvisionalLoad code from RenderView to RenderFrame.nasko@chromium.org2014-02-061-3/+6
| | | | | | | | | BUG=304341 R=creis@chromium.org Review URL: https://codereview.chromium.org/135723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249516 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some code inside USE_AURA and OS_WIN ifdefs in content.jam@chromium.org2014-01-141-1/+1
| | | | | | | | | | | I also removed the _win.cc files inside content. BUG=330735 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/137403005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244768 0039d316-1c4b-4281-b951-d872f2087c98
* Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts.creis@chromium.org2013-12-181-2/+4
| | | | | | | | | | | | | | | | | | | We still only have a RFHM for the main frame and not subframes, unless the --site-per-process flag is passed. To external callers, RFHM is still effectively swapping RenderViewHosts. RenderFrameHosts now indirectly keep their RenderViewHosts alive. Second attempt, after fixing memory leak from http://crrev.com/241151. R=nasko@chromium.org TBR=jam@chromium.org BUG=314791 TEST=No visible behavior change. Review URL: https://codereview.chromium.org/117693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241423 0039d316-1c4b-4281-b951-d872f2087c98
* Switch ContentSettingsObserver to be a RenderFrameObserver instead of a ↵jam@chromium.org2013-12-171-0/+1
| | | | | | | | | | | RenderViewObserver BUG=304341 R=boliu@chromium.org, nasko@chromium.org Review URL: https://codereview.chromium.org/104833006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241306 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 241151 "Make RenderFrameHostManager swap RenderFrameHosts..."tzik@chromium.org2013-12-171-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | r241151 seems to break content_unittests and browser_tests on Chrome OS ASAN bot: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29/builds/12154 > Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. > > We still only have a RFHM for the main frame and not subframes, unless > the --site-per-process flag is passed. To external callers, RFHM is > still effectively swapping RenderViewHosts. > > RenderFrameHosts now indirectly keep their RenderViewHosts alive. > > BUG=314791 > TEST=No visible behavior change. > > Review URL: https://codereview.chromium.org/106963004 TBR=creis@chromium.org Review URL: https://codereview.chromium.org/105523006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241159 0039d316-1c4b-4281-b951-d872f2087c98
* Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts.creis@chromium.org2013-12-171-2/+4
| | | | | | | | | | | | | | | We still only have a RFHM for the main frame and not subframes, unless the --site-per-process flag is passed. To external callers, RFHM is still effectively swapping RenderViewHosts. RenderFrameHosts now indirectly keep their RenderViewHosts alive. BUG=314791 TEST=No visible behavior change. Review URL: https://codereview.chromium.org/106963004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241151 0039d316-1c4b-4281-b951-d872f2087c98
* Make Navigator an interface.nasko@chromium.org2013-12-061-1/+0
| | | | | | | | | | InterstitialPageImpl has very different requirements for navigations than regular pages. As such, we need a different implementation of Navigator for it. This CL creates a specific version for interstitial pages and makes Navigator be an interface. BUG=304341 Review URL: https://codereview.chromium.org/105923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239194 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent the browser process from creating duplicate RenderWidgetHostsnasko@chromium.org2013-12-041-2/+4
| | | | | | | | | | This is a follow up CL for crrev.com/238575. The same problem exists when creating RenderWidgetHosts and this CL address this. BUG=312016 Review URL: https://codereview.chromium.org/105033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238750 0039d316-1c4b-4281-b951-d872f2087c98
* Add RenderFrameHostDelegate and plumb it through all the necessary classes.jam@chromium.org2013-12-041-0/+4
| | | | | | | | | | | This is an empty interface for now. I'm doing this separately in preparation for moving plugin creation from RenderView to RenderFrame. BUG=245126 R=creis@chromium.org Review URL: https://codereview.chromium.org/103633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238709 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent the browser process from creating duplicate RenderViewHosts.nasko@chromium.org2013-12-041-0/+1
| | | | | | | | BUG=312016 Review URL: https://codereview.chromium.org/92873004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238575 0039d316-1c4b-4281-b951-d872f2087c98
* Convert string16 to base::string16 in content.brettw@chromium.org2013-12-031-2/+2
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/102593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238447 0039d316-1c4b-4281-b951-d872f2087c98
* Add Navigator and NavigatorDelegate objects.nasko@chromium.org2013-11-091-1/+4
| | | | | | | | BUG=304341 Review URL: https://codereview.chromium.org/65363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234067 0039d316-1c4b-4281-b951-d872f2087c98
* Rename WebKit namespace to blink (part 3)abarth@chromium.org2013-11-071-1/+1
| | | | | | | | | | | This CL updates all references to the WebKit namespace in content. TBR=darin@chromium.org BUG=295096 Review URL: https://codereview.chromium.org/63253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233513 0039d316-1c4b-4281-b951-d872f2087c98
* Move navigation and frame tree classes to a new frame_host/ directory.nasko@chromium.org2013-10-301-0/+267
This CL moves all frame tree classes, Navigation* and its dependencies from web_contents/ to a separate frame_host/ directory. BUG=304341 Review URL: https://codereview.chromium.org/49823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231921 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-28 11:41:51 +0000