summaryrefslogtreecommitdiffstats
path: root/content/browser/frame_host/navigation_controller_impl.h
Commit message (Collapse)AuthorAgeFilesLines
* Don't leave aborted URLs in the omnibox unless we're on the NTP.creis@chromium.org2014-04-221-0/+4
| | | | | | | | | BUG=355537 TEST=See bug for repro steps. Review URL: https://codereview.chromium.org/245943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265325 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 265044 "Don't leave aborted URLs in the omnibox unless we..."rockot@chromium.org2014-04-211-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | This appears to be breaking prerender tests on some Mac and Linux builders. e.g. Mac: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%284%29/builds/22698/steps/browser_tests/logs/PrerenderDoublePendingSwap http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/40342/steps/browser_tests/logs/PrerenderPageNewTab Linux ASan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20Tests%20%28sandboxed%29/builds/971/steps/browser_tests/logs/PrerenderPageNewTab > Don't leave aborted URLs in the omnibox unless we're on the NTP. > > BUG=355537 > TEST=See bug for repro steps. > > Review URL: https://codereview.chromium.org/232463007 TBR=creis@chromium.org Review URL: https://codereview.chromium.org/244693007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265069 0039d316-1c4b-4281-b951-d872f2087c98
* Don't leave aborted URLs in the omnibox unless we're on the NTP.creis@chromium.org2014-04-211-0/+4
| | | | | | | | | BUG=355537 TEST=See bug for repro steps. Review URL: https://codereview.chromium.org/232463007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265044 0039d316-1c4b-4281-b951-d872f2087c98
* Remove frame ID from DidCommitProvisionalLoad.creis@chromium.org2014-03-031-12/+8
| | | | | | | | | | | | | Also passes RenderFrameHosts to RendererDidNavigate and cleans up the RenderFrameHost interface. BUG=314791 TEST=No behavior change. R=nasko@chromium.org Review URL: https://codereview.chromium.org/182713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254576 0039d316-1c4b-4281-b951-d872f2087c98
* Detect any callers that delete a pending entry while it is still in use.creis@chromium.org2014-02-281-0/+3
| | | | | | | | | | | | | Any crashes of this form indicate a bug somewhere in the call stack, since the navigation logic is not re-entrant. BUG=347742 TEST=Just a second line of defense, no intended behavior change. R=nasko@chromium.org, samarth@chromium.org Review URL: https://codereview.chromium.org/181433019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254252 0039d316-1c4b-4281-b951-d872f2087c98
* Move DidCommitProvisionalLoad code from RenderView to RenderFrame.nasko@chromium.org2014-02-121-11/+12
| | | | | | | | | | Another attempt at landing this. Original CL is https://codereview.chromium.org/135723003/ and patchset 1 is identical to it. BUG=304341 Review URL: https://codereview.chromium.org/132743011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250591 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 249516 "Move DidCommitProvisionalLoad code from RenderVie..."piman@chromium.org2014-02-071-12/+11
| | | | | | | | | | | | | | | | | | > Move DidCommitProvisionalLoad code from RenderView to RenderFrame. > > BUG=304341 > R=creis@chromium.org > > Review URL: https://codereview.chromium.org/135723003 Casuses a UAF on ASAN bots in SigninBrowserTest.SigninSkipForNowAndGoBack http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22688/steps/browser_tests/logs/stdio TBR=nasko@chromium.org Review URL: https://codereview.chromium.org/152143010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249583 0039d316-1c4b-4281-b951-d872f2087c98
* Move DidCommitProvisionalLoad code from RenderView to RenderFrame.nasko@chromium.org2014-02-061-11/+12
| | | | | | | | | BUG=304341 R=creis@chromium.org Review URL: https://codereview.chromium.org/135723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249516 0039d316-1c4b-4281-b951-d872f2087c98
* Support cross-process navigations in a single subframe RenderFrameHost.creis@chromium.org2013-12-271-3/+17
| | | | | | | | | | | | | | This relies on a hack of detecting when a NavigationEntry is for a subframe RenderFrameHost, even though the navigation occurs in a top-level RenderViewHost. It supports cases with at most one frame, and is only enabled when --site-per-process is used. BUG=314791 TEST=New process is created for a cross-site iframe with --site-per-process. Review URL: https://codereview.chromium.org/118443008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242639 0039d316-1c4b-4281-b951-d872f2087c98
* Handle should_replace_current_entry in prerender.davidben@chromium.org2013-12-131-2/+2
| | | | | | | | | | | | | | | This fixes calls to location.replace which trigger a prerender. History entries after the current one are incorrectly discarded (http://crbug.com/317872), but the current entry is correctly replaced. BUG=305400 TEST=PrerenderBrowserTest.PrerenderReplaceCurrentEntry NavigationControllerTest.CopyStateFromAndPruneReplaceEntry NavigationControllerTest.CopyStateFromAndPruneMaxEntriesReplaceEntry Review URL: https://codereview.chromium.org/49003011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240535 0039d316-1c4b-4281-b951-d872f2087c98
* Renamed CanPruneAllButVisible and PruneAllButVisible in the Navigation ↵jww@chromium.org2013-11-131-6/+7
| | | | | | | | Controller to CanPruneAllButLastCommitted and PruneAllButLastCommitted, respectively. Review URL: https://codereview.chromium.org/69013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234693 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead NavigationControllerImpl::IsRedirect.creis@chromium.org2013-11-061-3/+0
| | | | | | | | | BUG=none TEST=No behavior change. Review URL: https://codereview.chromium.org/59863004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233160 0039d316-1c4b-4281-b951-d872f2087c98
* Rename WebContentsScreenshotManager to NavigationEntryScreenshotManager.nasko@chromium.org2013-11-051-3/+3
| | | | | | | | | BUG= R=creis@chromium.org Review URL: https://codereview.chromium.org/58343006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233049 0039d316-1c4b-4281-b951-d872f2087c98
* Move navigation and frame tree classes to a new frame_host/ directory.nasko@chromium.org2013-10-301-0/+410
This CL moves all frame tree classes, Navigation* and its dependencies from web_contents/ to a separate frame_host/ directory. BUG=304341 Review URL: https://codereview.chromium.org/49823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231921 0039d316-1c4b-4281-b951-d872f2087c98