summaryrefslogtreecommitdiffstats
path: root/content/browser/in_process_webkit/webkit_thread.cc
Commit message (Collapse)AuthorAgeFilesLines
* Revert 129018 - Revert 128993 - Refactor BaseTimer to avoid spamming the ↵jbates@chromium.org2012-03-271-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | MessageLoop with orphaned tasks. This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time. * The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL. A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer). As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states. BUG=117451,103667,119714,119750 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128412 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=128506 Review URL: https://chromiumcodereview.appspot.com/9655006 TBR=jbates@chromium.org Review URL: https://chromiumcodereview.appspot.com/9791009 TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/9860014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129062 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 128993 - Refactor BaseTimer to avoid spamming the MessageLoop with ↵aa@chromium.org2012-03-261-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | orphaned tasks. This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time. * The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL. A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer). As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states. BUG=117451,103667,119714,119750 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128412 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=128506 Review URL: https://chromiumcodereview.appspot.com/9655006 TBR=jbates@chromium.org Review URL: https://chromiumcodereview.appspot.com/9791009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129018 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BaseTimer to avoid spamming the MessageLoop with orphaned tasks.jbates@chromium.org2012-03-261-1/+5
| | | | | | | | | | | | | | | | | | | | This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time. * The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL. A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer). As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states. BUG=117451,103667,119714,119750 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128412 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=128506 Review URL: https://chromiumcodereview.appspot.com/9655006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128993 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor BaseTimer to avoid spamming the MessageLoop with orphaned ↵rnk@chromium.org2012-03-231-5/+1
| | | | | | | | | | | | | | tasks." This reverts commit r128412, which is causing DCHECKs in thread destruction in media unittests. BUG=119714,119750 TBR=sky@chromium.org,petermayo@chromium.org Review URL: https://chromiumcodereview.appspot.com/9839059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128506 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BaseTimer to avoid spamming the MessageLoop with orphaned tasks.jbates@chromium.org2012-03-231-1/+5
| | | | | | | | | | | | | | | | This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time. * The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL. A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer). As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states. BUG=117451,103667 Review URL: http://codereview.chromium.org/9655006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128412 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate WEBKIT threadjoth@chromium.org2011-12-201-3/+4
| | | | | | | | | | BUG=106839 TEST=try servers pass Review URL: http://codereview.chromium.org/8879013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115116 0039d316-1c4b-4281-b951-d872f2087c98
* Start/stop WebKitThread from BrowserMainLoop like other BrowserThreads.joi@chromium.org2011-12-021-1/+3
| | | | | | | | | | | | | Move WebKitThread to the content namespace. Re-order thread objects in BrowserMainLoop declaration to match instantiation order. BUG=98716 Review URL: http://codereview.chromium.org/8776007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112682 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrowserThread to content namespace.joi@chromium.org2011-11-021-0/+2
| | | | | | | | | TBR=owners BUG=98716 Review URL: http://codereview.chromium.org/8437002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
* Split BrowserThread into public API and private implementation, step 1.joi@chromium.org2011-10-281-1/+1
| | | | | | | | | | | | | | | | | | | | | Only content/ now has the ability to create BrowserThread objects, with the exception that tests can create the content::TestBrowserThread subclass, and (temporarily) code in chrome/ can create the DeprecatedBrowserThread subclass. A follow-up change will make content/ take care of its own thread creation, remove DeprecatedBrowserThread, and move all state and non-trivial constructors from BrowserThread down to BrowserThreadImpl. Also moved BrowserProcessSubThread into content/ namespace. As part of follow-up cleanup, chrome/ will stop using this class. BUG=98716 TEST=existing Review URL: http://codereview.chromium.org/8392042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
* Move content_switches to content\public\common.jam@chromium.org2011-10-131-1/+1
| | | | | | | BUG=98716 Review URL: http://codereview.chromium.org/8277018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105389 0039d316-1c4b-4281-b951-d872f2087c98
* Do not intitialize V8 in browser process.dslomov@chromium.org2011-09-241-1/+1
| | | | | | Review URL: http://codereview.chromium.org/8031002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102625 0039d316-1c4b-4281-b951-d872f2087c98
* Update Chrome to use WebKitPlatformSupport instead of WebKitClient.abarth@chromium.org2011-09-021-5/+5
| | | | | | Review URL: http://codereview.chromium.org/7831035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99349 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix until WebKit::initialize does this for us.michaeln@google.com2011-05-251-0/+5
| | | | | | Review URL: http://codereview.chromium.org/7054002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86722 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of some dependencies on chrome from content.michaeln@google.com2011-04-011-1/+1
| | | | | | | | BUG=76697 TEST=n/a Review URL: http://codereview.chromium.org/6780007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80217 0039d316-1c4b-4281-b951-d872f2087c98
* Move in_process_webkit dir from chrome\browser to content\browser.jam@chromium.org2011-02-241-0/+61
Review URL: http://codereview.chromium.org/6580019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75902 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-22 16:52:39 +0000