summaryrefslogtreecommitdiffstats
path: root/content/browser/indexed_db
Commit message (Collapse)AuthorAgeFilesLines
* [FileAPI] Remove Flush() on write completion on SandboxFileSystemstzik@chromium.org2014-05-071-1/+2
| | | | | | | | | | | | The Flush() call is relatively less important for SandboxFileSystems which is stored in a internal storage, than external storage (e.g. USB storage). And, it hurts performance of truncate()-write() use case on encrypted disk. This CL removes Flush() on write completion on SandboxFileSystems. Review URL: https://codereview.chromium.org/264993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268914 0039d316-1c4b-4281-b951-d872f2087c98
* Move IsStringUTF8/ASCII to base namespacebrettw@chromium.org2014-05-071-1/+1
| | | | | | | | TBR=sky@chromium.org Review URL: https://codereview.chromium.org/270183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268754 0039d316-1c4b-4281-b951-d872f2087c98
* This is the implementation of the primary and secondary blob journals forericu@chromium.org2014-05-015-7/+338
| | | | | | | | | | | IDB/Blob support. It's not yet used at all, so there are a few fake calls to eliminate compiler errors until the rest of the code lands. BUG=108012 Review URL: https://codereview.chromium.org/264483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267665 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed IndexedDBCursor destruction bug.cmumford@chromium.org2014-05-011-2/+1
| | | | | | | | | | | | | | | | | | | | IndexedDBCursor's can now be destroyed with cursor messages still in an IPC message queue. Specifically in 368134 IndexedDBCallbacks::OnSuccessWithPrefetch() was called, enqueuing a CallbacksSuccessCursorPrefetch message via IndexedDBDispatcher. Before that message was handled (by IndexedDBDispatcher::OnSuccessCursorPrefetch()) IndexedDBDispatcher::CursorDestroyed() was called which removing the cursor ID from the map. This new behavior started as a result of Blink's r172568 which began deleting cursors earlier than the previous implementation. Also, unrevert's r266866 to re-enable the RenderThreadShutdownTest test. BUG=368134 Review URL: https://codereview.chromium.org/260713009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267571 0039d316-1c4b-4281-b951-d872f2087c98
* Some changes to support incognito mode, and some small cleanup.ericu@chromium.org2014-05-015-24/+40
| | | | | | | | BUG=108012 Review URL: https://codereview.chromium.org/260783003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267448 0039d316-1c4b-4281-b951-d872f2087c98
* Move mock_special_storage_policy from webkit/ to content/public/test/pilgrim@chromium.org2014-04-301-3/+3
| | | | | | | | | BUG=338338 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/259083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267345 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an unsafe test pattern.ericu@chromium.org2014-04-302-6/+10
| | | | | | | | | | | | | Relying on a destructor's call for test validation is dangerous if it's in a ref-counted object. In many failures, there's a reference left hanging, and the destructor won't get called. I found this by accident, by noticing that a test that should have been failing wasn't. BUG=none Review URL: https://codereview.chromium.org/260123009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267305 0039d316-1c4b-4281-b951-d872f2087c98
* Track which IndexedDBBackingStores have been opened since boot.ericu@chromium.org2014-04-307-24/+70
| | | | | | | | | | | | | This way we'll know which need to have their live blob journals cleaned, once blob support is in. This has a small overlap with https://codereview.chromium.org/240003011/ [currently in the commit queue] for ease of merging. However, it also fixes a bug in that CL in which GetDatabaseNames didn't have the request_context parameter. BUG=108012 Review URL: https://codereview.chromium.org/259063004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267031 0039d316-1c4b-4281-b951-d872f2087c98
* Add blob-writing functionality [as yet un-called] to IDB's backend.ericu@chromium.org2014-04-295-1/+414
| | | | | | | | | BUG=108012 R=cmumford@chromium.org, jsbell@chromium.org Review URL: https://codereview.chromium.org/240003011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266916 0039d316-1c4b-4281-b951-d872f2087c98
* [Sheriff] Disable RenderThreadShutdownTest in debug mode.machenbach@chromium.org2014-04-291-1/+2
| | | | | | | | | | | BUG=368134 TBR=robliao@chromium.org, ajwong@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/253103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266866 0039d316-1c4b-4281-b951-d872f2087c98
* Fix component build for indexed_db_quota_client_unittest.ccspang@chromium.org2014-04-251-5/+7
| | | | | | | | | | | | | | | | | | | | | This exports some functions used by tests to fix the following errors: ../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:115: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForHost(quota::StorageType, std::string const&, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)' ../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:115: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForHost(quota::StorageType, std::string const&, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)' ../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:115: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForHost(quota::StorageType, std::string const&, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)' ../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:115: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForHost(quota::StorageType, std::string const&, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)' ../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:101: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForType(quota::StorageType, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)' ../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:101: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForType(quota::StorageType, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)' ../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:101: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForType(quota::StorageType, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)' ../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:101: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForType(quota::StorageType, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)' TBR=jsbell@chromium.org BUG=none TEST=ninja -C out/Release aura_builder Review URL: https://codereview.chromium.org/258893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266276 0039d316-1c4b-4281-b951-d872f2087c98
* Tracing out a few more IndexedDB operations.cmumford@chromium.org2014-04-231-0/+4
| | | | | | | | | | | Adding tracing for these function because they are called when receiving a message. BUG= Review URL: https://codereview.chromium.org/246273007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265713 0039d316-1c4b-4281-b951-d872f2087c98
* Complete registration of blobs before sending back an indexed DB value that ↵ericu@chromium.org2014-04-182-46/+263
| | | | | | | | | | contains them. BUG=108012 Review URL: https://codereview.chromium.org/238043007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264728 0039d316-1c4b-4281-b951-d872f2087c98
* Make IDBObjectStore.clear work with corrupted database.cmumford@chromium.org2014-04-173-27/+24
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/236203014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264389 0039d316-1c4b-4281-b951-d872f2087c98
* Pass blob info through from the IPC to the backing store on put.ericu@chromium.org2014-04-178-19/+235
| | | | | | | | | | It's not used yet; this is all just preparatory plumbing. BUG=108012 Review URL: https://codereview.chromium.org/232343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264380 0039d316-1c4b-4281-b951-d872f2087c98
* Added IndexedDBTransactionTest::ScheduleNormalTask.cmumford@chromium.org2014-04-162-0/+64
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/238793005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264349 0039d316-1c4b-4281-b951-d872f2087c98
* Make iterating over a corrupted IndexedDB fail.cmumford@chromium.org2014-04-1617-219/+515
| | | | | | | | | | | | If an open corrupted IndexedDB was iterated over it would silently fail and the web page would never be informed. This change fixes that bug so that cursor iteration fails just like a get operation did previously. BUG=332524 Review URL: https://codereview.chromium.org/237143006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264256 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb request_context, ipc_process_id, and blob_storage_context through to ↵ericu@chromium.org2014-04-146-21/+123
| | | | | | | | | | where they'll be needed. BUG=108012 Review URL: https://codereview.chromium.org/229623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263693 0039d316-1c4b-4281-b951-d872f2087c98
* deleteDatabase() success should be IDBVersionChangeEvent [Chromium]jsbell@chromium.org2014-04-145-5/+10
| | | | | | | | | | | | | Found via the W3C web-platform-tests. Back-end needs to send the old version to the front-end, but can do so via existing plumbing. Blink side must land first, then Chromium side, then Blink tests. BUG=362251 Review URL: https://codereview.chromium.org/235083005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263641 0039d316-1c4b-4281-b951-d872f2087c98
* Added IndexedDBTransactionTest::SchedulePreemptiveTask.cmumford@chromium.org2014-04-112-0/+63
| | | | | | | | | | | Unrelated to a bug, just adding a unit test to verify operation of transactions containing preemptive tasks. BUG= Review URL: https://codereview.chromium.org/233463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263328 0039d316-1c4b-4281-b951-d872f2087c98
* IndexedDBTransactionTest::Timeout now calls Timeout().cmumford@chromium.org2014-04-092-2/+10
| | | | | | | | | | | | When the transaction timeout expires Timeout is called, which in turn calls Abort(). Making the test a friend so that Timeout can be called makes this a more realistic test. Also checking for correct diagnostic values. BUG= Review URL: https://codereview.chromium.org/228843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262797 0039d316-1c4b-4281-b951-d872f2087c98
* A handful of nits found while working on blobs.ericu@chromium.org2014-04-093-3/+2
| | | | | | | | | | | I'd just like to check them in to drop a few files out of the big CL. The DISALLOW_COPY_AND_ASSIGN isn't needed, and has to go for the big CL anyway. BUG=108012 Review URL: https://codereview.chromium.org/229473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262706 0039d316-1c4b-4281-b951-d872f2087c98
* New IPC message parameters for IDB/Blob support.ericu@chromium.org2014-04-091-16/+12
| | | | | | | | BUG=108012 Review URL: https://codereview.chromium.org/227693008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262608 0039d316-1c4b-4281-b951-d872f2087c98
* Move mock_quota_manager and friends from webkit/ to content/pilgrim@chromium.org2014-04-091-2/+2
| | | | | | | | | BUG=338338 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/214233005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262569 0039d316-1c4b-4281-b951-d872f2087c98
* Remove CreatePlatformFile from indexed_dbrvargas@chromium.org2014-04-082-32/+14
| | | | | | | | BUG=322664 Review URL: https://codereview.chromium.org/227703006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262317 0039d316-1c4b-4281-b951-d872f2087c98
* Resetting pending_preemptive_events_ in IndexedDBTransaction::Abort.cmumford@chromium.org2014-04-083-4/+55
| | | | | | | | | | | | An aborted transaction would not reset pending_preemptive_events_ which would result in IndexedDBTransaction::HasPendingTasks() returning true on an aborted transaction. Not the cause of any known bugs. BUG= Review URL: https://codereview.chromium.org/223623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262260 0039d316-1c4b-4281-b951-d872f2087c98
* Running AbortTasks for read_write/read_only transactions.cmumford@chromium.org2014-04-041-2/+22
| | | | | | | | | | | | This change also lays the foundation to modify other tests (and write new tests) which are parameterized so that they can for both of these modes (when applicable). BUG= Review URL: https://codereview.chromium.org/224443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261613 0039d316-1c4b-4281-b951-d872f2087c98
* Add the IndexedDBActiveBlobRegistry, currently unused, to enable future blobericu@chromium.org2014-04-0312-134/+782
| | | | | | | | | | | support. BUG=108012 R=cmumford,jsbell Review URL: https://codereview.chromium.org/203833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261440 0039d316-1c4b-4281-b951-d872f2087c98
* Un-revert Handling LevelDB errors encountered after open.jsbell@chromium.org2014-03-318-114/+449
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous IndexedDB implementation only checked for (and reported) corrupted LevelDB's during open. If they are determined to be corrupted during use then the database was simply closed. The page would be unaware of this, and would likely reopen the database at a later time (which would work) only to fail again during a read/write operation. There was no way for the page to get out of that corrupted state - the user would have to delete all origin data. This change will record the fact that the backing store was corrupted, and during open this would be read and, if present, result in the same dataLoss state being reported to the page in the upgradeneeded event. Also split IndexedDBBackingStore's REPORT_ERROR macro in two: REPORT_ERROR_UNTESTED (which calls NOTREACHED) and REPORT_ERROR. REPORT_ERROR is used for errors which are encountered during tests. This was done so that runtime errors could still be caught during a debug build run. The original change (r260147) had a buffer overrun in a unit test fixed in this CL. BUG=322707 R=isherman@chromium.org, jochen@chromium.org, jsbell@chromium.org Review URL: https://codereview.chromium.org/197333009 Patch from Christopher Mumford <cmumford@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260697 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 260147 "Handling LevelDB errors encountered after open."jsbell@chromium.org2014-03-289-445/+118
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The browser test is showing Mac ASAN failures. > Handling LevelDB errors encountered after open. > > The previous IndexedDB implementation only checked for (and reported) > corrupted LevelDB's during open. If they are determined to be corrupted > during use then the database was simply closed. The page would be unaware of > this, and would likely reopen the database at a later time (which would work) > only to fail again during a read/write operation. There was no way for the > page to get out of that corrupted state - the user would have to delete all > origin data. > > This change will record the fact that the backing store was corrupted, and > during open this would be read and, if present, result in the same dataLoss > state being reported to the page in the upgradeneeded event. > > Also split IndexedDBBackingStore's REPORT_ERROR macro in two: > REPORT_ERROR_UNTESTED (which calls NOTREACHED) and REPORT_ERROR. REPORT_ERROR > is used for errors which are encountered during tests. This was done so that > runtime errors could still be caught during a debug build run. > > BUG=322707 > R=isherman@chromium.org, jochen@chromium.org, jsbell@chromium.org > > Review URL: https://codereview.chromium.org/197333009 > > Patch from Christopher Mumford <cmumford@chromium.org>. TBR=jsbell@chromium.org Review URL: https://codereview.chromium.org/216433007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260209 0039d316-1c4b-4281-b951-d872f2087c98
* Handling LevelDB errors encountered after open.jsbell@chromium.org2014-03-289-118/+445
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous IndexedDB implementation only checked for (and reported) corrupted LevelDB's during open. If they are determined to be corrupted during use then the database was simply closed. The page would be unaware of this, and would likely reopen the database at a later time (which would work) only to fail again during a read/write operation. There was no way for the page to get out of that corrupted state - the user would have to delete all origin data. This change will record the fact that the backing store was corrupted, and during open this would be read and, if present, result in the same dataLoss state being reported to the page in the upgradeneeded event. Also split IndexedDBBackingStore's REPORT_ERROR macro in two: REPORT_ERROR_UNTESTED (which calls NOTREACHED) and REPORT_ERROR. REPORT_ERROR is used for errors which are encountered during tests. This was done so that runtime errors could still be caught during a debug build run. BUG=322707 R=isherman@chromium.org, jochen@chromium.org, jsbell@chromium.org Review URL: https://codereview.chromium.org/197333009 Patch from Christopher Mumford <cmumford@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260147 0039d316-1c4b-4281-b951-d872f2087c98
* Fix type conversion issues for Android x64zhenyu.liang@intel.com2014-03-281-5/+5
| | | | | | | | BUG=346626 Review URL: https://codereview.chromium.org/214203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260070 0039d316-1c4b-4281-b951-d872f2087c98
* Move ContentBrowserTest class to content/public, since it's used by ↵jam@chromium.org2014-03-271-2/+2
| | | | | | | | | | components_browsertests for browser tests which use Content Shell. R=avi@chromium.org Review URL: https://codereview.chromium.org/214823006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259967 0039d316-1c4b-4281-b951-d872f2087c98
* Made IndexedDB's comparators public.cmumford@chromium.org2014-03-274-27/+51
| | | | | | | | | | | | | | | Moved IndexedDBBackingStore::Comparator and LevelDBDatabase::ComparatorAdapter up into their respective class definitions. This allows them to be instantiated (or derived from). This change is necessary in order to facilitate the authoring of an IndexedDB diagnostic utility application. The design of LevelDB is such that the same comparator must be used when opening a LevelDB that was used to create it. BUG= Review URL: https://codereview.chromium.org/213263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259867 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. Indexed DB cleanup:pkasting@chromium.org2014-03-204-8/+8
| | | | | | | | | | | | | | | | | * Reorder the .h file so copy/assignment come after the normal constructors instead of in the middle * Make the .cc file ordering match the .h file * Make the param names in the .cc file constructors match those in the .h file * Rename Compare() to CompareTo() and IsEqual() to Equals() so they read more like "plain English" when they're used, and to distinguish CompareTo() from the newly-added Compare() (see next bullet) * Add templated Compare() function as suggested in https://codereview.chromium.org/202863004/ to avoid nested ternaries BUG=none TEST=none R=jsbell@chromium.org Review URL: https://codereview.chromium.org/204943004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258185 0039d316-1c4b-4281-b951-d872f2087c98
* Add IndexedDBValue wrapper class to group blob info with bits.ericu@chromium.org2014-03-1913-67/+138
| | | | | | | | | | | Depends on https://codereview.chromium.org/197023009. BUG=108012 R=cmumford,jsbell Review URL: https://codereview.chromium.org/197753011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258139 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "unreachable code" warnings (MSVC warning 4702) in content/.pkasting@chromium.org2014-03-191-18/+11
| | | | | | | | | | BUG=346399 TEST=none R=jam@chromium.org Review URL: https://codereview.chromium.org/202863004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258096 0039d316-1c4b-4281-b951-d872f2087c98
* Add IndexedDBBlobInfo class, to be used for IDB Blob support.ericu@chromium.org2014-03-184-3/+171
| | | | | | | | | | Note that this depends on https://codereview.chromium.org/198133002 for DatabaseMetaDataKey::kInvalidBlobKey. BUG=108012 Review URL: https://codereview.chromium.org/197023009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257719 0039d316-1c4b-4281-b951-d872f2087c98
* Added IndexedDBPendingConnection to group up a bunch of parameters that get ↵ericu@chromium.org2014-03-1811-171/+228
| | | | | | | | | | | | | passed around together. This includes a convenience method CreateConnection in IndexedDBDatabase.cc that's not strictly needed for this change, but makes the merge of other related CLs easier later. BUG=108012 R=cmumford,jsbell Review URL: https://codereview.chromium.org/198223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257568 0039d316-1c4b-4281-b951-d872f2087c98
* Add safe blob-over-IPC transfer from browser->renderer for IDB.ericu@chromium.org2014-03-182-1/+40
| | | | | | | | | BUG=108012 R=cmumford,jsbell Review URL: https://codereview.chromium.org/196473018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257537 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 257524 "Move IsStringASCII/UTF8 to base namespace."brettw@chromium.org2014-03-171-1/+1
| | | | | | | | | | | | | | | | > Move IsStringASCII/UTF8 to base namespace. > > Use StringPiece for IsStringUTF8. > > TBR=sky > > Review URL: https://codereview.chromium.org/196793010 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/198163004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257533 0039d316-1c4b-4281-b951-d872f2087c98
* Move IsStringASCII/UTF8 to base namespace.brettw@chromium.org2014-03-171-1/+1
| | | | | | | | | | Use StringPiece for IsStringUTF8. TBR=sky Review URL: https://codereview.chromium.org/196793010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257524 0039d316-1c4b-4281-b951-d872f2087c98
* Change LevelDBWriteOnlyTransaction to be writeable, and change its name to ↵ericu@chromium.org2014-03-143-12/+35
| | | | | | | | | | | LevelDBDirectTransaction. BUG=108012 R=cmumford,jsbell Review URL: https://codereview.chromium.org/198243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257045 0039d316-1c4b-4281-b951-d872f2087c98
* Add the leveldb coding changes for IDB blob support.ericu@chromium.org2014-03-142-6/+188
| | | | | | | | BUG=108012 Review URL: https://codereview.chromium.org/198133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257044 0039d316-1c4b-4281-b951-d872f2087c98
* Move more file_util functions to base namespace.brettw@chromium.org2014-03-132-2/+2
| | | | | | | | TBR=jam Review URL: https://codereview.chromium.org/189333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256863 0039d316-1c4b-4281-b951-d872f2087c98
* Closing IndexedDBConnection if still open in ↵cmumford@chromium.org2014-03-111-0/+2
| | | | | | | | | | | | | | | | | | IndexedDBContextImpl::ConnectionClosed() If the WebIDBDatabaseImpl destructor closes an open connection then this will result in the IndexedDBFactory having a dangling pointer to a deleted IndexedDBDatabase instance - because that is only removed when database is explicitly closed via IndexedDBDatabase::Close(). To protect against this the connection is closed, which in turn informs the IndexedDBFactory so that it can remove references. BUG=350100 Review URL: https://codereview.chromium.org/189843011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256135 0039d316-1c4b-4281-b951-d872f2087c98
* IndexedDB: Remove invalid DCHECK that database name is non-emptyjsbell@chromium.org2014-03-091-1/+0
| | | | | | | | | | | | | | Nothing in the spec - or Blink implementation - precludes empty names for databases. Remove this bogus DCHECK. Will add Blink-side layout tests once this lands. BUG=350133 R=cmumford Review URL: https://codereview.chromium.org/189413007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255828 0039d316-1c4b-4281-b951-d872f2087c98
* IndexedDB: Don't timeout read-only transactionsjsbell@chromium.org2014-03-072-6/+41
| | | | | | | | | | | | | | | | Chrome introduced a transaction timeout to deal with potentially wedged renderers (e.g. JS execution halted, etc) failing to complete transactions, leaving the browser's transaction queue in a bad state. This was done for all transactions, but since read-only transactions don't hold up the queue it's safe to ignore them, which can reduce false-positives. BUG=339229 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254846 Review URL: https://codereview.chromium.org/180163010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255673 0039d316-1c4b-4281-b951-d872f2087c98
* Move WriteFile and WriteFileDescriptor from file_util to base namespace.brettw@chromium.org2014-03-061-1/+1
| | | | | | | | | R=viettrungluu@chromium.org TBR=viettrungluu Review URL: https://codereview.chromium.org/184563006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255418 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of IndexedDB: Don't timeout read-only transactions ↵stgao@chromium.org2014-03-042-36/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/180163010/) Reason for revert: Break Chromium Memory on Linux ASan+LSan Tests (2) http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/65/steps/content_unittests/logs/NoTimeoutReadOnly Original issue's description: > IndexedDB: Don't timeout read-only transactions > > Chrome introduced a transaction timeout to deal with potentially wedged > renderers (e.g. JS execution halted, etc) failing to complete transactions, > leaving the browser's transaction queue in a bad state. This was done > for all transactions, but since read-only transactions don't hold up > the queue it's safe to ignore them, which can reduce false-positives. > > BUG=339229 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254846 TBR=dgrogan@chromium.org,cmumford@chromium.org,jsbell@chromium.org NOTREECHECKS=true NOTRY=true BUG=339229 Review URL: https://codereview.chromium.org/185403019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254868 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-26 05:04:01 +0000