| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit da22c3c95242b05675da6b5e452c5dad8c5db1ee.
TBR=japhet@chromium.org
BUG=364781
Review URL: https://codereview.chromium.org/268783004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=364781
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/252743007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=297026
R=ben@chromium.org
Review URL: https://codereview.chromium.org/231733005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of going through the renderers.
BUG=286074
R=ananta@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260678
Review URL: https://codereview.chromium.org/217593003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Causing mac debug bot assert.
> Make http range requests by plugins also go directly to the browser process instead of going through the renderers.
>
> BUG=286074
> R=ananta@chromium.org
>
> Review URL: https://codereview.chromium.org/217593003
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/220323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
instead of going through the renderers.
BUG=286074
R=ananta@chromium.org
Review URL: https://codereview.chromium.org/217593003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See
https://docs.google.com/document/d/1H-hCsIcMsAEP0fWHimbuiNA-Hc9eXEmR94eb-2RQAhA/edit?usp=sharing
for background.
This moves all process type dependent decisions on how to create
Linux processes (not how to sandbox them once created, not Android)
into the launch delegates and makes the arguments to the
ChildProcessLauncher constructor and
BrowserChildProcessHostImpl::Launch OS independent.
BUG=none
Review URL: https://codereview.chromium.org/177863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We need them (as well as other storage contexts) for further
browser-side plumbing.
BUG=349319
Review URL: https://codereview.chromium.org/195013003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by the site's URL.
Code in content always gets it now from ContentClient::GetUserAgent. In Chrome, there's a GetUserAgent function which returns it.
BUG=338338
R=isherman@chromium.org, pauljensen@chromium.org, scottmg@chromium.org, tfarina@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255858
Review URL: https://codereview.chromium.org/191093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are some browser_tests failures on the buildbots that don't reproduce locally. Reverting while I investigate.
> Simplify the user agent code some more since after r255534 it's not affected by the site's URL.
>
> Code in content always gets it now from ContentClient::GetUserAgent. In Chrome, there's a GetUserAgent function which returns it.
>
> BUG=338338
> R=isherman@chromium.org, pauljensen@chromium.org, scottmg@chromium.org, tfarina@chromium.org
>
> Review URL: https://codereview.chromium.org/191093002
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/192283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by the site's URL.
Code in content always gets it now from ContentClient::GetUserAgent. In Chrome, there's a GetUserAgent function which returns it.
BUG=338338
R=isherman@chromium.org, pauljensen@chromium.org, scottmg@chromium.org, tfarina@chromium.org
Review URL: https://codereview.chromium.org/191093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to ensure that we mark these processes as DPI aware at startup. Needed because NPAPI plugins perform UI operations like
creating windows parented to the browser etc.
BUG=341543
R=cpu@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/139253003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows systems for the rare operations that require administrator access.
IPCs to the utility process will be filtered when it is running elevated.
BUG=331881
Review URL: https://codereview.chromium.org/98603007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable Carbon plugin interposing by default. The theory is that there
are probably not any must-not-break plugins still relying on the Carbon
calls, so this is likely no longer necessary. Keeping the flag, but
flipped, will allow for easy testing if any bugs do show up.
BUG=157130
Review URL: https://codereview.chromium.org/110853009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initiated request.
This bug occurred because in certain conditions a renderer could have multiple channels open to the same plugin process. Every time a renderer creates an instance of a plugin, we reach NPChannelBase::GetChannel in the plugin process which consults a singleton to see if there's a channel to that renderer, and if not it creates it. When a plugin instance is removed, it ends up calling into NPChannelBase::RemoveRoute which, if it's the last instance to that renderer, will remove the PluginChannel from the map. The key thing is that the PluginChannel is still alive as long as there are live NPObjects using it. So if the renderer creates another plugin instance, then a new PluginChannel will be created. When the old PluginChannel is destroyed though, the entry in the browser process' map would be incorrectly deleted even though there's another PluginChannel to that renderer.
The fix is to make the map in PluginProcessHost ref counted.
BUG=302530
R=ananta@chromium.org
Review URL: https://codereview.chromium.org/25700008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=302530
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/25555006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This allows us to hide the OnMessageReceived which shouldn't be overridden from child classes, and also avoid the pattern of requiring an overridden method to have to call to the base class.
R=scherkus@chromium.org, scherkus
Review URL: https://codereview.chromium.org/24514003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
going through the renderer. This is needed because when we have site isolation enabled we won't trust the renderer to fetch urls from arbitrary origins, which is something that NPAPI plugins can do.
In a followup I'll implement range requests.
For now this is behind the --direct-npapi-requests flag.
BUG=286074
R=ananta@chromium.org, jschuh@chromium.org
Review URL: https://codereview.chromium.org/23503043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
re-implements the Posix version to be more like the Windows version and to share some parsing code. The new version will be somewhat slower due to some extra mallocs, but is shorter and more clear. I didn't want to implement a super optimized version on Windows, and the alternative would be to keep the new Windows version and the old Posix version in parallel which seemed less desirable.
This changes the input from a vector to a map and just adds the map on the LaunchOptions rather than requiring the caller to set a pointer. This cleans up the callsites somewhat.
BUG=
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/22750002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=237249
TBR=scottmg
Review URL: https://codereview.chromium.org/19894003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notes:
-gtk_plugin_container_manager* and gtk_plugin_container* move to content/browser/renderer_host/ since that's all where they're used
-plugin_list* and plugin_constants_win* move to content/common as they're used by child processes and the browser
-webplugin_impl* and webplugin_page_delegate.h move to content/renderer as that's where they're used. I will remove webplugin_page_delegate.h in a followup change as it's no longer needed.
-the rest moves to content/child/npapi
-a few constants moved from plugin_constants_win.h to plugin_util.h temporarily
BUG=237249
TBR=scottmg
Review URL: https://codereview.chromium.org/19761007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16625010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16408017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need a place to put code that is shared between child processes of different
types but not used in the browser process. For instance, the NPObject bindings
code is used in the plugin and renderer processes but depends on WebBindings
which the browser shouldn't depend on. Some web platform features require shared
code between renderer and worker processe. The WebKit image decoders are used
by worker, renderer and utility processes.
This creates a content/common_child directory for code shared by more than one
child process type. content/common_child can depend on content/common and all
content/ subdirs except for content/browser and content/common can depend on it.
The java bridge code is (more than a) bit busted since it pulls the NPObject
bindings in to the browser, but since this code is only intended for use on
android single-process configurations I've just created DEPS exceptions for
this bit of code.
BUG=241606
Review URL: https://chromiumcodereview.appspot.com/15047014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/14606009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/14339002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
callers of ChildProcessLauncher specify whether the process should be sandboxed or not through the SandboxedProcessLauncherDelegate interface.
BUG=191682
Review URL: https://codereview.chromium.org/12886041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for all processes. Instead have whoever creates a sandboxed process set this data. This allows us to clean a few NaCl related changes in content:
-remove NaCl sandbox rules from content
-remove the hack for ifdef'ing out the GPU policy since it didn't link for nacl64.exe
-remove the 1GB memory reservation for the NaCl loader process out of content
Other cleanup:
-renamed sandbox_policy.* to sandbox_win.* to match the other platform-specific sandbox files
-moved BrokerGetFileHandleForProcess to internal content files since it's not called from outside
-remove AddGpuDllEvictionPolicy since it was redundant (the one dll it removed was already listed in the generic list)
There's still more cleanup to be done in the sandbox code (i.e. remove chrome frame switch, nacl process type switch etc). I will do that in future changes.
BUG=191682
Review URL: https://codereview.chromium.org/12805004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disabled. CA plugins have been rendered through Chrome's compositor for several releases now and it has not been found necessary to revert back to the older behavior.
If the compositor is disabled, then support for the Core Animation and Invalidating Core Animation drawing models is no longer advertised.
Tested with the Unity and NPAPI Flash plugins. As expected, Unity no longer renders with the compositor disabled; NPAPI Flash falls back to the Core Graphics drawing model. (Pepper Flash is not affected; it happens to require the compositor before and after this change.)
BUG=105344
Review URL: https://chromiumcodereview.appspot.com/12641008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=170921
Review URL: https://codereview.chromium.org/12212089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12213066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11235068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allows testing without the Carbon in Mac plugins, to see how many of the
major plugins rely on Carbon calls (directly, or via indirect calls from
Cocoa to Carbon).
This is an incremental step to hopefully being able to remove this library
all together now that most plugins have hopefully moved away from
depending on Carbon.
BUG=157130
Review URL: https://chromiumcodereview.appspot.com/11236028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Logging doesn't work in utility process due to the related command line
options are not passed to utility process. For example, run
" ./chrome --vmodule=unpacker=1 --enable-logging=stderr", DVLOG(1)
message in unpacker.cc can not be output correctly. This patch passes the
related command line options to utility process.
BUG=
TEST=--enable-logging=stderr --vmodule=unpacker=1, then open chrome://extensions, drag a foo.crx in the page, you can see the DVLOG message " Installing extension ".
Review URL: https://chromiumcodereview.appspot.com/11103028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=153599
Review URL: https://chromiumcodereview.appspot.com/11049004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it easier to debug what is being blocked by the sandbox.
gpu and renderer processes were already covered, this adds propagation
for utility and worker processes, and nacl, pepper and npapi plugin
processes. The points to handle were discovered by looking for
kNoSandbox cases, which is why NPAPI is on the list, even though we do
not sandbox it on OSX at this time.
BUG=152327
TEST=--enable-sandbox-logging and look for messages from subprocesses in /var/log/syslog.log
Review URL: https://chromiumcodereview.appspot.com/10978037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Scrolling jank is noticable because the plugin moves at a different time than the content is updated. There are also a couple of other functions in RenderWidgetHostViewWin that enumerate plugin Windows that need to be shared, but I'm leaving these for a future change.
The code in render_widget_host_view_base.cc is all moved from render_widget_host_view_win.cc with the exception of the lines between the USE_AURA ifdef.
Review URL: https://codereview.chromium.org/10905122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[TPM is suspicious of Windows renderer crash rate. Seems impossible,
but who knows?]
It is useful to record breakpad keys for debugging, which is not
applicable to multi-process bugs. This adds infrastructure to allow
collection of information across processes.
Also, fix so that GetPluginChannelHost() can successfully fail without
crashing.
BUG=97285,141055
Review URL: https://chromiumcodereview.appspot.com/10908078
TBR=shess@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10908130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is useful to record breakpad keys for debugging, which is not
applicable to multi-process bugs. This adds infrastructure to allow
collection of information across processes.
Also, fix so that GetPluginChannelHost() can successfully fail without
crashing.
BUG=97285,141055
Review URL: https://chromiumcodereview.appspot.com/10908078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
they're the ones who bundle it. Make content still work without it. This allows plugins to work inside content_shell.
BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10806075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When compositing is disabled or blacklisted we won't be able to composite core animation plugins, so disable them.
BUG=122430
TEST=flash works on nytimes.com with --disable-accelerated-compositing
TBR=kbr
Review URL: https://chromiumcodereview.appspot.com/10695027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When compositing is disabled or blacklisted we won't be able to composite core animation plugins, so disable them.
BUG=122430
TEST=flash works on nytimes.com with --disable-accelerated-compositing
Review URL: https://chromiumcodereview.appspot.com/10542112
TBR=jbauman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10698028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When compositing is disabled or blacklisted we won't be able to composite core animation plugins, so disable them.
BUG=122430
TEST=flash works on nytimes.com with --disable-accelerated-compositing
Review URL: https://chromiumcodereview.appspot.com/10542112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104040
R=ben@chromium.org
TBR=tony@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10392068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add gtk dependency to base.gyp for android host_os="linux" case
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9969080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=115758
Review URL: https://chromiumcodereview.appspot.com/9460038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
base::file_handle_mapping_vector to StudlyCaps.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9429039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=113891
Review URL: http://codereview.chromium.org/9386003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Content API (i.e. don't have setters/getters on it, and make all the functions pure virtual).
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9369009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121287 0039d316-1c4b-4281-b951-d872f2087c98
|