| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
referenced in content/port anymore.
BUG=304341
R=avi@chromium.org
Review URL: https://codereview.chromium.org/264033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android currently uses custom TouchEvent timeout logic on unresponsive desktop
sites. The existence of this timeout has been a trouble spot, so move it to
a common, visible location where it can be examined and used by other platforms.
BUG=305273
Review URL: https://codereview.chromium.org/48973005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The OverscrollController queries the RenderWidgetHostImpl to determine if
an event should be forwarded for dispatch. Eliminate this call by returning
an event disposition, allowing the router to perform the query instead.
BUG=306194
Review URL: https://codereview.chromium.org/27535002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The path that any given WebInputEvent takes through the RenderWidgetHost,
through the InputRouter and on to the renderer, is too complex. Simplify
how events are routed, moving OverscrollController event dispatch code
into the router, removing all InputRouterClient::OnFooEvent callbacks, and
unifying how acks are processed synchronously from either being filtered
or consumed by the OverscrollController.
This originally landed as r228554, but was reverted due to deallocation issues
after keyboard ack-triggered shutdown. A workaround has been added, and
crbug.com/274029 has been filed to permanently fix the issue.
BUG=302492
Review URL: https://codereview.chromium.org/26775003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r228554 due to linux asan failure:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/16857/steps/interactive_ui_tests/logs/HandlersRegistered
TBR=jdduke
BUG=302492
Review URL: https://codereview.chromium.org/26343004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The path that any given WebInputEvent takes through the RenderWidgetHost,
through the InputRouter and on to the renderer, is too complex. Simplify
how events are routed, moving OverscrollController event dispatch code
into the router, removing all InputRouterClient::OnFooEvent callbacks, and
unifying how acks are processed synchronously from either being filtered
or consumed by the OverscrollController.
BUG=302492
Review URL: https://codereview.chromium.org/26775003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Make OverscrollController less intrusive to input-event dispatching. With this
change, the OverscrollController consumes an event on its way to dispatch only
if the event contributes to the overscroll.
* When an overscroll is in progress, and a gesture event comes in, this event is
not dispatched to the GestureEventFilter from RenderWidgetHostImpl. So, if the
event should be dispatched to the renderer, make sure it always goes through
the host from the OverscrollController.
* Remove HasQueuedGestureEvents() from InputRouter interface, and forward all
gesture events through the RenderWidgetHost from the overscroll-controller.
BUG=none
R=aelias@chromium.org, jdduke@chromium.org
Review URL: https://codereview.chromium.org/23801003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The BufferedInputRouter batches input events into EventPackets. The delivery of
these packets is dependent on periodic flush signals, as requested by the
InputRouterClient. A given flush involves the forwarding of EventPackets to the
renderer until all InputEvents from the original packet have been dispatched.
BUG=245499
Review URL: https://chromiumcodereview.appspot.com/20356003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Input event handling code in RenderWidgetHostImpl has evolved such that making
related changes is a fragile and delicate process. This patch factors out such
code into a single ImmediateInputRouter class, implementing an abstract
InputRouter. This makes minor input-related changes more self-contained, and
enables major changes to progress in parallel, as with the implementation of
the BufferedInputRouter.
BUG=245499
Review URL: https://chromiumcodereview.appspot.com/15789009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This seems to have broken RenderViewHostTest.BadMessageHandlerInputEventAck on
linux and chromeos on the waterfall.
> Factor out input event handling code from RenderWidgetHostImpl to InputRouter
>
> Input event handling code in RenderWidgetHostImpl has evolved such that making
> making related changes is a fragile and delicate process. This code factors out
> such code into a single ImmediateInputRouter class, implementing an abstract
> InputRouter. This makes minor input-related changes more self-contained, and
> enables major changes to progress in parallel, as with the implementation of
> the BufferedInputRouter.
>
> BUG=245499
>
> Review URL: https://chromiumcodereview.appspot.com/15789009
TBR=jdduke@chromium.org
Review URL: https://codereview.chromium.org/19492016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Input event handling code in RenderWidgetHostImpl has evolved such that making
making related changes is a fragile and delicate process. This code factors out
such code into a single ImmediateInputRouter class, implementing an abstract
InputRouter. This makes minor input-related changes more self-contained, and
enables major changes to progress in parallel, as with the implementation of
the BufferedInputRouter.
BUG=245499
Review URL: https://chromiumcodereview.appspot.com/15789009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212684 0039d316-1c4b-4281-b951-d872f2087c98
|