| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change has resulted in severe regressions in keyboard event dispatching -
the keydown and keypress events are no longer dispatched synchronously. Reverting as suggested by Darin Fisher.
BUG=106224
TEST=manual
TBR=darin
Review URL: http://codereview.chromium.org/8885009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
or select text.
BUG=104468,104469
TEST=none
Review URL: http://codereview.chromium.org/8776030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8704005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
shortcut handling to the RenderWidgetHost.
R=jam@chromium.org
Review URL: http://codereview.chromium.org/8727010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Plumbs the partial swap through on platforms that support it (currently just Linux GLX).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8513013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
RenderWidgetHostView implementation ask the RenderWidgetHost to ack for the swap buffers GPU message.
Review URL: http://codereview.chromium.org/8595002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes.
The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h.
Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now.
Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL.
BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8515027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Threaded compositing doesn't ever call DoDeferredUpdate, so never has a chance
to send the resize ack via an update message back to the browser. Fix by piping
through didBeginFrame (called at the beginning of a main thread frame) and
didFinishFrame (called during the client side OnSwapBuffers when a main thread
frame has been committed). This patch queues up update messages during
didBeginFrame and then sends them out during the corresponding didFinishFrame.
BUG=103776
TEST=run with threaded compositing, resize page multiple times
Review URL: http://codereview.chromium.org/8528006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thought I had finished with my last CL.
. Disable a check in BrowserMessageFilter that these messages are not handled on the UI thread, for Aura. In Aura, these messages need to be handled on the UI thread (since aura::Windows are not threadsafe). We do not have the NPAPI plugin constraints regular windows has, so this check is not important.
. Properly handle these messages in RWH, by sprinkling in some more defined(USE_AURA) to go with the defined(OS_POSIX).
. Properly define RenderWidgetHostView::GetDefaultScreenInfo() (it was being done as an override to a static?.. oops).
. Get rid of the USE_AURA NOTIMPLEMENTED() definition of the above in render_widget_host_view.cc, replacing with an impl in rwhva.cc. Also moves the _mac and _touch variants to their own .mm/.cc files.
. Gets rid of WillWmDestroy for Aura. It's normal-windows-only.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8566011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
RenderWidgetHost.
BUG=103667
TEST=in about:tracing, verify that the chrome UI thread doesn't show lots of tasks from StartHangMonitorTimeout.
Review URL: http://codereview.chromium.org/8510038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderWidgetHostView*
BUG=64859
TEST=None
Review URL: http://codereview.chromium.org/8491031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, painting from a TransportDIB onto a BackingStoreGtk would queue
several X drawing commands (which are asynchronous by nature) and then call
XSync(), which blocks the UI thread until the current event queue has been
handled. For full content area redraws, this can block the UI thread for 100ms.
Now, as long as the X server has the XSyncExtension, instead of blocking the UI
thread until the drawing queue has been cleared, we push a special command onto
the drawing queue which sends us an XEvent after that command was handled on
the X server. RenderWidgetHost::OnMsgUpdateRect() has been split into the part
that happens before and after the paint that sends the ACK back to the renderer.
We call that via a base::Closure if we can do the asynchronous trick.
This really helps message throughput.
BUG=83106
TEST=none
Review URL: http://codereview.chromium.org/8438054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Deletes code that incorrectly used a stat counter instead of a histogram,
and adds a function that runs 10 seconds after the browser starts and
updates a UMA enum histogram with the status of whether accessibility is
enabled or not. Also makes it so that manually enabling accessibility
from the command-line triggers this as well - we may want to separate
this out later.
BUG=99504
TEST=none
Review URL: http://codereview.chromium.org/8479015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
japhet synthesized this state in the renderer from just the focus
bit, which caused a mac-only regression. This is a prerequisite for
the fix.
BUG=101599
TEST=none
Review URL: http://codereview.chromium.org/8439049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: http://codereview.chromium.org/8382021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser.
BUG=98716
Review URL: http://codereview.chromium.org/8342048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content/public/browser.
This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header.
BUG=98716
TBR=joi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content\public\browser. I dropped the "content" from the name to match other files whose chrome version adds a "chrome_" prefix. I also moved it to the browser directory since notifications are only used in the browser process. I will move the other notification files in future changes.
BUG=98716
Review URL: http://codereview.chromium.org/8331001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lock the mouse.
This will be needed when adding mouse lock bubble infobar UI.
BUG=95136
TEST=None
Review URL: http://codereview.chromium.org/8306019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Match Style' on Mac)
MainMenu.xib details:
- Change 'Paste and Match Style' to send the pasteAndMatchStyle: message.
BUG=25238
TEST=In an editable field on a web page, right-click to 'Paste as plain text'.
Review URL: http://codereview.chromium.org/8234006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
text features
BUG=None
TEST=Manually
Review URL: http://codereview.chromium.org/7981036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
prior to refactoring/cleanup.
TBR=jam@chromium.org
http://crbug.com/99757
TEST=none
Review URL: http://codereview.chromium.org/8289005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderWidget.
This enables the RenderWidget to know when it has been placed into fullscreen
mode (which will be hooked up to Pepper in a subsequent change).
BUG=100264
Review URL: http://codereview.chromium.org/8283029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: http://codereview.chromium.org/8277018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Once webkit change https://bugs.webkit.org/show_bug.cgi?id=69846 is in,
it'll be fixed completely.
BUG=91003
TEST=press and hold a, then hit 1. An accented a should appear, the
unaccented a should disappear.
Review URL: http://codereview.chromium.org/8227018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
accessibility is enabled.
BUG=99504
TEST=none
Review URL: http://codereview.chromium.org/8205009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two new classes: InputEventFilter and CompositorThread.
The first sets up a MessageFilter designed to route input events
to the compositor thread. CompositorThread sets up the compositor
thread and it has a InputEventFilter.
When we pass an event to the CompositorThread, we are actually
passing it to a WebCompositor, which can respond asynchronously
via WebCompositorClient to tell us whether it handled the event or
wants us to punt it up to the WebWidget. It can also tell us that
it did not handle the event and that we should not bother sending
it to the WebWidget.
InputEventFilter contains all of the interesting thread marshalling
code. CompositorThread has the WebCompositor hookup.
Review URL: http://codereview.chromium.org/8089002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=41781
TEST=Manual test in ppapi/examples/mouse_lock.
Review URL: http://codereview.chromium.org/8072011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to chrome/
BUG=95257
TEST=none
Review URL: http://codereview.chromium.org/8103004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
version of the browser side.
BUG=41781
TEST=Manual test in ppapi/examples/mouse_lock
Review URL: http://codereview.chromium.org/7863003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with corresponding APIs
on the RenderWidgetHost/RenderViewHost objects. Moved the Edit operation APIs out of RenderViewHost to
RenderWidgetHost.
1. ViewMsg_UpdateWebPreferences
2. ViewMsg_SetBackground
3. ViewMsg_AccessibilityDoDefaultAction
4. ViewMsg_SetAccessibilityFocus
5. ViewMsg_ScrollFocusedEditableNodeIntoRect
6. ViewMsg_SelectRange
7. ViewMsg_Cut
8. ViewMsg_Copy
9. ViewMsg_Paste
10. ViewMsg_Delete
11. ViewMsg_SelectAll
12. ViewMsg_ClearFocusedNode
13. ViewMsg_SetAltErrorPageURL
14. ViewMsg_ExitFullscreen
Continuing fixes to ensure that IPC messages don't span across content and
chrome.
BUG=87335.
TEST=no change in functionality.
Review URL: http://codereview.chromium.org/7972006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The mouse wheel event coalescing logic didn't account for new WebMouseWheelEvent members.
BUG=97265
TEST=per bug
Review URL: http://codereview.chromium.org/7976012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7973003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
replaced them with
corresponding API's on the RenderWidgetHost object.
1. ViewMsg_Zoom.
2. ViewMsg_ReloadFrame.
3. ViewMsg_Find.
4. ViewMsg_CSSInsertRequest.
5. ViewMsg_DisableScrollbarsForSmallWindows.
6. ViewMsg_EnablePreferredSizeChangedMode.
Continuing fixes to ensure that IPC messages don't span across content and chrome.
BUG=87335.
TEST=no change in functionality.
Review URL: http://codereview.chromium.org/7923023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
'use_aura': 1,
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7850026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is a nearly-mechanical translation of wstring to string16.
Removes a *ton* of string conversions.
Review URL: http://codereview.chromium.org/7886023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
original CL w/LGTMs: http://codereview.chromium.org/7812036/
Review URL: http://codereview.chromium.org/7824041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so the original code that created the delayed callback is lost."
This reverts commit 4cf5cf73d319b69c32ad30af8954235755856455. (r99284)
TBR=jbates@chromium.org
Review URL: http://codereview.chromium.org/7825026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the original code that created the delayed callback is lost.
This change adds a tracked_objects::Location parameter to the APIs in base/timer.h so we can trace the PostTask callbacks. The other files are touched to add the FROM_HERE Location parameter.
Review URL: http://codereview.chromium.org/7812036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderWidgetHostViwe::GetNativeViewId
[Linux/Mac] Changed RenderWidgetHost::GetScreenInfo/GetWindowRect/GetRootWindowRect to use RWHV instead of NativeViewId as use of NativeViewId is no longer necessary.
This is necessary to allow us to switch RWHV implementations
(RenderWidgetHostViewGtk and RenderWidgetHostViewViews) on the fly. (Windows will need something similar to support NPAPI with pure views, but this part is not implemented)
The current code doesn't work with RenderWidgetHostWin as win uses IPC method to get screen/window information and needs more work.
BUG=none
TEST=none No functional change. All test should pass.
Review URL: http://codereview.chromium.org/7670039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverts a large chunk of: http://crrev.com/96387
This is now done in the renderer by WebKit.
Depends on: https://bugs.webkit.org/show_bug.cgi?id=66226
BUG=88353,92645
TEST=manual
Review URL: http://codereview.chromium.org/7671019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gesture
Use the intended APIs for swipe tracking. Remove the old, wrong, and now unneeded two-finger swipe detection code. Make target 'browser' depend on the block support target, since this is the first CL that uses ObjC blocks (only on 10.7).
No UI yet.
Approach:
* Scroll events are always first sent to the renderer
* RWH informs its view if a wheel event came back unhandled
* If a scroll event came back, and the viewport is pinned to
the left or there is no horizontal scrollbar, a back navigation
is triggered
* If a scroll event came back, and the viewport is pinned to
the right or there is no horizontal scrollbar, a forward navigation
is triggered
Depends on https://bugs.webkit.org/show_bug.cgi?id=66206
BUG=91513,90652,92786,90228,91144
TEST=
1.) Open http://en.wikipedia.org/wiki/Main_Page , then click a link and go back (so that back and forward buttons are active). Swiping left should go back, swiping right should go forward. Make browser window narrow so that horizontal scroller appears. Now sliding should scroll first if not at the edge, and trigger history if the viewport is on an edge at gesture start.
2.) Open http://pastie.org/2371939 . Scrolling over the div shouldn't trigger history, scrolling everywhere else should (or if there's no history, bounce instead)
3.) Open http://maps.google.com/ . Scrolling over the map area shouldn't trigger history, scrolling over the search box should.
4.) Open http://itunes.apple.com/us/app/cut-the-rope/id380293530?mt=8 Scrollling over the screenshot area should move screenshots (slowly), should tigger history (or bounce) everywhere else.
5.) With the back button active but the forward button inactive, going left/right/left/right in a single gesture should toggle between history on the left and bouncing on the right seamlessly.
Test this with an MBP, a magic trackpad, a magic mouse, and with scroll directions set to "natural" on and off in sysprefs. Also set "Swipe between pages" to three fingers and check if that works, and disable it and check that it's disabled.
Also check that the behavior on 10.5/10.6 and the behavior of mouses with conventional scroll wheels didn't change.
Review URL: http://codereview.chromium.org/7618036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=88353
TEST=On Lion, scroll past the edge of the web content area and see textured over-scroll area.
Review URL: http://codereview.chromium.org/7582009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Update extract_actions.py to scan for metrics specified in the WebUI code. A common pattern is <input pref="blah" metric="Options_Blah" type="checkbox">.
* Clean up almost all of the existing warnings thrown by extract_actions.py. There is one remaining use of RecordComputedAction that is a bit too subtle for me to lump into this patch.
* Add a new warning to extract_actions.py that scans for uses of UserMetricsAction with a non-literal string. Any such uses are going to be missed by the script, and hence should use RecordComputedAction instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7314020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23581
Review URL: http://codereview.chromium.org/7583038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Eventually, we need to remove all current instances of AllSources(). One by
one, they need to either changed to listen to a specific notification source,
or (in very few cases where we actually are listening for a global
notification) they need to work correctly in the presence of multiple profiles,
in which case they'll be turned to AllBrowserContextsAndSources().
This patch, in addition:
- Deletes more unused notifications.
- Changes a few AllSources() calls to listen to specific objects.
BUG=87457
TEST=none
Review URL: http://codereview.chromium.org/7548022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
visibility change notifications.
BUG=88100
TEST=none
Review URL: http://codereview.chromium.org/7291026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_notification_types.h.
This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END
which defines the end of the enum used by content to define notification types. The notificaton_type.h file
in content\common has been renamed to content_notification_types.h
BUG=76698
Review URL: http://codereview.chromium.org/7327007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead it is stored in a map in RenderWidgetHelper indexed by RenderWidgetHost route ID. This allows the UI thread to maintain the mapping as windows are created and destroyed and the IO thread to lookup the mapping in order to create GL contexts that render to the windows.
This avoids a race where JavaScript would open a popup window and immediately try to use an accelerated canvas to render to it (2D canvas or WebGL canvas). <-- This is no longer true of this patch. There was a potential deadlock.
WebGL canvas used to work in this case only because it would fall back to using ReadPixels.
This goes some way to fixing the bug referenced below but does not fix it completely.BUG=80703
Review URL: http://codereview.chromium.org/7136001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=85932
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90435
Review URL: http://codereview.chromium.org/7233022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90495 0039d316-1c4b-4281-b951-d872f2087c98
|