| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
These are just compositing triggers. GPU_FEATURE_TYPE_ACCELERATED_VIDEO
is completely ignored, and there's no reason to disable the compositing
trigger since FCM is always on in production.
BUG=362164
Review URL: https://codereview.chromium.org/240253006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We ignore GPU_FEATURE_TYPE_3D_CSS, so remove it.
Nothing sets --disable-accelerated-layers, and it doesn't correspond to
a production path, so remove it.
This lets us clean up some WebPreferences fields which are always set to
true.
Also remove WebPreferences::accelerated_compositing_for_plugins_enabled
which is always true.
BUG=362164,365847
R=bbudge@chromium.org, danakj@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/239973005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=337142,316394
TBR=kinuko@chromium.org
Review URL: https://codereview.chromium.org/247313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This cl depends on https://codereview.chromium.org/244903002/.
BUG=365235
Review URL: https://codereview.chromium.org/244623004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=348921
Review URL: https://codereview.chromium.org/242973006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome://serviceworker_internals.
Because version ids are unique within a storage partition but not across them, verion_id by itself is not sufficient to identify a version.
BUG=359517
Review URL: https://codereview.chromium.org/242923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The compositing field should show if hardware or software compositing
is being used, and if the thread is being used in either case.
ForceCompositingMode doesn't exist anymore (it's always on) so just
remove it from the page.
R=piman@chromium.org, zmo@chromium.org
BUG=363772
Review URL: https://codereview.chromium.org/238043006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=362782
TEST=gpu_unittests
R=ajuma@chromium.org, kbr@chromium.org
Review URL: https://codereview.chromium.org/240243005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=337142
R=jochen@chromium.org
TBR=jochen@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/235883014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the browser process receives the error of the top-level script EmbeddedWorkerInstance::OnStarted() is not called yet.
So onErrorReported() in serviceworker-internals.js is called with thread_id = -1.
And also onPartitionData() may not be called yet.
In this change:
- Only compare version_id.
- Save |error_info| to |errorLogs| variable and call displayErrorLogs() in onErrorReported().
- Call displayErrorLogs() in onPartitionData().
BUG=359517
Review URL: https://codereview.chromium.org/240503005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this cl we introduce ServiceWorkerContextObserver and make ServiceWorkerInternalsUI inherit from it.
In the constructor of ServiceWorkerContextWrapper we create ObserverListThreadSafe<ServiceWorkerContextObserver> and pass it to ServiceWorkerContextCore.
The methods of ServiceWorkerContextObserver will be called via ObserverListThreadSafe::Notify() called from ServiceWorkerContextCore on IO thread.
ServiceWorkerInternalsUI is registered to ObserverListThreadSafe in ServiceWorkerContextWrapper::AddObserver() on UI thread so these methods will be on UI thread.
BUG=359517
Review URL: https://codereview.chromium.org/236153004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Static initializers issue was fixed in r263789.
> Revert 263644 "[DevTools] Touch emulation in content."
>
> Reason for revert: broke
> http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/63653/
> by introducing two new static-initializers into the chrome binary:
> # velocity_tracker.cc ui::(anonymous namespace)::LeastSquaresVelocityTrackerStrategy::HORIZON
> # velocity_tracker.cc ui::(anonymous namespace)::ASSUME_POINTER_STOPPED_TIME
>
> > [DevTools] Touch emulation in content.
> >
> > When renderer requests touch emulation using mouse, host creates
> > a TouchEmulator object and passes mouse, mouse wheel and keyboard events
> > to emulator before sending them to renderer.
> >
> > Emulator completely blocks mouse-related events, and instead generates
> > touch events. Those touch events are handled over to gesture provider
> > after being acked by renderer. Resulting gestures are sent to the renderer.
> >
> > When shift is pressed, scroll gestures are converted to pinch gestures, so
> > user can scale the page. This is required because multitouch is not yet
> > supported by emulator.
> >
> > BUG=337142
> >
> > Review URL: https://codereview.chromium.org/138163016
>
> TBR=dgozman@chromium.org
>
> Review URL: https://codereview.chromium.org/237353003
TBR=fischman@chromium.org
Review URL: https://codereview.chromium.org/236063014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: broke
http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/63653/
by introducing two new static-initializers into the chrome binary:
# velocity_tracker.cc ui::(anonymous namespace)::LeastSquaresVelocityTrackerStrategy::HORIZON
# velocity_tracker.cc ui::(anonymous namespace)::ASSUME_POINTER_STOPPED_TIME
> [DevTools] Touch emulation in content.
>
> When renderer requests touch emulation using mouse, host creates
> a TouchEmulator object and passes mouse, mouse wheel and keyboard events
> to emulator before sending them to renderer.
>
> Emulator completely blocks mouse-related events, and instead generates
> touch events. Those touch events are handled over to gesture provider
> after being acked by renderer. Resulting gestures are sent to the renderer.
>
> When shift is pressed, scroll gestures are converted to pinch gestures, so
> user can scale the page. This is required because multitouch is not yet
> supported by emulator.
>
> BUG=337142
>
> Review URL: https://codereview.chromium.org/138163016
TBR=dgozman@chromium.org
Review URL: https://codereview.chromium.org/237353003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When renderer requests touch emulation using mouse, host creates
a TouchEmulator object and passes mouse, mouse wheel and keyboard events
to emulator before sending them to renderer.
Emulator completely blocks mouse-related events, and instead generates
touch events. Those touch events are handled over to gesture provider
after being acked by renderer. Resulting gestures are sent to the renderer.
When shift is pressed, scroll gestures are converted to pinch gestures, so
user can scale the page. This is required because multitouch is not yet
supported by emulator.
BUG=337142
Review URL: https://codereview.chromium.org/138163016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/205013002/
This is just the plumbing for the event, and a
chrome://serviceworker-internals button to activate it for debugging
purposes.
BUG=354112
Review URL: https://codereview.chromium.org/205033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=342685
Review URL: https://codereview.chromium.org/213703004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Each time you hit "start" or "stop" etc. in chrome://serviceworker-internals
the registration process is rerun, adding an addEventListener to each button
for each existing callback, causing a quadratic increase in event listeners.
This CL only allows the event to be registered once per button.
BUG=
Review URL: https://codereview.chromium.org/204573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the beginning of the internals page for service worker, to aid in
debugging and development. This lists all registered service workers and
allows you to manually start/stop the workers, as well as unregister them.
BUG=351197
Review URL: https://codereview.chromium.org/182383008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the graph drawing code assumes the minimum value displayed is 0.
Now it's extended to the actual value range including negative values.
BUG=347337
Review URL: https://codereview.chromium.org/182393003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
R=nduca@chromium.org
Review URL: https://codereview.chromium.org/173883008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before we only list information on why we disable a feature. It helps to also list information on why we apply a driver bug workaround.
BUG=330785
TEST=about:gpu
R=kbr@chromium.org, nduca@chromium.org
Review URL: https://codereview.chromium.org/171453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chrome://accessibility in Win8.
BUG=343865
Review URL: https://codereview.chromium.org/170963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
records are received.
This will get rid of the 1 second delay from waiting for setInternal to fire.
BUG=
Review URL: https://codereview.chromium.org/171263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of tracking ANGLE revisions manually, we've switched to
automatically embedding a commit id header. The ANGLE roll means
we need to update Chrome to the new version tracking.
BUG=343676
Review URL: https://codereview.chromium.org/164913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will enable displaying the BWE debug stats on chrome://webrtc-internals.
The JS is updated to special case the propagation delta value because the
value of the stat is a list and its timestamp is in the value of stat
receivedPacketGroupArrivalTime.
BUG=338380
Review URL: https://codereview.chromium.org/139473006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a non-perfect, temporary fix for the bug. It should be revisited after the M34 cut. There's e.g. discussions about tying this to getUserMedia. Bug for this: https://code.google.com/p/chromium/issues/detail?id=342770
BUG=342689
Review URL: https://codereview.chromium.org/152923005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It used to be limited to integer when the value <1024,
now changed to allow up to 2 decimal digits.
BUG=
Review URL: https://codereview.chromium.org/137703013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also use bold font for the stats table of the active ICE connection for highlight.
BUG=244648
Review URL: https://codereview.chromium.org/68103011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=332028
R=ajm@chromium.org, jansson@chromium.org, xians@chromium.org
Review URL: https://codereview.chromium.org/133013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 304023
Review URL: https://codereview.chromium.org/129833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The code is dead and we have no plan to implement RTP recording in the near term.
So removing to avoid confusion.
BUG=
Review URL: https://codereview.chromium.org/129533003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It was unprefixed back in Chrome 23.
BUG=330691
TEST=no behavior change
Review URL: https://codereview.chromium.org/121203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebRTCInternals caches the info to send to internal pages opened in the future.
The UI for representing the info on the internal page will be added later.
BUG=304023
Review URL: https://codereview.chromium.org/61733017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AEC dump = WebRTC echo canceller debug recordings.
This CL
- Adds a UI (checkbox) in chrome://webrtc-internals for enabling/disabling AEC dump.
- Hooking up the UI with the underlying functionality to enable/disable.
The UI part is originally done by jiayl@.
BUG=323928
R=fischman@chromium.org, jochen@chromium.org, joi@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/112683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds plumbing for streams to show up in chrome://media-internals as
well as have them identified since the Controller and Stream pages
are so similar.
BUG=260005
TEST=Streams show up properly labeled.
Review URL: https://codereview.chromium.org/104983006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to download the log through a form submission, which is recently
changed in Chrome to have an extra "?" at the end of the URL, which triggers
a navigation instead of a download. The change seems intended and consistent
with other browsers (see the issue for more details). So I'm now using an anchor tag to work around it.
BUG=323408
Review URL: https://codereview.chromium.org/100633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AVEA is the encode-side analogue of AndroidVideoDecodeAccelerator, or the
Android analogue of ExynosVideoEncodeAccelerator, depending on your POV.
Also included in this CL:
- MediaCodecBridge learns how to be an encoder, too.
- MediaCodecBridge::Start is sunk into Create since they were always called
together.
- android.os.Log() is given an exception parameter instead of concatenating its
.toString() (and losing its stacktrace!)
- MediaCodecBridge exposes its buffers to reduce unnecessary memcpy'ing
Performance impact: isolating encode performance by making Android decode only
240p and no audio send/receive with the following URLs:
z620/gprecise: https://apprtc.appspot.com/?video=maxHeight=240&audio=false&r=<ROOM>
Nexus5: https://apprtc.appspot.com/?video=minHeight=720,maxHeight=720,minWidth=1280,maxWidth=1280&audio=false&r=<ROOM>
All 4 cores are max'd are running at top speed (ondemand governor ramps them up
on its own with this workload).
SW encode: CPU utilization 80% and desktop receives 0.1-0.5FPS (jankily).
HW encode: CPU utilization 60-70% and desktop receives 30FPS reliably.
Comparing an easier workload of encoding 360p:
z620/gprecise: https://apprtc.appspot.com/?video=maxHeight=240&audio=false&r=<ROOM>
Nexus5: https://apprtc.appspot.com/?video=minHeight=360,maxHeight=360,minWidth=640,maxWidth=640&audio=false&r=<ROOM>
Set all 4 cores to "performance" governor for stable comparison.
SW encode: CPU utilization 63% and desktop receives 30FPS reliably.
HW encode: CPU utilization 53% and desktop receives 30FPS reliably.
BUG=313115
Review URL: https://codereview.chromium.org/74563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New and shiny!
- Interface lives in media.
- Adds support for tracking AudioOutputStreams instead of just
just AudioOutputControllers.
- Adds support for tracking AudioInputControllers (which are 1:1
with AudioInputStreams currently).
- Changes the API to be threadsafe from all threads instead of
just the IO thread.
- Removes the nebulous OnSetAudioStreamStatus().
- Removes OnMediaEvents() from the public media API, will still be
callable from the content implementation.
- "Improves" the style of media-internals.
- Fixes JavaScript errors from firing WebUI code before the WebUI
finishes loading.
- Fixes style inconsistencies around table headers.
- Fixes stuck "copy to clipboard" window.
Screenshot of the new UI: http://i.imgur.com/lzQds3e.png
Still to be done:
- Actually log AudioOutputStreams and AudioInputStreams.
BUG=260005
TEST=New unittest! Interface works.
Review URL: https://codereview.chromium.org/68173025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This makes it easier to find certain properties.
Review URL: https://codereview.chromium.org/63433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=316660
Review URL: https://codereview.chromium.org/66213005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also collapse the stats tables by default to avoid spamming page with uninteresting stats.
A screenshot of the new layout:
https://chromium.googlecode.com/issues/attachment?aid=2446480001000&name=Screenshot+from+2013-11-06+11%3A57%3A55.png&token=NZG93vkzJxi_nPIPcE5GAq9_hfI%3A1383768028226&inline=1
BUG=244648
Review URL: https://codereview.chromium.org/26852007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifying relative path works exactly the same as specifying absolute
path, as long as the script is declared using
WebUIDataSource::AddResourcePath (which it is in case of changed
WebUIs). So there is no behavioral change in case of Chromium. The
reason for this change is it makes the live of embedders of content
easier when embedder is loading the WebUI from a scheme that is not
chrome: (it is opera: for us). It allows us to save on on adding
security policy overrides for each content WebUI.
BUG=
Review URL: https://codereview.chromium.org/26930002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved GetFeatureStatus() from the gpu_internals_ui to compositor_util, so we can add it to the existing SystemInfo.getInfo API. This exposes the top three sections of the chrome://gpu page through DevTools to Telemetry.
BUG=296773
TEST=TBD
Review URL: https://codereview.chromium.org/24828002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
has no event log.
BUG=https://code.google.com/p/webrtc/issues/detail?id=2351
Review URL: https://chromiumcodereview.appspot.com/23698012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=260005
Review URL: https://chromiumcodereview.appspot.com/23754013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
More details for developers wanting to understand the behavior
of pages/workers using IndexedDB:
* process ID (of the renderer; matches Task Manager)
* transaction ID (unique within renderer)
* accurate queue state (created, blocked, started, running)
* age and run times
* completed and pending request counts
BUG=280741
Review URL: https://chromiumcodereview.appspot.com/23691048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new media-internals page is now default.
Along with moving files around, this CL also reverts the changes made in https://codereview.chromium.org/19722011 which added the flag --enable-new-media-internals.
BUG=260005
Review URL: https://chromiumcodereview.appspot.com/23769009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=260005
Review URL: https://chromiumcodereview.appspot.com/23454013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=260005
Review URL: https://chromiumcodereview.appspot.com/23536020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is an attempt to re-land https://codereview.chromium.org/23566014/ again, except now with some whitespace changes to work around http://crbug.com/284906
TBR=phajdan.jr@chromium.org
BUG=260005
Review URL: https://codereview.chromium.org/23686004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221121 0039d316-1c4b-4281-b951-d872f2087c98
|