| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=236029
R=avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14335017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is still failing on Mac10.7 Tests (1).
> Replace MediaStreamUIController with MediaStreamUIProxy.
>
> Previously a single object MediaStreamUIController was used to control UI for
> all streams. Replaced it with a per-stream MediaStreamUIProxy that simplifies
> code in many places.
> Also moved media request queueing logic from content layer to chrome. Now
> different types of requests may be queued differently (e.g. there is no
> reason to block screen capture requests on webcam infobar).
>
> This change was reviewed in https://codereview.chromium.org/13989003 and
> landed in r197222, but it had to be reverted reverted in r197242 because
> it caused test failures on buildbot "Mac10.7 Tests (1)". It's not clear
> what caused these failures - I could never reproduce them locally or on
> trybots.
>
> TBR=tommi@chromium.org
>
> Review URL: https://codereview.chromium.org/14584003
TBR=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/14824002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously a single object MediaStreamUIController was used to control UI for
all streams. Replaced it with a per-stream MediaStreamUIProxy that simplifies
code in many places.
Also moved media request queueing logic from content layer to chrome. Now
different types of requests may be queued differently (e.g. there is no
reason to block screen capture requests on webcam infobar).
This change was reviewed in https://codereview.chromium.org/13989003 and
landed in r197222, but it had to be reverted reverted in r197242 because
it caused test failures on buildbot "Mac10.7 Tests (1)". It's not clear
what caused these failures - I could never reproduce them locally or on
trybots.
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/14584003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Replace MediaStreamUIController with MediaStreamUIProxy.
>
> Previously a single object MediaStreamUIController was used to control UI for
> all streams. Replaced it with a per-stream MediaStreamUIProxy that simplifies
> code in many places.
> Also moved media request queueing logic from content layer to chrome. Now
> different types of requests may be queued differently (e.g. there is no
> reason to block screen capture requests on webcam infobar).
>
> TBR=tommi@chromium.org
>
> Review URL: https://codereview.chromium.org/13989003
TBR=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/14599002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously a single object MediaStreamUIController was used to control UI for
all streams. Replaced it with a per-stream MediaStreamUIProxy that simplifies
code in many places.
Also moved media request queueing logic from content layer to chrome. Now
different types of requests may be queued differently (e.g. there is no
reason to block screen capture requests on webcam infobar).
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/13989003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details.
BUG=234765
R=jam@chromium.org
Review URL: https://codereview.chromium.org/14386012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from content to chrome.
1. Added MediaStreamUI interface that is used by the content layer to
deliver notifications about state of each particular stream to the chrome.
2. Removed corresponding notifications from content::MediaObserver interface.
3. Cleaned up MediaStreamUIController, so now it always uses WebContents
pointers to identify tabs.
Review URL: https://chromiumcodereview.appspot.com/13695002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In r174057, ajwong@ added support for implicit testing to scoped_ptr<>. Removes
these in content/.
BUG=232084
Review URL: https://codereview.chromium.org/14081010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6.
Revert "Fix build after r193020."
This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a.
Revert "Really fix build after r193020."
This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This changelist was automatically generated using a clang tool.
BUG=171111
Review URL: https://codereview.chromium.org/13749004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change removes the error_code parameter to OnError() calls
as the parameter is not used when ending up in AudioRendererHost.
BUG=218641
Review URL: https://chromiumcodereview.appspot.com/12611030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For screen capture API we need to be able to stop media streams from screen
capture notification UI. This CL adds a callback parameter in
MediaObserver::OnCaptureDevicesOpened() that will allow chrome to notify
the content layer when screen capture needs to be stopped.
BUG=190156
Review URL: https://chromiumcodereview.appspot.com/12900004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98716
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12387070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doesn't appear to do anything. We DCHECK that it's true than if check
and call ShowAudioInputSettings(). However calling ShowAudioInputSettings()
when its false just does nothing, so there's no point in having the check.
BUG=none
TEST=compiles.
Review URL: https://codereview.chromium.org/12252025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Automated clean up of style checker errors that were missed due to the plugin
not being executed on implementation files.
BUG=115047
Review URL: https://chromiumcodereview.appspot.com/12210030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also enables speech bubble for platform apps in general.
Refactor FakeSpeechRecognitionManager so it's possible to use from public content API.
BUG=164382
TEST=browser_tests.WebViewSpeechTest.*;
content_browsertests.SpeechRecognitionBrowserTest.TestBasicRecognition*
Review URL: https://chromiumcodereview.appspot.com/12049025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=dalecurtis
TBR=darin,garykac
BUG=165264
Review URL: https://codereview.chromium.org/11791006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11618049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
deleting arrays.
This is based on the modifications by "Geoffrey Romer"
<gromer@google.com> to Google's internal version of scoped_ptr<>. All cleaver tricks are his, not mine. :)
It brings most of the features of C++11's unique_ptr<> into this class and should eliminate the need for scoped_array<>, scoped_malloc_free<>, and possibly a few other scopers. Please refer to the unique_ptr<> API for documentation.
Divergence from unique_ptr<>:
1) DefaultDeleter<T[n]> (sized-arrays) is explicitly disabled because this construct would cause the single-object delete to be called on a pointer to a T[n]. It is impossible to construct a single-object new expression that returns a T[n]*. You can only get this with new[] which should correspond to DefaultDeleter<T[n][]>. This issue has been raised with the C++ LWG as it is possible a unique_ptr<> spec defect.
2) Reference types for Deleters are not supported. This simplifies implementation significantly because there is no need to distinguish between the converting constructor + converting assignment operator and their move constructor + move assignment operator.
4) Move-only Deleters are not supported. Avoids the need to emulate std::forward().
BUG=109874
TBR=dhollowa,kinuko,ananta,hans,scherkus
Review URL: https://codereview.chromium.org/11149006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
provide URLs and access tokens to server-side services.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11573034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 170668
> Needs to revert this because its WebKit patch was unrolled.
> (See r136319, unreviewed, rolling out r136236).
> > Update the Speech Api to support array(s) of result items
> > instead of a single item at a time.
> >
> > BUG=143124
> > TEST=Covered by content_unittests
> >
> > Review URL: https://chromiumcodereview.appspot.com/11421103
>
> TBR=tommi@chromium.org
> Review URL: https://codereview.chromium.org/11416310
TBR=tasak@google.com
Review URL: https://codereview.chromium.org/11316330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Needs to revert this because its WebKit patch was unrolled.
(See r136319, unreviewed, rolling out r136236).
> Update the Speech Api to support array(s) of result items
> instead of a single item at a time.
>
> BUG=143124
> TEST=Covered by content_unittests
>
> Review URL: https://chromiumcodereview.appspot.com/11421103
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/11416310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=116954
Review URL: https://chromiumcodereview.appspot.com/11348275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
instead of a single item at a time.
BUG=143124
TEST=Covered by content_unittests
Review URL: https://chromiumcodereview.appspot.com/11421103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=156643
Review URL: https://codereview.chromium.org/11273056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
# Do not copy the DeviceRequest Struct, instead, use a pointer.
# GenerateStream(), OpenDevice(), .. request generators should return a std::string, instead of using a pointer in the input params.
These two refactoring requests are from Tommi and Brettw.
BUG=137645
TEST=content_unittests
Review URL: https://chromiumcodereview.appspot.com/11412154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
# use MakeMediaRequest to query the permission for the devices.
# Notify the UI on device opened and closed.
BUG=146498,132965
TEST=run chrome with --enable-scripted-speech, go to http://www.corp.google.com/~hwennborg/speechreco.html, test the behavior manually.
Review URL: https://chromiumcodereview.appspot.com/11415097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11411124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit baefae90f294a981c973bffbdd3eccabfe796b6a.
The change broke Chrome for Android because non-vanilla protobuf-lite
Java files were generated.
Original review:
https://codereview.chromium.org/11228038/
TBR=phajdan.jr
BUG=160256
Review URL: https://codereview.chromium.org/11359146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=131220
TEST=content_unittests
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11365186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with unpatched system protobuf.
This is a preparation for landing https://codereview.chromium.org/11231046/
and a solution chosen because our custom protobuf changes will not
be accepted upstream.
Setting defaults to optimize for lite runtime and retain unknown fields
makes it possible to use the same .proto files with system protobuf.
BUG=157155
TEST=none
Review URL: https://codereview.chromium.org/11228038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Create a pure-virtual interface called HttpUserAgentSettings that provides access to the Accept-Language, Accept-Charset, and User-Agent HTTP headers. Each UrlRequestContext should have a HttpUserAgentSettings implementation attached via set_http_user_agent_settings().
BUG=146596
Review URL: https://chromiumcodereview.appspot.com/10918279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11345006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tfarina
Review URL: https://codereview.chromium.org/11339014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/11347004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Build SpeechRecognitionManagerImpl on iOS:
* Ifdef-out PermissionRequest on iOS as it extends MediaStreamRequester which
is part of content/browser/renderer_host/media/ and is not build on iOS.
* Voice search can only be initiated by clear user action. Add DCHECKs
to clearly identify the expected behavior.
* Build all content/browser/speech/... unit tests.
Review URL: https://chromiumcodereview.appspot.com/11229004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The test SpeechRecognitionBrowserTest::TestCancelAll has been flaky on mac
on an internal waterfall.
Review URL: https://chromiumcodereview.appspot.com/11227003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/11144032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> media_stream_ui_controller is responsible for posting the request to UI and send the result back.
> Use MediaRequstResponseCallback (will be used by speech)
> Added unittests for the media_stream_manager::MakeMediaAccessRequest
BUG=146306,154286
TEST=pyauto test: chrome/test/functional/webrtc_*;
content_unittests;
Review URL: https://codereview.chromium.org/11060005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves kChannelOrderings extern into a function for export compatibility
with MSVC++ and the shared_memory_support target.
BUG=none
TEST=compiles.
Review URL: https://codereview.chromium.org/11198018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Per discussion with perkj@, after media stream is generated, all error messages would be sent to client, instead of media stream.
Review URL: https://codereview.chromium.org/11146008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also replace SpeechRecognitionSessionConfig::is_one_shot with is_legacy_api,
used by the old x-webkit-speech input elements and speech extensions.
This way the new speech API will always use the new server, both for continuous
and non-continuous recognition.
BUG=116954
Review URL: https://chromiumcodereview.appspot.com/11032032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
intermediate results.
The speech server does not provide confidence values for intermediate results.
For such results, we should use the 'stability' value instead.
BUG=116954
TEST=content_unittests --gtest_filter="GoogleStreamingRemoteEngineTest.*"
Review URL: https://chromiumcodereview.appspot.com/11028026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=116954
Review URL: https://chromiumcodereview.appspot.com/11065009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10909237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=132965
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10933018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=142853
Review URL: https://chromiumcodereview.appspot.com/10905127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155521 0039d316-1c4b-4281-b951-d872f2087c98
|