| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
BUG=117417
Review URL: https://chromiumcodereview.appspot.com/9815030
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@128077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
hand to M18.
BUG=117418
Review URL: https://chromiumcodereview.appspot.com/9694021
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@126271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
kMaxSessionHistoryEntries.
BUG=93427
TEST=See bug, comment 112
Review URL: http://codereview.chromium.org/9565045
TBR=creis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9605016
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@125175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unload requests.
Also fix incorrect DCHECKs in decidePolicyForNavigation and UpdateTitle.
BUG=93427
TEST=See bug, comment 50.
Review URL: https://chromiumcodereview.appspot.com/9374003
TBR=creis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9386017
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@121730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issue was that currently only a WasResized() message updates the resize corner information in WebKit, but if the download shelf opens, the web contents don't necessarily get resized.
As a fix, add an IPC to explicitly update the resize rect, and call this when the download shelf opens/closes, and when a TabContents object becomes active.
Depends on https://bugs.webkit.org/show_bug.cgi?id=77453
BUG=111266
TEST=open page with scrollbar, save it. no resize corner in web.
switch to background tab with scrollbar, no resize corner there
either.
close download shelf, resize corner doesn't overlap scrollbar.
back to first tab, there neither.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120282
Review URL: https://chromiumcodereview.appspot.com/9159057
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9380020
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@121531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9104017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=98716
TBR=joi
Review URL: https://chromiumcodereview.appspot.com/9159038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-got rid of JavaScriptDialogDelegate since the embedder really only needs to know one callback to give the results to content
-for telling it that the dialog is shown, it seemed that chrome's decision to activate the tab would be in chrome
-used WebContents as the token for resetting dialogs if their tab went away
-used currying to hide the implementation detail of reply_msg from the embedder
-made content handle NULL JS dialog creator interface instead of having a stub one in the public directory
BUG=098716
Review URL: https://chromiumcodereview.appspot.com/9159033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9296041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=93427
TEST=Go back/forward quickly with cross-process navigations.
Review URL: http://codereview.chromium.org/9271054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For example, if the current tab is navigated to a JPEG and the user chooses "Save Page As" from the wrench menu, the data will be retrieved from cache without validation even if Cache-Control: no-cache is specified.
BUG=32246,55551,94574
TEST=DownloadTest.SavePageNonHTMLViaGet
Review URL: http://codereview.chromium.org/9178029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I've removed EmptyWebUIFactory, since that doesn't fit in well with Content API now. There were only a few places in the code that called it, and handling NULL wasn't much work.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9288074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an alternate fix to http://codereview.chromium.org/8587029/.
BUG=93427
BUG=104600
TEST=Go back/forward quickly with cross-process navigations.
Review URL: http://codereview.chromium.org/9288037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Context entries for the page and "Save * as..." are unsupported.
The Windows "Save As" dialog can even crash if the host bubble closes.
Still allow menus for editable items and selections without links.
Those context entries all seem to work, and we shouldn't regress crbug.com/37850.
Early return via ExtensionHost::HandleContextMenu to disallow context menus.
Have TabContentsView[Gtk|Mac] call the delegate's HandleContextMenu like TabContentsViewViews.
BUG=37850,109171
TEST=ExtensionPopups no longer show link, media, and page context menus. Still show menus for textfields and un-linked selections (doesn't regress crbug.com/37850).
Review URL: http://codereview.chromium.org/9232031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is implemented by the SiteInstanceImpl class which lives
in content\browser\site_instance.cc/.h.
Changes as part of creating a content API.
BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8515027
Review URL: https://chromiumcodereview.appspot.com/9146028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementations.
Various dependencies on the GTK version remain, as does a single,
probably easy-to-remove dependency on the Mac implementation.
Did this primarily as follows:
a) Enforce the intent, that RenderWidgetHostView instances are created
via factory function.
b) Migrated a couple of methods to the interface, skipping
implementation for platforms where not needed.
c) Added InitAsChild, with parent view parameter, to the interface so
that Windows initialization can go through interface. Incidentally,
this fixes bug 102450. As noted in the bug, the approach of passing a
parent view pointer is somewhat ugly as it isn't needed by all
platform-specific implementations, but I think it is acceptable.
TBR=owners (interface change LGTMed by owner, rest is trivial updates)
BUG=98716,102450
Review URL: https://chromiumcodereview.appspot.com/9281003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9129026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a revert of http://codereview.chromium.org/3547008, which was
added to implement sidebars. aa has reverted most of the sidebar code
( http://codereview.chromium.org/9006027/ ), so this is no longer needed.
This not only makes the code simpler (look at all the red), but also fixes a
long-standing regression on Mac that was caused by the CL this reverts.
Parts of the windows part with help form sky@.
This does not add back the code in rwhv_win that was added by mad@ for
bug 458, since it has since then bitrotted, and it's not used anyway. If someone
wants to attack 458 again,
http://codereview.chromium.org/16488/diff/1101/chrome/browser/renderer_host/render_widget_host_view_win.cc
should be fairly easy to add back.
BUG=458,70482,107646
TEST=Not too much stuff breaks; resize box looks good again on 10.5/10.6
TBR=avi
Review URL: http://codereview.chromium.org/9265018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
WebContents itself, IsSavableURL to a file in chrome, and made Chrome's DownloadManagerDelegate give SavePackage the file path through a callback.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9254051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9150021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows the gpu process to ignore all knowledge of renderers. It simplifies
some of the gpu <-> browser and gpu <-> renderer IPC, but mostly paves the way
for non-renderer clients.
Surfaces are kept in a global GpuSurfaceTracker which is just a thread-safe map.
BUG=99516
TEST=covered by existing tests. Run chrome, open poster circle (or other accelerated content page).
Review URL: http://codereview.chromium.org/9194005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/9252010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also rename TestTabContentsView to TestWebContentsView.
Add content namespace to both.
TBR=owners (trivial updates)
BUG=98716
Review URL: http://codereview.chromium.org/9241011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See comment on BrowsingInstance class that explains it should only be
visible to SiteInstance. By restoring this design, we also eliminate
one Chrome->Content dependency.
TBR=ben@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/9221017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
class. The latter will be renamed to WebUIImpl in a followup change. This completes hiding WebUI from chrome code, and now we can block it through DEPS.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9241032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
more code. The only remaining place is tab_contents_view_mac.mm. Instead of waiting until it moves, I've moved it to a directory with a DEPS file to allow those includes. That way we can enforce that no new files include those headers. It took a few weeks work to remove all the dependencies, and we don't want them regressing.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9178026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is the ownership model since otherwise we'd have to make the interface class delete it, which is better avoided since it's supposed to be an interface. The controller has a pointer to the WebUI object.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9224002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110208, 104170
TEST=window zoom should work, as in bug 104170
Review URL: http://codereview.chromium.org/9215002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
each page implements. This first patch moves the virtual functions in WebUI that were overridden by pages into a separate interface, content::WebUIController.
BUG=98716
Review URL: http://codereview.chromium.org/9188056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
instead of duplicating the code from it. This simplifies things a bit.
Review URL: http://codereview.chromium.org/9148061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=93804
TEST=compiles
TBR=beng
Review URL: http://codereview.chromium.org/9185025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: http://codereview.chromium.org/9139007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename to be something less of a tongue-twister.
BUG=93804, 95573
TEST=no visible change
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117220
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=117222
Review URL: http://codereview.chromium.org/9114047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79722
TEST=none
Review URL: http://codereview.chromium.org/9147044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename to be something less of a tongue-twister.
BUG=93804, 95573
TEST=no visible change
Review URL: http://codereview.chromium.org/9114047
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/9186006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rename to be something less of a tongue-twister.
BUG=93804, 95573
TEST=no visible change
Review URL: http://codereview.chromium.org/9114047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50377
Review URL: http://codereview.chromium.org/9169027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117078
Review URL: http://codereview.chromium.org/9150016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PluginService to content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead.
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Review URL: http://codereview.chromium.org/9150016
TBR=jam@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes history problems that could arise with the previous approach.
BUG=109417
TEST=See bug for repro steps.
Review URL: http://codereview.chromium.org/9125016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead.
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Review URL: http://codereview.chromium.org/9150016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79722
TEST=compiles
First Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116956
Review URL: http://codereview.chromium.org/9151007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=79722
TEST=compiles
Review URL: http://codereview.chromium.org/9151007
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/9167002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79722
TEST=compiles
Review URL: http://codereview.chromium.org/9151007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
instead of TabContents. Update all callers accordingly.
I also got rid of WebUIFactory::Get. It was only called in a few places, and as part of the Content API we want to avoid cc files in the public directory.
BUG=98716
Review URL: http://codereview.chromium.org/9097005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Over 341 CLs, in ~3 months, touching 3251 unique files!
Top 5 most CLs:
(121) jhawkins
( 45) dcheng
( 24) achuith
( 23) csilv
( 12) tfarina
( 12) groby
~1000 files touched:
(918) jhawkins
100+ files touched:
(486) ajwong
(385) willchan
(372) dcheng
(126) csilv
(123) fischman
(112) sergeyu
49+ files touched:
(65) tfarina
(57) acolwell
(52) adamk
(49) tzik
BUG=35223
TEST=existing
Review URL: http://codereview.chromium.org/9114020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I've switched RenderViewHostTestHarness::controller() to return the interface instead of the concrete class. Only two tests needed NavigationControllerImpl, so it's much easier to switch those to cast, and to leave the interface object as the return value as many tests in chrome use it and RVHTH will have to be exposed to chrome.
BUG=98716
Review URL: http://codereview.chromium.org/9123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
exclusively. This allows updating all the creaters of TCW to not include tab_contents.h as well, and use WebContents::Create instead.
BUG=98716
Review URL: http://codereview.chromium.org/9108025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
trivial changes to use WebContents instead of TabContents.
BUG=98716
Review URL: http://codereview.chromium.org/9030032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8983012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116328 0039d316-1c4b-4281-b951-d872f2087c98
|