| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a toggle for global accessibility mode (on/off)
For each renderer:
- shows an accessibility mode toggle
- if accessibility mode is On, shows a 'Show(/hide) accessibility tree' toggle, which shows(/hides) a text representation of the accessibility tree inline in the page. The accessibility tree may also be refreshed.
BUG=178756
Review URL: https://chromiumcodereview.appspot.com/11791028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enables the Instant NTP page access to:
chrome-search://theme/*,
chrome-search://favicon/*, and
chrome-search://thumb/*.
This CL has a number of aspects to make the installed theme
background image available to the Instant overlay:
1. Utilizes the new chrome-search: scheme that is accessible only
to the Instant overlay's render process. This is enforced
on the renderer side by WebKit::WebSecurityPolicy
facilities. This is enforced on the browser side by the
InstantIOContext::ShouldServiceRequest and URLDataSource::ShouldServiceRequest facilities.
2. Whitelists the chrome-search://theme origin to be made
available to the specific Instant overlay's origin/url.
3. Backend CSS that sets the appropriate background image
that resides in the chrome-search://theme origin.
4. A small refactoring of the Instant tests to support mix-in
usage of InstantTestBase.
BUG=172408, 134937
TEST=InstantPolicyTest.SearchSchemePolicy
R=sreeram@chromium.org, creis@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186347
Review URL: https://chromiumcodereview.appspot.com/11896113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke MalwareDetailsTest:
[ RUN ] MalwareDetailsTest.HTTPCache
Received signal 11 SEGV_MAPERR 00010000001e
[0x00000285f2ee] base::debug::StackTrace::StackTrace()
[0x00000285f3f6] base::debug::(anonymous namespace)::StackDumpSignalHandler()
[0x7f5274c148f0] <unknown>
[0x0000028a82f7] base::SupportsUserData::GetUserData()
[0x00000215307f] (anonymous namespace)::GetDataForResourceContext()
[0x00000215315c] InstantIOContext::RemoveInstantProcessOnIO()
[0x000002881dd9] MessageLoop::RunTask()
[0x00000288261b] MessageLoop::DeferOrRunPendingTask()
[0x000002882c28] MessageLoop::DoWork()
[0x000002853f4a] base::MessagePumpLibevent::Run()
[0x00000287d8f2] MessageLoop::RunInternal()
[0x00000289966d] base::RunLoop::Run()
[0x00000287cca5] MessageLoop::Run()
[0x0000042ee488] content::BrowserThreadImpl::IOThreadRun()
[0x0000042ef28b] content::BrowserThreadImpl::Run()
[0x0000028b4d88] base::Thread::ThreadMain()
[0x0000028afc01] base::(anonymous namespace)::ThreadFunc()
[0x7f5274c0b9ca] start_thread
[0x7f5272728cdd] clone
> Add chrome-search: access from Instant overlay
>
> Enables the Instant NTP page access to:
> chrome-search://theme/*,
> chrome-search://favicon/*, and
> chrome-search://thumb/*.
>
> This CL has a number of aspects to make the installed theme
> background image available to the Instant overlay:
> 1. Utilizes the new chrome-search: scheme that is accessible only
> to the Instant overlay's render process. This is enforced
> on the renderer side by WebKit::WebSecurityPolicy
> facilities. This is enforced on the browser side by the
> InstantIOContext::ShouldServiceRequest and URLDataSource::ShouldServiceRequest facilities.
> 2. Whitelists the chrome-search://theme origin to be made
> available to the specific Instant overlay's origin/url.
> 3. Backend CSS that sets the appropriate background image
> that resides in the chrome-search://theme origin.
> 4. A small refactoring of the Instant tests to support mix-in
> usage of InstantTestBase.
>
> BUG=172408, 134937
> TEST=InstantPolicyTest.SearchSchemePolicy
> R=sreeram@chromium.org, creis@chromium.org
>
>
> Review URL: https://chromiumcodereview.appspot.com/11896113
TBR=dhollowa@chromium.org
Review URL: https://codereview.chromium.org/12521005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enables the Instant NTP page access to:
chrome-search://theme/*,
chrome-search://favicon/*, and
chrome-search://thumb/*.
This CL has a number of aspects to make the installed theme
background image available to the Instant overlay:
1. Utilizes the new chrome-search: scheme that is accessible only
to the Instant overlay's render process. This is enforced
on the renderer side by WebKit::WebSecurityPolicy
facilities. This is enforced on the browser side by the
InstantIOContext::ShouldServiceRequest and URLDataSource::ShouldServiceRequest facilities.
2. Whitelists the chrome-search://theme origin to be made
available to the specific Instant overlay's origin/url.
3. Backend CSS that sets the appropriate background image
that resides in the chrome-search://theme origin.
4. A small refactoring of the Instant tests to support mix-in
usage of InstantTestBase.
BUG=172408, 134937
TEST=InstantPolicyTest.SearchSchemePolicy
R=sreeram@chromium.org, creis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11896113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98716
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12387070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
base::Value too.
Review URL: https://chromiumcodereview.appspot.com/12207089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Automated clean up of style checker errors that were missed due to the plugin
not being executed on implementation files.
BUG=115047
Review URL: https://chromiumcodereview.appspot.com/12210030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously they were added later which doesn't mesh with pending
URLRequestJobFactory API changes.
BUG=146602,161529
Review URL: https://chromiumcodereview.appspot.com/11308362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12213066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disable the test for now.)
> Revert 180055: Very likely caused http://crbug.com/173885
> > Moving chrome://tracing to content.
> >
> > BUG=169170
> > Review URL: https://codereview.chromium.org/12088099
>
> TBR=jam@chromium.org
> Review URL: https://codereview.chromium.org/12194007
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/12197003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Moving chrome://tracing to content.
>
> BUG=169170
> Review URL: https://codereview.chromium.org/12088099
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/12194007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=169170
Review URL: https://codereview.chromium.org/12088099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
implementation details from the public API.
BUG=169170
Review URL: https://codereview.chromium.org/12153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=169170
Review URL: https://codereview.chromium.org/12086079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
to content.
BUG=169170
Review URL: https://codereview.chromium.org/12089034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 179271
> > Simplify how TestChromeWebUIControllerFactory is registered now that multiple WebUIControllerFactory instances are supported. Instead of compiling the test code into the shipping product, have tests which use it unregister the default one and register the test one. This also makes the non-test version used for the majority of the test, which keeps the browser_tests more like the shipping product.
> >
> > I've also moved the test harness code to chrome\test\base, which is where test harnesses live.
> >
> > BUG=169170
> > Review URL: https://codereview.chromium.org/12084029
>
> This seems cause a few webui test crashes on Linux ChromiumOS Tests
> (dbg)(2) since http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/6808
>
> I can reproduce the crash on my local machine with CookiesViewWebUITest.*
> (Note: not all failing tests can be reproduced but this one has a reliable
> reproduce of the crash).
> And after I revert this, the crash gone. I am not sure why chromeos try
> bots have a green run.
>
> The crash is:
> [17690:17690:0128/215636:6223762366:FATAL:web_ui_impl.cc(84)] Check failed: false. Blocked unauthorized use of WebUIBindings.
> [0x7f4eb3da52f0] base::debug::StackTrace::StackTrace()
> [0x7f4eb3dda2a3] logging::LogMessage::~LogMessage()
> [0x7f4eaf52c45b] content::WebUIImpl::OnWebUISend()
> [0x7f4eaf52deaa] DispatchToMethod<>()
> [0x7f4eaf52d823] ViewHostMsg_WebUISend::Dispatch<>()
> [0x7f4eaf52c28c] content::WebUIImpl::OnMessageReceived()
> [0x7f4eaf4fe6e8] content::WebContentsImpl::OnMessageReceived()
> [0x7f4eaf444489] content::RenderViewHostImpl::OnMessageReceived()
> [0x7f4eaf42f031] content::RenderProcessHostImpl::OnMessageReceived()
> [0x7f4eb40109c0] IPC::ChannelProxy::Context::OnDispatchMessage()
> [0x7f4eb4014a8b] base::internal::RunnableAdapter<>::Run()
> [0x7f4eb4014553] base::internal::InvokeHelper<>::MakeItSo()
> [0x7f4eb4013df3] base::internal::Invoker<>::Run()
> [0x7f4eb3d9a0cd] base::Callback<>::Run()
> [0x7f4eb3de0d21] MessageLoop::RunTask()
> [0x7f4eb3de0e3c] MessageLoop::DeferOrRunPendingTask()
> [0x7f4eb3de16cd] MessageLoop::DoWork()
> [0x7f4eb3d7aee7] base::MessagePumpGlib::HandleDispatch()
> [0x7f4eb3d7a557] (anonymous namespace)::WorkSourceDispatch()
> [0x7f4ea3adb9d2] g_main_context_dispatch
> [0x7f4ea3adf858] <unknown>
> [0x7f4ea3adfa0c] g_main_context_iteration
> [0x7f4eb3d7aaf4] base::MessagePumpGlib::RunWithDispatcher()
> [0x7f4eb3d7afc4] base::MessagePumpGlib::Run()
> [0x7f4eb3de0911] MessageLoop::RunInternal()
> [0x7f4eb3de07cc] MessageLoop::RunHandler()
> [0x7f4eb3e197c6] base::RunLoop::Run()
> [0x000003101379] content::RunThisRunLoop()
> [0x000003101306] content::RunMessageLoop()
> [0x000001b66d64] InProcessBrowserTest::QuitBrowsers()
> [0x000001b66c58] InProcessBrowserTest::RunTestOnMainThreadLoop()
> [0x0000030bd6dd] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
> [0x0000030bdb5b] base::internal::RunnableAdapter<>::Run()
> [0x0000030bdaf1] base::internal::InvokeHelper<>::MakeItSo()
> [0x0000030bdaa9] base::internal::Invoker<>::Run()
> [0x000000775215] base::Callback<>::Run()
> [0x00000333188c] ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
> [0x00000332fe46] ChromeBrowserMainParts::PreMainMessageLoopRun()
> [0x000002c50658] chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
> [0x7f4eaf197cba] content::BrowserMainLoop::CreateThreads()
> [0x7f4eaf19b57e] content::BrowserMainRunnerImpl::Initialize()
> [0x7f4eaf1959f7] content::BrowserMain()
> [0x0000030bd662] content::BrowserTestBase::SetUp()
> [0x000001b65e1a] InProcessBrowserTest::SetUp()
> [0x000001c8072b] testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> [0x000001c7de76] testing::internal::HandleExceptionsInMethodIfSupported<>()
> [0x000001c7305d] testing::Test::Run()
> [0x000001c738d6] testing::TestInfo::Run()
> [0x000001c74004] testing::TestCase::Run()
> [0x000001c78faf] testing::internal::UnitTestImpl::RunAllTests()
> [0x000001c81557] testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> [0x000001c7e67d] testing::internal::HandleExceptionsInMethodIfSupported<>()
> [0x000001c77a7e] testing::UnitTest::Run()
> [0x000001b8183c] base::TestSuite::Run()
> [0x000000e6b473] ChromeTestLauncherDelegate::RunTestSuite()
> [0x0000030fd3fc] content::LaunchTests()
> [0x000000e6b315] main
> [0x7f4ea2d7fc4d] __libc_start_main
> [0x00000072fc29] <unknown>
>
> TBR=jam@chromium.org
> Review URL: https://codereview.chromium.org/12089051
TBR=bshe@chromium.org
Review URL: https://codereview.chromium.org/12093047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Simplify how TestChromeWebUIControllerFactory is registered now that multiple WebUIControllerFactory instances are supported. Instead of compiling the test code into the shipping product, have tests which use it unregister the default one and register the test one. This also makes the non-test version used for the majority of the test, which keeps the browser_tests more like the shipping product.
>
> I've also moved the test harness code to chrome\test\base, which is where test harnesses live.
>
> BUG=169170
> Review URL: https://codereview.chromium.org/12084029
This seems cause a few webui test crashes on Linux ChromiumOS Tests
(dbg)(2) since http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/6808
I can reproduce the crash on my local machine with CookiesViewWebUITest.*
(Note: not all failing tests can be reproduced but this one has a reliable
reproduce of the crash).
And after I revert this, the crash gone. I am not sure why chromeos try
bots have a green run.
The crash is:
[17690:17690:0128/215636:6223762366:FATAL:web_ui_impl.cc(84)] Check failed: false. Blocked unauthorized use of WebUIBindings.
[0x7f4eb3da52f0] base::debug::StackTrace::StackTrace()
[0x7f4eb3dda2a3] logging::LogMessage::~LogMessage()
[0x7f4eaf52c45b] content::WebUIImpl::OnWebUISend()
[0x7f4eaf52deaa] DispatchToMethod<>()
[0x7f4eaf52d823] ViewHostMsg_WebUISend::Dispatch<>()
[0x7f4eaf52c28c] content::WebUIImpl::OnMessageReceived()
[0x7f4eaf4fe6e8] content::WebContentsImpl::OnMessageReceived()
[0x7f4eaf444489] content::RenderViewHostImpl::OnMessageReceived()
[0x7f4eaf42f031] content::RenderProcessHostImpl::OnMessageReceived()
[0x7f4eb40109c0] IPC::ChannelProxy::Context::OnDispatchMessage()
[0x7f4eb4014a8b] base::internal::RunnableAdapter<>::Run()
[0x7f4eb4014553] base::internal::InvokeHelper<>::MakeItSo()
[0x7f4eb4013df3] base::internal::Invoker<>::Run()
[0x7f4eb3d9a0cd] base::Callback<>::Run()
[0x7f4eb3de0d21] MessageLoop::RunTask()
[0x7f4eb3de0e3c] MessageLoop::DeferOrRunPendingTask()
[0x7f4eb3de16cd] MessageLoop::DoWork()
[0x7f4eb3d7aee7] base::MessagePumpGlib::HandleDispatch()
[0x7f4eb3d7a557] (anonymous namespace)::WorkSourceDispatch()
[0x7f4ea3adb9d2] g_main_context_dispatch
[0x7f4ea3adf858] <unknown>
[0x7f4ea3adfa0c] g_main_context_iteration
[0x7f4eb3d7aaf4] base::MessagePumpGlib::RunWithDispatcher()
[0x7f4eb3d7afc4] base::MessagePumpGlib::Run()
[0x7f4eb3de0911] MessageLoop::RunInternal()
[0x7f4eb3de07cc] MessageLoop::RunHandler()
[0x7f4eb3e197c6] base::RunLoop::Run()
[0x000003101379] content::RunThisRunLoop()
[0x000003101306] content::RunMessageLoop()
[0x000001b66d64] InProcessBrowserTest::QuitBrowsers()
[0x000001b66c58] InProcessBrowserTest::RunTestOnMainThreadLoop()
[0x0000030bd6dd] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
[0x0000030bdb5b] base::internal::RunnableAdapter<>::Run()
[0x0000030bdaf1] base::internal::InvokeHelper<>::MakeItSo()
[0x0000030bdaa9] base::internal::Invoker<>::Run()
[0x000000775215] base::Callback<>::Run()
[0x00000333188c] ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
[0x00000332fe46] ChromeBrowserMainParts::PreMainMessageLoopRun()
[0x000002c50658] chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
[0x7f4eaf197cba] content::BrowserMainLoop::CreateThreads()
[0x7f4eaf19b57e] content::BrowserMainRunnerImpl::Initialize()
[0x7f4eaf1959f7] content::BrowserMain()
[0x0000030bd662] content::BrowserTestBase::SetUp()
[0x000001b65e1a] InProcessBrowserTest::SetUp()
[0x000001c8072b] testing::internal::HandleSehExceptionsInMethodIfSupported<>()
[0x000001c7de76] testing::internal::HandleExceptionsInMethodIfSupported<>()
[0x000001c7305d] testing::Test::Run()
[0x000001c738d6] testing::TestInfo::Run()
[0x000001c74004] testing::TestCase::Run()
[0x000001c78faf] testing::internal::UnitTestImpl::RunAllTests()
[0x000001c81557] testing::internal::HandleSehExceptionsInMethodIfSupported<>()
[0x000001c7e67d] testing::internal::HandleExceptionsInMethodIfSupported<>()
[0x000001c77a7e] testing::UnitTest::Run()
[0x000001b8183c] base::TestSuite::Run()
[0x000000e6b473] ChromeTestLauncherDelegate::RunTestSuite()
[0x0000030fd3fc] content::LaunchTests()
[0x000000e6b315] main
[0x7f4ea2d7fc4d] __libc_start_main
[0x00000072fc29] <unknown>
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/12089051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
webui pages.
BUG=169170
Review URL: https://codereview.chromium.org/12087040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
multiple WebUIControllerFactory instances are supported. Instead of compiling the test code into the shipping product, have tests which use it unregister the default one and register the test one. This also makes the non-test version used for the majority of the test, which keeps the browser_tests more like the shipping product.
I've also moved the test harness code to chrome\test\base, which is where test harnesses live.
BUG=169170
Review URL: https://codereview.chromium.org/12084029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
implementation is not really depended on chrome (other than calling UseWebUIForURL, which content can already call). This makes creatinga new WebUIControllerFactory for content's webui pages simpler.
BUG=169170
Review URL: https://codereview.chromium.org/12084018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is possible to implement webui inside content.
BUG=169170
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175822
Review URL: https://codereview.chromium.org/11783038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
its own file, move all the code to the content namespace, and remove the "Chrome" prefix from classes.
TBR=scottmg
BUG=169170
Review URL: https://codereview.chromium.org/12093012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=169170
Review URL: https://codereview.chromium.org/12077017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the code that was moved in r178663
BUG=169170
Review URL: https://codereview.chromium.org/12047123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=169170
Review URL: https://codereview.chromium.org/12049052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 175890: actually, looks like we want this to also help move chromeos webui pages out of src/chrome.
> > Revert 175822
> >
> > After more investigation of what it would take to share the webui code framework from chrome with content, it didn't seam feasible to do this. The code in chrome (i.e. ChromeURLDataManager) is heavily tied to chrome, and is used by chrome for non-webui stuff. The JS code is also specific to Chrome. It seems better to not bring in all this stuff to content.
> >
> > > Allow multiple WebUIControllerFactory objects to be registered. This makes is possible to implement webui inside content.
> > > Review URL: https://codereview.chromium.org/11783038
> >
> > TBR=jam@chromium.org
> > Review URL: https://codereview.chromium.org/11818036
>
> TBR=jam@chromium.org
> Review URL: https://codereview.chromium.org/11819050
This seems like the most obvious candidate for chromiumos failures:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/11017
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28amd64%29/builds/5918
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/11828040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webui pages out of src/chrome.
> Revert 175822
>
> After more investigation of what it would take to share the webui code framework from chrome with content, it didn't seam feasible to do this. The code in chrome (i.e. ChromeURLDataManager) is heavily tied to chrome, and is used by chrome for non-webui stuff. The JS code is also specific to Chrome. It seems better to not bring in all this stuff to content.
>
> > Allow multiple WebUIControllerFactory objects to be registered. This makes is possible to implement webui inside content.
> > Review URL: https://codereview.chromium.org/11783038
>
> TBR=jam@chromium.org
> Review URL: https://codereview.chromium.org/11818036
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/11819050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
After more investigation of what it would take to share the webui code framework from chrome with content, it didn't seam feasible to do this. The code in chrome (i.e. ChromeURLDataManager) is heavily tied to chrome, and is used by chrome for non-webui stuff. The JS code is also specific to Chrome. It seems better to not bring in all this stuff to content.
> Allow multiple WebUIControllerFactory objects to be registered. This makes is possible to implement webui inside content.
> Review URL: https://codereview.chromium.org/11783038
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/11818036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
is possible to implement webui inside content.
Review URL: https://codereview.chromium.org/11783038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
results.
- Parse the JSON results from the history server, and return results to the frontend along with the results from the local DB.
- If necessary, sort and de-dupe results in the front-end.
- Implement a timeout on serverresults, so the local history is still visible.
- Move some history-specific code out of WebUIMessageHandler.
- Rename a field holding a JS Date to "date", rather than "time".
BUG=163390
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/11434038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11301011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed most of the files found with the following command line:
$ git grep --files-without-match --name-only "namespace content {" -- content/browser/{*.cc,*.h.*.mm}
R=jam@chromium.org
Review URL: https://codereview.chromium.org/11274038
TBR=tfarina@chromium.org
Review URL: https://codereview.chromium.org/11273049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed most of the files found with the following command line:
$ git grep --files-without-match --name-only "namespace content {" -- content/browser/{*.cc,*.h.*.mm}
R=jam@chromium.org
Review URL: https://codereview.chromium.org/11274038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
Test=Compiles
R=oshima
TBR=jam
Review URL: https://chromiumcodereview.appspot.com/10993008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID_COUNT=8
CID=7757,8647,11476,16931,16932,100206,100577,102872
BUG=none
TEST=none
R=tbreisacher@chromium.org
TBR=brettw@chromium.org,kalman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10696166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces uses of IPC::Message::Sender with IPC::Sender and
IPC::Channel::Listener with IPC::Listener. I also fixed up header files where
it was obvious.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10662005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as many places in the C++ code push images to Javascript.
Bug=133032
Test=Compiles
Review URL: https://chromiumcodereview.appspot.com/10535134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium now has my new CSS media queries for detecting a touch screen: (pointer:coarse) and (hover:0). Use them for touch-optimizing our WebUI instead of the hack we had previously.
This also cleans up a couple of the rules in chrome_shared_touch.css (eg. multiple conflicting rules), but shouldn't change any layout whatsoever.
We can also query this from JavaScript using window.matchMedia, but the only place we were checking in JavaScript today (card slider used in NTP) was really wrong - even when Chrome isn't in "touch optimized" mode, it may still have a touch screen and so should be prepared to respond to touch events.
BUG=123062
TEST=
Review URL: https://chromiumcodereview.appspot.com/10456065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=129904
Review URL: https://chromiumcodereview.appspot.com/10444066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=129288
Review URL: https://chromiumcodereview.appspot.com/10332305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By default ('auto') touch-optimized-UI will be enabled if any touch screen is present. The user can also manually disable or enable it ('disabled', 'enabled') for testing purposes.
Note that for now --enable-touch-events is still required to enable the use of touch screens (and hence impact 'auto' here) since it's still experimental.
Also cleans up all the different ways we were trying to read this mode, unifying on ui::GetDisplayLayout().
BUG=124199
TBR=estade@chromium.org (only change in resources is trivial comment change)
TEST=
Review URL: https://chromiumcodereview.appspot.com/10391035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this is a partial revert of r133077 and an alternative fix for bug 121741. The last commit was faulty because a same-document navigate would not send new DocumentAvailableInFrame IPCs, hence all WebUISend messages would be ignored after a same document navigation. An example of a same-document navigation is when the user presses back, and the page handles window.onpopstate.
The new fix:
Re-use WebUI objects for navigations where we re-use the render view, and the old and new URLs return the same WebUIController type. This covers both the reload case and the same-document nav case. This way, the re-used WebUI is still initialized and is able to continue to handle messages without the possibility of unexpected messages causing crashes. WebUI re-builds on every back/forward/reload are also wasteful so this is a performance win.
BUG=123705,121741,123710
TEST=
Review URL: http://codereview.chromium.org/10154004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When the page navigates (or reloads) and a RenderView is reused, in-flight WebUISend messages may still be handled rather than being cancelled. This results in a WebUI receiving unexpected messages (e.g. before initialization has had a chance to take place). This patch makes sure in-flight messages are ignored (in-flight messages will come in before the new document element is ready, thus they will be ignored). I've verified that chrome.send executed before load events are dispatched still works (adding a browsertest for that is a TODO).
BUG=121741
TEST=mashing reload and clicking on an entry in the search engine manager does not cause a crash
Review URL: https://chromiumcodereview.appspot.com/9968123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated comments.
BUG=105875
TEST=no change
Review URL: http://codereview.chromium.org/10073023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the WebContentsImpl class to files in web_contents.
BUG=105875
TEST=no change
Review URL: http://codereview.chromium.org/10054012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110784
TEST=content_unittests --gtest_filter="WebUIMessageHandlerTest.*"
Review URL: http://codereview.chromium.org/9732027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=base_unittests
TBR=abodenha@chromium.org,ajwong@chromium.org,chocobo@chromium.org,mnissler@chromium.org,akalin@chromium.org,brettw@chromium.org,arv@chromium.org
Review URL: http://codereview.chromium.org/9590002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9600036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9600021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125167 0039d316-1c4b-4281-b951-d872f2087c98
|