| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
engines.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8907052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/8680040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Copy the url onto the stack.
BUG=99242
TEST=none
Review URL: http://codereview.chromium.org/8907055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upcoming test infrastructure requires access to this meember.
TEST=try bots.
BUG=none.
Review URL: http://codereview.chromium.org/8917020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: I78ca835371a0cf70e3dcb7630a91838ca40e9005
BUG=107596
TEST=See issue
Review URL: http://codereview.chromium.org/8914017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Chrome Frame test flakyness has been resolved by
http://src.chromium.org/viewvc/chrome?view=rev&revision=114046
TBR=dmazzoni@chromium.org
TEST=try bots.
BUG=99629
Review URL: http://codereview.chromium.org/8914009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DownloadQuery will be used first by the DownloadsSearchFunction in download_extension_api.h/cc to implement the chrome.experimental.downloads.search() function outlined in http://goo.gl/6hO1n
BUG=12133
TEST=content_unittests DownloadQueryTest
Review URL: http://codereview.chromium.org/8601012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make NotificationService handle the process of instantiating NotificationServiceImpl instead.
BUG=98716
R=jam@chromium.org
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/8913009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When safe browsing is enabled, downloads that will be subject to
content based checked will be marked as non-safe even when we are
prompting the user for the download location. During filename
determination |DownloadItem::suggested_path_| will be set to an
intermediate filename for these downloads. For safe downloads,
|suggested_path_| is the final download path.
This patch:
- Changes target filename determination when prompting for the
download location in DownloadManagerImpl::RestartDownload() to use
the |target_name| instead of |suggested_path_| for non-safe
downloads.
- Allows the target filename to be altered in
DownloadItemImpl::OnPathDetermined after prompting.
- Uses the previously determined intermediate filename for non-safe
downloads if prompted in
ChromeDownloadManagerDelegate::OverrideIntermediatePath.
- Only uniquifies the target filename if it is a non-safe download for
which no file selection prompts have been shown, in
DownloadItemImpl::OnDownloadCompleting.
BUG=106194
TEST=unit_tests --gtest_filter=DownloadManagerTest.*
Review URL: http://codereview.chromium.org/8919019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=davemoore@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/8919017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Chrome Frame test flakyness has been resolved by
http://src.chromium.org/viewvc/chrome?view=rev&revision=114046
TBR=dmazzoni@chromium.org
TEST=try bots.
BUG=99629
Review URL: http://codereview.chromium.org/8937009
TBR=dtseng@chromium.org
Review URL: http://codereview.chromium.org/8930028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Chrome Frame test flakyness has been resolved by
http://src.chromium.org/viewvc/chrome?view=rev&revision=114046
TBR=dmazzoni@chromium.org
TEST=try bots.
BUG=99629
Review URL: http://codereview.chromium.org/8937009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8890087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scoped_ptr, scoped_ar..."
This reverts commit r113922.
Win Canary has been failing to link due to OOM since the weekend. While this was not the original cause, it might be making things worse. Speculatively remove for now.
Also changes render_widge_host_view to use Owned() instead of Passed().
BUG=none
TEST=existing.
Review URL: http://codereview.chromium.org/8931008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107172
TEST=none
R=ben@chromium.org,avi@chromium.org
Review URL: http://codereview.chromium.org/8921032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
JavaBridgeDispatcherHost must be ref-counted because it is used with
base::Bind. http://codereview.chromium.org/8834013 changed
JavaBridgeDispatcherHost to also inherit from RenderViewHostObserver. The base
implementation of RenderViewHostObserver::RenderViewHostDestroyed() deletes the
object. This is unwanted in this class, so we provide an empy implementation of
the method.
Review URL: http://codereview.chromium.org/8929005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
When running the fake ui, behind the media stream flag, there is a missing check for available devices.
Review URL: http://codereview.chromium.org/8883042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The implementation was removed by http://codereview.chromium.org/8820009.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/8919003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/8498036 broke it, because I didn't realize that AsyncPresentAndAcknowledge called the callback from a background thread.
I simply reverted part of that change which just meant to simplify the code, and it should go back to the expected behavior.
BUG=107083
TEST=gpu bots
Review URL: http://codereview.chromium.org/8921017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the subpages are iframes. On the C++ side, the uber WebUI keeps a collection of subpage WebUIs and proxies function calls to them. Calls into JS are directed to the correct iframe by setting a frame name.
The fact it's in an iframe is almost completely transparent to the options page (both from the C++ and JS side); you'll notice there are no changes to any options files.*
*exception: temporary command line changes
BUG=100885
TEST=chrome://uber should have an iframe with chrome://settings in it (fully functional)
Review URL: http://codereview.chromium.org/8889041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This can potentially cut the mouse move, mouse wheel, and touch move
latency for platforms that send the UpdateRect_ACK message within the
UpdateRect IPC handler. Today, it seems that windows and mac will
sometimes send the UpdateRect_ACK synchronously, while linux never will.
Patch also includes some extra instrumentation to make this easier to
track that we may or may not want to land.
BUG=none
Review URL: http://codereview.chromium.org/8820001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property.
We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow.
We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property.
I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation.
BUG=none
TEST=unit tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114095
Review URL: http://codereview.chromium.org/8894018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested using html5 drag demo and bookmark dragging to make sure that the patch didn't break dragging
BUG = 105886
Test = Manual
Review URL: http://codereview.chromium.org/8788002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property.
We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow.
We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property.
I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation.
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/8894018
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8926004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property.
We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow.
We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property.
I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation.
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/8894018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unit tests now instantiate their own AudioManager and can choose to
use the default one or provide their own mock implementation without
having to worry about conflicting with the singleton.
The teardown sequence of the AudioManager and its thread has been cleaned
up significantly and I don't think it has been completely tested before as
the audio thread was terminated before all objects that belonged to the
thread had a chance to do cleanup. The AudioManager unit tests do not use
the actual audio thread, so this part seems to have been left out.
In Chrome, the AudioManager instance is now owned by BrowserProcessImpl
and always constructed on the UI thread. This instance is then shared
in the same way that several other 'manager' type objects are shared to
'content' code, via content::ResourceContext. Audio specific classes
do though receive a direct pointer to the AudioManager and are required
to do proper reference counting if they need to hold onto the instance.
I chose to use the ResourceContext rather than direct use of g_browser_process
to avoid requiring another singleton when writing relatively simple tests
that touch the AudioManager.
I added a couple of safeguards to guard against future regressions:
- Not more than one instance of the AudioManager should be created.
- The AudioManager should not be addrefed by its own thread. This
can basically become a circular reference and prevent deterministic
shutdown.
Reviewers: Of course you're free to review everything,
but here's the breakdown in terms of the bare minimum from
the standpoint of "Owners approval". I'm asking Henrik to be the
main reviewer of the entire patch (sorry!).
Henrik: Everything minus the below, but it would be great if you could
take a look at the whole thing, specifically media/audio.
Pawel: I'd like you to take a generic look at this approach.
The key areas as far as the singleton itself goes are in
media/audio/audio_manager[_base].* and
chrome/browser/browser_process*.*
Satish: content/browser/speech/*
media/audio/audio_manager_base.* (new reference counting code)
Andrew: content/browser/renderer_host/media/*
content/renderer/media/webrtc_audio_device_unittest.cc (Owner)
Avi: content/browser/renderer_host/render_process_host_impl.cc
content/browser/resource_context.*
William: chrome/browser/profiles/profile_io_data.cc
chrome/browser/browser_process*.*
Robert: This is basically a heads up. I hope that I didn't break the OpenBSD
implementation, but unfortunately I have no way of knowing for sure.
Shijing: Please take a look at AudioManagerLinux. I replaced the set of
active streams with a simple counter.
BUG=105249
TEST=content_unittests, media_unittests, browser_tests.
Review URL: http://codereview.chromium.org/8818012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "Disable RendererAccessibilityBrowserTest.CrossPlatform* tests"
This reverts commit 2a31da98908e3e42b323f4d67b957fc8b85941e3.
and
ensures that we replace the test tree when receiving layout complete notifications.
Only pass on the test tree when the tree actually has a non-empty subtree. This indicates a non-blank test page.
BUG=106934
TEST=try bots.
TBR=jam,sergyu
Review URL: http://codereview.chromium.org/8895018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the Java Bridge uses the WEBKIT thread to manipulate injected objects
in the browser process. However, the WEBKIT thread is not set up when the
renderer is run in-process, and it may be deprecated.
This change adds a new background thread in JavaBridgeDispatcherHost, and updates the JavaBridge to use it in place of the WEBKIT thread.
BUG=106838
Review URL: http://codereview.chromium.org/8890018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK user interface show up on the chrome://tracing hierarchical profiler.
These were useful for tracking down tab changing speed problems.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8800029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8872038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/8887001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow the users of the utility process to specify whether the zygote
should be used on Linux. This will allow sandboxing the uses of the
utility process that don't do FS access.
This is the first step to get the utility process sandboxed
on Linux. Since most of the uses of the utility process
don't do file access, launching all of those from the zygote
will simplify sandboxing the one that does: extension
unpacking.
Subsequent CLs will port the uses of the utility process
that don't do file access to launch from the zygote.
BUG=93109
TEST=No functional changes yet, but test that nothing broke by
running browser_tests::ExtensionWebstorePrivateApiTest.* and also
logging into Chromium and installing an extension from the Web Store.
Review URL: http://codereview.chromium.org/8849007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/task.h is going away and being replaced by base/bind.h and base/callback.h.
This CL was automatically generated by sed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8872030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=94925
TEST=none
Review URL: http://codereview.chromium.org/8895010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8487002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is on.
This is also removing the UpdateRect ack in the accelerated compositing case,
because it is not needed (and adds scheduling constraints that reduce
throughput).
This also sends a "dummy" message to the browser to unblock the UI thread if it's waiting on an UpdateRect when the transition from non-accelerated to accelerated happens: the GPU process may need to round trip to the browser UI thread before sending the SwapBuffers callback.
BUG=58782
TEST=reduced jankiness on aura builds when resizing.
Review URL: http://codereview.chromium.org/8498036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=106897
TEST=cursor appears in a textfield on focus.
Review URL: http://codereview.chromium.org/8879049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8872046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This changes Socket::Read(), Socket::Write, and StreamSocket::Connect() to use CompletionCallback and fixes all users.
BUG=none
TEST=existing.
Review URL: http://codereview.chromium.org/8824006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have permission to open them directly. For example, right-click on a
"chrome://" link in an ordinary window should show two items: Copy link
location and inspect element, but a full menu from a WebUI window itself.
NOTE: Fixing this issue requires a fix to ChildProcessSecurityPolicy, which as been silently too permissive.
BUG=104466
Review URL: http://codereview.chromium.org/8588039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
JavaBridgeDispatcherHost::AddNamedObject() currently has a race condition, as
it posts to the WEBKIT thread before sending the injected object to the
renderer. See bug for details.
To fix this, JavaBridgeDispatcherHost::AddNamedObject() now creates the
NPVariant_Param synchronously, and immediately sends this to the renderer. This
requires use of a route ID generator which is shared with the
JavaBridgeChannelHost. Creation of the JavaBridgeChannelHost and the
corresponding NPObjectStub is done asynchronously on the WEBKIT thread.
This means that the channel handle is not available when the Java Bridge is
first initialized in the renderer. To overcome this, the renderer obtains it
from the browser with a new sync IPC call.
- RenderViewImpl - OnJavaBridgeInit() no longer supplies a channel handle.
- JavaBridgeDispatcher - Lazily gets channel handle from browser.
- JavaBridgeDispatcherHost - Now a RVH obsever to provide channel handle.
Uses shared route ID generator to synchronously create the NPVariant_Param
when a new object is injected. Creates the JavaBridgeChannelHost and the
corresponding NPObjectStub asynchronously on the WEBKIT thread.
- JavaBridgeChannelHost - Shares a route ID generator with the
JavaBridgeDispatcherHost.
BUG=106691
Review URL: http://codereview.chromium.org/8834013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Relies on WK patch: https://bugs.webkit.org/show_bug.cgi?id=73485 for damage to external texture
and WK patch: https://bugs.webkit.org/show_bug.cgi?id=67341 for scissoring optimization.
BUG=none
TEST=run GYP_DEFINES="use_aura=1 use_webkit_compositor=1" on a machine that supports GLX_MESA_copy_sub_buffer; go to http://www.webkit.org/blog-files/3d-transforms/poster-circle.html; move a different X11 window over top of the chrome window; see that only part of the chrome window (with the animation) gets redrawn
Review URL: http://codereview.chromium.org/8764001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and reap other simplifying rewards. Update messages to remove
intent_id where not needed. Tighten up intents message definitions.
R=jhawkins@chromium.org,jam@chromium.org
BUG=104980
TEST=*Intent*.*
Review URL: http://codereview.chromium.org/8795004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8831001
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/8889036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=106883
TEST=
Review URL: http://codereview.chromium.org/8879034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the new logic in SendPendingAccessibilityNotifications, it is no longer necessary to fire a load complete as the first notification to the browser. Since we walk the parent chain, looking for the first entry actually in our browser cache, we will always end up walking up to the root.
This change therefore also makes sure that notifications fired on the root will include all of the subtree when composing the notification.
BUG=none.
TEST=manual.
Merge remote-tracking branch 'origin' into build_break
Merge branch 'trunk' of http://git.chromium.org/git/chromium into build_break
Attempt fixes at chrome frame tests redness.
TBR=dtseng
Review URL: http://codereview.chromium.org/8869006
TBR=dtseng@chromium.org
Review URL: http://codereview.chromium.org/8888034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the new logic in SendPendingAccessibilityNotifications, it is no longer necessary to fire a load complete as the first notification to the browser. Since we walk the parent chain, looking for the first entry actually in our browser cache, we will always end up walking up to the root.
This change therefore also makes sure that notifications fired on the root will include all of the subtree when composing the notification.
BUG=none.
TEST=manual.
Merge remote-tracking branch 'origin' into build_break
Merge branch 'trunk' of http://git.chromium.org/git/chromium into build_break
Attempt fixes at chrome frame tests redness.
TBR=dtseng
Review URL: http://codereview.chromium.org/8869006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the new logic in SendPendingAccessibilityNotifications, it is no longer necessary to fire a load complete as the first notification to the browser. Since we walk the parent chain, looking for the first entry actually in our browser cache, we will always end up walking up to the root.
This change therefore also makes sure that notifications fired on the root will include all of the subtree when composing the notification.
BUG=none.
TEST=manual.
Merge remote-tracking branch 'origin' into build_break
Merge branch 'trunk' of http://git.chromium.org/git/chromium into build_break
Attempt fixes at chrome frame tests redness.
TBR=dtseng
Review URL: http://codereview.chromium.org/8869006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8831001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move GpuInfoUpdate to UI thread to avoid potential racing.
BUG=104768
TEST=ExtensionWebstorePrivateBundleTest.GetWebGLStatus
Review URL: http://codereview.chromium.org/8772031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113688 0039d316-1c4b-4281-b951-d872f2087c98
|