summaryrefslogtreecommitdiffstats
path: root/content/browser
Commit message (Collapse)AuthorAgeFilesLines
...
* CacheStorage: Implement Cache.matchAll()nhiroki2015-08-075-153/+556
| | | | | | | | | | | | | | | | | | | This CL implements Cache.matchAll(). When an optional request is omitted, CacheStorageCache iterates all responses in this cache and returns them. When the optional request is given, the backend runs an existing implementation for Cache.match(). Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#cache-matchall (1) Blink: https://codereview.chromium.org/1268463003/ (2) Chromium: THIS PATCH (3) Blink: https://codereview.chromium.org/1262773003/ BUG=428363 Review URL: https://codereview.chromium.org/1248003004 Cr-Commit-Position: refs/heads/master@{#342359}
* Change switches::kContentImageTextureTarget to a list of image texture targetsjie.a.chen2015-08-071-15/+23
| | | | | | | | | | | | | | | | Not knowing the GpuMemoryBuffer format that the compostor will use, the host is hard to determine the image texture target properly. This CL changes switches::kContentImageTextureTarget to a list of targets for each format, so that the compositor can decide what format it wants to use without having to worry about the target being wrong. BUG=490362,512665 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1251693003 Cr-Commit-Position: refs/heads/master@{#342339}
* aura: Sanitize the lifetime of aura::Env instance.sadrul2015-08-073-4/+5
| | | | | | | | | | | | | | | | | | | | | | | Currently, the aura::Env instance is created and/or destroyed from unexpected places (e.g. WebContentsViewAura), and that makes it difficult to reason about its lifetime. This patch tries to make this better. Notable changes: . Instead of having the ash::Shell instance be responsible for creating the aura::Env instance, make the creator of the Shell instance be responsible for also creating the aura::Env instance. . Individual TestSuite instances are responsible for managing the aura::Env instance for the tests (content::UnitTestTestSuite, ash::AuraShellTestSuite) . For chrome and browser-tests, the browser main-loop is responsible for managing the aura::Env instance. . For interactive-ui-tests that do not use the browser main-loop, each test explicitly manages its aura::Env instance. BUG=515031, 516898 TBR=avi@ for trivial change in content/browser/ Review URL: https://codereview.chromium.org/1270173004 Cr-Commit-Position: refs/heads/master@{#342300}
* Re-land: content: Enable native GpuMemoryBuffers by default on MacOSX.reveman2015-08-071-2/+18
| | | | | | | | | | | This eliminates the need for texture uploads to initialize tile textures on MacOSX. BUG=486922 Review URL: https://codereview.chromium.org/1165823003 Cr-Commit-Position: refs/heads/master@{#342287}
* Revert of cc: Use worker context for one-copy tile initialization. (patchset ↵kbr2015-08-0713-47/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #20 id:380001 of https://codereview.chromium.org/1230203007/ ) Reason for revert: Suspected of colliding with another patch and causing Issue 517719. Original issue's description: > cc: Use worker context for one-copy tile initialization. > > This moves management of staging resources to > OneCopyTileTaskWorkerPool class. This makes it possible > to use a worker context to issue and detect when copy > operations complete. > > BUG=490295 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/d5157ac5afec145b85746b42f2d86383483a8222 > Cr-Commit-Position: refs/heads/master@{#342235} TBR=piman@chromium.org,primiano@chromium.org,vmiura@chromium.org,vmpstr@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490295,517719 Review URL: https://codereview.chromium.org/1273163004 Cr-Commit-Position: refs/heads/master@{#342284}
* Move Service Worker %2f path validation logic from browser into Blink (1)jeremyarcher2015-08-0721-609/+18
| | | | | | | | | | | | | | | | | | This patch adds an interface by which the path validation logic can be kept in Chromium but called from within Blink. It will be eventually used to ensure that navigator.serviceWorker.register() rejects with a TypeError instead of a DOMException (see spec). 1. (Chromium) This CL. 2. (Blink) https://codereview.chromium.org/1260003003/ 3. (Chromium) https://codereview.chromium.org/1256833004/ BUG=513622 R=nhiroki,falken Review URL: https://codereview.chromium.org/1259213002 Cr-Commit-Position: refs/heads/master@{#342279}
* Sync compositor: Ignore command buffer memory callbackboliu2015-08-073-2/+55
| | | | | | | | | | | | | | Synchronous compositor client directly controls memory allocation. After switching to ipc-based command buffer, this conflicts the memory allocation callbacks from the command buffer. Note in-process command buffer never supposed memory callbacks. BUG=509702 Review URL: https://codereview.chromium.org/1268383003 Cr-Commit-Position: refs/heads/master@{#342267}
* Remove SoftwareFrameDatajbauman2015-08-0712-33/+18
| | | | | | | | | | We never transmit software frames over IPC anymore, so this is unnecessary. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1265243004 Cr-Commit-Position: refs/heads/master@{#342265}
* Avoid UAF in PepperUDP/TCPSocketMessageFilterraymes2015-08-074-7/+16
| | | | | | | | | | | | We were trying to access BrowserPpapiHost or ResourceHost after they may have been destroyed. Instead cache IsPotentiallySecurePluginContext in an instance variable to report in UMA. BUG=515943 Review URL: https://codereview.chromium.org/1276763002 Cr-Commit-Position: refs/heads/master@{#342261}
* Revert of Update SplitString calls to new form (patchset #5 id:80001 of ↵pkasting2015-08-079-31/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1272823003/ ) Reason for revert: Caused Blink layout test failures in media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html : http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=media%2Fencrypted-media%2Fencrypted-media-requestmediakeysystemaccess.html Original issue's description: > Update SplitString calls to new form > > Uses the new form for most (but not quite all) of the remaining users of the old form. > > Changes media mime util codec list parsing to expect no result from the string "," rather than two empty strings. The old SplitString call had a special case where if the input was empty, it would return empty, but if it had one split character, it would return two empty strings as results. > > The new one lets you choose but the options are either (1) empty string -> one empty string and "," -> two empty strings, or (2) map both to no results for when you don't want empty results. I'm pretty sure media codec parsing actually wants the latter behavior, so I updated the call to discard empty results and MimeUtilTest.ParseCodecString is updated. > > Committed: https://crrev.com/0aa7c64253cca8b636d52d1d01d94f96ab9c13fa > Cr-Commit-Position: refs/heads/master@{#342238} TBR=sky@chromium.org,dalecurtis@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1278973003 Cr-Commit-Position: refs/heads/master@{#342257}
* Revert of Fix cancellation of a pair of URLRequestJob subclasses (patchset ↵pkasting2015-08-072-97/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6 id:240001 of https://codereview.chromium.org/1271593002/ ) Reason for revert: Caused crashes in the following tests due to DCHECK failures: http/tests/serviceworker/registration.html http/tests/serviceworker/chromium/register-error-messages.html See e.g. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(dbg)/builds/25550/steps/webkit_tests/logs/stdio for a log. Original issue's description: > Fix cancellation of a pair of URLRequestJob subclasses > > URLRequestSimpleJob and URLRequestChromeJob can call back into their > parent URLRequestJob class after Kill() has been invoked, which can > cause Bad Things. > > Longer term, we should think about the interface between URLRequestJob > and its subclasses, to see if we can create a more robust interface. > > BUG=508900 > > Committed: https://crrev.com/363ce98af274c07f43acac74b7ca7c23641c996e > Cr-Commit-Position: refs/heads/master@{#342211} TBR=davidben@chromium.org,mmenke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508900 Review URL: https://codereview.chromium.org/1273813005 Cr-Commit-Position: refs/heads/master@{#342255}
* Service Worker: Add UMA for stopping workers.falken2015-08-071-0/+3
| | | | | | | | | | | These may help us understand the cause of stalled-in-stopping workers. BUG=509904 Review URL: https://codereview.chromium.org/1276773002 Cr-Commit-Position: refs/heads/master@{#342253}
* Get rid of FrameAccessibility using AXTreeIDsdmazzoni2015-08-0717-628/+487
| | | | | | | | | | | | | | | | | | Depends on: https://codereview.chromium.org/1257093005/ Instead of keeping track of the relationship between frames in FrameAccessibility, create a subclass of AXNodeData that's only allowed to be used within the content module, and once an AX tree is received in the browser process, convert routing IDs to global AXTreeIDs that can be stored AXNodeData. BUG=368298 Review URL: https://codereview.chromium.org/1267663002 Cr-Commit-Position: refs/heads/master@{#342251}
* [Presentation API] Change ListenForSessionMessages API to observers.imcheng2015-08-074-216/+179
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ListenForSessionMessages is now observer style and listens for a single presentation as opposed to all sessions in that frame. This change also separate presentation url / id from the various SessionMessage structs from presentation mojom / content. Now SendSessionMessage / ListenForSessionMessages must pass in an explicit PresentationSessionInfo. Doing this allows us to avoid parsing presenation url/id from route id for presentation session - MediaRoute association, because previously we would have to fill out the url/id field of content::PresentationSessionMessage struct and there was no good way to do it without parsing. Now we simply bind the PresentationSessionInfo to the callback that receives the messages. Removing the pres url/id from the message struct also avoids duplication when sending a batch of messages for the same session. Added PresentationSessionMessagesObserver class and MediaRouter API to implement the observer style API. MediaRouterMojoImpl contains logic to adapt the observer stlye API to the getNext style API for listening for route messages from the Media Route Provider. Another change that were needed to completely remove the route id parsing logic is to invoke MediaRouteResponseCallbacks with the resulting presentation id generated by MediaRouter. This is needed due to browser-initiated presentations where the presentation id is not known in advance. BUG=510297,510267 Review URL: https://codereview.chromium.org/1259073004 Cr-Commit-Position: refs/heads/master@{#342249}
* Update SplitString calls to new formbrettw2015-08-079-31/+31
| | | | | | | | | | | | Uses the new form for most (but not quite all) of the remaining users of the old form. Changes media mime util codec list parsing to expect no result from the string "," rather than two empty strings. The old SplitString call had a special case where if the input was empty, it would return empty, but if it had one split character, it would return two empty strings as results. The new one lets you choose but the options are either (1) empty string -> one empty string and "," -> two empty strings, or (2) map both to no results for when you don't want empty results. I'm pretty sure media codec parsing actually wants the latter behavior, so I updated the call to discard empty results and MimeUtilTest.ParseCodecString is updated. Review URL: https://codereview.chromium.org/1272823003 Cr-Commit-Position: refs/heads/master@{#342238}
* cc: Use worker context for one-copy tile initialization.reveman2015-08-0613-18/+47
| | | | | | | | | | | | | | This moves management of staging resources to OneCopyTileTaskWorkerPool class. This makes it possible to use a worker context to issue and detect when copy operations complete. BUG=490295 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1230203007 Cr-Commit-Position: refs/heads/master@{#342235}
* Refactor CreateOpenerProxies to support updates to frame openers.alexmos2015-08-063-10/+274
| | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, CreateOpenerProxies assumes that (1) each opener chain can be recursively traversed until hitting a node with no opener, and (2) subframes can't have openers. Neither (1) nor (2) will hold once we propagate frame opener updates (that happen via window.open) to the browser process. To address (1), this CL changes the recursive traversal in CreateOpenerProxies to a BFS traversal that is resilient to potential cycles on the opener chain. To address (2), openers are examined for all nodes on a given FrameTree, rather than just for the root node. If the opener graph contains cycles, some proxies created by CreateOpenerProxies may not have their opener_routing_id available at creation time. In a future CL, once opener update IPCs are implemented, these proxies will need to set their openers in a second pass (note that this is expected to be very rare, hence an extra IPC should be ok). This CL prepares for this by adding logic to collect nodes involved in cycles that will need this extra processing. BUG=225940 Review URL: https://codereview.chromium.org/1268153002 Cr-Commit-Position: refs/heads/master@{#342221}
* Replace StringToLowerASCII with base::ToLowerASCIIbrettw2015-08-061-4/+5
| | | | | | | | | | | | | | Standardize on using string pieces and returning strings. Remove in-place version (this was only used in a couple places and they were not performance-critical). De-templatize the character versions of ToUpperASCII/ToLowerASCII. This would lead to bizarre errors if you pass other things (like a string). This is so little code, it's now just duplicated. I renamed StringToLowerASCII to just be ToLowerASCII so you can pass whatever you want to ToLowerASCII and it does the right thing. This seems simpler to me. This replaces all calls of StringToUpperASCII to the new form. The lowercase version is more common and will be done in a separate pass. Review URL: https://codereview.chromium.org/1280473002 Cr-Commit-Position: refs/heads/master@{#342219}
* Fix cancellation of a pair of URLRequestJob subclassesmmenke2015-08-062-35/+97
| | | | | | | | | | | | | | | URLRequestSimpleJob and URLRequestChromeJob can call back into their parent URLRequestJob class after Kill() has been invoked, which can cause Bad Things. Longer term, we should think about the interface between URLRequestJob and its subclasses, to see if we can create a more robust interface. BUG=508900 Review URL: https://codereview.chromium.org/1271593002 Cr-Commit-Position: refs/heads/master@{#342211}
* Remove debugging information for state setting.avi2015-08-061-19/+1
| | | | | | | | | | This finishes the revert of commit 99f2bfdaa1400b028801961be4ab4d91c201f840. BUG=369661 Review URL: https://codereview.chromium.org/1279833002 Cr-Commit-Position: refs/heads/master@{#342199}
* Add latency tracking for mouse move/keyboard eventmiletus2015-08-0614-46/+115
| | | | | | | | BUG=515553 Review URL: https://codereview.chromium.org/1262553005 Cr-Commit-Position: refs/heads/master@{#342198}
* Support restricting browsing data removal for downloads by origin.ttr3142015-08-064-9/+90
| | | | | | | | | | | | | This CL adds support for restricting removal of downloads by origin. We do so by extending DownloadManager's API and passing in the origin. BUG=113969 TEST=added unit tests Review URL: https://codereview.chromium.org/1251243003 Cr-Commit-Position: refs/heads/master@{#342187}
* Android: Fix null onscreen surfacesievers2015-08-061-4/+7
| | | | | | | | | | | | Make sure the current onscreen surface is registered as long as the OutputSurface is alive, so that the GPU thread will not see a null handle. BUG=517279,517283 Review URL: https://codereview.chromium.org/1277653003 Cr-Commit-Position: refs/heads/master@{#342186}
* Implement glue to integrate battor power tracing with trace controller.prabhur2015-08-067-2/+225
| | | | | | | | | | | Staging the tracing_controller to add battor power tracing. BattorPowerTraceProvider is where the battor h/w controller implementation should be. The actual implementation that will be ported into BattorPowerTraceProvider is here: https://github.com/aschulm/battor. Currently this is a No-op implementation i.e this code doesn't run even if we enable tracing. Review URL: https://codereview.chromium.org/1256143006 Cr-Commit-Position: refs/heads/master@{#342174}
* Revert of [tracing] Throttle rate of heavy dumps and support to request ↵waffles2015-08-061-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | light/heavy dumps (patchset #5 id:80001 of https://codereview.chromium.org/1267963002/ ) Reason for revert: Suspect it breaks Linux telemetry tests (or possibly introduces flakiness): Example https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/28807 telemetry.internal.backends.chrome_inspector.tracing_backend_unittest.TracingBackendMemoryTest.testDumpMemorySuccess failed unexpectedly 0.2190s: Traceback (most recent call last): File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py", line 144, in testDumpMemorySuccess dump_id = self._browser.DumpMemory() File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/browser/browser.py", line 291, in DumpMemory return self._browser_backend.DumpMemory(timeout) File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py", line 321, in DumpMemory return self.devtools_client.DumpMemory(timeout) File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py", line 231, in DumpMemory return self._tracing_backend.DumpMemory(timeout) File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py", line 128, in DumpMemory 'Tracing.requestMemoryDump:\n' + json.dumps(response, indent=2)) TracingUnexpectedResponseException: Inspector returned unexpected response for Tracing.requestMemoryDump: { "id": 2, "error": { "message": "Tracing is not started", "code": -32603 } } Original issue's description: > [tracing] Throttle rate of heavy dumps and support to request light/heavy dumps > > Currently all the dump providers dump detailed dumps every periodic > dump. This makes the trace files huge. So, this CL throttles down the > rate of heavy dumps of all the dump providers and removes temporary > hacks. Along with this, this CL also adds support to request light and > heavy dumps by adding MemoryDumpArgs as param to RequestGlobalDump() > > TBR=pfeldman@chromium.org > BUG=499731 > > Committed: https://crrev.com/33f2d3a5b276b70040adfd21edf364bd666b0aa2 > Cr-Commit-Position: refs/heads/master@{#342145} TBR=petrcermak@chromium.org,nduca@chromium.org,pfeldman@chromium.org,ssid@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=499731 Review URL: https://codereview.chromium.org/1272703003 Cr-Commit-Position: refs/heads/master@{#342167}
* [tracing] Throttle rate of heavy dumps and support to request light/heavy dumpsssid2015-08-061-1/+3
| | | | | | | | | | | | | | | Currently all the dump providers dump detailed dumps every periodic dump. This makes the trace files huge. So, this CL throttles down the rate of heavy dumps of all the dump providers and removes temporary hacks. Along with this, this CL also adds support to request light and heavy dumps by adding MemoryDumpArgs as param to RequestGlobalDump() TBR=pfeldman@chromium.org BUG=499731 Review URL: https://codereview.chromium.org/1267963002 Cr-Commit-Position: refs/heads/master@{#342145}
* Add default statement in WebResponseTypeToProtoResponseType().horo2015-08-061-0/+4
| | | | | | | | | | | WebServiceWorkerResponseTypeOpaqueRedirect will be added in blink to support "opaqueredirect" response type. To avoid the compile error, this cl adds default statement in WebResponseTypeToProtoResponseType(). BUG=510650 Review URL: https://codereview.chromium.org/1276883002 Cr-Commit-Position: refs/heads/master@{#342122}
* Plumb notification action index for desktop SW notificationclickjohnme2015-08-064-7/+19
| | | | | | | | | | | | | | | | | | | | | | | | Spec: https://github.com/whatwg/notifications/pull/48 Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/6tlbJW0NjEA/LF0kPfJx7c0J Part of a sequence of patches: - https://codereview.chromium.org/1254423011 (blink) - https://codereview.chromium.org/1263043002 (blink) - https://codereview.chromium.org/1263043003 (blink) - https://codereview.chromium.org/1268813007 (blink) - https://codereview.chromium.org/1267673003 (chromium) - https://codereview.chromium.org/1262893005 (blink) - this patch (chromium) - https://codereview.chromium.org/1262893006 (chromium) - https://codereview.chromium.org/1264403002 (blink) BUG=513671 Review URL: https://codereview.chromium.org/1269923003 Cr-Commit-Position: refs/heads/master@{#342121}
* [tracing] Introduce MemoryDumpArgs to enable light and heavy dumpsssid2015-08-062-1/+3
| | | | | | | | | | | | | | | | The memory dump providers dump a lot of details at each dump which causes the trace size to be huge. So, this CL introduces MemoryDumpArgs that will be passed to each DumpProvider as an argument of OnMemoryDump. The args specify a high or low level of detail. This provides a means to request a light or heavy dump from the providers when necessary. TBR=reed@google.com, jam@chromium.org BUG=499731 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1262333005 Cr-Commit-Position: refs/heads/master@{#342103}
* Disable flaky EncryptedMediaTests from content_browsertestsvabr2015-08-061-0/+3
| | | | | | | | | | | | | | More info in http://crbug.com/517018#c6. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517018 TBR=jrummell@chromium.org Review URL: https://codereview.chromium.org/1280633002 Cr-Commit-Position: refs/heads/master@{#342098}
* ozone: Introduce ClientPixmap and ClientPixmapFactory for non-GPU processes.dongseong.hwang2015-08-063-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's part of "native GpuMemoryBuffer on ChromeOS Freon" implementation. * Design doc: https://docs.google.com/document/d/1qpLLo4mBkzHBh5cuBtBjJZAzXK2X9BgBJtpESh-mNn8 Renderer needs to use Ozone platform interface because of native GpuMemoryBuffer support. However 99% of OzonePlatform isn't usable from the Renderer. So this CL introduces ClientPixmapFactory. ClientPixmapFactory allows external implementations to hook into Chromium to provide a client pixmap for non-GPU processes. GPU process creates NativePixmap and sends GpuMemoryBufferHandle to Browser or Renderer. The non-GPU processes will import a client pixmap from the handle in https://codereview.chromium.org/1134993003/ To demonstrate why this interface is needed, make GpuMemoryBufferFactoryOzoneNativeBuffer use this interface. IsGpuMemoryBufferConfigurationSupported() must answer if the configuration is supported with respect to each Ozone platform, but currently the answer is hardcoded, which is true only on Ozone GBM. This CL makes each Ozone platform answer this question. Browser and Renderer have the singleton ClientPixmapFactory instance like Android and MacOS. For more information why a pixmap is created by SurfaceFactoryOzone, instead of ClientPixmapFactory, (1) The privileged (GPU process) API. This is SurfaceFactoryOzone. It's used to allocate buffer objects and swap onto a surface/display, etc. By design there's only one process using this API. It's extremely driver specific under the hood, including in userspace. CreateNativePixmap goes here. (2) The unprivileged API. This is ClientPixmapFactory. It can only take handles to existing objects and map them, and it should work under the sandbox. It's only driver specific in the kernel; the userland part doesn't require loading drivers. ImportClientPixmap goes here. TEST=content_unittests --gtest_filter=GpuMemoryBuffer* --ozone-platform=gbm --ozone-use-surfaceless Run amd64_generic_freon image BUG=475633 Review URL: https://codereview.chromium.org/1128113011 Cr-Commit-Position: refs/heads/master@{#342094}
* Service Worker: Add missing ServiceWorkerDispatcherHost::SendUpdateError.jungkee.song2015-08-062-1/+20
| | | | | | | | | | | | | | | | | | | Add ServiceWorkerDispatcherHost::SendUpdateError method as a follow-up patch for https://codereview.chromium.org/1270513002/. While working on the layout test, itt has been found that ServiceWorkerDispatcherHost::UpdateComplete was calling ServiceWorkerDispatcherHost::SendRegistrationError instead of the missing ServiceWorkerDispatcherHost::SendUpdateError so the callback in the renderer-side could not be properly located. Related CL: https://codereview.chromium.org/1270513002/ BUG=513655 Review URL: https://codereview.chromium.org/1278713002 Cr-Commit-Position: refs/heads/master@{#342091}
* Improve wheel event trace coveragejdduke2015-08-062-1/+8
| | | | | | | | | | | | | Add browser process trace coverage for wheel deltas of new events seen by the RenderWidgetHostImpl, and events that are coalesced in the InputRouterImpl. BUG=517187 NOTRY=true Review URL: https://codereview.chromium.org/1272823002 Cr-Commit-Position: refs/heads/master@{#342034}
* Revert of Refactor browser side navigator.connect code to not use ↵mek2015-08-066-201/+368
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MessagePortService. (patchset #2 id:60001 of https://codereview.chromium.org/1224263007/ ) Reason for revert: Seems to be crashing on windows. BUG=517281 Original issue's description: > Refactor browser side navigator.connect code to not use MessagePortService. > > This is the first step towards unifying client side and service side ServicePort > instances, but also removes a layer of abstraction in how connections to > services are setup. The abstraction layer will probably later be reintroduced > differently. > > BUG=426458 > > Committed: https://crrev.com/9b053ed8f7b8893ad0a5a33d31546c70563ddf20 > Cr-Commit-Position: refs/heads/master@{#341987} TBR=avi@chromium.org,bsittler@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=426458 Review URL: https://codereview.chromium.org/1278483004 Cr-Commit-Position: refs/heads/master@{#342026}
* Adds tracing support for GL textures in both CC (via ResourceProvider) and ↵ericrk2015-08-065-8/+28
| | | | | | | | | | | GPU (via TextureManager). Does not currently log all renderer textures, as we still need a follow up patch to account for Skia allocations. BUG=512534 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1256613002 Cr-Commit-Position: refs/heads/master@{#342020}
* Disable tap suppression logic for WebViewjdduke2015-08-061-64/+30
| | | | | | | | | | | | | | | | WebView embedders can suppress fling animation updates, potentially confusing the tap suppression controller. As the feature isn't critical, simply disable it for WebView. Also refactor the input router settings helper to use ui::GestureConfiguration directly for configuring tap suppression. This makes it simpler for different platforms to customize behavior. BUG=514783 Review URL: https://codereview.chromium.org/1267693004 Cr-Commit-Position: refs/heads/master@{#342019}
* Remove debugging information for title setting.avi2015-08-051-22/+1
| | | | | | | | | | | This partially reverts commit 99f2bfdaa1400b028801961be4ab4d91c201f840. BUG=369661 TBR=creis@chromium.org Review URL: https://codereview.chromium.org/1271423003 Cr-Commit-Position: refs/heads/master@{#342007}
* Refactor browser side navigator.connect code to not use MessagePortService.mek2015-08-056-368/+201
| | | | | | | | | | | | | This is the first step towards unifying client side and service side ServicePort instances, but also removes a layer of abstraction in how connections to services are setup. The abstraction layer will probably later be reintroduced differently. BUG=426458 Review URL: https://codereview.chromium.org/1224263007 Cr-Commit-Position: refs/heads/master@{#341987}
* Add "secure explanations" to SecurityStyleExplanationsestark2015-08-051-0/+3
| | | | | | | | | | | | | This CL adds a field to SecurityStyleExplanations to explain the page's secure properties: namely, if it has a valid certificate and has all secure subresources (no mixed content), then these properties are explained in |secure_explanations|. BUG=484387 Review URL: https://codereview.chromium.org/1270273002 Cr-Commit-Position: refs/heads/master@{#341981}
* Fix invalid cast in AppCacheGroup::AddUpdateObserver.krasin2015-08-052-6/+9
| | | | | | | | BUG=chromium:457523,chromium:516513 Review URL: https://codereview.chromium.org/1265353003 Cr-Commit-Position: refs/heads/master@{#341973}
* Fix invalid cast to FrameMsg_CommitNavigation.krasin2015-08-051-6/+4
| | | | | | | | | | In all cases, the real type is IPC::Message. BUG=chromium:516523,chromium:457523 Review URL: https://codereview.chromium.org/1255123009 Cr-Commit-Position: refs/heads/master@{#341965}
* Fixed variable shadowing in BackgroundTracingManagerImpl::IsSupportedConfigoysteine2015-08-051-10/+8
| | | | | | | | R=dsinclair Review URL: https://codereview.chromium.org/1277503005 Cr-Commit-Position: refs/heads/master@{#341964}
* Setup TestRenderFrameHostFactory in WebContentsVideoCaptureDeviceTest.krasin2015-08-051-0/+6
| | | | | | | | | | | | | | | | | Before this CL, a real content::RenderFrameHostImpl was used instead of content::TestRenderFrameHost, which caused an invalid cast in content::TestWebContents::GetMainFrame. See http://crbug.com/516528 for more details. This bug was found by Control Flow Integrity check: https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity BUG=chromium:457523,chromium:516528 Review URL: https://codereview.chromium.org/1270263002 Cr-Commit-Position: refs/heads/master@{#341943}
* Avoid crashing if can't allocate software buffer for window.jbauman2015-08-051-3/+2
| | | | | | | | | | | Content can create really big popup box windows, so the code should avoid crashing if it can't allocate a buffer big enough to draw into them. BUG=501690 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1268663006 Cr-Commit-Position: refs/heads/master@{#341941}
* Detect whether to enable reader mode when the HTML finishes loadingwychen2015-08-051-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Checking whether a page is distillable was done in two events: - didNavigateMainFrame (right after navigating to a new page) - didFinishLoad (when all the resources are loaded) Checking in didNavigateMainFrame made sense because IsOpenGraphArticle() only needs to check <head>. However, Adaboost model is going to be the default option, and it needs the whole <body>, which is unlikely to be available at didNavigateMainFrame. On the other hand, didFinishLoad could be very late, and what we need in the Adaboost model is mostly complete when the HTML in the main frame finishes loading. Now the checking is done in these two events instead: - documentLoadedInFrame (HTML in main frame finishes loading) - didFinishLoad One more parameter (isMainFrame) is added to documentLoadedInFrame in WebContentsObserver. BUG=510254 Review URL: https://codereview.chromium.org/1249133002 Cr-Commit-Position: refs/heads/master@{#341915}
* Fix all failed and canceled URLRequestStatuses without errors.davidben2015-08-052-5/+6
| | | | | | | | | | | | | | As a step towards removing URLRequestStatus::Status, stop creating FAILED and CANCELED URLRequestStatuses without supplying an error. IO_PENDING is left for later as that'll want a bit more careful auditing of error() callers. BUG=490311 Review URL: https://codereview.chromium.org/1239993004 Cr-Commit-Position: refs/heads/master@{#341913}
* [BackgroundTracing] Add network type to metadatafmeawad2015-08-051-0/+29
| | | | | | | | | | | Network type can be used to cluster traces in groups that have the same network characteristics. BUG=516855 Review URL: https://codereview.chromium.org/1272003005 Cr-Commit-Position: refs/heads/master@{#341904}
* Reland of Move BackgroundSyncManager::ErrorType to BackgroundSyncStatusjkarlin2015-08-059-116/+148
| | | | | | | | | | | | | | | | https://codereview.chromium.org/1246483002/ broke the tree due to a conflict with another CL landing at the same time. Move BackgroundSyncManager::ErrorType to BackgroundSyncStatus This needs to be in its own file to prevent dependency loop issues. And it's more of a status than an error code so renaming. TBR=iclelland@chromium.org,mvanouwerkerk@chromium.org BUG=511278 Review URL: https://codereview.chromium.org/1274573003 Cr-Commit-Position: refs/heads/master@{#341895}
* Fix bug in EmbeddedWorkerRegistry::RemoveWorkerfalken2015-08-053-3/+66
| | | | | | | | | RemoveWorker would remove the worker's process id from the process map, but other workers may live in that process. Review URL: https://codereview.chromium.org/1274573002 Cr-Commit-Position: refs/heads/master@{#341890}
* This reverts 3 CLsoshima2015-08-052-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | Revert "aura: Do not create Env instance from WebContentsViewAura." https://crrev.com/8a68e6ae1f1eab523d52c469ecc380c3f50ab0a7 Revert "aura-test: Create the Env instance only if one doesn't already exist." https://crrev.com/58b1d0146d23ba2475a1dc550f0a02e8a9a86c74 Revert "aura: Remove more code that explicitly creates/destroys aura::Env." https://crrev.com/842addb19884a14e672612380209c7e439d14a27 Reason for revert: Invalid read error on memory bots: see bug for more details. Invalid read of size 8 std::vector<aura::EnvObserver*, std::allocator<aura::EnvObserver*> >::size() const (/mnt/data/b/build/slave/chromium-rel-linux-valgrind-tests-3/build/src/out/Release/unit_tests) base::ObserverListBase<aura::EnvObserver>::size() const (/mnt/data/b/build/slave/chromium-rel-linux-valgrind-tests-3/build/src/out/Release/unit_tests) base::ObserverList<aura::EnvObserver, false>::might_have_observers() const (/mnt/data/b/build/slave/chromium-rel-linux-valgrind-tests-3/build/src/out/Release/unit_tests) aura::Env::NotifyWindowInitialized(aura::Window*) (ui/aura/env.cc:97) aura::Window::Init(ui::LayerType) (ui/aura/window.cc:171) .... BUG=515031,516898 TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/1268223002 Cr-Commit-Position: refs/heads/master@{#341884}
generated by cgit v1.1 at 2025-03-26 08:55:25 +0000