| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FileAndBlobMessageFilter.
So that we can handle files and blobs in a unified way.
BUG=115603
TEST="existing tests should pass"
Review URL: http://codereview.chromium.org/9514010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110796
TEST=Run ui_tests --gtest_filter=PPAPITest.*Clipboard* and ui_unittests --gtest_filter=*Clipboard*.
Review URL: http://codereview.chromium.org/9349023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=115758
Review URL: https://chromiumcodereview.appspot.com/9460038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It always bothered me when the text said "Leave this page" when I was
actually reloading.
BUG=40535
TEST=BrowserTest.BeforeUnloadVsBeforeReload plus manual testing.
Review URL: http://codereview.chromium.org/9460056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=115603
TEST=None
Review URL: https://chromiumcodereview.appspot.com/9475036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=115603
TEST=will test when we finish adding the plumbing
Review URL: https://chromiumcodereview.appspot.com/9475015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to copy data out of the backing store to satisfy the existing users.
Note that the ThumbnailGenerator test turned out to be testing a feature that has since been removed! So I removed that test and the supporting code.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9515009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When this command line flag is on, touch gestures are broken (i.e. panning with one finger, two finger tap for right click, etc.) because Windows allows only touch or gesture, but not both.
TEST=http://www.cuttherope.ie/ http://paulirish.com/demo/multi
Review URL: http://codereview.chromium.org/9475025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use if !defined(OS_ANDROID) to remove AudioRenderHost, VideoCaptureHost,
and AudioInputRendererHost from Android builds. These are not used
in Chrome for Android and there are linker errors with
BrowserMainLoop::GetAudioManager() as BrowserMainLoop is excluded
from Android builds.
BUG=115941
TEST=
Review URL: http://codereview.chromium.org/9479019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
window-level controls.
BUG=115712
TEST=None
Review URL: http://codereview.chromium.org/9475007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=108472
R=willchan
TEST=in js console chrome:loadtimes() should print SPDY
protocol that was negotiated.
Review URL: http://codereview.chromium.org/9413038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
According to Darin, it doesn't make sense to call CancelRequest if it's not pending. Checking is_pending before calling CancelRequest fixes the flakiness (passed on 1,000 tries)
BUG=40932
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9453028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make SequencedWorkerPool ref-counted, merge it with ::Inner, and
make its destructor private. Make users hold a scoped_refptr.
Fix bug where SequencedWorkerPool::Worker wasn't taking a reference
to the worker pool.
Rename SequencedWorkerPool::PostTask to PostTaskHelper.
Clean up includes and use forward declarations when possible.
Make SequencedWorkerPool::Shutdown completely thread-safe by merging
the terminating_ and shutdown_called_ flag. (Now that it's ref-counted,
it can be passed around multiple threads.)
Clean up includes and params in webkit/dom_storage a bit.
BUG=114329,114330
TEST=
Review URL: https://chromiumcodereview.appspot.com/9347056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it's not necessary anymore (it's now set on destruction).
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9475019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
chrome's mapping of click to disposition).
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9481008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
rewritten to the same value as they were read on the IO thread.
BUG=115678
Review URL: https://chromiumcodereview.appspot.com/9466031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It can't live on the RootWindow since there's no way to locate a relevant RootWindow when it is called.
http://crbug.com/112131
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9464048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hostname must now be explicitly specified (previously default was 127.0.0.1). See the following CL for further details:
http://codereview.chromium.org/9369029/
A follow-up CL will remove the deprecated constructor:
http://codereview.chromium.org/9431002/
BUG=114369
TEST=everything still compiles and passes
Review URL: http://codereview.chromium.org/9475002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
namespace.
BUG=98716
R=jam@chromium.org
TBR=mirandac@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9463040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and delete ResourceQueue.
Review URL: http://codereview.chromium.org/9395061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/112131
TEST=none
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/9455081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These functions add TimeDelta interfaces in addition to the int ms interfaces,
which will be removed at a later date.
BUG=108171
Review URL: http://codereview.chromium.org/9427023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added unit tests for direct and navigated download 404 errors.
BUG= 114020
TEST=Set up a server with a web page that has an invalid link. Right click on the link and select Save As to download the file.
Review URL: http://codereview.chromium.org/9378035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9455046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on https://bugs.webkit.org/show_bug.cgi?id=75874 (which has landed, but has yet to roll).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9430005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content implementation.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9463029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it and it was just a glorified std::pair after the recent refactorings.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9467016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
code so that it only calls profile-wide operations (i.e. saving session/purging memory/clearing local state on exit) on the BrowserContext. The content layer takes care of calling the necessary objects on the right thread.
WebKitContext now does almost nothing and I'll remove it completely in the next change.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9462007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it anymore to implement the embedder bits, instead it implements a delegate for that class.
There used to be an existing delegate that SpeechInputManager called SpeechInputDispatcherHost through. But there were no other implementations of that interface, so rather than keep two delegate interfaces, I removed it.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9463001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=chrome_frame_net_tests don't crash at shutdown (Note, they currently crash at startup or simply don't run without a few other patches applied - this fixes one of the crashes!).
Review URL: http://codereview.chromium.org/9443033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9453015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is behind a flag (--ui-use-gpu-process).
Currently problems occur when the GPU process crash, this will be handled in a follow-up CL.
BUG=99516
TEST=chrome --ui-use-gpu-process (with an aura build)
TBR=sky,jam,apatrick
Review URL: https://chromiumcodereview.appspot.com/9442017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fieldset to MSAA's ROLE_SYSTEM_GROUPING.
BUG=89191
TEST=Manually, with AViewer
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122805
Review URL: http://codereview.chromium.org/9427028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a PPAPI plugin does not support drawing composition text by themselves,
the browser is expected to do it instead. This patch is for implementing
it for MacOS (32bits).
BUG=97189
TEST=Manual:
1. make ppapi_example_ime
2. ./your/chrome --register-pepper-plugins=\
"/path/to/ppapi_example_ime.plugin;application/x-ppapi-example-ime" \
file:///path/to/ppapi/examples/ime/ime.html
3. Verify that on the middle 2 of the 4 plugins show bottomline input
window for text input via input methods.
Review URL: http://codereview.chromium.org/9429041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
base::file_handle_mapping_vector to StudlyCaps.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9429039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class was hitting a ThreadRestrictions assert because it called
OpenFile on the UI thread. To reduce unnecessary copying, I've changed
the OnTraceDataCollected argument from std::string to RefCountedString.
Second attempt (originally committed in 123140, reverted in 123146).
Added DISALLOW_COPY_AND_ASSIGN to fix Windows compilation error.
BUG=None
TEST=content_unittests
Review URL: http://codereview.chromium.org/9443020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as without this patch (and everything is still behind a flag).
BUG=105115
TEST=
Review URL: http://codereview.chromium.org/9360018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DumpAccessibilityTreeTest.PlatformTreeDifferenceTest fails:
..\content\browser\accessibility\dump_accessibility_tree_browsertest.cc(106): error: Value of: actual_contents8
Actual: "|ROLE_SYSTEM_DOCUMENT||IA2_STATE_HORIZONTAL|IA2_STATE_OPAQUE\n|IA2_ROLE_SECTION||IA2_STATE_HORIZONTAL|IA2_STATE_OPAQUE\n"
Expected: expected_contents
Which is: "|ROLE_SYSTEM_DOCUMENT||IA2_STATE_OPAQUE|IA2_STATE_VERTICAL\n|IA2_ROLE_SECTION||IA2_STATE_HORIZONTAL|IA2_STATE_OPAQUE\n"
Revert "Revert 122617 - Adds dump accessibility tree support in Windows."
This reverts commit ca8de581137b34eb04ca8b68186f143d4bea98e8.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9429026
TBR=dtseng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9454033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
matters to embedders is that they can influence this object's lifetime.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9447039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "Revert 122617 - Adds dump accessibility tree support in Windows."
This reverts commit ca8de581137b34eb04ca8b68186f143d4bea98e8.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9429026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=115150
TEST=
TBR=dgrogan@chromium.org
Review URL: http://codereview.chromium.org/9456028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
12% of samples are greater than the current maximum value of 1024.
Review URL: http://codereview.chromium.org/9432039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9453023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9456025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL temporarily removes GetBufferSizeForSampleRate() and uses
SelectSamplesPerPacket() to determine the size of samples_per_packet in
AudioDevice. This restores the buffer size that AudioRendererImpl
used prior to r113821. SelectSamplesPerPacket() calculates a much larger
samples_per_packet value than GetBufferSizeForSampleRate(), so it fixes
the issue described in 108239.
This CL also does some mild refactoring to move audio_common.cc into
audio_util.cc.
BUG=108239
TEST=media_unittests,content_unittests, manual testing of different playback rates
Review URL: https://chromiumcodereview.appspot.com/9416085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
change I will remove WebKitContext usage from chrome, and then in another change probably remove it altogether.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9447010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reason is the content module should create all the concrete objects that it knows about, instead of depending on every embedder to do so. ResourceContext is then just the interfaces that it implements and which it provides on the IO thread.
The AudioManager getter was a global, so I added a getter to the AudioManager class. MediaStreamManager now has its own static getter like other internal content classes on ResourceContext or BrowserContext.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9433006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
https://crash/reportdetail?reportid=11e1136804b56110
Either the user's downloads sqlite table really contained the same db_handle twice, or OnPersistentStoreQueryComplete() was called twice somehow. Add checks for both.
Review URL: http://codereview.chromium.org/9390020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This begins the process of extracting RWH and RVH interfaces and
leaving RenderWidgetHostImpl and RenderViewImpl classes in content.
There will be parallel inheritance hierarchies, i.e. RWHImpl inherits
from RWH, RVH inherits from RWH, RVHImpl inherits from RVH and
RWHImpl. Thus, chrome will only see the interfaces.
I fully expect that some of the things chrome needs from the RVH
interface, once I introduce that, will more properly belong on the RWH
interface, in which case I expect to move them there. But first to
define the base interfaces.
BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123227
Review URL: https://chromiumcodereview.appspot.com/9432027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This begins the process of extracting RWH and RVH interfaces and
leaving RenderWidgetHostImpl and RenderViewImpl classes in content.
There will be parallel inheritance hierarchies, i.e. RWHImpl inherits
from RWH, RVH inherits from RWH, RVHImpl inherits from RVH and
RWHImpl. Thus, chrome will only see the interfaces.
I fully expect that some of the things chrome needs from the RVH
interface, once I introduce that, will more properly belong on the RWH
interface, in which case I expect to move them there. But first to
define the base interfaces.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9432027
TBR=joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9453010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123234 0039d316-1c4b-4281-b951-d872f2087c98
|