| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=79734
TEST=no
Review URL: http://codereview.chromium.org/7387012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Nobody was getting notified when workers crash.
(This was caught by a further patch of mine that adds OVERRIDE to
users of this file, which would have caught this.)
Review URL: http://codereview.chromium.org/7468010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code was never called, because TabContents doesn't implement
the interface that calls this method. I assume it was moved to
the class this was forwarding to. I tried to track down when
this happened in the history but we've moved code so many times
I couldn't find it.
Review URL: http://codereview.chromium.org/7467009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7471040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When performing a long running search in the history, turn on the tab thobber to indicate that an operation is in progress.
BUG=14730
TEST=Ensure you have a large browsing history, go to chrome://history, search for something, notice the throbber come on.
Review URL: http://codereview.chromium.org/7399007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89371
TEST=see bug
Review URL: http://codereview.chromium.org/7448012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation.
Handle the "multiple tabs requesting certs for same site" issue.
BUG=73223,50710
TEST=Try some sites that use SSL client auth. See bug 73223 for multiple-tabs issue.
Review URL: http://codereview.chromium.org/7362008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents
The TabContents object is the one in which the URL will be opened if it can be determined immediately.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/7343013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
readers can access HTML tables.
BUG=66874,89220,89221
TEST=Adds new tests.
Review URL: http://codereview.chromium.org/7358004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's likely something seriously wrong with the graphics driver if preliminary gpu info collection fails.
BUG=89358
TEST=bots green
Review URL: http://codereview.chromium.org/7472002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AudioIndputDeviceManager is responsible for tracking which devices has been opened, normally by WebKit. AudioInputDeviceManager is called from MediaStreamManager when a user has approved a webpage to use the audio input device.
AudioInputRendererHost will call AudioInputDeviceManager asking for which device to start, given the session id created when opening the device.
This patch is one of the patches to add support for WhatWG peer connection API.
This patch replaces 7081002 previously uploaded by xians.
BUG=none
TEST=unit_tests
Review URL: http://codereview.chromium.org/7307021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeOS may kill chrome right after process
starts (when a user closes lid right away for example), and
sending magic number to browser process can fail. Instead of
CHECK, exit normally on chromeos.
BUG=chromium-os:17606
TEST=autotest will not crash with session manager sending SIGTERM
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93171
Review URL: http://codereview.chromium.org/7433011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make it private and establish a friend whitelist for existing users.
BUG=64339
TEST=none
Review URL: http://codereview.chromium.org/7438002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7458016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7458015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
hasn't been loaded yet, or has been invalidated.
BUG=69516
TEST=no dcheck
Review URL: http://codereview.chromium.org/7399022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7453019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from devtools_manager.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7429006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
console evaluation result.
See http://chromesshgw.corp.google.com/i/chromium/builders/Linux%20Builder%20%28ChromiumOS%29/builds/9891/steps/interactive_ui_tests/logs/InspectSharedWorker
TBR=pfeldman
BUG=89845
TEST=WorkerDevToolsSanityTest.InspectSharedWorker
Review URL: http://codereview.chromium.org/7453018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeOS may kill chrome right after process
starts (when a user closes lid right away for example), and
sending magic number to browser process can fail. Instead of
CHECK, exit normally on chromeos.
BUG=chromium-os:17606
TEST=autotest will not crash with session manager sending SIGTERM
Review URL: http://codereview.chromium.org/7433011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Test that DevTools window can be opened for a shared worker and console will allow to evaluate expressions in the worker global context.
BUG=None
TEST=WorkerDevToolsSanityTest.InspectSharedWorker
Review URL: http://codereview.chromium.org/7433009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removed unused/irrelevant functions
removed irrelevant comments
Moved stl_util-inl.h => stl_util.h
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7342047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
be confident in blocking it without annoying a huge percentage of users.
Review URL: http://codereview.chromium.org/7453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sensors API will unify various types of sensor data into a set of channels, each of which provides change events and periodic updates.
This version of the API is intended only to support the experimental screen rotation code and is not for general use. In particular, the final listener will declare generic |OnSensorChange| and |OnSensorUpdate| methods, rather than the special-purpose |OnScreenOrientationChange|.
BUG=none
TEST=manual with http://codereview.chromium.org/7273073/
Review URL: http://codereview.chromium.org/7366011
TBR=cwolfe@chromium.org
Review URL: http://codereview.chromium.org/7455002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80596
TEST=ui_tests
TBR=robertshield@chromium.org
Review URL: http://codereview.chromium.org/7452001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sensors API will unify various types of sensor data into a set of channels, each of which provides change events and periodic updates.
This version of the API is intended only to support the experimental screen rotation code and is not for general use. In particular, the final listener will declare generic |OnSensorChange| and |OnSensorUpdate| methods, rather than the special-purpose |OnScreenOrientationChange|.
BUG=none
TEST=manual with http://codereview.chromium.org/7273073/
Review URL: http://codereview.chromium.org/7366011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
content/common/result_codes.h contains only the codes defined in content. chrome/common/chrome_result_codes.h contains the codes defined in chrome and also includes (for convenience) the content header.
R=jam@chromium.org
BUG=76699
TEST=everything compiles
Review URL: http://codereview.chromium.org/7397004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=82782
Review URL: http://codereview.chromium.org/7396029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mark those APIs as private and friend existing uses.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7397008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7399030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
interfering with its lifetime.
BUG=82782
Review URL: http://codereview.chromium.org/7398003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60149
TEST=None
Review URL: http://codereview.chromium.org/7395033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ResourceDispatcherHost will not cancel download requests after they've begun. However, when a profile goes away, all of its requests should be cancelled, including the download requests, so that they will not try to access deleted objects. This changelist exposes a new RDH API to cancel all requests associated with a content::ResourceContext. ProfileIOData uses this API to cancel all leftover requests. As of time of writing this changelist, the only leftover requests seem to be download requests. It's conceivable this could change in the future, but currently we assert that the only leftover requests are download requests, in order to help catch leaked requests.
BUG=88660
TEST=ResourceDispatcherHost.CancelRequestsForContext
Review URL: http://codereview.chromium.org/7398022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
history.
Avoid racing with the history callback by unilaterally removing
DownloadItem from queues on cancel/interrupt. This keeps the
state<->queue correspondence cleaner, and avoids leaving things on
queues during shutdown. It might also fix 85408; we'll see :-}.
BUG=85408
TEST=
Review URL: http://codereview.chromium.org/7294013
TBR=rdsmith@chromium.org
Review URL: http://codereview.chromium.org/7401024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid racing with the history callback by unilaterally removing
DownloadItem from queues on cancel/interrupt. This keeps the
state<->queue correspondence cleaner, and avoids leaving things on
queues during shutdown. It might also fix 85408; we'll see :-}.
BUG=85408
TEST=
Review URL: http://codereview.chromium.org/7294013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
is the only place that uses it.
BUG=76697
Review URL: http://codereview.chromium.org/7399009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fork implementations.
BUG=nativeclient:480
TEST=existing zygote tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92787
Review URL: http://codereview.chromium.org/7397003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of r80962.
BUG=82782
Review URL: http://codereview.chromium.org/7398013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We need to pass an extra URL parameter to let shared worker devtools front-end know that it is opened for shared worker, not for a page.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7368002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7302012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7400013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for flexible
fork implementations.
BUG=nativeclient:480
TEST=existing zygote tests
Review URL: http://codereview.chromium.org/7397003
TBR=bradchen@google.com
Review URL: http://codereview.chromium.org/7400014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fork implementations.
BUG=nativeclient:480
TEST=existing zygote tests
Review URL: http://codereview.chromium.org/7397003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
crash in NaCl Win64.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2018
TEST= manual win64 nacl, trybots for chrome
Review URL: http://codereview.chromium.org/7388021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 92749 - Fix problem when 'ended' event was fired before stream really ended.
That caused impression that rewind does not work. With that
change small JS program
var a = new Audio("file:///home/enal/temp/click2/click2.wav");
var num_played = 0;
a.addEventListener('canplaythrough', function() {
a.play();
});
a.addEventListener('ended', function() {
num_played ++;
if (num_played < 10) {
a.currentTime = 0;
a.play();
}
});
works correctly, you hear 10 clicks one after another, and it takes
~1.5 seconds to play all 10 sounds (one click is 146ms). Current
Chrome plays only beginnings of the first 9 clicks and then entire
10th click -- 'ended' event fires too early, so rewind stops audio
playback for all clicks but last one.
With that fix you can easily create pool of audio objects -- on 'ended'
event just add audio object to the pool.
Fix consists of 3 parts:
1) For low-latency code path pass entire "audio state" object to the renderer
process. That allows renderer take into account number of pending bytes
in the buffer.
2) When using low-latency code path renderer not only fills the buffer with
data, but also writes length of data into first word of the buffer. That
allows host process to pass correct byte counts to renderer.
3) Renderer now keeps track of the earliest time playback can end based on the
number of rendered bytes, and will not call 'ended' callback till that time.
BUG=http://code.google.com/p/chromium/issues/detail?id=78992
http://codereview.chromium.org/7328030
Review URL: http://codereview.chromium.org/7328030
TBR=enal@chromium.org
Review URL: http://codereview.chromium.org/7395014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That caused impression that rewind does not work. With that
change small JS program
var a = new Audio("file:///home/enal/temp/click2/click2.wav");
var num_played = 0;
a.addEventListener('canplaythrough', function() {
a.play();
});
a.addEventListener('ended', function() {
num_played ++;
if (num_played < 10) {
a.currentTime = 0;
a.play();
}
});
works correctly, you hear 10 clicks one after another, and it takes
~1.5 seconds to play all 10 sounds (one click is 146ms). Current
Chrome plays only beginnings of the first 9 clicks and then entire
10th click -- 'ended' event fires too early, so rewind stops audio
playback for all clicks but last one.
With that fix you can easily create pool of audio objects -- on 'ended'
event just add audio object to the pool.
Fix consists of 3 parts:
1) For low-latency code path pass entire "audio state" object to the renderer
process. That allows renderer take into account number of pending bytes
in the buffer.
2) When using low-latency code path renderer not only fills the buffer with
data, but also writes length of data into first word of the buffer. That
allows host process to pass correct byte counts to renderer.
3) Renderer now keeps track of the earliest time playback can end based on the
number of rendered bytes, and will not call 'ended' callback till that time.
BUG=http://code.google.com/p/chromium/issues/detail?id=78992
http://codereview.chromium.org/7328030
Review URL: http://codereview.chromium.org/7328030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ensures that a race between an asynchronous back/forward and a navigation
in the renderer doesn't confuse NavigationController.
BUG=86758
TEST=RenderViewTest.IgnoreStaleNavigations
TEST=NavigationControllerTest.InPage_Replace
Review URL: http://codereview.chromium.org/7327014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
basically a revert of r85762, with updating for code changes in the meantime.
BUG=82782
Review URL: http://codereview.chromium.org/7374008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builds compile.
TBR=jam@chromium.org
BUG=none
TEST=
Review URL: http://codereview.chromium.org/7400002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new file into chrome/common and does a lot of renaming.
The current version is just a sketch of the headers, and nothing will
compile.
R=jam@chromium.org
BUG=76699
TEST=everything still compiles and runs
Review URL: http://codereview.chromium.org/7377010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92730 0039d316-1c4b-4281-b951-d872f2087c98
|