| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
We still need to render flipped while doing render-to-texture in GLRenderer,
otherwise anything using RTT appears upside down (menus, screenshots), so
InitializeViewport now takes the flip state directly
BUG=418149
Review URL: https://codereview.chromium.org/637653003
Cr-Commit-Position: refs/heads/master@{#301692}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the problem that loading inspector from content_shell is failing with
thread_checker_.CalledOnValidThread() failed.
At ShellDevToolsFrontend::Show(), DevToolsHttpHandlerImpl::GetFrontendURL()
is called to get the frontend url, and inside the function,
HttpServer::GetLocalAddress() is called directly which is expected to be
called on the DevToolsHandler thread only.
To prevent the DCHECK failure, this patch keeps the ip address of HttpServer
as a member of DevToolsHttpHandlerImpl instance and use it.
BUG=425423
Review URL: https://codereview.chromium.org/666673007
Cr-Commit-Position: refs/heads/master@{#301684}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to latest editor spec http://rawgit.com/w3c/html-api-map/master/index.html
Recommended AXRoleDescription of "address" to disambiguate
from "contentinfo" landmark role for address element.
BUG=169577
Review URL: https://codereview.chromium.org/670493002
Cr-Commit-Position: refs/heads/master@{#301671}
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html
Article tag should have 'article' as AXRoleDescription.
BUG=426836
TBR=piman
Review URL: https://codereview.chromium.org/673213002
Cr-Commit-Position: refs/heads/master@{#301665}
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary for in-process command buffer to be able
to use this interface.
BUG=423533
Review URL: https://codereview.chromium.org/656263003
Cr-Commit-Position: refs/heads/master@{#301662}
|
|
|
|
|
|
|
|
|
| |
Enables the slimming paint work: http://www.chromium.org/blink/slimming-paint
This is dependent on https://codereview.chromium.org/684653002/
Review URL: https://codereview.chromium.org/678763007
Cr-Commit-Position: refs/heads/master@{#301659}
|
|
|
|
|
|
|
|
|
|
|
| |
renderer’s, for debug builds only
BUG=407376
TEST=none
Review URL: https://codereview.chromium.org/676823003
Cr-Commit-Position: refs/heads/master@{#301646}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/628773003/)
Reason for revert:
Made inspector/geolocation-emulation-tests.html layout test crash on all platforms
Flakiness dashboard link:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Fgeolocation-emulation-tests.html
Chromium revisions range:
https://chromium.googlesource.com/chromium/src/+log/a772ed62ff0641df984feffe977b1545e94d53f1..5a5999ebee2d83c5a8dc72b3c6035fd803fdf90d?pretty=fuller
Original issue's description:
> Partially convert geolocation IPC to Mojo.
>
> This CL converts the non-permissions-related geolocation IPC to Mojo. The Mojo
> GeolocationService interface allows clients to observe location updates. In
> //content, the service and its client connect on a per-frame basis, eliminating
> the need for the tracking of multiple frames that GeolocationDispatcherHost had
> previously been doing. To handle the fact that geolocation updates can be
> paused and resumed at per-WebContents granularity, we introduce a
> GeolocationServiceContext class, which is used to scope the granularity of
> pauses and resumes.
>
> Currently, GeolocationDispatcherHost still handles permissions-related
> geolocation IPC. This IPC will be moved to Mojo once there is resolution on
> what the right model for handling permissions there is.
>
> BUG=420497
> TEST=Go to maps.google.com, allow location tracking, and check that your
> location is correctly pinpointed on the map.
>
> Committed: https://crrev.com/28e88081438dc08b06d5f05cfdd980c407db1638
> Cr-Commit-Position: refs/heads/master@{#301604}
TBR=qsr@chromium.org,mvanouwerkerk@chromium.org,timvolodine@chromium.org,brettw@chromium.org,creis@chromium.org,tsepez@chromium.org,aa@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420497
Review URL: https://codereview.chromium.org/680323002
Cr-Commit-Position: refs/heads/master@{#301629}
|
|
|
|
|
|
|
|
|
|
| |
This is to comply with spec.
BUG=424629
Review URL: https://codereview.chromium.org/678733002
Cr-Commit-Position: refs/heads/master@{#301627}
|
|
|
|
|
|
|
|
|
|
|
| |
Some sites apparently like to add a title attribute to a link - that should
never override its visible text.
BUG=384107
Review URL: https://codereview.chromium.org/673123002
Cr-Commit-Position: refs/heads/master@{#301613}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-state
[1] Blink: https://codereview.chromium.org/678253002/
[2] Chromium: THIS PATCH
[3] Blink: https://codereview.chromium.org/683733002/
BUG=424081
TEST=content_unittests --gtest_filter=ServiceWorker*
Review URL: https://codereview.chromium.org/685503004
Cr-Commit-Position: refs/heads/master@{#301612}
|
|
|
|
|
|
|
|
|
|
|
|
| |
I initially thought that navigations flagged as "restores" would not
trigger beforeunload events. That's in fact not the case so this
histogram had a misleading name and hence this renaming.
BUG=416877
Review URL: https://codereview.chromium.org/685433002
Cr-Commit-Position: refs/heads/master@{#301606}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL converts the non-permissions-related geolocation IPC to Mojo. The Mojo
GeolocationService interface allows clients to observe location updates. In
//content, the service and its client connect on a per-frame basis, eliminating
the need for the tracking of multiple frames that GeolocationDispatcherHost had
previously been doing. To handle the fact that geolocation updates can be
paused and resumed at per-WebContents granularity, we introduce a
GeolocationServiceContext class, which is used to scope the granularity of
pauses and resumes.
Currently, GeolocationDispatcherHost still handles permissions-related
geolocation IPC. This IPC will be moved to Mojo once there is resolution on
what the right model for handling permissions there is.
BUG=420497
TEST=Go to maps.google.com, allow location tracking, and check that your
location is correctly pinpointed on the map.
Review URL: https://codereview.chromium.org/628773003
Cr-Commit-Position: refs/heads/master@{#301604}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are currently 2 sources of EWOULDBLOCK. One is from the system which we don't have any monitoring in place. The other is generated by the socket implementation of WebRTC. This change adds UMA for both places. The UMAs added here are
1. max consecutive EWOULDBLOCK that we receive from the system. It's protocol dependent.
2. max consecutive EWOULDBLOCK that WebRTC socket generates. Protocol independent.
3. % of packet loss in WebRTC socket layer due to its own EWOULDBLOCK generation. Protocol independent.
Tested in a call and the dtor is invoked when a call is terminated. However, if a user just closes the renderer abruptly, the dtor is not invoked such that these UMA data points will be lost.
BUG=427555
Review URL: https://codereview.chromium.org/677473002
Cr-Commit-Position: refs/heads/master@{#301575}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HTML Tag: input type reset button, samp, s, dt, progress
ARIA Role: button, dialog, radiogroup
ARIA state/property: aria-live
Following are already present:
HTML Tag input type in date and time state
ARIA state/property: aria-checked
Other changes incorporated in this CL:
1. There should be no STATE_SYSTEM_READONLY for ARIA role dialog.
2. ARIA role radiogroup is exposed correctly.
BUG=170578
Review URL: https://codereview.chromium.org/674873004
Cr-Commit-Position: refs/heads/master@{#301573}
|
|
|
|
|
|
|
|
| |
Drawing in this case isn't productive and can cause DCHECKs to be hit.
Review URL: https://codereview.chromium.org/677983006
Cr-Commit-Position: refs/heads/master@{#301571}
|
|
|
|
|
|
|
|
| |
BindToClient should return false so the compositor doesn't attempt to use the context.
Review URL: https://codereview.chromium.org/682963002
Cr-Commit-Position: refs/heads/master@{#301570}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ability was added for Android WebView to limit the number of
gralloc buffers, which has a low limit on the number of allocations.
Android WebView no longer uses gralloc buffers, so no need to keep this
ability.
Use memory limit to limit the staging resource pool for 1-copy
rasterizer.
BUG=426548
Review URL: https://codereview.chromium.org/643993005
Cr-Commit-Position: refs/heads/master@{#301559}
|
|
|
|
|
|
|
|
|
|
|
| |
This is because content view core object could be destroyed at the time when
a method is called on it.
BUG=427684
Review URL: https://codereview.chromium.org/677423003
Cr-Commit-Position: refs/heads/master@{#301548}
|
|
|
|
|
|
|
|
|
|
|
| |
This restriction doesn't allow registration of the ServiceWorker scope outside the script directory.
As per discussion on https://github.com/slightlyoff/ServiceWorker/issues/468
BUG=423983
Review URL: https://codereview.chromium.org/677003002
Cr-Commit-Position: refs/heads/master@{#301547}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=nasko@chromium.org
Review URL: https://codereview.chromium.org/678073006
Cr-Commit-Position: refs/heads/master@{#301534}
|
|
|
|
|
|
|
|
| |
This may help startup time.
Review URL: https://codereview.chromium.org/648413004
Cr-Commit-Position: refs/heads/master@{#301512}
|
|
|
|
|
|
|
|
|
|
|
| |
Remove v2.
R=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/682713003
Cr-Commit-Position: refs/heads/master@{#301493}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=asvitkine@chromium.org
Review URL: https://codereview.chromium.org/679243002
Cr-Commit-Position: refs/heads/master@{#301491}
|
|
|
|
|
|
|
|
|
| |
BUG=407376
TEST=none
Review URL: https://codereview.chromium.org/683563003
Cr-Commit-Position: refs/heads/master@{#301467}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
service (patchset #23 id:570001 of https://codereview.chromium.org/592153002/)
Reason for revert:
Broke battery-status LayoutTests: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=battery-status
Original issue's description:
> Replace Chrome IPC with Mojo IPC for querying BatteryStatus service
>
> This is based on patch set 26 from Darin's https://codereview.chromium.org/457933002/ .
>
> BUG=420623
>
> Committed: https://crrev.com/9e6d2387b6d9b28ab6defe7f5feb715a5abbc242
> Cr-Commit-Position: refs/heads/master@{#301380}
TBR=rockot@chromium.org,timvolodine@chromium.org,jam@chromium.org,viettrungluu@chromium.org,jln@chromium.org,tsepez@chromium.org,ppi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420623
Review URL: https://codereview.chromium.org/676953005
Cr-Commit-Position: refs/heads/master@{#301402}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements the WebNotificationManager Blink API in //content,
together with a dispatcher to communicate with the browser process and
for the browser process to communicate with the appropriate Notification
Manager. This code path is not being used yet, but will be once the
Blink Web Notification API switches over.
BUG=392187
Review URL: https://codereview.chromium.org/644643005
Cr-Commit-Position: refs/heads/master@{#301398}
|
|
|
|
|
|
|
|
|
| |
BUG=418019
TEST=None
Review URL: https://codereview.chromium.org/681813002
Cr-Commit-Position: refs/heads/master@{#301396}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch changes Notification objects created for Web Notifications to
go without an associated WebContents. Because we want Web Notifications
to be used from Web Workers, this no longer is a valid assumption to make.
BUG=415160
Review URL: https://codereview.chromium.org/578883003
Cr-Commit-Position: refs/heads/master@{#301394}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Making GestureConfiguration as an interface to serve all the platforms,
so that Aura and Android push to and pull from the same data source,
GestureConfiguration, where gesture configuring parameters are.
BUG=339203
Review URL: https://codereview.chromium.org/613373004
Cr-Commit-Position: refs/heads/master@{#301393}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is just a heuristic to handle a situation where neither the link or
image are labeled. Since we can only export a single name attribute on
Android - unlike other systems where we export several fields and let the
assistive technology decide - this tries to do the sensible thing when
there's a link containing an image.
BUG=386623
Review URL: https://codereview.chromium.org/639773012
Cr-Commit-Position: refs/heads/master@{#301390}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a groundwork to support CursorAnchorInfo API for Android 5.0. No user visible change is intended with this CL.
With this CL, ImeCompositionRangeChanged event will be routed from the renderer to the browser in Android 5.0 and above. The underlying functionality has been widely used in desktop OSes for years. There should be no performance impact for existing in Android 4.4 and prior version. Performance impact on Android 5.0 devices will be tracked as Issue 427090. Actual plumbing from native to Java layer will be handled in subsequent CLs.
BUG=424866, 427090
TEST=Manually done on Nexus 7 Build/LPX13D
Review URL: https://codereview.chromium.org/671503005
Cr-Commit-Position: refs/heads/master@{#301384}
|
|
|
|
|
|
|
|
|
|
| |
This is based on patch set 26 from Darin's https://codereview.chromium.org/457933002/ .
BUG=420623
Review URL: https://codereview.chromium.org/592153002
Cr-Commit-Position: refs/heads/master@{#301380}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the header says
The Put() function performs an async init() with a weakptr callback.
If the weakptr is null then the callback won't be called, breaking the
contract that Put()'s callback will always be called.
This CL fixes that by making the PutImpl callback a static member (so
that it can access Cache::backend_). The other Put callbacks and its
necessary classes came along for the ride.
Upstream of: https://codereview.chromium.org/649203005
BUG=426964
Review URL: https://codereview.chromium.org/658583006
Cr-Commit-Position: refs/heads/master@{#301355}
|
|
|
|
|
|
|
|
| |
BUG=392145
Review URL: https://codereview.chromium.org/622793002
Cr-Commit-Position: refs/heads/master@{#301338}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After a render process dies, the main RenderFrameHostImpl can be reused for a
new RenderFrame in a new render process. In this case, the Mojo connection
between the RFHI and the new RenderFrame was not being set up. This CL fixes
the glitch and additionally future-proofs for the case where sub-frames can be
reused as well:
- When the FrameTree resets process state, it instructs the RFHI's affected
to invalidate their Mojo connections.
- When the RenderFrameHostManager creates a new RenderFrame for an RFHI,
it instructs that RFHI to set up the Mojo connection if necessary.
BUG=421069
TEST=Navigate to about://omnibox. Kill the tab via the Task Manager and reload.
Observe that the page produces output upon submission of input.
Review URL: https://codereview.chromium.org/666563005
Cr-Commit-Position: refs/heads/master@{#301329}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html
HTML pre tag should be exposed as follow:
MSAA + IAccessible2
Role: IA2_ROLE_PARAGRAPH
AX
AXRole: AXGroup
AXSubrole: (nil)
AXRoleDescription: "group"
This CL depends on blink side CL https://codereview.chromium.org/671003002/ (Reverted)
Re-Land CL https://codereview.chromium.org/663233004/
BUG=426053
TBR=kalman
Review URL: https://codereview.chromium.org/671033002
Cr-Commit-Position: refs/heads/master@{#301321}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/665963002/)
Reason for revert:
This appears to break the entire world as far as LayoutTests are concerned. Here's a small sample: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=css1%2Fbasic%2Fcontainment.html%2Ccss1%2Fbasic%2Fcomments.html%2Ccss1%2Fbasic%2Fgrouping.html%2Ccss1%2Fbasic%2Fclass_as_selector.html%2Ccss1%2Fbasic%2Finheritance.html%2Ccss1%2Fbasic%2Fcontextual_selectors.html%2Ccss1%2Fbasic%2Fid_as_selector.html
Original issue's description:
> Enable virtual viewport on all platforms except Android WebView.
>
> BUG=148816
>
> Committed: https://crrev.com/e52372c24d2e1e9785703f0563ffc3423f7161cc
> Cr-Commit-Position: refs/heads/master@{#301307}
TBR=aelias@chromium.org,mkosiba@chromium.org,cpu@chromium.org,bokan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=148816
Review URL: https://codereview.chromium.org/679973003
Cr-Commit-Position: refs/heads/master@{#301311}
|
|
|
|
|
|
|
|
| |
BUG=148816
Review URL: https://codereview.chromium.org/665963002
Cr-Commit-Position: refs/heads/master@{#301307}
|
|
|
|
|
|
|
|
|
|
|
| |
The related patch:
https://codereview.chromium.org/663783002/
BUG=323143
Review URL: https://codereview.chromium.org/663793002
Cr-Commit-Position: refs/heads/master@{#301303}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The related to CL:
https://codereview.chromium.org/654303004/
BUG=347854
TBR=rockot
Review URL: https://codereview.chromium.org/656683004
Cr-Commit-Position: refs/heads/master@{#301272}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This revisits focus handling logic relating to Flash fullscreen in
WebContentsImpl. Before this change, calls to WebContentsImpl::Focus()
would directly call RenderWidgetHostView::Focus(), but this prevented
WebContentsView and its delegate from "shadowing" these focus changes in
the browser UI. In other words, on Windows/Linux/CrOS, the focus state
for widgets in the ui::views toolkit were not necessarily synchronized
with the render widget's focus state (see bug for details).
90% of this change adds regression testing for everything described
above. The tests run a simulated fullscreened Flash widget, and then
invoke user keyboard and mouse actions on the browser UI to confirm both
the Flash widget and ui::views are in agreement and respond correctly to
focus changes; also, including focus store/restore when switching tabs.
BUG=403641
TEST=Repro steps in bug 403641; and also that focus remains with the omnibox or tab contents when switching back and forth to other tabs. New automated interactive_ui_tests.
Review URL: https://codereview.chromium.org/670653005
Cr-Commit-Position: refs/heads/master@{#301269}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This provides a platform agnostic implementation of discardable
memory based on shared memory. Managment of discardable memory is
moved to the browser process instead of being local to each renderer.
This provides much better control over chromium's total discardable
memory usage.
A round-trip to the browser IO thread is necessary for a renderer
to allocate a new discardable memory segment but the cost of this
can be reduced by maintaining free lists on the renderer side and
have discardable memory instances share the same discardable
memory segment. The implementation of this optimization is left as
a follow up.
Note: while the general implementation is platform agnostic, it
takes advantage of the ftruncate syscall available on Posix
platforms. This syscall makes it possible to release discardable
memory segments immediately to the OS from the browser process.
BUG=381178,400423,422953
TEST=base_unittests --gtest_filter=DiscardableMemoryTests*, base_unittests --gtest_filter=DiscardableSharedMemory.*, content_unittests --gtest_filter=HostDiscardableSharedMemoryManagerTest.*
Review URL: https://codereview.chromium.org/531343002
Cr-Commit-Position: refs/heads/master@{#301247}
|
|
|
|
|
|
|
|
| |
BUG=399775
Review URL: https://codereview.chromium.org/673243003
Cr-Commit-Position: refs/heads/master@{#301244}
|
|
|
|
|
|
|
|
|
|
|
| |
SetTakesFocusOnlyOnMouseDown is no longer used.
BUG=424766
R=avi@chromium.org
Review URL: https://codereview.chromium.org/679503002
Cr-Commit-Position: refs/heads/master@{#301237}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The motivation for this is that the GPU process on Mac will need to force
its CAOpenGLLayers (among other things) to re-create themselves when
the GPU switches.
Move the OnGpuSwitching observer method to a new class,
ui::GpuSwitchingObserver.
Inform the GPU process of OnGpuSwitching events via an IPC from
the browser. This is so that
- any blacklisting or filtering of events can be done in one location
- it is possible to reason about the order in which notifications occur
- the existing interactions with GpuDataManager remain unchanged
BUG=424433
Review URL: https://codereview.chromium.org/649933005
Cr-Commit-Position: refs/heads/master@{#301207}
|
|
|
|
|
|
|
|
|
|
|
| |
Existing GLHelper uses a different command buffer, so the copies race the
bind & swap.
BUG=380861
Review URL: https://codereview.chromium.org/655103004
Cr-Commit-Position: refs/heads/master@{#301190}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unnecessary values (cache size) and organize the
request/response metadata into separate messages. This is cleaner in
the long run and now is the time to do it before the cache bit is
flipped and people start using it.
BUG=426878
Review URL: https://codereview.chromium.org/650993005
Cr-Commit-Position: refs/heads/master@{#301180}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:910001 of https://codereview.chromium.org/531343002/)
Reason for revert:
Causes compile error.
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/39232
../../base/memory/discardable_shared_memory.cc:208:5:error: ignoring return value of function declared with warn_unused_result attribute [-Werror,-Wunused-result]
ftruncate(handle.fd, sizeof(SharedState));
^~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Original issue's description:
> Add browser-wide discardable memory implementation.
>
> This provides a platform agnostic implementation of discardable
> memory based on shared memory. Managment of discardable memory is
> moved to the browser process instead of being local to each renderer.
> This provides much better control over chromium's total discardable
> memory usage.
>
> A round-trip to the browser IO thread is necessary for a renderer
> to allocate a new discardable memory segment but the cost of this
> can be reduced by maintaining free lists on the renderer side and
> have discardable memory instances share the same discardable
> memory segment. The implementation of this optimization is left as
> a follow up.
>
> Note: while the general implementation is platform agnostic, it
> takes advantage of the ftruncate syscall available on Posix
> platforms. This syscall makes it possible to release discardable
> memory segments immediately to the OS from the browser process.
>
> BUG=381178,400423,422953
> TEST=base_unittests --gtest_filter=DiscardableMemoryTests*, base_unittests --gtest_filter=DiscardableSharedMemory.*, content_unittests --gtest_filter=HostDiscardableSharedMemoryManagerTest.*
>
> Committed: https://crrev.com/2ac2d83d86b0206b908eea0d6e1002850d238a88
> Cr-Commit-Position: refs/heads/master@{#301152}
TBR=skuhne@chromium.org,rmcilroy@chromium.org,danakj@chromium.org,rsesek@chromium.org,nasko@chromium.org,reveman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=381178,400423,422953
Review URL: https://codereview.chromium.org/678603003
Cr-Commit-Position: refs/heads/master@{#301156}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This provides a platform agnostic implementation of discardable
memory based on shared memory. Managment of discardable memory is
moved to the browser process instead of being local to each renderer.
This provides much better control over chromium's total discardable
memory usage.
A round-trip to the browser IO thread is necessary for a renderer
to allocate a new discardable memory segment but the cost of this
can be reduced by maintaining free lists on the renderer side and
have discardable memory instances share the same discardable
memory segment. The implementation of this optimization is left as
a follow up.
Note: while the general implementation is platform agnostic, it
takes advantage of the ftruncate syscall available on Posix
platforms. This syscall makes it possible to release discardable
memory segments immediately to the OS from the browser process.
BUG=381178,400423,422953
TEST=base_unittests --gtest_filter=DiscardableMemoryTests*, base_unittests --gtest_filter=DiscardableSharedMemory.*, content_unittests --gtest_filter=HostDiscardableSharedMemoryManagerTest.*
Review URL: https://codereview.chromium.org/531343002
Cr-Commit-Position: refs/heads/master@{#301152}
|