summaryrefslogtreecommitdiffstats
path: root/content/common/np_channel_base.cc
Commit message (Collapse)AuthorAgeFilesLines
* Add a CHECK() in NPChannelBase::GetChannel() to help investigate crbug.com/97285steveblock@chromium.org2012-05-301-0/+4
| | | | | | | | | | | | | This will indicate whether the crash is because the NPChannelBase fails to find the named channel in its map, or whether it's because we try to re-initialize an existing channel with an invalid socket FD. BUG=97285 Review URL: https://chromiumcodereview.appspot.com/10447017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139521 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a superfluous DCHECK() from NPChannelBase::RemoveRoute()steveblock@chromium.org2012-05-251-4/+1
| | | | | | | | | If the DCHECK() fails, we will crash cleanly on the next line anyway. Review URL: https://chromiumcodereview.appspot.com/10445010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139090 0039d316-1c4b-4281-b951-d872f2087c98
* Remove references to a bug that should be fixed.thestig@chromium.org2012-04-051-2/+2
| | | | | | | | BUG=95732 TEST=none Review URL: https://chromiumcodereview.appspot.com/9960026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130814 0039d316-1c4b-4281-b951-d872f2087c98
* Verify the child process with a secret hellojschuh@chromium.org2012-03-171-4/+2
| | | | | | | | | BUG=117627 TEST=IPCSyncChannelTest.Verified Review URL: http://codereview.chromium.org/9692035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127327 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all remaining explicit LeakyLazyInstanceTraits users to ::Leakyfischman@chromium.org2012-01-261-5/+3
| | | | | | | | | | | | | and hide LeakyLazyInstanceTraits in base::internal to discourage cargo-culting new users. BUG=none TEST=none Review URL: http://codereview.chromium.org/9117038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119173 0039d316-1c4b-4281-b951-d872f2087c98
* Add more CHECK in GPU and NPAPI process on invalid file descriptorsxhwang@chromium.org2011-12-091-0/+8
| | | | | | | | | | | | | | | | Goes with r112647, where we added CHECKs for invalid file descriptors. Regarding the GPU process, we already have a crash in GpuChannelManager::OnEstablishChannel() function due to invalid renderer fd. But it's not clear whether this is due to channel reuse or failure in creating channel in server mode. Talked to apatrick@ and the reuse one should never happen in normal case. Adding check on that case so we can hopefully rule out that case. Regarding the NPAPI process, we already have a lot of crashes due to invalid file descriptors in the rederer. In NPAPI process, add a CHECK right after the channel is created in server mode to see where this invalid fd originates from. BUG=none TEST=passed unit tests Review URL: http://codereview.chromium.org/8877001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113767 0039d316-1c4b-4281-b951-d872f2087c98
* Add CHECK on file descriptor in various IPC::ChannelHandle passed in.xhwang@chromium.org2011-12-021-0/+7
| | | | | | | | | | | | | Regarding Chromium issues 73355, 95129, 95732, 97285, 103957 and Chromium-os issue 18437, 22372, we suspect the channel handles passed to the renderer have invalid file descriptors (fd). This is supported by the fact that using a channel handle with a valid name but an invalid fd will produce crashes with exactly the same stack trace as reported in these issues. Running out of fd in either the renderer, browser or the other process (GPU, broker, etc) could cause this to happen, but we are not sure if that's the real cause. Adding check for the fd in various places to help investigate these issues further. We will be able to tell if invalid fd is passed in and if yes, which process generates it. Browser side check is only added for the broker case to limit the scale of bad user experience, while providing enough cases for investigation. BUG=none TEST=passed unit tests Review URL: http://codereview.chromium.org/8735015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112647 0039d316-1c4b-4281-b951-d872f2087c98
* Allow linker initialization of lazy instancejoth@chromium.org2011-11-151-2/+2
| | | | | | | | | | | | | | Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
* content: Remove 16 exit time destructors and 15 static initializers.thakis@chromium.org2011-11-081-19/+22
| | | | | | | | | | BUG=101600,94925 TEST=none TBR=ben Review URL: http://codereview.chromium.org/8493016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108982 0039d316-1c4b-4281-b951-d872f2087c98
* Add NPChannelBase::GetModalDialogEvent() to avoid content/plugin/ include ↵steveblock@chromium.org2011-09-221-0/+5
| | | | | | | | | | | | | | | | from npobject_proxy.cc This patch adds a new virtual method NPChannelBase::GetModalDialogEvent() to avoid the need for NPObjectProxy to cast its NPChannelBase to PluginChannel. Refactoring only, no functional change. BUG=96703 Review URL: http://codereview.chromium.org/7983032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102212 0039d316-1c4b-4281-b951-d872f2087c98
* Add shutdown event argument to NPChannelBase::GetChannel()steveblock@chromium.org2011-09-201-5/+5
| | | | | | | | | | | | | | | | | | Currently NPChannelBase uses ChildProcess::current()->GetShutDownEvent() as the shutdown event for its underlying SyncChannel. This change allows child classes to specify their own shutdown event. This is required to allow NPChannelBase to be used between the renderer and non-child processes. This change is refactoring only and introduces no change in behaviour. BUG=96703 Review URL: http://codereview.chromium.org/7971006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101948 0039d316-1c4b-4281-b951-d872f2087c98
* Move NPObjectBase and PluginChannelBase from content/plugin to content/commonsteveblock@chromium.org2011-09-201-0/+271
Also rename PluginChannelBase to NPChannelBase, fix variable naming to be agnostic of plugins, and fix a comment in NPChannelBase. This change is refactoring only and introduces no change in behaviour. BUG=96703 Review URL: http://codereview.chromium.org/7891003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101874 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-07 14:43:56 +0000