summaryrefslogtreecommitdiffstats
path: root/content/common/sandbox_mac_system_access_unittest.mm
Commit message (Collapse)AuthorAgeFilesLines
* Standardize usage of virtual/override/final in content/dcheng2014-10-211-6/+7
| | | | | | | | | | | | This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=avi@chromium.org Review URL: https://codereview.chromium.org/671663002 Cr-Commit-Position: refs/heads/master@{#300461}
* Replace FINAL and OVERRIDE with their C++11 counterparts in contentmohan.reddy2014-10-091-6/+6
| | | | | | | | | | | This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/637183002 Cr-Commit-Position: refs/heads/master@{#298804}
* Change base/file_utils.h includes to base/files/file_utils.h in content/thestig2014-09-051-1/+1
| | | | | | | | TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/538403002 Cr-Commit-Position: refs/heads/master@{#293559}
* Write MacSandboxTest.OpenSSLAccess.davidben@chromium.org2014-07-191-1/+34
| | | | | | | | | | | Replaces MacSandboxTest.NSSAccess. With this, content_unittest links and this new test passes (modulo BoringSSL switchover fixes still pending). BUG=395231 Review URL: https://codereview.chromium.org/400293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284266 0039d316-1c4b-4281-b951-d872f2087c98
* Add HANDLE_EINTR in some places missing it.brettw@chromium.org2014-03-271-3/+3
| | | | | | | | | | | This implements agl's comments on https://codereview.chromium.org/191673003/ R=agl@chromium.org TBR=agl Review URL: https://codereview.chromium.org/203213005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259986 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ScopedFD in terms of ScopedGeneric.brettw@chromium.org2014-03-171-7/+6
| | | | | | | | | | | | | | | Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later. I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified. I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition). Reland of https://codereview.chromium.org/191673003/ R=agl, viettrungluu Review URL: https://codereview.chromium.org/202113004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257473 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Implement ScopedFD in terms of ScopedGeneric. ↵jochen@chromium.org2014-03-151-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/191673003/) Reason for revert: Doesn't correctly link /mnt/data/b/build/slave/Chromium_Linux_Codesearch/build/src/third_party/gold/gold64: warning: hidden symbol 'base::internal::ScopedFDCloseTraits::Free(int)' in obj/base/files/nacl_helper.scoped_file.o is referenced by DSO lib/libipc.so Original issue's description: > Implement ScopedFD in terms of ScopedGeneric. > > Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later. > > I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified. > > I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition). > > BUG= > R=agl@chromium.org, viettrungluu@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257001 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257179 TBR=viettrungluu@chromium.org,agl@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/201203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257323 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ScopedFD in terms of ScopedGeneric.brettw@chromium.org2014-03-141-7/+6
| | | | | | | | | | | | | | | | | Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later. I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified. I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition). BUG= R=agl@chromium.org, viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257001 Review URL: https://codereview.chromium.org/191673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257179 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Implement ScopedFD in terms of ScopedGeneric. ↵thakis@chromium.org2014-03-141-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/191673003/) Reason for revert: Doesn't build on android: FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/base/memory/base.discardable_memory_allocator_android.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_CONFIGURATION_POLICY -DENABLE_NEW_GAMEPAD_API=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_EGLIMAGE=1 -DENABLE_AUTOFILL_DIALOG=1 -DCLD_VERSION=1 -DENABLE_PRINTING=1 -DENABLE_MANAGED_USERS=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DBASE_IMPLEMENTATION -DANDROID -D__GNU_SOURCE=1 -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 '-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -Igen/base -I../../third_party/android_tools/ndk/sources/android/cpufeatures -I../.. -fstack-protector --param=ssp-buffer-size=4 -Werror -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-reserved-user-defined-literal -Wno-deprecated-register -Xclang -load -Xclang /mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-url-directory -fcolor-diagnostics -Wexit-time-destructors -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=softfp -mthumb -no-integrated-as -B/mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin -ffunction-sections -funwind-tables -g -fstack-protector -fno-short-enums -Wa,--noexecstack -D__compiler_offsetof=__builtin_offsetof -Dnan=__builtin_nan -target arm-linux-androideabi -mllvm -arm-enable-ehabi --sysroot=/mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm -I/mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport -Os -g -fomit-frame-pointer -fdata-sections -ffunction-sections -funwind-tables -g0 -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -Wno-implicit-exception-spec-mismatch -Wno-abi -c ../../base/memory/discardable_memory_allocator_android.cc -o obj/base/memory/base.discardable_memory_allocator_android.o ../../base/memory/discardable_memory_allocator_android.cc:84:25:error: no matching function for call to 'mmap' void* const address = mmap( ^~~~ /mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm/usr/include/sys/mman.h:47:15: note: candidate function not viable: no known conversion from 'base::ScopedFD' (aka 'ScopedGeneric<int, internal::ScopedFDCloseTraits>') to 'int' for 5th argument extern void* mmap(void *, size_t, int, int, int, off_t); ^ 1 error generated. Original issue's description: > Implement ScopedFD in terms of ScopedGeneric. > > Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later. > > I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified. > > I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition). > > BUG= > R=agl@chromium.org, viettrungluu@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257001 TBR=viettrungluu@chromium.org,agl@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/197873014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257005 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ScopedFD in terms of ScopedGeneric.brettw@chromium.org2014-03-141-7/+6
| | | | | | | | | | | | | | | Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later. I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified. I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition). BUG= R=agl@chromium.org, viettrungluu@chromium.org Review URL: https://codereview.chromium.org/191673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257001 0039d316-1c4b-4281-b951-d872f2087c98
* Add the MacSandboxTest.NSSAccess test to content_unittests.wtc@chromium.org2013-06-111-0/+22
| | | | | | | | | | | | | Allow sandboxed processes to call stat() on /dev/urandom because NSS does that during initialization. R=rsleevi@chromium.org,jeremy@chromium.org,shess@chromium.org BUG=244661 TEST=content_unittests --gtest_filter=MacSandboxTest.NSSAccess Review URL: https://chromiumcodereview.appspot.com/16748002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205666 0039d316-1c4b-4281-b951-d872f2087c98
* Allow sandboxed OS X processes to open /dev/urandomrsleevi@chromium.org2013-05-251-24/+9
| | | | | | | | | | | | | Match Linux/POSIX and Windows in allowing sandboxed processes access to OS entropy (RtlGenRandom on Win, /dev/urandom on Linux/POSIX). BUG=242702 R=jeremy TBR=cevans@chromium.org, piman@chromium.org Review URL: https://chromiumcodereview.appspot.com/15637004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202267 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 193912 "Disable MacSandboxTest.{ClipboardAccess,FileAcces..."glider@chromium.org2013-04-151-15/+3
| | | | | | | | | | | | | > Disable MacSandboxTest.{ClipboardAccess,FileAccess,UrandomAccess} under ASan on Mac. > > BUG=196561 > Review URL: https://codereview.chromium.org/12620016 As the instrumentation of globals is currently disabled on ASan Mac, these tests fail no more, and it's safe to enable them back. Review URL: https://codereview.chromium.org/14256004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194147 0039d316-1c4b-4281-b951-d872f2087c98
* Disable MacSandboxTest.{ClipboardAccess,FileAccess,UrandomAccess} under ASan ↵glider@chromium.org2013-04-121-3/+15
| | | | | | | | | on Mac. BUG=196561 Review URL: https://codereview.chromium.org/12620016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193912 0039d316-1c4b-4281-b951-d872f2087c98
* Update sys_string_conversions includes in chrome_frame, content, net, and ui.brettw@chromium.org2013-03-281-1/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/13004021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191172 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Chromium style checker cleanuprsleevi@chromium.org2013-02-201-4/+4
| | | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 TBR=brettw, scherkus Review URL: https://chromiumcodereview.appspot.com/12279015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183469 0039d316-1c4b-4281-b951-d872f2087c98
* Move sandbox code in content to content namespace.jam@chromium.org2012-10-231-10/+8
| | | | | | Review URL: https://codereview.chromium.org/11228040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163656 0039d316-1c4b-4281-b951-d872f2087c98
* Allow /dev/urandom from ppapi sandbox.shess@chromium.org2012-07-161-1/+42
| | | | | | | | | | | | | Bits of Adobe Flash wish to read urandom directly rather than re-using our cached file descriptor. BUG=none TEST=no user-visible changes at this time. Review URL: https://chromiumcodereview.appspot.com/10695185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146879 0039d316-1c4b-4281-b951-d872f2087c98
* A second attempt at renderer sandbox tests for macofri@chromium.org2011-10-091-1/+4
| | | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8114002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104678 0039d316-1c4b-4281-b951-d872f2087c98
* Move some chrome\common code to content in preparation for moving chrome\gpu.jam@chromium.org2011-03-111-0/+96
TBR=avi Review URL: http://codereview.chromium.org/6686002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77868 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 17:33:13 +0000