| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The size of the frame data from a delegated source will not in general match up
exactly with the delegated layer's bounds. Frame sizes and layer bounds are both
expressed as integers, but frame sizes are in physical pixels and layer bounds
are in device-independent pixels. If the device scale is not an integer, there
may not be an exact mapping between the two spaces. For instance, if the layer
size is 105 x 211 and the device scale is 1.5, the delegated content is
responsible for filling 157.5 x 316.5 physical pixels in the final output. This
isn't really possible so what actually happens is the delegated renderer
produces a frame with a physical size of 158 x 317 pixels and sends that up to
the DRLI. To map this frame into physical space, the DRLI should apply the
inverse of the device scale factor to reflect that the frame covers 105.333 x
211.3333 logical pixels.
Before this patch, DRLI would attempt to scale the frame by (105/158, 211/317)
resulting in the frame being scaled down non-uniformly to try to make 158 x 317
pixels fit into a 157.5 x 316.6 space. This scaling looks bad and ends up
mapping pixels partially outside of the layer's logical bounds into the layer's
logical bounds.
BUG=370074
Review URL: https://codereview.chromium.org/311253004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/314293004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change makes each platform specific ChannelImpl into
a subclass of Channel: ChannelPosix, ChannelWin, ChannelNacl.
delegated functions are now virtual.
TEST=none
BUG=377980
R=darin@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/310293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Turns out no-one needs this.
BUG=359566
Review URL: https://codereview.chromium.org/315653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
alive until we receive an acknowledgment from the renderer that the renderer side constructs have been cleaned up. Otherwise we can receive messages from still executing content referring to sessions that were prematurely deleted.
BUG=371304
Review URL: https://codereview.chromium.org/305103003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Restrict prctl(2) in the baseline policy. We temporarily allow in the
GPU and PPAPI policies, so the net effect of this CL is only to restrict
prctl for NaCl processes.
BUG=270914
R=mdempsky@chromium.org
Review URL: https://codereview.chromium.org/315383003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a tab not playing audio is sent to the background, set timer slack to its maximum value.
Support for setting timer slack is added at the MessageLoop level, the concrete implementation of this CL only affects CFMessagePump backed MessageLoops (which means just the main thread for backgrounded renderer processes at present).
The MessageLoop implementation is designed to support its use on Windows and Linux (the Windows API sets slack per-timer like the Mac one, while on Linux slack, is set per-thread via a call to prctl() using PR_SET_TIMERSLACK).
BUG=356804
Review URL: https://codereview.chromium.org/289863005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=380463
Review URL: https://codereview.chromium.org/309203003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The only missing bit is to have proper values when the promise is
succussfully resolved.
BUG=162827
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275058
Review URL: https://codereview.chromium.org/298193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change replaces constructors with Create() methods of
ChannelProxy and SyncChannel. This open the possibility to introduce
polymorphism to these classes.
This is a revision of r274310 (https://codereview.chromium.org/301973003/)
in which I added bunch of Create*() method variants.
The chagne was reverted. This change no longer does it and just keeps
using Channel::Mode to specify the channel type.
TEST=none
BUG=377980
R=darin@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/310853003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/298193003/)
Reason for revert:
Breaks Linux ASan LSan Tests: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/3385
Original issue's description:
> Basic Promise-based lockOrientation() implementation in content/.
>
> The only missing bit is to have proper values when the promise is
> succussfully resolved.
>
> BUG=162827
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275058
TBR=dcheng@chromium.org,peter@chromium.org,jochen@chromium.org,jam@chromium.org,mlamouri@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=162827
Review URL: https://codereview.chromium.org/317803006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the new WebSocket implementation was unable to handle sites
with self-signed certificates and other cases where the user had
overridden certificate errors. Add code to support this case.
This requires adding infrastructure to pass the SSL error back up to the
content layer which knows how to handle it. It also requires that the ID
of the frame be known, so an extra parameter has been added to the
WebSocketHostMsg_AddChannelRequest IPC message.
BUG=364361
Review URL: https://codereview.chromium.org/304093003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The only missing bit is to have proper values when the promise is
succussfully resolved.
BUG=162827
Review URL: https://codereview.chromium.org/298193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is causing a lot of crashes on Win64.
BUG=380963
Review URL: https://codereview.chromium.org/317633008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Once https://codereview.chromium.org/293363013/ lands blink will never call
getContextAttribute() so there is no need to implement this function or to query
the alpha/depth/stencil/sample state from the default framebuffer.
R=kbr@chromium.org
BUG=378018
Review URL: https://codereview.chromium.org/301563007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=380666
> Lobotomize the GPU memory manager
>
> On desktop, always set the memory limit to 256MB, and ask that the renderer
> only use that memory to draw content that is near the viewport. The effective
> limit prior to this patch was 384MB, but would quickly get cut down as multiple
> windows are opened, but would not fall too much lower than 256MB (e.g, 128
> on Mac).
>
> On mobile, use all available memory for the current, only, renderer.
>
> Do not take into account unmanaged (e.g, WebGL) memory usage.
>
> BUG=377065
>
> Review URL: https://codereview.chromium.org/308743005
TBR=ccameron@chromium.org
Review URL: https://codereview.chromium.org/313163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=True
Review URL: https://codereview.chromium.org/308393002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The handle_map_ was holding onto them, so they weren't being released. Instead, they should be removed from the map whenever that first SharedBitmap that was created is destroyed.
BUG=362924
TBR=piman@chromium.org
Review URL: https://codereview.chromium.org/310973003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This was an oversight in https://codereview.chromium.org/305643004/
TBR=kbr@chromium.org
Review URL: https://codereview.chromium.org/317523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Link against IOSurface.framework instead -- this is an option starting in 10.6.
BUG=314190
Review URL: https://codereview.chromium.org/301973010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add touch stream validation similar to the existing gesture stream validation.
Also add validation of the *output* stream from the InputRouter (in addition to
the existing *input* stream validation).
BUG=345372
Review URL: https://codereview.chromium.org/290473006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal of this change is to give more accurate information about when
a video frame is generated. VideoFrame already provides a TimeDelta
value as the presentation timestamp. This is unchanged but we provide
an additional TimeTicks value to indicate the estimated capture time of
the video frame.
It accurately records the time when the videoframe is generated for local
sources such as camera and tab capture device. This value will be an
estimate for remote sources such as WebRTC.
After this change cast streaming API is able to collect accurate
information about how much time is spent in capturing.
BUG=374541
Review URL: https://codereview.chromium.org/287313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch 2 of 4 to specify the deviceSource of a desired fling animation
request via enum throughout Blink and Chromium.
BUG=343327
Review URL: https://codereview.chromium.org/304793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On desktop, always set the memory limit to 256MB, and ask that the renderer
only use that memory to draw content that is near the viewport. The effective
limit prior to this patch was 384MB, but would quickly get cut down as multiple
windows are opened, but would not fall too much lower than 256MB (e.g, 128
on Mac).
On mobile, use all available memory for the current, only, renderer.
Do not take into account unmanaged (e.g, WebGL) memory usage.
BUG=377065
Review URL: https://codereview.chromium.org/308743005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This blocks the DLL from loading in sandbox processes. It was causing sandbox
startup failure on Win64.
TBR=jschuh@chromium.org
BUG=379730
Review URL: https://codereview.chromium.org/308993003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke Windows compile:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder&number=180
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\remoting\host\win\remoting_core.wts_session_process_delegate.obj.rsp /c ..\..\remoting\host\win\wts_session_process_delegate.cc /Foobj\remoting\host\win\remoting_core.wts_session_process_delegate.obj /Fdobj\remoting\remoting_core.cc.pdb
c:\b\build\slave\win_x64_builder\build\src\remoting\host\win\wts_session_process_delegate.cc(386) : error C2661: 'IPC::ChannelProxy::ChannelProxy' : no overloaded function takes 4 arguments
ninja: build stopped: subcommand failed.
> Introduce IPC::ChannelProxy::Create*() and IPC::SynChannel::Create*()
>
> This change hides constructors of these classes so that we can turn
> them polymorphic classes.
>
> Note that having almost identical ChannelProxy::Init*() isn't great
> and they will be replaced by a factory-like abstraction in coming
> changes.
>
> TEST=none
> R=darin,cpu
> BUG=377980
>
> Review URL: https://codereview.chromium.org/301973003
TBR=morrita@chromium.org
Review URL: https://codereview.chromium.org/312553004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change hides constructors of these classes so that we can turn
them polymorphic classes.
Note that having almost identical ChannelProxy::Init*() isn't great
and they will be replaced by a factory-like abstraction in coming
changes.
TEST=none
R=darin,cpu
BUG=377980
Review URL: https://codereview.chromium.org/301973003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the final cleanup before the unified gesture recognizer is turned on.
Tests are passing with the unified GR flag on and with the flag off.
BUG=332418
Test=GestureRecognizerTest.*, GestureProviderTest.*
Review URL: https://codereview.chromium.org/306483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for the delegated software renderer. For the GL delegated
render, the texture state is maintained by the driver.
BUG=314190
Review URL: https://codereview.chromium.org/303063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support dumping coverage data generated by AsanCoverage from sandboxed processes. For the GPU process, we simply pre-open a file before engaging the sandbox. For the renderers, we use a helper process which we fork from the zygote. The helper process collects coverage data from renderers over a socket and writes it to a file. This allows an arbitrary number of renderers to share one output file.
With this change, GPU and renderers will write coverage data to .sancov.packed files which may contain data from multiple modules/processes. Previously, we created one .sancov file per process per module (and still do so for other processes).
Note that the new behavior takes effect regardless of whether the sandbox is actually enabled.
BUG=336212
R=jln@chromium.org
TBR=kbr@chromium.org
Review URL: https://codereview.chromium.org/280303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows has a fancy backgrounding mode which lowers IO priority.
Sadly it can only be set from within the process to be backgrounded.
So add a new ChildProcessMsg to tell child processes when they should
enter and leave background mode.
This reduces glitching during background tab load. This should only be
landed along with https://codereview.chromium.org/298253004/ which
removes backgrounding for active audio tabs.
I expect this will reduce CPU and I/O load significantly for background
processes which will lead to power savings.
This is only done on Windows since ChromeOS / Linux require privileges
only available to the browser process for setting background mode.
BUG=362294
TEST=Play audio. Load background tabs. Observe less/no glitching.
R=jam@chromium.org, luken@chromium.org, nasko@chromium.org
Review URL: https://codereview.chromium.org/305533006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=338338
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/298293010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=378462
Review URL: https://codereview.chromium.org/301353004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rename "//ui/base:ui_base" to "//ui/base:base" to make it easier to specify
BUG=
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/306113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes a specialization of base::DefaultDeleter so that scoped_ptr will
use Destroy() instead of the destructor. Without this, it seems wrong to
hold VideoDecodeAccelerator in a scoped_ptr, given that letting scoped_ptr
delete it via the destructor would be an error.
Also moves the destructors to protected, to prevent mistakes.
BUG=
Review URL: https://codereview.chromium.org/292183011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In an effort to simplify zoom, this CL removes ViewMsg_SetZoomLevel and plumbs zoom on WebContentsImpl directly through to HostZoomMap.
At present calls to WebContents::SetZoomLevel() invoke up to three cross-process IPCs, and introduce a synchronization requirement for any caller that needs to block until the results of the operation are visible via WebContents::GetZoomLevel().
This CL simplifies this down to one IPC and removal of the
synchronization requirement. It adds a new IPC message to signal changes in a view's ability to be zoomed, and removes an ViewMsg_SetZoomLevel that was used only by SetZoomLevel().
BUG=none
Review URL: https://codereview.chromium.org/287093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=343941
Review URL: https://codereview.chromium.org/303143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow Blink-side to provide a body in its responses to
fetch events.
BUG=374123
R=michaeln@chromium.org, mmenke@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/293083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Bitmaps allocated in the browser process may have to be shared between compositors (for surfaces) but not between processes, so they should be backed by new[] and use the SharedBitmap mechanism.
BUG=
Review URL: https://codereview.chromium.org/307973004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces IPC::Channel::Create*() API to turn
IPC::Channel into a heap allocated object. This will allow us to
make Channel a polymorphic class.
This change also tries to hide Channel::Mode from public API
so that we can simplify channel creation code paths cleaner in
following changes. ChannelProxy has to follow same pattern to
finish this cleanup. Such changes will follow.
TEST=none
BUG=377980
R=darin@chromium.org,cpu@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273575
Review URL: https://codereview.chromium.org/307653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
do not require an actual buffer
These updates would enable the surfaceless context extension where available.
BUG=377497
Review URL: https://codereview.chromium.org/303223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
also cleans up some whitespace in dxva code.
BUG=373288
NOTRY=true
Review URL: https://codereview.chromium.org/307773003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We make several synchronous GL calls during compositor initialization, some
of which appear unnecessary. This adds some more tracing to make these calls
easier to understand.
R=jbauman
Review URL: https://codereview.chromium.org/304513005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/186753002/)
Reason for revert:
The Android plumbing to use the root selection bounds has been removed, and the
visibility calculation will soon be performed by the compositor
(see crbug.com/135959).
Original issue's description:
> Chromium plumbing to use the selection root bounds.
>
> This is asking the selection root bounds to Blink and send it back to
> the RenderWidgetHostView implementation in the browser process.
>
> BUG=236033
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257199
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/306803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently any time a new GL function is added both classes need to be updated
with identical code. This patch moves the shared portion of the code into a
common location.
R=piman@chromium.org
Review URL: https://codereview.chromium.org/305643004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke win compile.
> Introduce IPC::Channel::Create*() to ensure it being heap-allocated.
>
> This change introduces IPC::Channel::Create*() API to turn
> IPC::Channel into a heap allocated object. This will allow us to
> make Channel a polymorphic class.
>
> This change also tries to hide Channel::Mode from public API
> so that we can simplify channel creation code paths cleaner in
> following changes. ChannelProxy has to follow same pattern to
> finish this cleanup. Such changes will follow.
>
> TEST=none
> BUG=377980
> R=darin@chromium.org,cpu@chromium.org
>
> Review URL: https://codereview.chromium.org/307653003
TBR=morrita@chromium.org
Review URL: https://codereview.chromium.org/304153005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is not yet hooked up.
Adds power_gadget build file.
Removes blink headers stub config now that the real target exists.
TBR=scottmg
Review URL: https://codereview.chromium.org/300383002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces IPC::Channel::Create*() API to turn
IPC::Channel into a heap allocated object. This will allow us to
make Channel a polymorphic class.
This change also tries to hide Channel::Mode from public API
so that we can simplify channel creation code paths cleaner in
following changes. ChannelProxy has to follow same pattern to
finish this cleanup. Such changes will follow.
TEST=none
BUG=377980
R=darin@chromium.org,cpu@chromium.org
Review URL: https://codereview.chromium.org/307653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Post clean-up only.
- Removing ifdef's
- Re-enabling tests
(Needs to be landed after https://codereview.chromium.org/287363004/ lands)
BUG=376733
TEST=content_browsertests:ServiceWorkerFetchEvent_Response
Review URL: https://codereview.chromium.org/293383006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NetInfo v3.
Design doc: https://docs.google.com/a/chromium.org/document/d/1LTk9uVMGi4kurzcF5ellsAJReTF31fFJMHrQwSVtBjc/
BUG=368358
Review URL: https://codereview.chromium.org/298803006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273555 0039d316-1c4b-4281-b951-d872f2087c98
|