| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dramatically improves scaling quality.
BUG=351458
TEST=videos are noticeably sharper.
TBR=ananta
Review URL: https://codereview.chromium.org/713603002
Cr-Commit-Position: refs/heads/master@{#303545}
(cherry picked from commit 991bb31434938a71af3cbb3e080cfea6a0240009)
Review URL: https://codereview.chromium.org/720913002
Cr-Commit-Position: refs/branch-heads/2214@{#14}
Cr-Branched-From: 03655fd3f6d72165dc3c9bd2c89807305316fe6c-refs/heads/master@{#303346}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This support is minimalist, and does not carefully verify SPS IDs, so its behavior is not guaranteed for streams with strange SPS/PPS ordering (especially after seeking).
Resolution change support is included and fully functional.
BUG=642453003
Review URL: https://codereview.chromium.org/653663006
Cr-Commit-Position: refs/heads/master@{#303278}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pass data
In the original CL 652953008, the layout test failed because transition elements were got on UI thread in navigator_impl.cc. This CL passes the data to TransitionRequestManager with TransitionElement struct, but defers passing transition elements to TransitionPageHelper on Java side. So navigator does not need to get the transition elements during navigation. And the Java side will fetch the transition elements later.
ref: https://codereview.chromium.org/652953008
BUG=370696
Review URL: https://codereview.chromium.org/698043002
Cr-Commit-Position: refs/heads/master@{#303270}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This follows the pattern of Notifications permission requests.
Depends on https://crrev.com/707833002/
This is part of a series of changes in both Blink and Chromium.
BUG=389194
TEST=PushMessagingBrowserTest*
TEST=LayoutTests/push_messaging/*
Review URL: https://codereview.chromium.org/710433002
Cr-Commit-Position: refs/heads/master@{#303258}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is just piping gpu::Capabilities through the initialization patch.
For that, I needed to move the IPC traits for gpu::Capabilities from
content/ to gpu/ipc/ so that we can use it in ppapi/proxy.
BUG=325391
Review URL: https://codereview.chromium.org/706533002
Cr-Commit-Position: refs/heads/master@{#303164}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This keeps track of buffers allocated for child processes in
BrowserGpuMemoryBufferManager and makes sure
GpuMemoryBufferImpl::DeletedByChildProcess is called
appropriately when a process is removed.
BUG=
Review URL: https://codereview.chromium.org/703463005
Cr-Commit-Position: refs/heads/master@{#303136}
|
|
|
|
|
|
|
|
|
|
| |
They are not used on the client side.
BUG=None
Review URL: https://codereview.chromium.org/706513002
Cr-Commit-Position: refs/heads/master@{#303106}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements a key piece of making Find In Page accessible on Android.
A new notification from Blink (depending on codereview.chromium.org/696533003)
associates a find request id with a range in the accessibility tree.
When the user commits to a search query (e.g., by pressing Enter or by
pressing the Next or Previous buttons), we fire an event that results in
moving accessibility focus to the node containing the text.
On Android, the best we can do is jump to the text node containing the start
of the search result, but on other platforms we may be able to route the
user directly to the proper text range.
BUG=426414
Review URL: https://codereview.chromium.org/706533006
Cr-Commit-Position: refs/heads/master@{#303086}
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the common case (one browser window) smoother, but doesn't
help multi-window smoothness much.
BUG=422000
Review URL: https://codereview.chromium.org/708483003
Cr-Commit-Position: refs/heads/master@{#303074}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's possible to finish a frame as soon as one of the above NAL units
are found in the data stream. This allows to display a frame sooner, without
the need to wait for the next frame NAL units.
BUG=428939
TEST=Create an h264 stream with AUD units, and modify the video_decode ppapi example so that it will just send a frame + AUD NAL units. After each AUD unit sent to the decoder, the last frame should be displayed. It's possible to confirm that by comparing the frame id received with the ones sent to the decoder.
Review URL: https://codereview.chromium.org/693593003
Cr-Commit-Position: refs/heads/master@{#303018}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #5 id:80001 of https://codereview.chromium.org/703463005/)
Reason for revert:
Blink layout tests are failing and this CL might be the cause. Let me revert this CL.
Original issue's description:
> content: Cleanup GpuMemoryBuffers when child process is removed.
>
> This keeps track of buffers allocated for child processes in
> BrowserGpuMemoryBufferManager and makes sure
> GpuMemoryBufferImpl::DeletedByChildProcess is called
> appropriately when a process is removed.
>
> BUG=
>
> Committed: https://crrev.com/32e22ea8b72f52ac89e5d5720d1a26596f015caf
> Cr-Commit-Position: refs/heads/master@{#302968}
TBR=piman@chromium.org,alexst@chromium.org,kenrb@chromium.org,reveman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/709433002
Cr-Commit-Position: refs/heads/master@{#302984}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this series of patches, registration succeeds even if the worker script
has a syntax error because the installing sequence does not check the result of
the script evaluation.
This makes EmbeddedWorkerInstance wait for the completion and reject an install
promise if the evaluation fails.
Patch dependency:
[1] Blink: https://codereview.chromium.org/692003002/
[2] Chromium: THIS PATCH
[3] Blink: https://codereview.chromium.org/697833004/
BUG=426344
TEST=run-webkit-tests --debug http/tests/serviceworker/
TEST=content_unittests --gtest_filter=ServiceWorker*
Review URL: https://codereview.chromium.org/697593002
Cr-Commit-Position: refs/heads/master@{#302970}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This keeps track of buffers allocated for child processes in
BrowserGpuMemoryBufferManager and makes sure
GpuMemoryBufferImpl::DeletedByChildProcess is called
appropriately when a process is removed.
BUG=
Review URL: https://codereview.chromium.org/703463005
Cr-Commit-Position: refs/heads/master@{#302968}
|
|
|
|
|
|
|
|
|
|
|
| |
Use template to choose between RenderPassDrawQuad and
StreamVideoDrawQuad for LargestDrawQuad.
BUG=429552
Review URL: https://codereview.chromium.org/698053002
Cr-Commit-Position: refs/heads/master@{#302833}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserGpuChannelHostFactory::EstablishRequest::FinishOnMain to locate jankiness.
BrowserGpuChannelHostFactory::EstablishRequest::FinishOnMain is responsible
for 17.9 janks per hour in UI thread. I need to instrument
the code inside it to find out which part causes jank.
Dear reviewer! If you know where the jank is, or have ideas where I need to add
more instrumentations, please let me know!
This is a mechanical change that adds instrumentation required to locate the
source of jankiness (i.e. a long-running fragment of code executed as a part of
the task that causes jank) in the code. See the bug for details on what kind of
jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've
helped to find and fix janky code. The code of the instrumentation is highly
optimized and is not expected to affect performance. The code simply creates a
diagnostic task which is identical to ones created by PostTask or IPC message
handlers. The task gets created only in developer build and in Canary channel.
BUG=430106
Review URL: https://codereview.chromium.org/691143003
Cr-Commit-Position: refs/heads/master@{#302810}
|
|
|
|
|
|
|
|
|
|
|
| |
This is made in preparation for enabling selection auto scroll using touch
handles.
BUG=340658
Review URL: https://codereview.chromium.org/657803002
Cr-Commit-Position: refs/heads/master@{#302776}
|
|
|
|
|
|
|
|
| |
BUG=414571
Review URL: https://codereview.chromium.org/681503002
Cr-Commit-Position: refs/heads/master@{#302756}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were a number of ozone targets that had rusted or never
been implemented in the GN build for Chrome OS. Fix it!
R=cmasone
TBR=brettw
BUG=424334
TEST=build chrome with os=chromeos use_ozone=true use_clang=true
Review URL: https://codereview.chromium.org/705623004
Cr-Commit-Position: refs/heads/master@{#302752}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the GpuMemoryBufferManager instance on the browser
side allocate ids. The result is that each id is unique and
that makes management much easier. This also allows some more
concrete handling of the client id used for GPU service side
allocation of buffers.
BUG=
Review URL: https://codereview.chromium.org/685983005
Cr-Commit-Position: refs/heads/master@{#302726}
|
|
|
|
|
|
|
|
|
|
|
| |
It is possible for an allocation to fail on the gpu side, we should handle it gracefully.
Currently we DCHECK that it succeeded in the browser, which in release leads to unexpected behaviour and NOTREACHED hit during destruction on the gpu side.
BUG=
Review URL: https://codereview.chromium.org/701873005
Cr-Commit-Position: refs/heads/master@{#302721}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a regression in r298758 where if a 64-bit plugin was loaded after
a 32-bit plugin, and the versions were the same, then the 32-bit plugin would
be removed from the list, the 64-bit plugin plugin would be removed and
neither plugin would successfully load.
Solution is to only load the correct architecture plugins from the registry.
BUG=428549
Review URL: https://codereview.chromium.org/674073003
Cr-Commit-Position: refs/heads/master@{#302713}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
supported
BUG=430096
TBR=nasko@chromium.org for render_widget_host_view_guest.*
TBR=kenrb@chromium.org for browser_plugin_messages.h
TBR=lazyboy@chromium.org for overall.
Review URL: https://codereview.chromium.org/690263003
Cr-Commit-Position: refs/heads/master@{#302623}
|
|
|
|
|
|
|
|
|
|
| |
This code conditionally stashes a sync point for buffer types that require it for the destruction phase.
BUG=416873
Review URL: https://codereview.chromium.org/654223006
Cr-Commit-Position: refs/heads/master@{#302561}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/699643002 moved
gpu_memory_buffer_factory_x11.cc to *_linux.cc. Since Ozone provides its
own implementation there are multiple definitions of the same symbol.
BUG=none
NOTRY=true
TBR=piman@chromium.org
Review URL: https://codereview.chromium.org/688493003
Cr-Commit-Position: refs/heads/master@{#302551}
|
|
|
|
|
|
|
|
|
|
|
| |
Most changes are updates to the mojom syntax for modules.
R=viettrungluu@chromium.org
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/698883005
Cr-Commit-Position: refs/heads/master@{#302542}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the client side arrays feature is controlled by a compile flag.
And the flag is only defined in nacl build. This change uses a variable to
control it. So we could enable it in runtime.
BUG=429179
Review URL: https://codereview.chromium.org/702493002
Cr-Commit-Position: refs/heads/master@{#302478}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code is not being shipped and there are no plans that will
change that. Remove it for now as it means less code to maintain
and will allow some cleanup. It can be added back later if needed.
BUG=
R=piman@chromium.org
Review URL: https://codereview.chromium.org/699643002
Cr-Commit-Position: refs/heads/master@{#302470}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Restricts Plugin Power Saver to small content that's cross-origin.
Also handles the temporary whitelist for cross-origin as described by
thestig@ in the design doc.
Design doc: http://goo.gl/iDix3p
BUG=403800
Review URL: https://codereview.chromium.org/680193002
Cr-Commit-Position: refs/heads/master@{#302466}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The BrokerProcess class is too complex. It both serves as management
of a new broker process, as well as the implementation of an
async-signal-safe IPC mechanism suitable to broker syscall.
We split the BrokerProcess class into 4 simpler classes. This will make it
easier to replace the broker process with a thread or a new Chrome process
type.
BUG=429028
Review URL: https://codereview.chromium.org/688843003
Cr-Commit-Position: refs/heads/master@{#302370}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The root cause was that ImageTransportSurfaceFBO was using the pixel
size of the surface to early-out of surface reallocation. This is a problem
when scale factor changed and pixel size doesn't -- the change in scale
factor is never propagated to the underlying CALayer.
Move all logic for changing the size of the surface and for skipping
changes in the size of the surface to AllocateOrResizeFramebuffer.
Rename ambiguous sizes to be labeled as pixel_size or dip_size.
Remove a stray ScopedCAActionDisabler that does nothing (found by
inspection of nearby code).
Add myself as an OWNER for this path.
BUG=424713
Review URL: https://codereview.chromium.org/696823002
Cr-Commit-Position: refs/heads/master@{#302363}
|
|
|
|
|
|
|
|
|
|
| |
For consistency with other VDAs, and to make sure that Chromium's GL state is in sync with reality.
BUG=642453003
Review URL: https://codereview.chromium.org/645713002
Cr-Commit-Position: refs/heads/master@{#302344}
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need a full IDR frame (not just I slices) when requesting keyframe because
we need all the reference buffers to be reset.
BUG=424443
TEST=verify with video_encode_accelerator_unittest and H264 test app on squawks and daisy
Review URL: https://codereview.chromium.org/686283002
Cr-Commit-Position: refs/heads/master@{#302306}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
starting provisional load (Chrome side) (patchset #7 id:120001 of https://codereview.chromium.org/652953008/)
Reason for revert:
Crashing a LayoutTest
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=fast/html/navigation-transition.html
Hitting an assertion:
10:15:12.016 3607 [10283:10283:1031/101511:5678803780814:FATAL:transition_request_manager.cc(161)] Check failed: ::content::BrowserThread::CurrentlyOn(BrowserThread::IO). Must be called on Chrome_IOThread; actually called on CrBrowserMain.
10:15:12.016 3607 #0 0x7f66666664ce base::debug::StackTrace::StackTrace()
10:15:12.016 3607 #1 0x7f6666700bf5 logging::LogMessage::~LogMessage()
10:15:12.016 3607 #2 0x7f66612dcafa content::TransitionRequestManager::GetPendingTransitionRequest()
10:15:12.016 3607 #3 0x7f6660bccdb1 content::NavigatorImpl::DidStartProvisionalLoad()
10:15:12.016 3607 #4 0x7f6660bdb821 content::RenderFrameHostImpl::OnDidStartProvisionalLoadForFrame()
10:15:12.016 3607 #5 0x7f6660bf3554 DispatchToMethod<>()
10:15:12.016 3607 #6 0x7f6660be38b7 FrameHostMsg_DidStartProvisionalLoadForFrame::Dispatch<>()
10:15:12.016 3607 #7 0x7f6660bda57e content::RenderFrameHostImpl::OnMessageReceived()
10:15:12.016 3607 #8 0x7f666103ad0e content::RenderProcessHostImpl::OnMessageReceived()
10:15:12.016 3607 #9 0x7f666103b11f content::RenderProcessHostImpl::OnMessageReceived()
10:15:12.016 3607 #10 0x7f6664fe5e9d IPC::ChannelProxy::Context::OnDispatchMessage()
10:15:12.016 3607 #11 0x7f6664feea5a base::internal::RunnableAdapter<>::Run()
10:15:12.016 3607 #12 0x7f6664fee9b1 base::internal::InvokeHelper<>::MakeItSo()
10:15:12.016 3607 #13 0x7f6664fee94c base::internal::Invoker<>::Run()
10:15:12.016 3607 #14 0x7f666664eb3e base::Callback<>::Run()
10:15:12.016 3607 #15 0x7f666666cb89 base::debug::TaskAnnotator::RunTask()
10:15:12.016 3607 #16 0x7f6666729968 base::MessageLoop::RunTask()
10:15:12.016 3607 #17 0x7f6666729acb base::MessageLoop::DeferOrRunPendingTask()
10:15:12.016 3607 #18 0x7f6666729d05 base::MessageLoop::DoWork()
10:15:12.016 3607 #19 0x7f66666227bc base::MessagePumpGlib::HandleDispatch()
10:15:12.016 3607 #20 0x7f6666622fd1 base::(anonymous namespace)::WorkSourceDispatch()
10:15:12.016 3607 #21 0x7f6658588d13 g_main_context_dispatch
10:15:12.016 3607 #22 0x7f6658589060 <unknown>
10:15:12.016 3607 #23 0x7f6658589124 g_main_context_iteration
10:15:12.016 3607 #24 0x7f66666228c5 base::MessagePumpGlib::Run()
10:15:12.016 3607 #25 0x7f6666729432 base::MessageLoop::RunHandler()
10:15:12.016 3607 #26 0x7f66667920d4 base::RunLoop::Run()
10:15:12.016 3607 #27 0x7f66609ca164 content::BrowserMainLoop::MainMessageLoopRun()
10:15:12.016 3607 #28 0x7f66609c9fc1 content::BrowserMainLoop::RunMainMessageLoopParts()
10:15:12.016 3607 #29 0x7f66609d3075 content::BrowserMainRunnerImpl::Run()
10:15:12.016 3607 #30 0x000000452ef4 (anonymous namespace)::RunOneTest()
10:15:12.016 3607 #31 0x000000452b53 (anonymous namespace)::RunTests()
10:15:12.016 3607 #32 0x0000004529af LayoutTestBrowserMain()
10:15:12.016 3607 #33 0x00000044fcda content::ShellMainDelegate::RunProcess()
10:15:12.017 3607 #34 0x7f6660849f01 content::RunNamedProcessTypeMain()
10:15:12.017 3607 #35 0x7f666084e232 content::ContentMainRunnerImpl::Run()
10:15:12.017 3607 #36 0x7f66608493f5 content::ContentMain()
10:15:12.017 3607 #37 0x00000044ee5c main
10:15:12.017 3607 #38 0x7f665785676d __libc_start_main
10:15:12.017 3607 #39 0x00000044ed49 <unknown>
Original issue's description:
> Navigation transitions (web to native app): Pass data after starting provisional load (Chrome side)
>
> Pass transitional elements' CSS selector, names and rects to TransitionPageHelper after starting provisional load. Those data are needed when overriding the URL navigation to jump to a native Android app.
>
> The is the Chrome side of the CL. The Clank side is here: https://chrome-internal-review.googlesource.com/#/c/180668/
>
> BUG=370696
>
> Committed: https://crrev.com/5b846f579d3dd1a0f4d0b8c26ff274117bfba0bc
> Cr-Commit-Position: refs/heads/master@{#302279}
TBR=nasko@chromium.org,sievers@chromium.org,oysteine@chromium.org,zhenw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370696
Review URL: https://codereview.chromium.org/689123003
Cr-Commit-Position: refs/heads/master@{#302284}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we can determine whether the data_reduction_proxy was used or not for
PLT UMA.
BUG=374264
Committed: https://crrev.com/ac77ecc781ff1860e3344b99d6f5a8e9d672dd73
Cr-Commit-Position: refs/heads/master@{#302150}
Review URL: https://codereview.chromium.org/686313002
Cr-Commit-Position: refs/heads/master@{#302280}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
provisional load (Chrome side)
Pass transitional elements' CSS selector, names and rects to TransitionPageHelper after starting provisional load. Those data are needed when overriding the URL navigation to jump to a native Android app.
The is the Chrome side of the CL. The Clank side is here: https://chrome-internal-review.googlesource.com/#/c/180668/
BUG=370696
Review URL: https://codereview.chromium.org/652953008
Cr-Commit-Position: refs/heads/master@{#302279}
|
|
|
|
|
|
|
|
|
|
| |
Depends on https://codereview.chromium.org/658723003/
BUG=401424
Review URL: https://codereview.chromium.org/661463002
Cr-Commit-Position: refs/heads/master@{#302259}
|
|
|
|
|
|
|
|
|
|
|
|
| |
OnError was meant to support the "onerror" event for Web Notifications,
but it has no call sites. There are a few future use-cases for this event,
but those don't concern non-Web Notifications so we don't need this plumbing.
BUG=428370
Review URL: https://codereview.chromium.org/687183004
Cr-Commit-Position: refs/heads/master@{#302248}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit ac77ecc781ff1860e3344b99d6f5a8e9d672dd73.
Speculative revert.
ResourceDispatcherHostBrowserTest.CrossSiteNavigationErrorPage started
flaking on Mac ASan and Mac ASan 64 following this change.
BUG=374264
Review URL: https://codereview.chromium.org/691323002
Cr-Commit-Position: refs/heads/master@{#302207}
|
|
|
|
|
|
|
|
|
|
| |
This relands https://codereview.chromium.org/683583002/
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/695583002
Cr-Commit-Position: refs/heads/master@{#302203}
|
|
|
|
|
|
|
|
|
|
| |
This is a spinoff from: https://codereview.chromium.org/680193002/
BUG=NONE
Review URL: https://codereview.chromium.org/688343003
Cr-Commit-Position: refs/heads/master@{#302199}
|
|
|
|
|
|
|
|
|
|
| |
This involves a couple of browser-side plumbing changes, as well as teaching RenderFrameProxy how to swap itself out in favor of a RenderFrameImpl.
BUG=422583
Review URL: https://codereview.chromium.org/600553003
Cr-Commit-Position: refs/heads/master@{#302193}
|
|
|
|
|
|
|
|
| |
BUG=133828
Review URL: https://codereview.chromium.org/642453003
Cr-Commit-Position: refs/heads/master@{#302182}
|
|
|
|
|
|
|
|
|
|
|
| |
we can determine whether the data_reduction_proxy was used or not for
PLT UMA.
BUG=374264
Review URL: https://codereview.chromium.org/686313002
Cr-Commit-Position: refs/heads/master@{#302150}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #6 id:120001 of https://codereview.chromium.org/683583002/)
Reason for revert:
Suspected to cause android bot failures:
New warnings.
Please fix, or perhaps add to /b/build/slave/Android_Builder__dbg_/build/src/build/android/findbugs_filter/findbugs_known_bugs.txt
--------------------------------------------------------------------------------
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.imported.ImportedInterface_Internal$ImportedInterfaceDoSomethingParams.equals(Object) At ImportedInterface_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.math.Calculator_Internal$CalculatorClearParams.equals(Object) At Calculator_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.mojo.IntegrationTestInterface2_Internal$IntegrationTestInterface2Method0Params.equals(Object) At IntegrationTestInterface2_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithParameterAndEmptyResponseResponseParams.equals(Object) At CheckMethodWithEmptyResponse_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithouParameterAndEmptyResponseParams.equals(Object) At CheckMethodWithEmptyResponse_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithouParameterAndEmptyResponseResponseParams.equals(Object) At CheckMethodWithEmptyResponse_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.EmptyStruct.equals(Object) At EmptyStruct.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.sample.NamedObject_Internal$NamedObjectGetNameParams.equals(Object) At NamedObject_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.test_structs.EmptyStruct.equals(Object) At EmptyStruct.java
--------------------------------------------------------------------------------
*** 9 FindBugs warnings! ***
*** 9: new ***
Original issue's description:
> Update mojo sdk to rev e083961bf11fd0c94d40be8853761da529b6d444
>
> TBR=jam@chromium.org
>
> Committed: https://crrev.com/37273cab357d03ad9d2bcfa4ae467567ce93e2c4
> Cr-Commit-Position: refs/heads/master@{#302038}
TBR=jamesr@chromium.org,aa@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/694463002
Cr-Commit-Position: refs/heads/master@{#302066}
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/683583002
Cr-Commit-Position: refs/heads/master@{#302038}
|
|
|
|
|
|
|
|
|
|
|
| |
This isn't expected to be reached but would help diagnose failures.
BUG=424024
R=cpu@chromium.org
Review URL: https://codereview.chromium.org/690753003
Cr-Commit-Position: refs/heads/master@{#302024}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PageNotificationDelegate will proxy events from the Notification sub-
system to the Web Notification object in Blink for notification whose
lifetime is tied to that of the page.
This patch also moves the NotificationMessageFilter to a new directory
in //content/browser/, as there will be new files when Service Worker
integration is being added in the near future.
BUG=392187
Review URL: https://codereview.chromium.org/681783004
Cr-Commit-Position: refs/heads/master@{#301974}
|
|
|
|
|
|
|
|
| |
BUG=383125
Review URL: https://codereview.chromium.org/629393002
Cr-Commit-Position: refs/heads/master@{#301965}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Usage of ListContainer is replacing scoped_ptr_vector. SharedQuadState
is stored in DrawQuad as pointer form. ListContainer should act as
container of pointers.
This CL changes the return value from dereference iterator from
reference to pointers.
BUG=344962
Review URL: https://codereview.chromium.org/629343002
Cr-Commit-Position: refs/heads/master@{#301916}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's only used by Loader code.
BUG=426442
Committed: https://crrev.com/69c091ddba1bddda795eb5da4e400d16b29cc732
Cr-Commit-Position: refs/heads/master@{#301110}
Review URL: https://codereview.chromium.org/669073003
Cr-Commit-Position: refs/heads/master@{#301843}
|