| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=463660
Review URL: https://codereview.chromium.org/1318583002
Cr-Commit-Position: refs/heads/master@{#345562}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net::FormatUrl and related are specifically concerned with display
policies of URLs, which is not something that //net needs to be aware
of, as that's a UX question.
This folds in net::FormatURL along with the existing //components/url_fixer
and //components/secure_display into a common component,
//components/url_formatter, that handles reformatting URLs for user-friendly
or data storage (url_formatter), for use in security prompts (elide_url),
or for reformatting URLs from user input (url_fixer)
(Disabling presubmit since this is intentionally not fixing a legacy API, just moving it for future cleanups)
BUG=486979
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1171333003
Cr-Commit-Position: refs/heads/master@{#342445}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//components (patchset #16 id:290001 of https://codereview.chromium.org/1171333003/ )
Reason for revert:
breaks gn_check on Android: https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/28796/steps/gn_check/logs/stdio
Original issue's description:
> Move net::FormatUrl and friends outside of //net and into //components
>
> net::FormatUrl and related are specifically concerned with display
> policies of URLs, which is not something that //net needs to be aware
> of, as that's a UX question.
>
> This folds in net::FormatURL along with the existing //components/url_fixer
> and //components/secure_display into a common component,
> //components/url_formatter, that handles reformatting URLs for user-friendly
> or data storage (url_formatter), for use in security prompts (elide_url),
> or for reformatting URLs from user input (url_fixer)
>
> (Disabling presubmit since this is intentionally not fixing a legacy API, just moving it for future cleanups)
>
> BUG=486979
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/1659865c3eb47166c82378bb840801135b057a09
> Cr-Commit-Position: refs/heads/master@{#341605}
TBR=droger@chromium.org,jam@chromium.org,mkwst@chromium.org,pkasting@chromium.org,sky@chromium.org,stuartmorgan@chromium.org,felt@chromium.org,rsleevi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=486979
Review URL: https://codereview.chromium.org/1260033005
Cr-Commit-Position: refs/heads/master@{#341691}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net::FormatUrl and related are specifically concerned with display
policies of URLs, which is not something that //net needs to be aware
of, as that's a UX question.
This folds in net::FormatURL along with the existing //components/url_fixer
and //components/secure_display into a common component,
//components/url_formatter, that handles reformatting URLs for user-friendly
or data storage (url_formatter), for use in security prompts (elide_url),
or for reformatting URLs from user input (url_fixer)
(Disabling presubmit since this is intentionally not fixing a legacy API, just moving it for future cleanups)
BUG=486979
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1171333003
Cr-Commit-Position: refs/heads/master@{#341605}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of bunching up all resources used by the default views controls into the
common ui_resources pack, move them into views_resources, so that it is possible
for a component to depend on views and pull in the necessary resources without
building ui_resources with |toolkit_views| flag on.
BUG=500004, 503224
TBR=jam@ for content/shell/BUILD.gn and content/browser/webui changes.
Review URL: https://codereview.chromium.org/1199143002
Cr-Commit-Position: refs/heads/master@{#335938}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch removes a lot of plugin placeholder code from builds that don't support plugins (enable_plugins==0).
This is a reland of https://codereview.chromium.org/1126073003/.
See patchsets for fixes of the crashes.
BUG=493889
TBR=
Review URL: https://codereview.chromium.org/1161923004
Cr-Commit-Position: refs/heads/master@{#334054}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Motivations:
1. Eliminates a large number of windows crashes hit while loading the DLL (see bugs)
2. Reducing the size of binary (about 400KB on linux, about 265KB on 32bit windows) due to dead-code elimination
3. Simplifying media library initialization (Remove bool-ness, it just works)
Licensing:
We've audited all the licenses for the files we actually use and have the green light from legal as long as we include the license text in the credits.
BUG=435455, 429131, 441908
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/bfef6d6ba82b172ac0e48c80d9ccf1a1ca0ea5c5
Cr-Commit-Position: refs/heads/master@{#332891}
Review URL: https://codereview.chromium.org/1141703002
Cr-Commit-Position: refs/heads/master@{#333423}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting because of component test failures around isolate expectations.
This change may not actually be directly responsible, but I'm out of time
to investigate for the day. Will re-land it soon.
BUG=496975
TBR=enne@chromium.org, gunsch@chromium.org, jochen@chromium.org, isherman@chromium.org, thomasvl@chromium.org, phajdan@chromium.org, grt@chromium.org, mmoss@chromium.org, sergeyu@chromium.org, sky@chromium.org, dalecurtis@chromium.org
This reverts commit bfef6d6ba82b172ac0e48c80d9ccf1a1ca0ea5c5.
NOPRESUBMIT=true
NOTRY=true
Review URL: https://codereview.chromium.org/1161183003
Cr-Commit-Position: refs/heads/master@{#332994}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This embeds mojo/shell's ApplicationManager in content/browser
and provides a way for arbitrary browser code to connect to
Mojo apps as if the browser itself were a Mojo app.
This is a basic implementation of Mojo app support which only
loads static apps either in the browser process or a (per-app)
utility process.
Future CLs will address connection to apps from arbitrary render
frames (i.e. connection requests which include the requestor's
origin) as well as refactoring the utility process code further
so that it serves strictly as a Mojo app runner.
BUG=492422
Review URL: https://codereview.chromium.org/1149833007
Cr-Commit-Position: refs/heads/master@{#332974}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Motivations:
1. Eliminates a large number of windows crashes hit while loading the DLL (see bugs)
2. Reducing the size of binary (about 400KB on linux, about 265KB on 32bit windows) due to dead-code elimination
3. Simplifying media library initialization (Remove bool-ness, it just works)
Licensing:
We've audited all the licenses for the files we actually use and have the green light from legal as long as we include the license text in the credits.
BUG=435455, 429131, 441908
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1141703002
Cr-Commit-Position: refs/heads/master@{#332891}
|
|
|
|
|
|
|
|
|
| |
BUG=478250
R=mkwst@chromium.org,torne@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/1167703002
Cr-Commit-Position: refs/heads/master@{#332583}
|
|
|
|
|
|
|
|
|
|
| |
tests.
BUG=436562
Review URL: https://codereview.chromium.org/1158063002
Cr-Commit-Position: refs/heads/master@{#332235}
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the last dependency from the test_runner library on content
R=mkwst@chromium.org
BUG=478250
Review URL: https://codereview.chromium.org/1153053002
Cr-Commit-Position: refs/heads/master@{#331751}
|
|
|
|
|
|
|
|
| |
BUG=460945
Review URL: https://codereview.chromium.org/1127013004
Cr-Commit-Position: refs/heads/master@{#331251}
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of https://codereview.chromium.org/1126543009/, which
broke gtests built by GN.
BUG=476410
Review URL: https://codereview.chromium.org/1143903002
Cr-Commit-Position: refs/heads/master@{#331056}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTestBluetoothAdapterProvider.
This patch doesn't add any new tests.
Split for easier reviewing. This is the last of two patches to remove
testing from BluetoothDispatcherHost and BluetoothDispatcher:
[1] http://crrev.com/1125133005
[2] This patch.
BUG=436284
Review URL: https://codereview.chromium.org/1132943002
Cr-Commit-Position: refs/heads/master@{#330748}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:120001 of https://codereview.chromium.org/1126543009/)
Reason for revert:
broke http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android
e.g. http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/builds/1922
Original issue's description:
> [Android] Refactor the native test wrappers.
>
> BUG=476410
>
> Committed: https://crrev.com/581d25e509e4a2b1e8927c6d8accc0c90ea86090
> Cr-Commit-Position: refs/heads/master@{#330531}
TBR=jochen@chromium.org,cjhopman@chromium.org,jaekyun@chromium.org,perezju@chromium.org,tedchoc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=476410
Review URL: https://codereview.chromium.org/1138993009
Cr-Commit-Position: refs/heads/master@{#330591}
|
|
|
|
|
|
|
|
| |
BUG=476410
Review URL: https://codereview.chromium.org/1126543009
Cr-Commit-Position: refs/heads/master@{#330531}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary because it is one of the dependencies of the
'blink_tests' group that should be built.
BUG=483171
R=avi@chromium.org,dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1138653004
Cr-Commit-Position: refs/heads/master@{#330164}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary because it is one of the dependencies of the
'blink_tests' group that should be built.
BUG=483171
R=avi@chromium.org,dpranke@chromium.org
Review URL: https://codereview.chromium.org/1131773004
Cr-Commit-Position: refs/heads/master@{#329580}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And WebKitTestResultPrinter to BlinkTestResultPrinter.
This is in preparation for the Blink merge of third_party/WebKit/ into
//blink.
BUG=None
TEST=content_shell && content_unittests
R=avi@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1128633002
Cr-Commit-Position: refs/heads/master@{#328547}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that webkit/ is gone, we are preparing ourselves for the merge of
third_party/WebKit into //blink.
BUG=None
BUG=content_shell && content_unittests
R=avi@chromium.org
Review URL: https://codereview.chromium.org/1118183003
Cr-Commit-Position: refs/heads/master@{#328202}
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=content_shell && content_unittests
R=avi@chromium.org
Review URL: https://codereview.chromium.org/1119013004
Cr-Commit-Position: refs/heads/master@{#328050}
|
|
|
|
|
|
|
|
|
|
| |
New discovery is used in content shell, extensions and chromecast. Once all embedders migrate to devtools_discovery, DevToolsTarget will be removed from content.
BUG=476496
Review URL: https://codereview.chromium.org/1056343004
Cr-Commit-Position: refs/heads/master@{#326337}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves DevToolsHttpHandler into it's own component.
It still depends on content::DevToolsTarget, which will be moved to
devtools_discovery component next.
BUG=476496
Review URL: https://codereview.chromium.org/1089413002
Cr-Commit-Position: refs/heads/master@{#325849}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The function snprintf is not available in Visual Studio prior to VS
2015. In some places this omission is dealt with with a #define to map
snprintf to _snprintf. This was never a good idea (_snprintf doesn't
guarantee null-termination) and with VS 2015 it is not even legal.
This change conditionally disables one instance of this remapping.
The build errors that occur without this change are:
stdio.h(1926): warning C4005: 'snprintf': macro redefinition
stdio.h(1926): note: command-line arguments: see previous
definition of 'snprintf'
stdio.h(1929): fatal error C1189: #error: Macro definition of
snprintf conflicts with Standard Library function declaration
R=scottmg@chromium.org
BUG=440500
Review URL: https://codereview.chromium.org/1069433002
Cr-Commit-Position: refs/heads/master@{#324157}
|
|
|
|
|
|
|
|
|
|
|
| |
This makes chrome usage of blink images refer to the new IDR2_*s in the
blink_image_resource paks, and removes references to blink_resource_100_percent.pak.
BUG=471609, 467176
Review URL: https://codereview.chromium.org/1055593002
Cr-Commit-Position: refs/heads/master@{#323765}
|
|
|
|
|
|
|
|
|
|
|
| |
Remove references to android_webview_build now that we no longer support
that build configuration.
BUG=440793
Review URL: https://codereview.chromium.org/1044903002
Cr-Commit-Position: refs/heads/master@{#322861}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is creating a content/public/browser/permission_manager.h interface
that is hooked on the BrowserContext. It has an implementation in chrome/
android_webview/, content/shell/ and one for layout tests.
BUG=437770, 430238
Review URL: https://codereview.chromium.org/1011953003
Cr-Commit-Position: refs/heads/master@{#322721}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the image resources that blink depends on are in the blink
repository, we depend on the blink resources directly, delete the ones
in the chrome tree, and use these resources in the html_viewer.
[This reland also contains a fix to the generate_blink_resource_map.py
file so that its generated code uses unsigned chars, which should
hopefully fix the Win8 gn bot.]
BUG=467176
First Review URL: https://codereview.chromium.org/1033733004
Review URL: https://codereview.chromium.org/1038723002
Cr-Commit-Position: refs/heads/master@{#322427}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
blink."
This reverts committ: https://crrev.com/ebbf3c1bf5f41b0133657515302e3b110abedee1
Broke on the Win8 gn bot which doesn't appear to be in the CQ and treats
signedness of characters differently than all other configurations.
BUG=467176
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1012773009
Cr-Commit-Position: refs/heads/master@{#322210}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the image resources that blink depends on are in the blink
repository, we depend on the blink resources directly, delete the ones
in the chrome tree, and use these resources in the html_viewer.
BUG=467176
Review URL: https://codereview.chromium.org/1033733004
Cr-Commit-Position: refs/heads/master@{#322201}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Crashpad is always compiled in to Chrome and its handler is always
enabled. It is only possible to enable uploads in official builds.
Crashpad talks to the existing Breakpad server. There should be no
noticeable changes to crash reporting on the server side, except the
client IDs will all change to a new ID and will no longer be
synchronized with UMA client IDs. This is a one-time change. After this,
the client ID will remain stable within a single --user-data-dir.
BUG=386208,390217,415547,427611,crashpad:12
R=rsesek@chromium.org
TBR=cpu@chromium.org,jochen@chromium.org
Review URL: https://codereview.chromium.org/1001103002
Cr-Commit-Position: refs/heads/master@{#320466}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::Value.
Also adds a simple service to allow layout tests to test all this.
This is part of a series of changes:
[1/5] Blink side changes in https://codereview.chromium.org/924983002/ that expose a needed v8 context
[2/5] https://codereview.chromium.org/921013002/ allow MessagePort to send messages as values
[3/5] https://codereview.chromium.org/944443003/ which causes the send_messages_as_values flag to be propagated
[4/5] This CL
[5/5] https://codereview.chromium.org/940423004/ adds layout tests to blink to test these new features
BUG=426458
Review URL: https://codereview.chromium.org/938403005
Cr-Commit-Position: refs/heads/master@{#318903}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of a series of three CLs:
1. https://codereview.chromium.org/962713002
2. <this>
3. https://codereview.chromium.org/962733002
BUG=462255
Review URL: https://codereview.chromium.org/960983002
Cr-Commit-Position: refs/heads/master@{#318462}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #4 id:60001 of https://codereview.chromium.org/907893002/)
Reason for revert:
While the LayoutTests only test the logic in the mocks and the plumbing, maintaining the mocks while working on the platform/public interface is a pain and requires landing patches simultaneously in Blink and Chromium repositories. There's no layout test using this anyway yet.
I'll add layout tests later when the Blink-Chromium interface is stable and maybe Blink is merged into Chromium.
Original issue's description:
> Retry to add MockPresentationClient to use in layout tests.
>
> Now there's a MockPresentationService that's owned by WebTestProxy and
> accepts private method calls from the tests.
>
> MockPresentationClient was moved to WebFrameTestProxy instance since
> we want one per each frame. Reset logic is added too to make tests more
> independent.
>
> BUG=412331
>
> Committed: https://crrev.com/57b3af2412a81a4c0abf54e0146c0f7bf5530249
> Cr-Commit-Position: refs/heads/master@{#316199}
TBR=mkwst@chromium.org,peter@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=412331
Review URL: https://codereview.chromium.org/963493002
Cr-Commit-Position: refs/heads/master@{#318230}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now there's a MockPresentationService that's owned by WebTestProxy and
accepts private method calls from the tests.
MockPresentationClient was moved to WebFrameTestProxy instance since
we want one per each frame. Reset logic is added too to make tests more
independent.
BUG=412331
Review URL: https://codereview.chromium.org/907893002
Cr-Commit-Position: refs/heads/master@{#316199}
|
|
|
|
|
|
|
|
|
|
|
|
| |
For tools/sort_sources.py to be useful, existing GYP files
should be sorted.
BUG=456014
TEST=everything should build as before
Review URL: https://codereview.chromium.org/919923002
Cr-Commit-Position: refs/heads/master@{#316133}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:1 of https://codereview.chromium.org/905823004/)
Reason for revert:
This is causing layout failures on the blink bots. They're crashing with the following assertion:
STDERR: [17800:1287:0207/062834:4514258387182:FATAL:mock_presentation_client.cc(34)] Check failed: controller_ != controller && (!controller || !controller_).
Original issue's description:
> Added MockPresentationClient to use in layout tests.
>
> Blink change with the test follows: https://codereview.chromium.org/906673002/
>
> BUG=412331
>
> Committed: https://crrev.com/49a225f6ecb52b805a99d55e9e37ed7e21ef7c1b
> Cr-Commit-Position: refs/heads/master@{#315204}
TBR=mkwst@chromium.org,peter@chromium.org,avayvod@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=412331
Review URL: https://codereview.chromium.org/906753002
Cr-Commit-Position: refs/heads/master@{#315208}
|
|
|
|
|
|
|
|
|
|
| |
Blink change with the test follows: https://codereview.chromium.org/906673002/
BUG=412331
Review URL: https://codereview.chromium.org/905823004
Cr-Commit-Position: refs/heads/master@{#315204}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The IME code in ui/base/ime depends on ui/ozone to support keyboard
control (via the InputController interface). This dependency is
currently missing from the build.
Unfortunately, we cannot simply add this dependency, because ui/ozone
depends on code from ui/base/cursor and ui/base/resource
(for cursor bitmaps).
Break this cycle by componentizing ui/base/ime & add a dependency
from the new ui/base/ime component to ui/ozone.
This also helps clean things up a bit because iOS builds ui/base
but not ui/base/ime. So there is already a fault line here.
The handful of IME tests are left as part of ui_base_unittests.
BUG=445627
TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' &&
ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes)
TBR=jam
Committed: https://crrev.com/2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82
Cr-Commit-Position: refs/heads/master@{#314815}
Review URL: https://codereview.chromium.org/889323003
Cr-Commit-Position: refs/heads/master@{#314860}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/889323003/)
Reason for revert:
Windows builds failing with
ERROR at //ui/base/ime/BUILD.gn:170:5: Undefined variable for +=.
libs += [ "imm32.lib" ]
^---
I don't have something with this name in scope now.
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4403/steps/gn/logs/stdio
(perhaps missed a .gn update)?
Original issue's description:
> Split ui/base/ime into a new component
>
> The IME code in ui/base/ime depends on ui/ozone to support keyboard
> control (via the InputController interface). This dependency is
> currently missing from the build.
>
> Unfortunately, we cannot simply add this dependency, because ui/ozone
> depends on code from ui/base/cursor and ui/base/resource
> (for cursor bitmaps).
>
> Break this cycle by componentizing ui/base/ime & add a dependency
> from the new ui/base/ime component to ui/ozone.
>
> This also helps clean things up a bit because iOS builds ui/base
> but not ui/base/ime. So there is already a fault line here.
>
> The handful of IME tests are left as part of ui_base_unittests.
>
> BUG=445627
> TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' &&
> ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes)
> TBR=jam
>
> Committed: https://crrev.com/2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82
> Cr-Commit-Position: refs/heads/master@{#314815}
TBR=sky@chromium.org,thakis@chromium.org,jam@chromium.org,yukishiino@chromium.org,spang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=445627
Review URL: https://codereview.chromium.org/895363005
Cr-Commit-Position: refs/heads/master@{#314823}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The IME code in ui/base/ime depends on ui/ozone to support keyboard
control (via the InputController interface). This dependency is
currently missing from the build.
Unfortunately, we cannot simply add this dependency, because ui/ozone
depends on code from ui/base/cursor and ui/base/resource
(for cursor bitmaps).
Break this cycle by componentizing ui/base/ime & add a dependency
from the new ui/base/ime component to ui/ozone.
This also helps clean things up a bit because iOS builds ui/base
but not ui/base/ime. So there is already a fault line here.
The handful of IME tests are left as part of ui_base_unittests.
BUG=445627
TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' &&
ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes)
TBR=jam
Review URL: https://codereview.chromium.org/889323003
Cr-Commit-Position: refs/heads/master@{#314815}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
currently, we have JNI_OnLoad defined multiple places which has a lot of
duplicated code and JNI registration and initialization are mixed;
This patch
- Added JNIOnLoadDelegate class for each component specific initialization.
- Added base::android::OnJNIOnLoad() to call a list of delegates
- Migrate testing, content_shell, chrome_shell.
BUG=447393
TBR=thakis
Review URL: https://codereview.chromium.org/864563002
Cr-Commit-Position: refs/heads/master@{#313592}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously only simple mock responses were supported in
BluetoothDispatcherHost. This change adds use of an actual adapter,
and enables the first actual bluetooth.requestDevices responses
to function in the browser (with the experimental-web-platform-features
flag).
BUG=420284
Review URL: https://codereview.chromium.org/787953004
Cr-Commit-Position: refs/heads/master@{#312241}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
runtime. (patchset #1 id:1 of https://codereview.chromium.org/835223006/)
Reason for revert:
not on cq => doesn't qualify for reverts. will fix live.
Original issue's description:
> Revert of linux/gyp: Find missing symbols at build time, not runtime. (patchset #10 id:180001 of https://codereview.chromium.org/854753002/)
>
> Reason for revert:
> Breaks compile on chromium.webkit/Linux Tests (dbg) and probably also chromium.lkgr/ASAN Debug
>
> http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29?numbuilds=50
> http://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Debug
>
> Original issue's description:
> > linux/gyp: Find missing symbols at build time, not runtime.
> >
> > Limited to very few cases for now (non-chromeos, non-android,
> > non-official, component builds only).
> >
> > BUG=371125
> > TBR=piman,dalecurtis
> >
> > Committed: https://crrev.com/faffc1a04d17dd977ff9eb335c0c67b3b86dad5e
> > Cr-Commit-Position: refs/heads/master@{#312020}
> >
> > Committed: https://crrev.com/fdaea4c9e63c845db9c009d236205e7ed4fcb663
> > Cr-Commit-Position: refs/heads/master@{#312032}
>
> TBR=jamesr@chromium.org,piman@chromium.org,dalecurtis@chromium.org,machenbach@chromium.org,thakis@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=371125
>
> Committed: https://crrev.com/6019325be9a7a4195368d8d4362047e1a4381541
> Cr-Commit-Position: refs/heads/master@{#312068}
TBR=jamesr@chromium.org,piman@chromium.org,dalecurtis@chromium.org,machenbach@chromium.org,timloh@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=371125
Review URL: https://codereview.chromium.org/860623002
Cr-Commit-Position: refs/heads/master@{#312070}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #10 id:180001 of https://codereview.chromium.org/854753002/)
Reason for revert:
Breaks compile on chromium.webkit/Linux Tests (dbg) and probably also chromium.lkgr/ASAN Debug
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29?numbuilds=50
http://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Debug
Original issue's description:
> linux/gyp: Find missing symbols at build time, not runtime.
>
> Limited to very few cases for now (non-chromeos, non-android,
> non-official, component builds only).
>
> BUG=371125
> TBR=piman,dalecurtis
>
> Committed: https://crrev.com/faffc1a04d17dd977ff9eb335c0c67b3b86dad5e
> Cr-Commit-Position: refs/heads/master@{#312020}
>
> Committed: https://crrev.com/fdaea4c9e63c845db9c009d236205e7ed4fcb663
> Cr-Commit-Position: refs/heads/master@{#312032}
TBR=jamesr@chromium.org,piman@chromium.org,dalecurtis@chromium.org,machenbach@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=371125
Review URL: https://codereview.chromium.org/835223006
Cr-Commit-Position: refs/heads/master@{#312068}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Limited to very few cases for now (non-chromeos, non-android,
non-official, component builds only).
BUG=371125
TBR=piman,dalecurtis
Committed: https://crrev.com/faffc1a04d17dd977ff9eb335c0c67b3b86dad5e
Cr-Commit-Position: refs/heads/master@{#312020}
Review URL: https://codereview.chromium.org/854753002
Cr-Commit-Position: refs/heads/master@{#312032}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #9 id:160001 of https://codereview.chromium.org/854753002/)
Reason for revert:
Broke Ozone:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/10001
gyp: Dependency '/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/build/linux/system.gyp:x11#target' not found while trying to load target /b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/content/content_shell_and_tests.gyp:test_netscape_plugin#target
Original issue's description:
> linux/gyp: Find missing symbols at build time, not runtime.
>
> Limited to very few cases for now (non-chromeos, non-android,
> non-official, component builds only).
>
> BUG=371125
> TBR=piman,dalecurtis
>
> Committed: https://crrev.com/faffc1a04d17dd977ff9eb335c0c67b3b86dad5e
> Cr-Commit-Position: refs/heads/master@{#312020}
TBR=jamesr@chromium.org,piman@chromium.org,dalecurtis@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=371125
Review URL: https://codereview.chromium.org/851313004
Cr-Commit-Position: refs/heads/master@{#312028}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Limited to very few cases for now (non-chromeos, non-android,
non-official, component builds only).
BUG=371125
TBR=piman,dalecurtis
Review URL: https://codereview.chromium.org/854753002
Cr-Commit-Position: refs/heads/master@{#312020}
|