summaryrefslogtreecommitdiffstats
path: root/content/plugin
Commit message (Collapse)AuthorAgeFilesLines
* Use skia::RefPtr in place of manual ref-counting for Skia types.danakj@chromium.org2012-12-042-25/+24
| | | | | | | | | | | | | This covers remaining content/ and webkit/ manual ref-counting. BUG=163454 R=piman Depends on: https://codereview.chromium.org/11418217/ NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11428099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170879 0039d316-1c4b-4281-b951-d872f2087c98
* Move eintr_wrapper.h from base to base/posixbrettw@chromium.org2012-11-141-1/+1
| | | | | | Review URL: https://codereview.chromium.org/11366229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167739 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify platform_canvas.h by recognizing that PlatformCanvas does not ↵reed@google.com2012-11-142-15/+11
| | | | | | | | | | | | | | | | | | | | | actually extend SkCanvas in any way, other than provide a host of constructors (and delayed constructors in the form of 'initialize' methods). These late initializers are a problem, as SkCanvas is deprecating its setDevice() call, moving to model where the backingstore/device for the canvas must be created before the canvas is created. This is necessary to allow skia to continue to extend SkCanvas for its backends (e.g. GPU, PDF, Picture, Pipe, etc.). The practical change in this CL is to make PlatformCanvas just a typedef for SkCanvas, and change the call-sites that want to call initialize() to instead create the canvas using one of the provided Factory functions (e.g. CreatePlatformCanvas). The modifier Platform is maintained, to document that this canvas may be backed by platform-specific pixels (e.g. allocated by GDI or cairo). Review URL: https://codereview.chromium.org/11138024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167669 0039d316-1c4b-4281-b951-d872f2087c98
* Get windowless plugins working when accelerated compositing is turned on by ↵jam@chromium.org2012-11-103-70/+6
| | | | | | | | | copying the buffers using skia instead of OS specific ways that need the platform device. Also remove the code that kept the background buffer in sync with plugins since it's not necessary anymore. Looks like Flash and Silverlight support this correctly now. Review URL: https://codereview.chromium.org/11361170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167042 0039d316-1c4b-4281-b951-d872f2087c98
* Move global_descriptors to base/posix.brettw@chromium.org2012-11-091-1/+1
| | | | | | | | | | This file represents a posix-only concept. BUG= Review URL: https://codereview.chromium.org/11293210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167008 0039d316-1c4b-4281-b951-d872f2087c98
* Use the RenderView's routing_id, instead of HWND, as the unique identifier ↵jam@chromium.org2012-11-025-40/+30
| | | | | | | | used in plugin code as a key for the page-wide event used to enable nested message loops. Review URL: https://codereview.chromium.org/11367056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165722 0039d316-1c4b-4281-b951-d872f2087c98
* Stop passing the parent hwnd to the plugin process on initialization.jam@chromium.org2012-11-021-21/+1
| | | | | | | | | | | This was only used on Windows. Windowed plugins get reparented in the browser anyways, so just creat it initially parented to the desktop (it's hidden then). For windowless plugins, made the plugin process watch WM_WINDOWPOSCHANGING for the dummy window used for activation so that it can update the value used for NPNVnetscapeWindow. I've verified that the subtle code that was added to make IMEs work correctly still functions. This is a followup to r165373 and is another step in getting rid of the parent hwnd in the renderer, which doesn't work in Aura anymore since it changes when a tab drag to a new window occurs. Review URL: https://codereview.chromium.org/11362045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165631 0039d316-1c4b-4281-b951-d872f2087c98
* Make "dummy window" which is used for windowless plugins be parented in the ↵jam@chromium.org2012-11-012-5/+7
| | | | | | | | browser. This is a step towards removing usage of parent hwnd in the renderer which is problematic on aura since that hwnd changes. In non-aura builds, this doesn't change so caching worked. Review URL: https://codereview.chromium.org/11361024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165373 0039d316-1c4b-4281-b951-d872f2087c98
* Add Vector2d classes that represent offsets, instead of using Point.danakj@chromium.org2012-10-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously Point served two purposes, to be a position in 2d space, and also an offset from the origin. This introduces a Vector2d class to represent an offset, allowing typesafety checks for geometric operations. The following are now the case: Point +/- Vector = Point - A point plus/minus an offset gives you a point at a position offset by the vector. Vector +/- Vector = Vector - Two offsets can be added together to make a new offset. Point - Point = Vector - Subtracting one point from another gives you the offset between the two points. We add some new methods to perform these operations: Rect::OffsetFromOrigin() gives the offset between the position of the rect and the origin. Point::OffsetFromOrigin() gives the offset between the point and the origin. PointAtOffsetFromOrigin(Vector2d) converts a Vector2d to a Point at the given offset away from the origin. Rect::Offset(), Point::Add(), and Point::Subtract() now receive a Vector2d instead of a point. BUG=147395 R=sky Review URL: https://codereview.chromium.org/11269022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165198 0039d316-1c4b-4281-b951-d872f2087c98
* Move the remaning files in content\common to the content namespace.jam@chromium.org2012-10-241-5/+3
| | | | | | Review URL: https://codereview.chromium.org/11235068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163732 0039d316-1c4b-4281-b951-d872f2087c98
* Make gfx::Rect class operations consistently mutate the class they are ↵danakj@chromium.org2012-10-231-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | called on. Currently some methods mutate the class, and some return a new value, requiring API users to know what kind of method they are calling each time, and making inconsistent code. For example: gfx::Rect rect; rect.Inset(1, 1, 1, 1); rect = rect.Intersect(other_rect); rect.Offset(1, 1); Instead of: gfx::Rect rect; rect.Inset(1, 1, 1, 1); rect.Intersect(other_rect); rect.Offset(1, 1); We could go either way - making the class immutable or all methods return a new instance - but I believe it is better to instead make all methods mutate the class. This allows for shorter lines of code by avoiding having to repeat the object's name twice in order to change it. This patch changes gfx::Rect classes and all the callsites that uses these methods. It should make no change in behaviour, so no new tests added. R=sky BUG=147395 Review URL: https://codereview.chromium.org/11110004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163579 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Carbon cursor call interposing in Mac NPAPI pluginsstuartmorgan@chromium.org2012-10-233-54/+0
| | | | | | | | | | | | | | | | Cocoa cursor calls have been supported for quite some time, and Carbon is long-deprecated; plugins should not be using Carbon calls to change the cursor. This reduces the complexity of the interpose library, which should ideally be completely eliminated at some point. BUG=None Review URL: https://chromiumcodereview.appspot.com/11192052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163523 0039d316-1c4b-4281-b951-d872f2087c98
* Move content's a plugin, ppapi_plugin, utility, and worker subdirectories to ↵jam@chromium.org2012-10-2114-14/+66
| | | | | | | | the content namespace. Review URL: https://codereview.chromium.org/11231016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163210 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a dead code path in Mac NPAPI context menu supportstuartmorgan@chromium.org2012-10-181-14/+3
| | | | | | | | | | | This complicated path was for 10.5 only, so is no longer used. BUG=None Review URL: https://chromiumcodereview.appspot.com/11191053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162688 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Legacy NPAPI Flash Sandbox supportjschuh@chromium.org2012-10-053-121/+1
| | | | | | | | BUG=153599 Review URL: https://chromiumcodereview.appspot.com/11049004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160310 0039d316-1c4b-4281-b951-d872f2087c98
* Use ScopedCOMInitializer in more places. While this doesn't always simplify ↵pkasting@chromium.org2012-10-031-3/+3
| | | | | | | | | | code, it does mean we do consistent logging and error-checking at all these sites. BUG=none TEST=none Review URL: https://codereview.chromium.org/11050009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159908 0039d316-1c4b-4281-b951-d872f2087c98
* Remove memory hole mitigation for Flash Windows pluginjschuh@chromium.org2012-09-171-40/+0
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10892045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157206 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all support for the Carbon NPAPI event modelstuartmorgan@chromium.org2012-09-114-64/+1
| | | | | | | | | | | | | | | | | Plugins already cannot negotiate the Carbon event model; this removes all the code supporting the Carbon model now that it is no longer necessary. The interpose library is left in place because plugins that use the Cocoa event model may still make Carbon OS calls for window or cursor managament. BUG=125915 Review URL: https://chromiumcodereview.appspot.com/10928072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156102 0039d316-1c4b-4281-b951-d872f2087c98
* Initial NPAPI plugin support in Win Aura.jam@chromium.org2012-09-111-0/+5
| | | | | | | | | Scrolling jank is noticable because the plugin moves at a different time than the content is updated. There are also a couple of other functions in RenderWidgetHostViewWin that enumerate plugin Windows that need to be shared, but I'm leaving these for a future change. The code in render_widget_host_view_base.cc is all moved from render_widget_host_view_win.cc with the exception of the lines between the USE_AURA ifdef. Review URL: https://codereview.chromium.org/10905122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156090 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 155122 - Code to collect issue 97285 debugging info for crash reports.shess@chromium.org2012-09-061-21/+0
| | | | | | | | | | | | | | | | | | | | | | [TPM is suspicious of Windows renderer crash rate. Seems impossible, but who knows?] It is useful to record breakpad keys for debugging, which is not applicable to multi-process bugs. This adds infrastructure to allow collection of information across processes. Also, fix so that GetPluginChannelHost() can successfully fail without crashing. BUG=97285,141055 Review URL: https://chromiumcodereview.appspot.com/10908078 TBR=shess@chromium.org Review URL: https://chromiumcodereview.appspot.com/10908130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155240 0039d316-1c4b-4281-b951-d872f2087c98
* Code to collect issue 97285 debugging info for crash reports.shess@chromium.org2012-09-061-0/+21
| | | | | | | | | | | | | | | | It is useful to record breakpad keys for debugging, which is not applicable to multi-process bugs. This adds infrastructure to allow collection of information across processes. Also, fix so that GetPluginChannelHost() can successfully fail without crashing. BUG=97285,141055 Review URL: https://chromiumcodereview.appspot.com/10908078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155122 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race condition with windowless plugin buffers. The problem, which is ↵jam@chromium.org2012-08-152-34/+63
| | | | | | | | | already fixed for Mac, is that the buffers can be deleted during a paint because of a resize during an NPN_Evaluate call. So keep a local reference. BUG=139462 Review URL: https://chromiumcodereview.appspot.com/10855141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151734 0039d316-1c4b-4281-b951-d872f2087c98
* Move the injection test API to content/public.avi@chromium.org2012-08-101-1/+1
| | | | | | | | | BUG=139631,98716 TEST=none Review URL: https://chromiumcodereview.appspot.com/10827282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151087 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Let Carbon plugin stuff buid with the 10.7 SDKthakis@chromium.org2012-07-262-1/+14
| | | | | | | | | | | | | | | | QuickDraw.h is gone, but the frameworks still exports the symbols on 10.8. So just declare the functions for now, so that we can build with the 10.7 SDK. We can remove Carbon plugin support later. BUG=136844 TEST=none TBR=stuartmorgan,tony Review URL: https://chromiumcodereview.appspot.com/10826036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148647 0039d316-1c4b-4281-b951-d872f2087c98
* Get the path of the plugin interposing library from the embedder, since ↵jam@chromium.org2012-07-231-3/+4
| | | | | | | | | they're the ones who bundle it. Make content still work without it. This allows plugins to work inside content_shell. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10806075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147965 0039d316-1c4b-4281-b951-d872f2087c98
* Move the Windows sandbox to sandbox/winjln@chromium.org2012-07-182-2/+2
| | | | | | | | | | | | | This is a rather large refactor to move the Windows sandbox to the right place. BUG= TEST= NOTRY=true TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147151 0039d316-1c4b-4281-b951-d872f2087c98
* Emergency revert; rietveld broke; tree brokeerg@google.com2012-07-132-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146646 0039d316-1c4b-4281-b951-d872f2087c98
* sandbox/src -> sandbox/win/srcjln@chromium.org2012-07-132-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146626 0039d316-1c4b-4281-b951-d872f2087c98
* Remove #pragma once from contentajwong@chromium.org2012-07-116-8/+2
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10696166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98
* Use IPC::Sender and IPC::Listener in content.brettw@chromium.org2012-06-252-6/+7
| | | | | | | | | | | | | This replaces uses of IPC::Message::Sender with IPC::Sender and IPC::Channel::Listener with IPC::Listener. I also fixed up header files where it was obvious. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10662005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143920 0039d316-1c4b-4281-b951-d872f2087c98
* Tighten up DEPS some more. NaCl/service process code are including internal ↵jam@chromium.org2012-06-041-1/+1
| | | | | | | | | content files. Fix the instances other sandbox stuff, which I'll do in a followup. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10512010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140346 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move gl/ directory out of gfx/, up to ui/.tfarina@chromium.org2012-05-122-3/+3
| | | | | | | | | | BUG=104040 R=ben@chromium.org TBR=tony@chromium.org Review URL: https://chromiumcodereview.appspot.com/10392068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136777 0039d316-1c4b-4281-b951-d872f2087c98
* RefCounted types should not have public destructors, content/ remaining bitsrsleevi@chromium.org2012-05-113-76/+81
| | | | | | | | | | BUG=123295 TEST=none TBR=jam Review URL: https://chromiumcodereview.appspot.com/10069054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136631 0039d316-1c4b-4281-b951-d872f2087c98
* Android content shell bringup.jrg@chromium.org2012-05-101-0/+10
| | | | | | | | | | | | | | | | | | Build media java files (we weren't). Fix adb_install_content_shell for cases where the app was stuck. Add upstream staging gyp var / #define. Be more consistent about jar output files (all in lib.java). Upstream a bunch of random files (e.g. ppapi). Upstream a bunch of java and native code hit as part of shlib init. Properly package jar files in content shell. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10377059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136219 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move surface/ directory out of gfx/, up to ui/.tfarina@chromium.org2012-05-032-5/+5
| | | | | | | | | | BUG=104040 R=ben@chromium.org TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/10351002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135232 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrokerDuplicateHandle() to be declared in content/publicmseaborn@chromium.org2012-04-161-2/+2
| | | | | | | | | | | | This is necessary so that BrokerDuplicateHandle() can be used from chrome/browser while passing the check_deps rules. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2719 TEST=build Review URL: https://chromiumcodereview.appspot.com/10082018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132405 0039d316-1c4b-4281-b951-d872f2087c98
* Convert plugin and GPU process to brokered handle duplication.jschuh@chromium.org2012-04-143-36/+11
| | | | | | | BUG=119250 Review URL: https://chromiumcodereview.appspot.com/9958034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132303 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 132218 - Convert plugin and GPU process to brokered handle duplication.eroman@chromium.org2012-04-133-11/+36
| | | | | | | | | | | | (Seems to be responsible for VMTest failure on ChromiumOS). BUG=119250 Review URL: https://chromiumcodereview.appspot.com/9958034 TBR=jschuh@chromium.org Review URL: https://chromiumcodereview.appspot.com/10081018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132254 0039d316-1c4b-4281-b951-d872f2087c98
* Convert plugin and GPU process to brokered handle duplication.jschuh@chromium.org2012-04-133-36/+11
| | | | | | | BUG=119250 Review URL: https://chromiumcodereview.appspot.com/9958034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132218 0039d316-1c4b-4281-b951-d872f2087c98
* Add an interface for Flash to clear its data.brettw@chromium.org2012-04-122-9/+2
| | | | | | | | | | This mirrors NPP_ClearSiteData. I basically just hooked into the existing infrastructure in the browser process, and create a new plugin. I changed the NPAPI IPC message to take the max age rather than compute it from the time so I did not have to duplicate the time computation code. Review URL: https://chromiumcodereview.appspot.com/9981015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132067 0039d316-1c4b-4281-b951-d872f2087c98
* Creates an IME-host window for a sandboxed Flash.hbono@chromium.org2012-04-051-3/+20
| | | | | | | | | | | This change creates an edit control before our sandbox locks down Flash so an IME can attach itself to a plug-in process. (This change implements a method suggested by an Adobe person to Chrome.) BUG=118882 TEST=manual Review URL: http://codereview.chromium.org/9963060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130943 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TOOLKIT_USES_GTK and consolidate it into TOOLKIT_GTKoshima@chromium.org2012-04-051-3/+3
| | | | | | | | | | | Add gtk dependency to base.gyp for android host_os="linux" case BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9969080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130784 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 130199 - Revert 128179 - Make sure the plugin scriptable object is ↵wez@chromium.org2012-04-042-8/+19
| | | | | | | | | | | | | | | | | | | | | | released before NPP_Destroy. We're reinstating this patch based on its impact on plugin crash rates between 20.0.1089.0 (with patch) and 20.0.1090.0 (without) builds. When the we tear down a plugin instance the plugin process first invokes NPP_Destroy, and then tears down the IPC channel to the renderer, to give NPP_Destroy a chance to do last-minute scripting. When the IPC channel for the last instance is torn down we also clean up the IPC channels and stubs for any plugin-side NPObjects that remain. We suspect that some plugins implement the scriptable object as part of the plugin instance, rather than independently ref-counted, so that our releasing the object after NPP_Destroy actually triggers the plugin process to crash. This CL tears down the stub for the plugin's scriptable object before we call NPP_Destroy. BUG=101968,119414 Original Review URL: http://codereview.chromium.org/9817023 Revert Review URL: https://chromiumcodereview.appspot.com/9959078 TBR=cpu@chromium.org Review URL: https://chromiumcodereview.appspot.com/9979022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130698 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 128179 - Make sure the plugin scriptable object is released before ↵wez@chromium.org2012-04-022-19/+8
| | | | | | | | | | | | | | | | | | | | | | | NPP_Destroy. We're temporarily reverting this change to gather more data on its impact on plugin crash rates. When the we tear down a plugin instance the plugin process first invokes NPP_Destroy, and then tears down the IPC channel to the renderer, to give NPP_Destroy a chance to do last-minute scripting. When the IPC channel for the last instance is torn down we also clean up the IPC channels and stubs for any plugin-side NPObjects that remain. We suspect that some plugins implement the scriptable object as part of the plugin instance, rather than independently ref-counted, so that our releasing the object after NPP_Destroy actually triggers the plugin process to crash. This CL tears down the stub for the plugin's scriptable object before we call NPP_Destroy. As per crbug.com/119414, we will remove this code if it doesn't significantly impact crashes. BUG=101968 Review URL: http://codereview.chromium.org/9817023 TBR=cpu@chromium.org Review URL: https://chromiumcodereview.appspot.com/9959078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130199 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 129627 - Add a sandbox API for broker handle duplicationjschuh@chromium.org2012-03-293-11/+36
| | | | | | | | | | BUG=119250 Review URL: https://chromiumcodereview.appspot.com/9838083 TBR=jschuh@chromium.org Review URL: https://chromiumcodereview.appspot.com/9924010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129629 0039d316-1c4b-4281-b951-d872f2087c98
* Add a sandbox API for broker handle duplicationjschuh@chromium.org2012-03-293-36/+11
| | | | | | | BUG=119250 Review URL: https://chromiumcodereview.appspot.com/9838083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129627 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilation error due to deprecated glib APIqiankun.miao@intel.com2012-03-281-0/+4
| | | | | | | | | | | | | | | g_thread_init and g_thread_get_initialized are two deprecated APIs since glib version 2.32. The Glib threading system is automatically initialized at the start of a program. There will be compilation error with these two functions. Remove calls to these two functions. BUG=119669 TEST=NONE Review URL: http://codereview.chromium.org/9835044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129350 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the plugin scriptable object is released before NPP_Destroy.wez@chromium.org2012-03-222-8/+19
| | | | | | | | | | | | | | | | When the we tear down a plugin instance the plugin process first invokes NPP_Destroy, and then tears down the IPC channel to the renderer, to give NPP_Destroy a chance to do last-minute scripting. When the IPC channel for the last instance is torn down we also clean up the IPC channels and stubs for any plugin-side NPObjects that remain. We suspect that some plugins implement the scriptable object as part of the plugin instance, rather than independently ref-counted, so that our releasing the object after NPP_Destroy actually triggers the plugin process to crash. This CL tears down the stub for the plugin's scriptable object before we call NPP_Destroy. As per crbug.com/119414, we will remove this code if it doesn't significantly impact crashes. BUG=101968 Review URL: http://codereview.chromium.org/9817023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128179 0039d316-1c4b-4281-b951-d872f2087c98
* Keep one copy of the delegate & plugin teardown code.wez@chromium.org2012-03-211-7/+4
| | | | | | Review URL: http://codereview.chromium.org/9826001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128085 0039d316-1c4b-4281-b951-d872f2087c98
* mac: fix flash videos with --disable-composited-core-animation-pluginspiman@chromium.org2012-03-141-2/+2
| | | | | | | | | | | | | http://codereview.chromium.org/9194005 Missed one renaming. This fixes it. BUG=117916 TEST=chrome --disable-composited-core-animation-plugins, load youtube videos Review URL: http://codereview.chromium.org/9693031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126560 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 20:49:49 +0000