| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
R=calamity@chromium.org
Review URL: https://codereview.chromium.org/24856003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason: androidwebview_instrumentation_tests failing starting from this build:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/14741
Locally verified that at least this test starts passing after revert:
org.chromium.android_webview.test.AndroidScrollIntegrationTest#testNoSpuriousOverScrolls
Unsolved mystery remains around the passing trybot with the Rietveld issue:
http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/89522
> Cancel resources in the plugin process when a user presses the stop button or window.stop() is called.
>
> BUG=286074
> R=ananta@chromium.org
>
> Review URL: https://codereview.chromium.org/24302012
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/24570003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
or window.stop() is called.
BUG=286074
R=ananta@chromium.org
Review URL: https://codereview.chromium.org/24302012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/24395008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to break a dependency on ui/base from ui/compositor.
R=sky@chromium.org
TBR=sky@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/23460052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the browser process.
This also fixes a number of issues I saw when testing Netflix:
-fix http status header not reaching plugin
-send a Content-Type header if one isn't specified by the plugin for POSTs
-null check info->headers, needed for data: URLs
This doesn't support responding to 200s after a byte-range request. I'm gathering stats now to see how often this happens.
BUG=286074
R=ananta@chromium.org, jschuh@chromium.org
Review URL: https://codereview.chromium.org/23830007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None, no functional change.
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23658056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
going through the renderer. This is needed because when we have site isolation enabled we won't trust the renderer to fetch urls from arbitrary origins, which is something that NPAPI plugins can do.
In a followup I'll implement range requests.
For now this is behind the --direct-npapi-requests flag.
BUG=286074
R=ananta@chromium.org, jschuh@chromium.org
Review URL: https://codereview.chromium.org/23503043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
method order in webplugin_proxy.h and change WebKit::WebCanvas usage to SkCanvas.
R=tburkard@chromium.org
Review URL: https://codereview.chromium.org/23684023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23112033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in content now.
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/22862003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=265753
R=tburkard@chromium.org
Review URL: https://codereview.chromium.org/22730004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PowerMonitor status is now captured in the browser process, which has the
appropriate UI thread, and then sent via IPC to other processes which are
interested in the power state.
BUG=236031
R=apatrick@chromium.org, jam@chromium.org, jar@chromium.org, jvoung@chromium.org, kbr@chromium.org, mpcomplete@chromium.org, palmer@chromium.org, piman@chromium.org, vandebo@chromium.org
Review URL: https://codereview.chromium.org/17074009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changes.
BUG=242290
TBR=avi@chromium.org
Review URL: https://codereview.chromium.org/20114003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables classes deriving frmo ChildThread to cleanly shut down
WebKit
BUG=263034
R=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19641008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-NPAPIPluginsSupported moves to PluginService
-no need to call it in PluginList methods anymore since PluginService is now the only place that calls these methods, and it can check first
-no need for the renderer to call this first since now the browser won't enumerate NPAPI plugins if it's disabled
-CreateVersionFromString moves to WebPluginInfo. I couldn't find a better place to put it.
-move the constants back to plugin_constants_win.h
-move PLUGIN_QUIRK_DIE_AFTER_UNLOAD handling to WebPluginDelegateStub and PluginThread instead of being a global
-GetDefaultWindowParent moves to plugin_constants_win.h. I couldn't find a better place.
-IsPluginWindow moves to PluginService
-GetPluginNameFromWindow and GetPluginVersionFromWindow are both replaced by GetPluginInfoFromWindow which is on PluginService
-IsDummyActivationWindow was called by one place so I moved the code there
BUG=237249
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/19844003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
directory.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/19462016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notes:
-gtk_plugin_container_manager* and gtk_plugin_container* move to content/browser/renderer_host/ since that's all where they're used
-plugin_list* and plugin_constants_win* move to content/common as they're used by child processes and the browser
-webplugin_impl* and webplugin_page_delegate.h move to content/renderer as that's where they're used. I will remove webplugin_page_delegate.h in a followup change as it's no longer needed.
-the rest moves to content/child/npapi
-a few constants moved from plugin_constants_win.h to plugin_util.h temporarily
BUG=237249
TBR=scottmg
Review URL: https://codereview.chromium.org/19761007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
content/public/, content/renderer/, gpu/.
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19379005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19463008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and webkit_support methods that referenced or used PluginList.
BUG=237249
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/19381007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=253250
TEST=Run PluginTest.PluginSingleRangeRequest from content_browsertests.
The problem was caused by not resuming resources,
associated with range requests, in plugin_stream_url.cc.
Review URL: https://chromiumcodereview.appspot.com/18105003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=229660
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/18868005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dsinclair
Review URL: https://chromiumcodereview.appspot.com/17451017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is required to support crrev.com/14019005 landing.
It depends upon crrev.com/17913003.
BUG=152006
Review URL: https://chromiumcodereview.appspot.com/17906003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=254986
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18154002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting due to crashes.
BUG=255165
> Make plugin destruction asynchronous.
>
> This patch causes the webplugin to be deleted after the response
> to the synchronous PluginMsg_DestroyInstance IPC is sent.
>
> On my z620, plugin destruction often takes 300-400ms. This patch
> improves the typical_25 page cycler suite by 14% overall (average PLT
> drops by 193ms from 1356ms to 1163ms).
>
> BUG=254665
>
> Review URL: https://chromiumcodereview.appspot.com/17834016
TBR=tonyg@chromium.org
Review URL: https://codereview.chromium.org/18034011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=254539
Review URL: https://chromiumcodereview.appspot.com/17913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=254986
TEST=none
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/18063004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch causes the webplugin to be deleted after the response
to the synchronous PluginMsg_DestroyInstance IPC is sent.
On my z620, plugin destruction often takes 300-400ms. This patch
improves the typical_25 page cycler suite by 14% overall (average PLT
drops by 193ms from 1356ms to 1163ms).
BUG=254665
Review URL: https://chromiumcodereview.appspot.com/17834016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created fully mechanically by running
git grep -l base::mac::ScopedCFTypeRef | xargs sed -i -e 's/base::mac::ScopedCFTypeRef/base::ScopedCFTypeRef/g'
git commit -a -m.
git clang-format HEAD^ --style=Chromium
git commit -a -m.
git cl upload -t $TITLE
BUG=251957
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/16917011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Chrome)
This CL makes Chrome-side changes necessary for tracking of
NPObject ownership to out-of-process NPAPI plugin instances.
Ownership information is now included whenever an NPObject
is marshalled across IPC, to be passed when instantiating
NPObjectProxy instances for objects.
In the plugin process each NPObject is tracked to its owning
plugin instance, and browser-owned objects are tracked to a dummy NPP identifier.
This depends upon crrev.com/17220002 and is a prerequisite for crrev.com/17208003.
BUG=152006
Review URL: https://chromiumcodereview.appspot.com/17208003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes a dependency on media/ via ui/surface from gpu.gyp, allowing
media to use gpu.gyp for gpu::Mailbox.
R=piman@chromium.org, sky@chromium.org
BUG=179729
Review URL: https://codereview.chromium.org/17381009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes the majority of include paths from the old
Source/WebKit/chromium/public to the new public/web directory.
TBR=darin
BUG=239545
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/17148003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16358021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove forwarding header
BUG=
R=avi@chromium.org
Review URL: https://codereview.chromium.org/16667019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was just trying to move content/common/resource_dispatcher.{cc,h}, but that ends up needing a lot of other things to move.
TBR=jam@chromium.org
BUG=246357
Review URL: https://codereview.chromium.org/16328003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As prerequiste for linked bug.
TBR=palmer@chromium.org
R=jam@chromium.org,jamesr@chromium.org
BUG=246357
Review URL: https://chromiumcodereview.appspot.com/16325022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=245942
R=avi@chromium.org
Review URL: https://codereview.chromium.org/16256018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"operator T*"
Linux fixes
BUG=110610
TBR=darin
Review URL: https://chromiumcodereview.appspot.com/16294003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces a new target webkit_common which lives in webkit_common.gypi and
builds a dll/static lib based on the component flag. This target only contains the webcursor
sources for now.
BUG=237249
TBR=jamesr@chromium.org, mnaganov@chromium.org, palmer@chromium.org, piman@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/15971005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will help ensure that we don't have to depend on WebKit when we use the WebCursor
class. The current consumers of this class are plugins and browser.
We still have a dependency on the WebCursorInfo::Type enum which is fine.
Added helper functions InitializeCursorFromWebKitCursorInfo and GetWebKitCursorInfo to the webkit_glue
namespace in the newly added cursor_utils.cc/.h files which live in webkit_glue. These functions adapt
WebCursorInfo to our WebCursor and vice versa.
With this change we can move the WebCursor class to webkit\common in a subsequent CL.
BUG=237249
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/15946004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need a place to put code that is shared between child processes of different
types but not used in the browser process. For instance, the NPObject bindings
code is used in the plugin and renderer processes but depends on WebBindings
which the browser shouldn't depend on. Some web platform features require shared
code between renderer and worker processe. The WebKit image decoders are used
by worker, renderer and utility processes.
This creates a content/common_child directory for code shared by more than one
child process type. content/common_child can depend on content/common and all
content/ subdirs except for content/browser and content/common can depend on it.
The java bridge code is (more than a) bit busted since it pulls the NPObject
bindings in to the browser, but since this code is only intended for use on
android single-process configurations I've just created DEPS exceptions for
this bit of code.
BUG=241606
Review URL: https://chromiumcodereview.appspot.com/15047014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=147622
R=jln@chromium.org, piman@chromium.org, skaslev@chromium.org
Review URL: https://codereview.chromium.org/13529027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is continuation of the ongoing work for bug https://code.google.com/p/chromium/issues/detail?can=2&q=237249
which is splitting chrome.dll into a browser and renderer component due to build issues on Windows.
Changes in this CL as below:-
1 Move the plugins sources out of the webkit glue target into a new target 'plugins' which creates a static lib/dll
depending on the component build flag.
This target is specified by the newly added webkit_plugins.gypi file in the webkit\plugins folder. This is included
by webkit_support.gyp. The motivation for moving the plugins out to an independent target is to enable the chrome
browser code to link to the plugins without depending on glue.
2. We have a plugins_common target in webkit_plugins.gypi which builds a static lib and contains common plugin functionality
like plugin_utils, webplugininfo, etc. Next step is to move the plugin list sources to this common target as we want to avoid
browser to depend on Webkit through plugins. That would need some code changes which I wanted to avoid in this CL.
3. The 'glue' target in webkit_glue.gypi currently depends on webkit_media which sadly depends on plugins because of the HTML5
DRM code. I moved files which are needed by plugins and other consumers like browsers into a static lib target 'glue_common'
'glue' now depends on 'glue_common' and 'plugins'. 'plugins' depends on 'glue_common'.
4. The other targets like 'renderer', etc also depend on 'glue_common'.
Will move the common plugin files to the newly added webkit common folder in an upcoming CL.
BUG=237249
TBR=cpu@chromium.org, darin@chromium.org, jamesr@chromium.org
Review URL: https://codereview.chromium.org/14720012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move the plugins sources out of the webkit glue target into a new target 'plugins' which creates a static lib/dll
> depending on the component build flag.
>
> This target is specified by the added webkit_plugins.gypi file in the webkit\plugins folder. This is included
> by webkit_support.gyp.
>
> This is continuation of the ongoing work for bug https://code.google.com/p/chromium/issues/detail?can=2&q=237249
> which is splitting chrome.dll into a browser and renderer component due to build issues on Windows.
>
> The motivation for moving the plugins out to an independent target is to enable the chrome browser code to
> link to the plugins lib without depending on glue.
>
> We also have a plugins_common target in webkit_plugins.gypi which builds a static lib and contains common plugin
> functionality like plugin_utils, webplugininfo, etc.
>
> Next step is to move the plugin list sources to this common target as we want to avoid browser depending Webkit
> through plugins. That would need some code change which I wanted to avoid in this CL.
>
> Will also move the common plugin files to the newly added webkit common folder in an upcoming CL.
>
> BUG=237249
> TBR=cpu@chromium.org, darin@chromium.org, jamesr@chromium.org
>
> Review URL: https://codereview.chromium.org/15020011
TBR=ananta@chromium.org
Review URL: https://codereview.chromium.org/14646038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
'plugins' which creates a static lib/dll
depending on the component build flag.
This target is specified by the added webkit_plugins.gypi file in the webkit\plugins folder. This is included
by webkit_support.gyp.
This is continuation of the ongoing work for bug https://code.google.com/p/chromium/issues/detail?can=2&q=237249
which is splitting chrome.dll into a browser and renderer component due to build issues on Windows.
The motivation for moving the plugins out to an independent target is to enable the chrome browser code to
link to the plugins lib without depending on glue.
We also have a plugins_common target in webkit_plugins.gypi which builds a static lib and contains common plugin
functionality like plugin_utils, webplugininfo, etc.
Next step is to move the plugin list sources to this common target as we want to avoid browser depending Webkit
through plugins. That would need some code change which I wanted to avoid in this CL.
Will also move the common plugin files to the newly added webkit common folder in an upcoming CL.
BUG=237249
TBR=cpu@chromium.org, darin@chromium.org, jamesr@chromium.org
Review URL: https://codereview.chromium.org/15020011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=236029
R=avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14335017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details.
BUG=234765
R=jam@chromium.org
Review URL: https://codereview.chromium.org/14386012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r185551 changed the ordering of events in scoped_ptr<T>::reset();
specifically, callers can no longer rely on get() to return the old
value of the stored pointer during a reset(). This causes issues such as
http://crbug.com/232981. In order to break the dependency on the value
of main_thread_.get() during main_thread_.reset(), destruction of
ChildThread has been split into two parts.
BUG=233761
Review URL: https://codereview.chromium.org/13878020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195628 0039d316-1c4b-4281-b951-d872f2087c98
|