| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
BUG=265753, 338338, 237249
TEST=content_unittests
R=jam@chromium.org, torne@chromium.org
TBR=darin
Review URL: https://codereview.chromium.org/201473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One more step towards removing src/webkit/
BUG=265753
TEST=content_shell and content_unittests
R=jochen@chromium.org,jam@chromium.org
TBR=darin
Review URL: https://codereview.chromium.org/151023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
processes.
BUG=332481
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/132233022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The removed conditions are already satisfied through their respective
enclosing conditions.
Review URL: https://codereview.chromium.org/138213004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I also removed the _win.cc files inside content.
BUG=330735
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/137403005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When plugin_stubs_.erase removes the last reference of WebPluginDelegateStub, its destructor can send a sync message to the renderer. While waiting for a sync reply, other messages are handled, some of which may call into the same plugin_stubs_ vector while ::erase is still ongoing.
BUG=314088
Review URL: https://codereview.chromium.org/115233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First part (this CL): remove only caller.
Back in the days of Flash 9, we added this code to restore
the unhandled exception handler which flash sometimes stole.
Since flash 10 this is no longer true, and now it is not possible
in chrome to use old flashes so this code just adds complexity
for no good reason.
TBR=jam
BUG=none
Review URL: https://codereview.chromium.org/122553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-remove ResourceRequestInfo::GetRenderViewForRequest
-reduce usage of GetAssociatedRenderView and add GetAssociatedRenderFrame which will replace it
-move the cookie jar from RenderView to RenderFrame
-switch most of the usages of RenderView to RenderFrame in WebPluginImpl
BUG=304341
R=boliu@chromium.org, nasko@chromium.org
Review URL: https://codereview.chromium.org/114573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Converts creation of MessageLoopForUI from MessageLoop(TYPE_UI) to
MessageLoopForUI.
This is a step in the direction of moving type out of MessageLoop.
BUG=none
TEST=none
R=darin@chromium.org
Review URL: https://codereview.chromium.org/108713004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/102593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is
generally undefined on Mac, but as of r223369, it is incorrect in Chrome on
Mac.
To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not
used with close, and that IGNORE_EINTR is only used with close. Unnecessary
#includes of eintr_wrapper.h are also removed.
base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc
contain non-mechanical changes. Variable naming within the latter is updated
per r178174. Missing #includes for <errno.h> in
content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were
manually added. Mechanical changes were generated by running:
sed -E -i '' \
-e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \
-e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \
-e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \
$(git grep -El 'HANDLE_EINTR.*close')
sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \
$(grep -EL '(HANDLE|IGNORE)_EINTR' \
$(git grep -El '#include.*eintr_wrapper\.h"'))
BUG=269623
R=agl@chromium.org, jln@chromium.org
TBR=OWNERS
Review URL: https://codereview.chromium.org/100253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None, no functional changes.
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/97683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let me know if you prefer to keep some of these as INFO or just delete
them.
R=jam@chromium.org
BUG=322805
Review URL: https://codereview.chromium.org/84293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a prerequisite for removing the old (redirected) headers.
In a few DEPS and in webview_plugin.cc the include was redundant and
just removed instead.
BUG=none
Review URL: https://codereview.chromium.org/68683009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
An innocent attempt.
BUG=none
Review URL: https://codereview.chromium.org/66443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by:
$ git grep -l webkit/glue/webkit_glue.h > list.txt
$ for f in $(cat list.txt); do if ! grep -q 'PlatformFileInfoToWebFileInfo' $f ; then echo $f; fi; done
$ for f in $(cat list.txt); do if ! grep -q 'SetJavaScript' $f ; then echo $f; fi; done
BUG=None
TEST=unit_tests, content_unittests
R=thestig@chromium.org
TBR=joth,avi,jamesr
Review URL: https://codereview.chromium.org/59323005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL updates all references to the WebKit namespace in content.
TBR=darin@chromium.org
BUG=295096
Review URL: https://codereview.chromium.org/63253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
init failed.
AddMappingForNPObjectOwner() won't get called if initialization failed.
Therefore, we should not call RemoveMappingForNPObjectOwner() in dtor in that
case.
BUG=309102,307713
TEST=none
Review URL: https://codereview.chromium.org/29623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
or window.stop() is called.
BUG=286074
R=ananta@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225099
Review URL: https://codereview.chromium.org/24302012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=calamity@chromium.org
Review URL: https://codereview.chromium.org/24856003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason: androidwebview_instrumentation_tests failing starting from this build:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/14741
Locally verified that at least this test starts passing after revert:
org.chromium.android_webview.test.AndroidScrollIntegrationTest#testNoSpuriousOverScrolls
Unsolved mystery remains around the passing trybot with the Rietveld issue:
http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/89522
> Cancel resources in the plugin process when a user presses the stop button or window.stop() is called.
>
> BUG=286074
> R=ananta@chromium.org
>
> Review URL: https://codereview.chromium.org/24302012
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/24570003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
or window.stop() is called.
BUG=286074
R=ananta@chromium.org
Review URL: https://codereview.chromium.org/24302012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/24395008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to break a dependency on ui/base from ui/compositor.
R=sky@chromium.org
TBR=sky@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/23460052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the browser process.
This also fixes a number of issues I saw when testing Netflix:
-fix http status header not reaching plugin
-send a Content-Type header if one isn't specified by the plugin for POSTs
-null check info->headers, needed for data: URLs
This doesn't support responding to 200s after a byte-range request. I'm gathering stats now to see how often this happens.
BUG=286074
R=ananta@chromium.org, jschuh@chromium.org
Review URL: https://codereview.chromium.org/23830007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None, no functional change.
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23658056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
going through the renderer. This is needed because when we have site isolation enabled we won't trust the renderer to fetch urls from arbitrary origins, which is something that NPAPI plugins can do.
In a followup I'll implement range requests.
For now this is behind the --direct-npapi-requests flag.
BUG=286074
R=ananta@chromium.org, jschuh@chromium.org
Review URL: https://codereview.chromium.org/23503043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
method order in webplugin_proxy.h and change WebKit::WebCanvas usage to SkCanvas.
R=tburkard@chromium.org
Review URL: https://codereview.chromium.org/23684023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23112033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in content now.
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/22862003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=265753
R=tburkard@chromium.org
Review URL: https://codereview.chromium.org/22730004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PowerMonitor status is now captured in the browser process, which has the
appropriate UI thread, and then sent via IPC to other processes which are
interested in the power state.
BUG=236031
R=apatrick@chromium.org, jam@chromium.org, jar@chromium.org, jvoung@chromium.org, kbr@chromium.org, mpcomplete@chromium.org, palmer@chromium.org, piman@chromium.org, vandebo@chromium.org
Review URL: https://codereview.chromium.org/17074009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changes.
BUG=242290
TBR=avi@chromium.org
Review URL: https://codereview.chromium.org/20114003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables classes deriving frmo ChildThread to cleanly shut down
WebKit
BUG=263034
R=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19641008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-NPAPIPluginsSupported moves to PluginService
-no need to call it in PluginList methods anymore since PluginService is now the only place that calls these methods, and it can check first
-no need for the renderer to call this first since now the browser won't enumerate NPAPI plugins if it's disabled
-CreateVersionFromString moves to WebPluginInfo. I couldn't find a better place to put it.
-move the constants back to plugin_constants_win.h
-move PLUGIN_QUIRK_DIE_AFTER_UNLOAD handling to WebPluginDelegateStub and PluginThread instead of being a global
-GetDefaultWindowParent moves to plugin_constants_win.h. I couldn't find a better place.
-IsPluginWindow moves to PluginService
-GetPluginNameFromWindow and GetPluginVersionFromWindow are both replaced by GetPluginInfoFromWindow which is on PluginService
-IsDummyActivationWindow was called by one place so I moved the code there
BUG=237249
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/19844003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
directory.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/19462016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notes:
-gtk_plugin_container_manager* and gtk_plugin_container* move to content/browser/renderer_host/ since that's all where they're used
-plugin_list* and plugin_constants_win* move to content/common as they're used by child processes and the browser
-webplugin_impl* and webplugin_page_delegate.h move to content/renderer as that's where they're used. I will remove webplugin_page_delegate.h in a followup change as it's no longer needed.
-the rest moves to content/child/npapi
-a few constants moved from plugin_constants_win.h to plugin_util.h temporarily
BUG=237249
TBR=scottmg
Review URL: https://codereview.chromium.org/19761007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
content/public/, content/renderer/, gpu/.
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19379005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19463008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and webkit_support methods that referenced or used PluginList.
BUG=237249
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/19381007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=253250
TEST=Run PluginTest.PluginSingleRangeRequest from content_browsertests.
The problem was caused by not resuming resources,
associated with range requests, in plugin_stream_url.cc.
Review URL: https://chromiumcodereview.appspot.com/18105003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=229660
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/18868005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dsinclair
Review URL: https://chromiumcodereview.appspot.com/17451017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is required to support crrev.com/14019005 landing.
It depends upon crrev.com/17913003.
BUG=152006
Review URL: https://chromiumcodereview.appspot.com/17906003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=254986
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18154002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting due to crashes.
BUG=255165
> Make plugin destruction asynchronous.
>
> This patch causes the webplugin to be deleted after the response
> to the synchronous PluginMsg_DestroyInstance IPC is sent.
>
> On my z620, plugin destruction often takes 300-400ms. This patch
> improves the typical_25 page cycler suite by 14% overall (average PLT
> drops by 193ms from 1356ms to 1163ms).
>
> BUG=254665
>
> Review URL: https://chromiumcodereview.appspot.com/17834016
TBR=tonyg@chromium.org
Review URL: https://codereview.chromium.org/18034011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=254539
Review URL: https://chromiumcodereview.appspot.com/17913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=254986
TEST=none
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/18063004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch causes the webplugin to be deleted after the response
to the synchronous PluginMsg_DestroyInstance IPC is sent.
On my z620, plugin destruction often takes 300-400ms. This patch
improves the typical_25 page cycler suite by 14% overall (average PLT
drops by 193ms from 1356ms to 1163ms).
BUG=254665
Review URL: https://chromiumcodereview.appspot.com/17834016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created fully mechanically by running
git grep -l base::mac::ScopedCFTypeRef | xargs sed -i -e 's/base::mac::ScopedCFTypeRef/base::ScopedCFTypeRef/g'
git commit -a -m.
git clang-format HEAD^ --style=Chromium
git commit -a -m.
git cl upload -t $TITLE
BUG=251957
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/16917011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208245 0039d316-1c4b-4281-b951-d872f2087c98
|