summaryrefslogtreecommitdiffstats
path: root/content/ppapi_plugin
Commit message (Collapse)AuthorAgeFilesLines
* Fold away now dead NSS code.davidben2015-10-021-7/+0
| | | | | | | | | | | Anything not built on iOS can now assume USE_OPENSSL is set. Most notably, the libc urandom override is now gone. BUG=519504 Review URL: https://codereview.chromium.org/1364023003 Cr-Commit-Position: refs/heads/master@{#352061}
* Enforce marking "override" for functions overriding Blink in content/.avi2015-09-262-27/+26
| | | | | | | | | BUG=535367 TEST=it all stays working Review URL: https://codereview.chromium.org/1365383003 Cr-Commit-Position: refs/heads/master@{#350981}
* Make SharedMemoryHandle a class on windows.erikchen2015-09-251-1/+4
| | | | | | | | | | | | | | | | This CL is intended to be a refactor and should not introduce any behavior changes. Previously, SharedMemoryhandle was typedefed to HANDLE. Making it a class allows us to add metainformation about the process in which the HANDLE is valid. This will be used in the future by Chrome's IPC system to automatically duplicate HANDLEs into their destination process. BUG=493414, 535028 Review URL: https://codereview.chromium.org/1320783002 Cr-Commit-Position: refs/heads/master@{#350932}
* Add a scheduler to PpapiBlinkPlatformImplalexclarke2015-09-243-1/+16
| | | | | | | | | | | This is to fix a bug where blink code called from within the ppapi process crashes if it calls Platform::current()->currentThread()->scheduler(). BUG=534972 Review URL: https://codereview.chromium.org/1366583003 Cr-Commit-Position: refs/heads/master@{#350517}
* Added GDI font emulation support for Flash.forshaw2015-09-221-0/+6
| | | | | | | | | | | This patch adds simple GDI font enumeration emulation support to get Flash running under win32k lockdown. BUG=523278 Review URL: https://codereview.chromium.org/1327673002 Cr-Commit-Position: refs/heads/master@{#350245}
* Added directwrite warmup for PPAPI processes.forshaw2015-09-221-1/+17
| | | | | | | | | | | | This patch warms up the directwrite skia font code when running a PPAPI process under win32k lockdown. This allows users of the Skia (such as the PPAPI itself) to bypass GDI calls when dealing with fonts. BUG=523278 Review URL: https://codereview.chromium.org/1325843002 Cr-Commit-Position: refs/heads/master@{#350191}
* Prevent a couple of intentional crash sites from being merged.thestig2015-09-191-2/+10
| | | | | | | | | | | The linker may merge identical looking functions and this is confusing for crash report processing. Similar to https://crrev.com/345663 Review URL: https://codereview.chromium.org/1358633003 Cr-Commit-Position: refs/heads/master@{#349816}
* Don't initialize V8 via Blink in ppapi pluginsjochen2015-09-171-2/+2
| | | | | | | | | | | | | Instead, for the PDF plugin, use gin to manage V8. Also add myself as owner for the v8 stuff. BUG=530093 R=raymes@chromium.org,thestig@chromium.org Review URL: https://codereview.chromium.org/1346143003 Cr-Commit-Position: refs/heads/master@{#349379}
* Print stack traces in browser tests when any process crashes, or an assert ↵jam2015-08-171-6/+0
| | | | | | | | | | | | | | | | | | | | fires. The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from processes on all platforms and not just Linux (i.e. to be able to debug the large flakiness that occurred last week). This is disabled for official builds. Also make release (non-official) builds print the callstack on asserts, just like debug builds. This makes it easier to debug test failures on the CQ (for example, DCHECKs for non-threadsafe usage of pointers). Add a regression test that both renderer and browser process crashes print the callstack. BUG=517488,358267,521148 NOPRESUBMIT=true Committed: https://crrev.com/8ba532e170befc312e66d032587fa2ad04bac975 Cr-Commit-Position: refs/heads/master@{#343240} Review URL: https://codereview.chromium.org/1291553003 Cr-Commit-Position: refs/heads/master@{#343626}
* Revert of Print stack traces in child processes when browser tests failed. ↵rockot2015-08-161-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #5 id:80001 of https://codereview.chromium.org/1291553003/ ) Reason for revert: This is unfortunately breaking Windows 10 in a major way. I did a local bisect and narrowed it down to this CL. BUG=521242 Original issue's description: > Print stack traces in child processes when browser tests failed. > > The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from child processes on all platforms (i.e. to be able to debug the large flakiness that occurred since last week). This is disabled for official builds. > > BUG=517488,358267 > > Committed: https://crrev.com/8ba532e170befc312e66d032587fa2ad04bac975 > Cr-Commit-Position: refs/heads/master@{#343240} TBR=scottmg@chromium.org,jln@chromium.org,wfh@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517488,358267 Review URL: https://codereview.chromium.org/1299583002 Cr-Commit-Position: refs/heads/master@{#343603}
* Allow access to /System/Library/Exensions on El Capitan+ to solve GPU crashes.kerrnel2015-08-141-1/+1
| | | | | | | | | | | While in the sandbox profiles, I also cleaned up some comments and formatting problems. BUG=515280 Review URL: https://codereview.chromium.org/1285423003 Cr-Commit-Position: refs/heads/master@{#343410}
* Print stack traces in child processes when browser tests failed.jam2015-08-131-6/+0
| | | | | | | | | | The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from child processes on all platforms (i.e. to be able to debug the large flakiness that occurred since last week). This is disabled for official builds. BUG=517488,358267 Review URL: https://codereview.chromium.org/1291553003 Cr-Commit-Position: refs/heads/master@{#343240}
* Add UMA for ppapi plugin load time.xhwang2015-07-172-11/+38
| | | | | | | | | BUG=510234 TEST=Manually tested and verified in about://histograms. Review URL: https://codereview.chromium.org/1235393007 Cr-Commit-Position: refs/heads/master@{#339203}
* Refactor OS X sandbox processing and audit sandbox fileskerrnel2015-07-161-6/+4
| | | | | | | | | | | | | | | | | | | Audited the sandbox files to enusre all rules are necessary and removed any incorrect comments. The OS X Sandbox code is refactored to get rid of all string processing of the raw scheme code in the sandbox profiles. By using the ability to pass parameters into sandbox profiles, the variable substitution logic is performed by the scheme interpreter itself. BUG=242704 Committed: https://crrev.com/76eaa8778a322803dc3ac20cda05525e615dec4d Cr-Commit-Position: refs/heads/master@{#336610} Review URL: https://codereview.chromium.org/1186233004 Cr-Commit-Position: refs/heads/master@{#339038}
* media: Add trace event for pepper plugin (CDM) loading time.xhwang2015-07-151-1/+6
| | | | | | | | | | BUG=510234 TEST=Maually tested. R=ddorwin@chromium.org Review URL: https://codereview.chromium.org/1228733003 Cr-Commit-Position: refs/heads/master@{#338924}
* Only initialize NSS in PpapiPluginMain on !USE_OPENSSL builds.davidben2015-07-081-1/+1
| | | | | | | | | | | | | | | | This dates to https://chromiumcodereview.appspot.com/11411013 which was added to resolve the ClearKey CDM. ClearKey uses routines from //crypto which may use NSS. But it doesn't need NSS in the chimera build, so we should limit this to !USE_OPENSSL builds. (The tests in question have also since moved to browser_tests and out of //content.) BUG=506323 Review URL: https://codereview.chromium.org/1222103005 Cr-Commit-Position: refs/heads/master@{#337935}
* Fixed all overloaded virtual methods on Windows.mgiuca2015-07-082-2/+2
| | | | | | | | | | | | | | | | | | | | | | | This fixes the 'overloaded-virtual' Clang warning on Windows (currently disabled; will be enabled in a follow-up CL). - PpapiThread::PreCacheFont: Renamed to PreCacheFontForFlash to avoid conflict with PreCacheFont method in base class ChildThreadImpl. (This method is only called by another method called PreCacheFontForFlash so the new name is appropriate.) - PrintingContextSytemDialogWin::InitializeSettings: Renamed to InitializeSettingsWithRanges to avoid conflict with InitializeSettings in base class PrintingContextWin. (These two methods are called on different code paths and the former is not meant to override the latter, so they should have different names.) - Removed PrintingContextWin::ShowPrintDialog. This method was totally unused and its name was conflicting with a method in a subclass. BUG=505301 Review URL: https://codereview.chromium.org/1216013005 Cr-Commit-Position: refs/heads/master@{#337735}
* Revert of Refactor OS X sandbox processing and audit sandbox files (patchset ↵caseq2015-06-301-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6 id:120001 of https://codereview.chromium.org/1186233004/) Reason for revert: Speculative revert to see if this could be a possible reason for MacOS 10.6 layout test bot failures starting since http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/41745 Original issue's description: > Refactor OS X sandbox processing and audit sandbox files > > Audited the sandbox files to enusre all rules are necessary and removed > any incorrect comments. > > The OS X Sandbox code is refactored to get rid of all string processing > of the raw scheme code in the sandbox profiles. By using the ability to > pass parameters into sandbox profiles, the variable substitution logic > is performed by the scheme interpreter itself. > > BUG=242704 > > Committed: https://crrev.com/76eaa8778a322803dc3ac20cda05525e615dec4d > Cr-Commit-Position: refs/heads/master@{#336610} TBR=rsesek@chromium.org,kerrnel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=242704 Review URL: https://codereview.chromium.org/1213113006 Cr-Commit-Position: refs/heads/master@{#336757}
* Refactor OS X sandbox processing and audit sandbox fileskerrnel2015-06-291-6/+4
| | | | | | | | | | | | | | | | Audited the sandbox files to enusre all rules are necessary and removed any incorrect comments. The OS X Sandbox code is refactored to get rid of all string processing of the raw scheme code in the sandbox profiles. By using the ability to pass parameters into sandbox profiles, the variable substitution logic is performed by the scheme interpreter itself. BUG=242704 Review URL: https://codereview.chromium.org/1186233004 Cr-Commit-Position: refs/heads/master@{#336610}
* Remove jeremy@ from Mac OWNERS, and use file references.Robert Sesek2015-06-251-1/+1
| | | | | | | | | | I'll take over ownership of the Mac sandbox files. R=avi@chromium.org, jeremy@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1200263007. Cr-Commit-Position: refs/heads/master@{#336153}
* Further clean up pepper's use of SharedMemory.erikchen2015-06-041-9/+17
| | | | | | | | | | | | | This CL uses the new methods content::BrokerDuplicateSharedMemoryHandle() and base::SharedMemory::DuplicateHandle() to remove some duplicated code. This CL changes the implementation of ShareSharedMemoryhandleWithRemote() to no longer assume that the SharedMemoryHandle is backed by a POSIX fd. BUG=466437 Review URL: https://codereview.chromium.org/1166443004 Cr-Commit-Position: refs/heads/master@{#332903}
* Update pepper to not assume that SharedMemoryHandle is an int.erikchen2015-06-022-0/+18
| | | | | | | | | | | | | | | | | | | This CL is a refactor. This CL contains no intended behavior changes. Pepper code assumes that SharedMemoryHandle is backed by a PlatformFile, and that the relevant HANDLE or fd can be cast to an int. These assumptions will no longer be true once SharedMemory is backed by Mach primitives on Mac. This CL adds the method ShareSharedMemoryHandleWithRemote() to ProxyChannel::Delegate. This method is used in place of ShareHandleWithRemote() when a SharedMemory object is being shared between processes. This CL updates the type of all SharedMemory handles to be SharedMemoryHandle. BUG=466437 Review URL: https://codereview.chromium.org/1154613006 Cr-Commit-Position: refs/heads/master@{#332325}
* content/child: Remove use of MessageLoopProxy and deprecated MessageLoop APIsskyostil2015-05-212-3/+3
| | | | | | | | | | | | This patch was mostly autogenerated with https://codereview.chromium.org/1010073002/. BUG=465354 TBR=jochen@chromium.org,raymes@chromium.org Review URL: https://codereview.chromium.org/1142063003 Cr-Commit-Position: refs/heads/master@{#330939}
* Fork the mojo shell interfaces used by Mandoline.jam2015-05-141-1/+1
| | | | | | | | | | | | Per in-person discussions, as long as we have a fork of mojo shell we'll fork the interfaces. I'll do third_party/mojo/src/mojo/public/java/application in a followup. TBR=tsepez Review URL: https://codereview.chromium.org/1139123006 Cr-Commit-Position: refs/heads/master@{#329965}
* Fix //content/test:test_support under component builds.sammc2015-04-281-1/+15
| | | | | | | | | | | | | | | | | | | | | | Previously, //content/test:test_support depended directly on *_sources targets. In component builds, this caused the browser_tests and content_browsertests binaries to include their own copies of content as well as depend on libcontent.so. This caused browser_tests and content_browsertests to crash on startup. This CL changes test_support to depend on the targets that forward to //content in component builds and introduces such targets for gpu and ppapi_plugin. The test_support changes also exposed underspecified dependencies in extensions/renderer/BUILD.gn and third_party/libjingle/BUILD.gn, and incorrect generated file dependencies in content/browser/devtools; the generated files depend on other non-generated files so have to be directly included in //content/browser. BUG=432959 Review URL: https://codereview.chromium.org/1104973002 Cr-Commit-Position: refs/heads/master@{#327188}
* Rename USE_NSS to USE_NSS_CERTS.davidben2015-04-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | USE_NSS is confusing because it's not actually the analog of USE_OPENSSL; it's the analog to USE_OPENSSL_CERTS. This is in preparation for the chimera build which will set USE_OPENSSL and USE_NSS(_CERTS). This CL was partially done automatically by the following command: git grep -l USE_NSS | xargs sed -i -e 's/defined(USE_NSS)/defined(USE_NSS_CERTS)/' The remaining were caught by the following command and fixed manually: git grep 'USE_NSS\([^_]\|$\)' Finally, the following command verified nothing in a separate repository was sensitive to this change: find . -name '*.cc' -o -name '*.h' | xargs grep 'USE_NSS\([^_]\|$\)' For now, the old name is still defined, but not used within Chromium. A follow-up CL will remove deprecated use_nss and USE_NSS #defines together which will then cause downstream churn. Though from a grep of known downstreams, the churn seems to be fairly minimal. The removal is split from this CL so that, if we need to revert, the CL to revert is small. TBR=pneubeck@chromium.org BUG=462040 Review URL: https://codereview.chromium.org/1082123003 Cr-Commit-Position: refs/heads/master@{#325710}
* content: Set DiscardableMemoryAllocator instance in PpapiThread.reveman2015-04-151-0/+9
| | | | | | | | | | | This is required for discardable memory to be available to ppapi processes. BUG=477047 Review URL: https://codereview.chromium.org/1082373002 Cr-Commit-Position: refs/heads/master@{#325192}
* Don't lock ProxyLock on the IO threaddmichael2015-04-021-5/+7
| | | | | | | | | | Introduce ResourceMessageFilter and UDPSocketFilter to receive messages on the IO thread. This allows us to queue messages up when there's no callback, and dispatch them directly to the appropriate thread when there is a callback pending. (This depends on TrackedCallback being Run()-able without the ProxyLock; see https://codereview.chromium.org/923263003/) BUG=439588 Review URL: https://codereview.chromium.org/869883003 Cr-Commit-Position: refs/heads/master@{#323517}
* [Win, Android] Don't create WebSandboxSupport when it would have no methods.jbroman2015-03-092-30/+20
| | | | | | | | | | | | | | | This removes includes of android/ and win/WebSandboxSupport.h, and only has the platform implementations create it on the platforms that do have a WebSandboxSupport (Mac, Linux). If this lands, the empty WebSandboxSupport headers can be removed from Blink in a followup CL. BUG=463506 Review URL: https://codereview.chromium.org/976163002 Cr-Commit-Position: refs/heads/master@{#319653}
* Work on GN Win64 build.brettw2015-02-181-2/+4
| | | | | | | | | | | | Adds a new config to disable size_t -> int truncations and use it in various places where the x64 Windows build currently gives warnings. This covers Chrome (except for Blink which has a separate patch) and the tests. We should do a second pass to replace the existing instances of /wd4267 with this config. Review URL: https://codereview.chromium.org/927363005 Cr-Commit-Position: refs/heads/master@{#316874}
* Split apart the PPAPI GN targetsbrettw2015-02-141-1/+1
| | | | | | | | | | | | This puts BUILD files in the corresponding directories without duplicate names. Adds a template for ppapi examples and writes the build for one example. I only did one at this point to test the infrastructure without making this patch too large. NOPRESUBMIT=true Review URL: https://codereview.chromium.org/921953002 Cr-Commit-Position: refs/heads/master@{#316352}
* Mechanical rename of base::debug -> base::trace_event for /contentssid2015-02-092-4/+5
| | | | | | | | | | | | | | | This is the last stage of the trace_event directory restructuring. This is part of a set of 3 CLs which is moving tracing clients to use the new base::trace_event namespace. See crrev.com/837303004 and the related bug for motivations. BUG=451032 TBR=jam@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/892213004 Cr-Commit-Position: refs/heads/master@{#315310}
* Make chrome.exe built with ASan/Win work with sandbox enabledtimurrrr2015-02-051-0/+6
| | | | | | | | | | Also add an ASan test to sbox_integration_tests on Windows BUG=382867 Review URL: https://codereview.chromium.org/868253011 Cr-Commit-Position: refs/heads/master@{#314780}
* Unify the three places that patch font loading for PDFium on Windows.jam2015-02-033-67/+17
| | | | | | | | | | | | This also removed the code from content, which doesn't belong there because it's for a feature in Chrome. In order to implement this in a unified way, I needed to create a public interface around ChildThread. A lot of the change is updating callers of ChildThread to use ChildThreadImpl instead. BUG=448473 Review URL: https://codereview.chromium.org/897563002 Cr-Commit-Position: refs/heads/master@{#314367}
* Move //mojo/{public, edk} underneath //third_partyblundell2015-01-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This CL move //mojo/public and //mojo/edk to live in the following locations: - //third_party/mojo/src/mojo/public - //third_party/mojo/src/mojo/edk It moves the related gypfiles from //mojo to //third_party/mojo and updates them as necessary to account for the file moves. It also updates clients of the mojo SDK and EDK targets in both GYP and GN. (Note that for GN, the mojo SDK and EDK build systems are maintained in the Mojo repo and designed to be flexible wrt the location of the SDK/EDK in a client repo, so no changes are needed. This CL does not update include paths to the code being moved to limit the number of moving parts, instead relying on the include_dirs that the SDK and EDK targets supply to their direct dependents to ensure that include paths continue to resolve correctly. NOPRESUBMIT=true Review URL: https://codereview.chromium.org/814543006 Cr-Commit-Position: refs/heads/master@{#312129}
* Fix font loading in OOP PDFscottmg2015-01-151-0/+58
| | | | | | | | | | | | | | | | | This does two things - avoids pdf.dll being loaded into the renderer when OOP PDF is being used (this was caused by the patching) - does the patch in PpapiThread when pdf.dll is loaded there for OOP The IAT patch to GetFontData allows various users of GDI font methods to succeed when sandboxed. R=cpu@chromium.org,raymes@chromium.org,ananta@chromium.org BUG=448473 Review URL: https://codereview.chromium.org/854773002 Cr-Commit-Position: refs/heads/master@{#311730}
* Make callers of CommandLine use it via the base:: namespace.avi2014-12-233-6/+5
| | | | | | | | | | | | Covers content/. BUG=422426 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/803813003 Cr-Commit-Position: refs/heads/master@{#309496}
* Remove old WebSocket implementation from content/ricea2014-10-242-7/+0
| | | | | | | | | | | | | | | | | | Remove the old SocketStream-based WebSocket implementation from content/. Large parts of the implementation still exist in net/. They will be removed in a subsequent CL. There are also a few traces in chrome/, and some interfaces in Blink that cannot be removed until this CL is submitted. BUG=423201 TEST=layout tests, browser_tests Review URL: https://codereview.chromium.org/655253006 Cr-Commit-Position: refs/heads/master@{#301075}
* Standardize usage of virtual/override/final in content/dcheng2014-10-213-24/+22
| | | | | | | | | | | | This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=avi@chromium.org Review URL: https://codereview.chromium.org/671663002 Cr-Commit-Position: refs/heads/master@{#300461}
* Refactoring: Make IPC::Channel::TakeClientFileDescriptor() a ScopedFD.morrita2014-10-201-1/+1
| | | | | | | | | | | | | By using base::ScopedFD, the ownership of the returned FD becomes clearer. BUG=415294 R=brettw@chromium.org, jam@chromium.org, yzshen@chromium.org, sehr@chromium.org TBR=gene@chromium.org Review URL: https://codereview.chromium.org/621613002 Cr-Commit-Position: refs/heads/master@{#300381}
* Replace OVERRIDE and FINAL with override and final in ↵anand.ratn2014-10-072-16/+16
| | | | | | | | | | content/ppapi_plugin/[a-s]* BUG=417463 Review URL: https://codereview.chromium.org/636493002 Cr-Commit-Position: refs/heads/master@{#298460}
* content: Rename all classes with WebKitPlatform to BlinkPlatform.tfarina2014-10-055-64/+66
| | | | | | | | | | BUG=359244 TEST=None R=avi@chromium.org Review URL: https://codereview.chromium.org/628793003 Cr-Commit-Position: refs/heads/master@{#298176}
* Remove implicit HANDLE conversions from content.rvargas2014-09-251-1/+1
| | | | | | | | | | BUG=416722 R=piman@chromium.org TBR=cpu@chromium.org (sandbox_win.cc) Review URL: https://codereview.chromium.org/606463002 Cr-Commit-Position: refs/heads/master@{#296603}
* PPAPI: Fix GetBrowserInterface race conditionsdmichael2014-09-181-2/+2
| | | | | | | | | | | | | | - Previously, we had an unguarded bool flag for whether an interface lookup had been logged to UMA. Now each InterfaceInfo has a lock+flag. Should be near-zero contention. - Previously, PpapiGlobals::GetBrowserSender did lazy creation with no synchronization. Now we create it at process startup and clear it at process shutdown, so there should be no race while the plugin is running. BUG=413513,414150 Committed: https://crrev.com/d1b2c8f719b0ab471a476bf53911a3657bb4c06a Cr-Commit-Position: refs/heads/master@{#294715} Review URL: https://codereview.chromium.org/568793002 Cr-Commit-Position: refs/heads/master@{#295551}
* Revert of [Mac] Implement a new WebSandboxSupport method to get the ↵noel2014-09-151-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | display's color space. (patchset #1 id:1 of https://codereview.chromium.org/549213004/) Reason for revert: Not needed, used https://codereview.chromium.org/554033002 instead. Original issue's description: > [Mac] Implement a new WebSandboxSupport method to get the display's color space. > > This new interface is defined at https://codereview.chromium.org/554033002/. > > BUG=397642,306348 > R=avi@chromium.org > > Committed: https://crrev.com/b6ae4d0ecc983a71a32ab1480a70e065c718c195 > Cr-Commit-Position: refs/heads/master@{#293852} TBR=avi@chromium.org,rsesek@chromium.org NOTREECHECKS=true NOTRY=true BUG=397642,306348 Review URL: https://codereview.chromium.org/563943003 Cr-Commit-Position: refs/heads/master@{#294786}
* Revert of PPAPI: Fix GetBrowserInterface race conditions (patchset #6 ↵raymes2014-09-151-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:100001 of https://codereview.chromium.org/568793002/) Reason for revert: Sorry to revert but I randomly noticed this to be causing a top crasher e.g. go/crash/75090c1e31f33cfd The reason is because the patch explicitly calls PluginGlobals::SetPluginProxyDelegate with NULL from PpapiThread::Shutdown but the pointer is used immediately inside the function. I guess it should be a simple fix. I was going to put up a fix which just reset the browser_sender_ to NULL in that case, but then I noticed there were cases where we call GetBrowserSender() and use it without checking whether it is NULL (e.g. https://code.google.com/p/chromium/codesearch#search/&q=%22PluginGlobals::Get()-%3EGetBrowserSender()-%3ESend%22&sq=package:chromium&type=cs) I felt it would be better to just revert for now, sorry :( Original issue's description: > PPAPI: Fix GetBrowserInterface race conditions > > BUG=413513 > > Committed: https://crrev.com/d1b2c8f719b0ab471a476bf53911a3657bb4c06a > Cr-Commit-Position: refs/heads/master@{#294715} TBR=teravest@chromium.org,piman@chromium.org,dmichael@chromium.org NOTREECHECKS=true NOTRY=true BUG=413513 Review URL: https://codereview.chromium.org/566243004 Cr-Commit-Position: refs/heads/master@{#294782}
* PPAPI: Fix GetBrowserInterface race conditionsdmichael2014-09-131-2/+2
| | | | | | | | BUG=413513 Review URL: https://codereview.chromium.org/568793002 Cr-Commit-Position: refs/heads/master@{#294715}
* Make chrome GN build work in component mode.Brett Wilson2014-09-111-0/+4
| | | | | | | | | | This also fixes a resources regression (added extensions resources) that caused chrome not to run. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/554393009 Cr-Commit-Position: refs/heads/master@{#294406}
* [Mac] Implement a new WebSandboxSupport method to get the display's color space.rsesek2014-09-091-0/+7
| | | | | | | | | | | This new interface is defined at https://codereview.chromium.org/554033002/. BUG=397642,306348 R=avi@chromium.org Review URL: https://codereview.chromium.org/549213004 Cr-Commit-Position: refs/heads/master@{#293852}
* Change base/file_utils.h includes to base/files/file_utils.h in content/thestig2014-09-052-2/+2
| | | | | | | | TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/538403002 Cr-Commit-Position: refs/heads/master@{#293559}
generated by cgit v1.1 at 2025-01-11 18:24:47 +0000