| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This fixes the following logcat error:
E/SpannableStringBuilder(14995): SPAN_EXCLUSIVE_EXCLUSIVE spans cannot have a zero length
BUG=229809
Review URL: https://chromiumcodereview.appspot.com/13820016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EnsureEndsWithSeparator used to check whether the file existed. This seems bad and unnecessary so I removed it.
I removed file_util::ContainsPath and used the existing file_util::IsParent instead. The functions descriptions are the same but the implementations do slightly different things, which is worrying. The only non-test use of this function to worry about is content/browser/storage_partition_impl_map.cc. As far as I see, the requirements for this seem OK, but I'm not very familiar with this.
After some discussion with akalin, I changed sync/internal_api/sync_manager_impl.cc to be a DCHECK that the path is absolute rather than make it absolute. The old code relied on the behavior of the old function that the argument would be unchanged if the file didn't exist, and this (possibly relative) path would be used later. This behavior doesn't make a lot of sense, and it looks like now that the path is always absolute, so I replaced this call with a DCHECK.
BUG=
Review URL: https://codereview.chromium.org/13196006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string_piece.h was moved into base/strings/ in r191206 -
https://chromiumcodereview.appspot.com/12982018/
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13892006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cleaning up the content/public/android/java/src/.. ../content/browser/
directory by moving input related classes to a separate directory.
BUG=230059
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14100003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
kStorageTypeSyncable.
This bug is visible in Android for mail.google.com
Even after Clearing all the data, the syncable data was left behind.
This CL should fix this bug.
BUG=180249
Review URL: https://chromiumcodereview.appspot.com/13357004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change Month picker to use non deprecated APIs
Remove a member variable that should really be a local one
No changes in functionality
BUG=227198
Review URL: https://chromiumcodereview.appspot.com/13789003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Turns on the corresponding setting in Blink for AW.
Review URL: https://chromiumcodereview.appspot.com/13814013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Accessibility notifications use are posted on an HWND,
giving it the id of the target object. In Win Aura, a
single HWND contains both Views UI and one or more
RWHVs, so requests for accessibility objects on the
Views-owned HWND now need to be routed to the
correct RWHV. To do this, each views::WebView registers
itself with the views accessibility code.
In addition, this change defines separate id-spaces for the ids
used by Views and web. No need for anything more complicated.
(Depends on https://codereview.chromium.org/13770015/)
BUG=175156
Review URL: https://chromiumcodereview.appspot.com/13598027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For normal APKs, the build generates a list of libraries to load at
build time and this is used at runtime to load libraries. Update our
gtest APKs to use this.
This makes gtest APKs work in the component build.
BUG=158821
Review URL: https://chromiumcodereview.appspot.com/13962003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As of https://chromiumcodereview.appspot.com/12665004, LocaleUtils depends on base_i18n
and hence can't live in base anymore. This is actually a better place for it as it's
alongside similar code for other ports.
BUG=158821
TBR=ben,mark
Review URL: https://chromiumcodereview.appspot.com/13465018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=149661
Review URL: https://codereview.chromium.org/13862016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/13427006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was originally put in that file for ease of modification of the
downloads public content API during the downloads refactor. The
refactor has quieted down, and I'm no longer working on downloads, so
I'm removing myself to get away from getting other
content/public/browser reviews from people who don't read the note in
the file :-}.
Review URL: https://chromiumcodereview.appspot.com/13912005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/12722002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For apps using ContentViewRenderView, make it possible to inject
SurfaceView object that ContentViewRenderView will use. Provide
default operation which just creates a new SurfaceView object.
BUG=229369
R=yfriedman@chromium.org
TBR=yfriedman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13812009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=170921
Review URL: https://codereview.chromium.org/13875002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now, Chrome doesn't need --disable-web-sockets flag any more.
This flag was added due to security concern in early days.
BUG=none
TEST=layout tests, browser_tests, net_unittests, and so on
Review URL: https://chromiumcodereview.appspot.com/13913004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content::InternalDocumentStateData.
BUG=none
TEST=none (cleanup).
R=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13722005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
access is pretty much the same as
PROCESS_ALL_ACCESS
http://msdn.microsoft.com/en-us/library/ms684880(v=vs.85).aspx
Change valid callers to OpenProcessHandle to call
OpenPrivilegedProcessHandle instead
also fix small handle leak in
ChromeFrameMemoryTest::GetMemoryConsumptionDetails
A separate bug will be raised to go through all
calls to OpenPrivilegedProcessHandle and examine
whether they actually need this level of access and if not
change call to OpenProcessHandleWithAccess with minimum rights
needed to perform the operations
BUG=226430
TBR=grt, yoshiki, jar
Review URL: https://chromiumcodereview.appspot.com/13598009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6.
Revert "Fix build after r193020."
This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a.
Revert "Really fix build after r193020."
This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This works by adding a new flag to the content layer:
kDisableHTMLNotifications, which causes Chrome not to expose the
webkitNotifications.createHTMLNotification function to JS contexts.
Chrome appends this switch to new renderer processes when appropriate
in ChromeContentBrowserClient.
BUG=225918
Review URL: https://chromiumcodereview.appspot.com/13533019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the just the WebUI code necessary to show HTML at the chrome://indexeddb-internals
URL. The page just says "Welcome" to start.
BUG=174188
Review URL: https://chromiumcodereview.appspot.com/13230003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=228978,228897
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13771021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DevTools are always enabled in Content.
R=pfeldman
BUG=None
Review URL: https://chromiumcodereview.appspot.com/13529010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Earlier we used to pass all the relevant bits to WebContentsDelegate::CanDownload
This also allows for DownloadRequestLimiter to work on Android (show the infobar when multiple downloads are initiated from a page)
BUG=
Review URL: https://chromiumcodereview.appspot.com/13649009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content's embedder API. The main reasons are that it makes content's embedder interfaces harder to change if they're reused by the embedder, and that its makes it confusing for embedder code when there are multiple ways to do the same thing.
BUG=227047
Review URL: https://codereview.chromium.org/13409003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=224923
Review URL: https://chromiumcodereview.appspot.com/13510002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the browser cache for a given profile is cleared
we will now clear out any shaders stored in the
shader disk cache for that profile.
BUG=176289
Review URL: https://chromiumcodereview.appspot.com/12500009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add ContentViewCore#udpateFrameInfo trace event.
BUG=
Review URL: https://chromiumcodereview.appspot.com/13688003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=223664
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/13537003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The SystemMonitor is a mixed monitor which not only monitors
the power state changes but also the devices changes. This
patch is to separate the power monitor from SystemMonitor
as a new class PowerMonitor which is dedicated to monitor
power state.
The next step is to seek a opportunity to refactor SystemMonitor
as something like DeviceMonitor.
BUG=149059
TEST=base_unittests --gtest_filter=PowerMonitorTest.*
Review URL: https://chromiumcodereview.appspot.com/10959020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=145881
Review URL: https://chromiumcodereview.appspot.com/12493012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13392008
TBR=brettw (for oneliners outside webui)
This change splits chrome-devtools:// handler into the one serving chrome-devtools://devtools (for embedded) and chrome-devtools://remote (for remote) front-ends. It also remove command line check for remote/ path.
Drive-by: move url constants from content/ to chrome/, remove legacy data source registration.
Review URL: https://codereview.chromium.org/13465007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Exposed event:
event.type = 'download'
event.requestMethod = 'GET'/'POST'...
event.url = url
BUG=141204
TEST=Pending: osx + win (b/c there is a *ViewGuest change).
Added browser_tests:WebViewTest.Download, ran unit_tests:DownloadRequestLimiterTest*
Review URL: https://chromiumcodereview.appspot.com/13037003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous patch was reverted. Problem has been fixed (see comment in CL).
Original CL here: https://codereview.chromium.org/12770031/
TBR=ben@chromium.org, joi@chromium.org
(ben - gypis, joi - public/browser/ comment update)
BUG=159265
Review URL: https://chromiumcodereview.appspot.com/13393015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Miscellaneous missing dependencies and a few more exports.
BUG=158821
Review URL: https://chromiumcodereview.appspot.com/12988003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Truly small follow-up from r191695.
No functional changes.
BUG=
Review URL: https://chromiumcodereview.appspot.com/13469003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Before, we limit to manage 32 features. Now we can manage as many as we want.
BUG=222857
TEST=content_unittests, waterfall
Review URL: https://codereview.chromium.org/13240002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In our current html5 media implemtation, we pretend everything is loaded and gave a temporary duration of 100 seconds to WebKit.
However, this will break things if developer do sth like video.seek(video.duration). Also, width and height information are not available.
This change adds a thread in browser process to extract media metadata from the elements, before reporting to WebKit that media is loaded.
This only works if wifi or ethernet is available.
Review URL: https://chromiumcodereview.appspot.com/12518035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is required to let TV (large screen) device have tablet UI. Additional
changes necessary to layout resources will be handled separately.
BUG=157371
Review URL: https://chromiumcodereview.appspot.com/13135002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At build time, we know what native libraries an apk needs to load.
Instead of requiring those .apks to specify this again in code, instead
generate a .java file containing a list of the libraries to load.
This is done using a pattern similar to resources, content_java is built
with a placeholder NativeLibraries.java (i.e. without an actual value
for its libraries list). The corresponding .class file is not included
in content_java.jar. Then, when building an apk we generate the "real"
NativeLibraries.java (with the real String[]) and include that in the
.apk.
This is designed to also support the component build, where, we will
have to calculate the list of libraries at build time, and sort them in
dependency order (because Android's linker, for some reason, doesn't do
that itself).
BUG=158821
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12939021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks to be slightly less flaky than its sister test, but something definitely seems
to be up with scrolling in general.
BUG=224458
Review URL: https://chromiumcodereview.appspot.com/13392017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interesting. Interesting being the first paint after a non-empty
layout.
BUG=none
TEST=none
R=simonjam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13220003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Both GetOSFileDescriptor and RequestOSFileHandle use GetOSFileDescriptor
chrome IPC for now. I'm planning to remove call sites of
GetOSFileDescriptor PPAPI and rename GetOSFileDescriptor chrome IPC to
RequestOSFileHandle.
- Add --allow-get-os-file-handle-api. With this flag,
1. browser_tests can test this API and 2. we can use this API even
before this issue is resolved: http://crbug.com/224123
- Add TestRequestOSFileHandle in FileIO. This checks if read, write,
lseek, and mmap work for FD fetched by this API.
- PepperFileIOHost::OnHostMsgGetOSFileDescriptor use
ShareHandleWithRemote to pass a file handle
- Fix ShareHandleWithRemote for in-process API
BUG=183015
TEST=trybots, browser_tests
Review URL: https://chromiumcodereview.appspot.com/13032002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=jam
Review URL: https://chromiumcodereview.appspot.com/13305002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser_tests and unit_tests failures on many bots. For example:
IsolatedAppsManifestTest.IsolatedApps crashes here:
http://goo.gl/3iAgy
> Move AppIsolation out of Extension Class
>
> TBR=ben@chromium.org, joi@chromium.org
> (ben - gypis, joi - public/browser/ comment update)
> BUG=159265
>
>
> Review URL: https://chromiumcodereview.appspot.com/12770031
TBR=rdevlin.cronin@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben@chromium.org, joi@chromium.org
(ben - gypis, joi - public/browser/ comment update)
BUG=159265
Review URL: https://chromiumcodereview.appspot.com/12770031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This adds a "using" to the header to avoid having to update everything at once. However, all forward declares and the locations that use the forward declares need to be updated (since they don't see the using in message_loop.h).
BUG=
Review URL: https://codereview.chromium.org/13243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191566 0039d316-1c4b-4281-b951-d872f2087c98
|