| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
into one.
BUG=377169
TEST=None
Review URL: https://codereview.chromium.org/326403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=369531
TEST=everything still works
Review URL: https://codereview.chromium.org/263973003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves the creation of RenderFrameProxyHost earlier in the timeline of cross-process navigation. Instead of waiting until commit time, it creates it at the time SwapOut message is sent to the old RenderFrameHost.
It also creates the renderer-side RenderFrameProxy object. Since now both sides have proxies, when in swapped out state, RenderFrameHost and RenderFrame send their messages through the proxies. This both helps verify proxies exist and paves the way of removing the notion of swapping out frames.
BUG=357747
Review URL: https://codereview.chromium.org/281663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's only tracked to update the previous navigation entry just before update.
Now that HistoryController is tracked in Chromium, just sample before updating
HistoryController.
BUG=none
Review URL: https://codereview.chromium.org/266013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test is failing on the TSANv2 bot. From analysis it seems that an
assumption about the number of messages sent might not match reality
under some circumstances. To test that theory this change encodes
that assumption into the test. If the theory is true the new expectation
should fail on the failing bot.
TBR=avi
BUG=371865
Review URL: https://codereview.chromium.org/287513004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The motivation is for WebContentsObserver to pass RenderFrameHost* to message handlers easily.
As an example, an observer would look like this:
bool FooWebContentsObserver::OnMessageReceived(
const IPC::Message& message,
RenderFrameHost* render_frame_host) {
IPC_BEGIN_MESSAGE_MAP_WITH_PARAM(FooWebContentsObserver, message, RenderFrameHost, render_frame_host)
IPC_MESSAGE_HANDLER(FooHostMsg_Bar, OnBar)
.
.
.
void FooWebContentsObserver::OnBar(RenderFrameHost* render_frame_host, ...
You can of course still have dispatchers without the extra parameter as before.
This is generalizing the existing code that allows an IPC message handler to have a "const IPC::Message& message) first parameter to get access to the IPC.
Sync IPCs don't support this yet. It's a lot more work because for them we conveniently reuse tuple's DispatchToMethod. This isn't urgent yet, since sync IPCs aren't dispatched on the UI thread for the most part because of NPAPI and Windows, so punting on this for now.
BUG=304341
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/283623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=308321
Review URL: https://codereview.chromium.org/251903006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PageStateToHistoryEntry was returning a raw pointer to an object that it
allocated, expecting all callers to manage its lifetime, and this test wasn't.
Change PageStateToHistoryEntry to return a scoped_ptr<HistoryEntry>, and use
scoped_ptrs in some other places to ensure future correct usage.
BUG=368798
TEST=No more leak
Review URL: https://codereview.chromium.org/267503006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
HistoryEntry is now used to store the history tree.
BUG=
Review URL: https://codereview.chromium.org/248013003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The only reason it is in content/public/ is so that content/shell can dump
history state for testing. Move back/forward list dumping to content/test/.
BUG=
Review URL: https://codereview.chromium.org/246163006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23581
Review URL: https://codereview.chromium.org/246553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=346764
Review URL: https://codereview.chromium.org/238033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, all history state updates are initiated from content/renderer, but are implemented in blink's Source/core/page. This moves the HistoryController class to content/renderer/, hangs it off of RenderViewImpl, and updates it to use chromium types.
I tried to change as little as possible in the logic of the code compared to src.chromium.org/viewvc/blink/trunk/Source/core/page/HistoryController.cpp.
This is step 4 of 5 in http://crbug.com/357327
BUG=357327
Review URL: https://codereview.chromium.org/229283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=scottmg@chromium.org
TBR=ben
Review URL: https://codereview.chromium.org/233263005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=297026
R=ben@chromium.org
Review URL: https://codereview.chromium.org/231733005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=346764
Review URL: https://codereview.chromium.org/229253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This leaves the state in RenderViewHost for now, to make this an easier
first step.
BUG=304341
TEST=No behavior change.
R=nasko@chromium.org
Review URL: https://codereview.chromium.org/208243019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extendSelectionAndDelete on WebFrame instead of WebView.
BUG=304341
R=nasko@chromium.org
Review URL: https://codereview.chromium.org/213283006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=309681
Review URL: https://codereview.chromium.org/184803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the edit commands to RenderFrame.
BUG=304341
R=nasko@chromium.org
Review URL: https://codereview.chromium.org/207253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
duplication of code in the browser test harness for setting up the browser process, and also ensures that initialization code in ContentMainRunner runs.
Most of the changes are to unit tests which run in browser test executables. These were getting all the setup that these binaries did for browser tests even though they were unit tests. Now they have to explicitly setup objects that they need. This would be done automatically if they were in a unit test binary and therefore using the unit test harness. The goal should be to move these tests to unit test binaries, and make them support launching some tests in separate processes building on the work that Pawel did.
BUG=350550
R=sky@chromium.org
Review URL: https://codereview.chromium.org/190663012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes WideToASCII and changes all callers to use UTF16ToASCII instead.
Moves UTF16ToASCII from base/strings/string_util.h to base/strings/utf_string_conversions.h and into the base namespace.
Convert a few related string_util functions to take a StringPiece16 instead of a string16. Remove IsStringASCII(std::wstring) which was unused.
Updates callers' includes and namespace usage accordingly.
TBR=sky
Review URL: https://codereview.chromium.org/176843022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This teaches LoadProgressTracker about multiple frames loading at once and has it calculate progress as the product of all the individual frames' progresses.
RenderViewImpl has didStartLoading()/didStopLoading() shims still in place, which call the new RenderFrameImpl versions, which in turn call permanent versions in RenderViewImpl. RenderViewImpl's shims are marked as deprecated and will be deleted once blink calls RenderFrameImpl directly in https://codereview.chromium.org/183793002/.
BUG=347643
Review URL: https://codereview.chromium.org/180113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=285976
Review URL: https://codereview.chromium.org/183993004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like it wasn't responsible, and we've re-landed r249676 as well.
> Revert 251563 "Move browser initiated navigation from RenderView..."
>
> Speculatively revert to help diagnose bug 345757.
> Mainly useful to make it easier to revert r249676, which changes the
> lifetime of RenderViewHosts.
>
> > Move browser initiated navigation from RenderViewHost to RenderFrameHost.
> >
> > BUG=304341
> > TBR=jochen@chromium.org
> >
> > Review URL: https://codereview.chromium.org/148083013
>
> TBR=nasko@chromium.org
>
> Review URL: https://codereview.chromium.org/177713006
TBR=nasko@chromium.org, ajwong@chromium.org
Review URL: https://codereview.chromium.org/181113009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WebDocument::clearFocusedNode is a deprecated Api, move chromium to new api clearFocusedElement.
BUG=258763
Review URL: https://codereview.chromium.org/177863007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculatively revert to help diagnose bug 345757.
Mainly useful to make it easier to revert r249676, which changes the
lifetime of RenderViewHosts.
> Move browser initiated navigation from RenderViewHost to RenderFrameHost.
>
> BUG=304341
> TBR=jochen@chromium.org
>
> Review URL: https://codereview.chromium.org/148083013
TBR=nasko@chromium.org
Review URL: https://codereview.chromium.org/177713006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=304341
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/148083013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
builders.
(It uses --single-process, which is disabled on branded builders.)
BUG=342418
Review URL: https://codereview.chromium.org/161093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Another attempt at landing this. Original CL is https://codereview.chromium.org/135723003/ and patchset 1 is identical to it.
BUG=304341
Review URL: https://codereview.chromium.org/132743011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=341745
TBR=rdsmith
Review URL: https://codereview.chromium.org/139233007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move DidCommitProvisionalLoad code from RenderView to RenderFrame.
>
> BUG=304341
> R=creis@chromium.org
>
> Review URL: https://codereview.chromium.org/135723003
Casuses a UAF on ASAN bots in SigninBrowserTest.SigninSkipForNowAndGoBack
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22688/steps/browser_tests/logs/stdio
TBR=nasko@chromium.org
Review URL: https://codereview.chromium.org/152143010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through to error page. Specifically, add a "stale_copy_in_cache" argument to all of (ordered from Browser->Renderer):
* ResourceMsg_RequestComplete IPC message.
* ResourceDispatcher::OnRequestComplete
* ResourceLoaderBridge::Peer::OnCompletedRequest.
* All subclasses of RLB::P::OnCompleted Request, including WebURLLoaderImpl::context::OnCompletedRequest.
* Blink WebURLError and ResourceError classes (https://codereview.chromium.org/138493002).
* LocalizedError::GetStrings.
This is a paired commit with the blink CL
https://codereview.chromium.org/138493002. That CL must be landed before this one.
BUG=329620
Review URL: https://codereview.chromium.org/138513002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=304341
R=creis@chromium.org
Review URL: https://codereview.chromium.org/135723003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The selection code will have to move as well. That will happen in future changes.
BUG=304341
R=nasko@chromium.org
Review URL: https://codereview.chromium.org/130773004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android requires us to call restart input when input node changes.
Previously we relied on onHandleGesture which is not the right way
to do it.
BUG=242715
Review URL: https://codereview.chromium.org/56643003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for using the new LinkDoctor API.
BUG=308232
R=darin@chromium.org, tsepez@chromium.org, ttuttle@chromium.org
Review URL: https://codereview.chromium.org/67283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding this parameter lets the same object act as an observer for multiple
RenderFrames.
BUG=329618
TEST=unit,trybot
Review URL: https://codereview.chromium.org/134183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=304341
Review URL: https://codereview.chromium.org/118553006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ResourceLoader and SSLClientAuthHandler.
BUG=304341
R=nasko@chromium.org
TBR=mkosiba
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242656
Review URL: https://codereview.chromium.org/120413003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetAssociatedRenderFrame in ResourceLoader and SSLClientAuthHandler."
This reverts commit 6952f00643ee2d1a58177dd90f35e3542690cc87.
Gardening. This patch breaks 33 layout tests
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/encoding/mailto-always-utf-8.html,fast/forms/mailto/advanced-get.html,fast/forms/mailto/advanced-put.html,fast/forms/mailto/formenctype-attribute-button-html.html,fast/forms/mailto/formenctype-attribute-input-2.html,fast/forms/mailto/formenctype-attribute-input-html.html,fast/forms/mailto/get-multiple-items-text-plain.html,fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html,fast/forms/mailto/get-multiple-items.html,fast/forms/mailto/get-non-ascii-always-utf-8.html,fast/forms/mailto/get-non-ascii-text-plain-latin-1.html,fast/forms/mailto/get-non-ascii-text-plain.html,fast/forms/mailto/get-non-ascii.html,fast/forms/mailto/get-overwrite-query.html,fast/forms/mailto/post-append-query.html,fast/forms/mailto/post-multiple-items-multipart-form-data.html,fast/forms/mailto/post-multiple-items-text-plain.html,fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html,fast/forms/mailto/post-multiple-items.html,fast/forms/mailto/post-text-plain-with-accept-charset.html,fast/forms/mailto/post-text-plain.html,fast/loader/onload-policy-ignore-for-frame.html,fast/loader/reload-policy-delegate.html,http/tests/download/basic-ascii.html,http/tests/download/default-encoding.html,http/tests/download/inherited-encoding-form-submission-result.html,http/tests/download/inherited-encoding.html,http/tests/download/literal-utf-8.html,http/tests/history/back-to-post.html,http/tests/media/media-source/mediasource-remove.html,http/tests/misc/policy-delegate-called-twice.html,http/tests/navigation/post-redirect-get-reload.php,http/tests/security/feed-urls-from-remote.html
BUG=
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/101723004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ResourceLoader and SSLClientAuthHandler.
BUG=304341
R=nasko@chromium.org
Review URL: https://codereview.chromium.org/120413003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/102993018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=329295
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/113403006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/121033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a FaviconDownloader which downloads all icons
when creating streamlined hosted apps from the current web
contents, providing higher resolution icons.
BUG=318607
Review URL: https://codereview.chromium.org/64853004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jam@chromium.org
BUG=none
TESTS=more
Review URL: https://codereview.chromium.org/109793004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/102593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These IPCs correspond to Javascript IME API events
(oncandidatewindow*) defined in
https://dvcs.w3.org/hg/ime-api/raw-file/8c061ee19f99/Overview.html#inputmethodcontext-interface
They will fire when IME candidate window changes its appearance.
The Blink side of the change is already checked in:
https://src.chromium.org/viewvc/blink?revision=161139&view=revision
This is the Chromium part of sending IPCs to renderer and
a test for both Chromium and Blink code path, which is not
covered by blink r161139.
The whole change FYI is worked on at
https://codereview.chromium.org/80583002/
and other CLs (to generate actual events from IMEs etc.)
will follow.
BUG=238585
TEST=content_browsertests --gtest_filter="RenderViewImplTest.SendCandidateWindowEvents"
Review URL: https://codereview.chromium.org/84963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1) RenderViewImplTest::SendKeyEvent fabricates native events for each platform, creates a NativeWebKeyboardEvent and sends it. Running the tests with Ozone would fall through to the NOTIMPLEMENTED case. Added an Ozone implementation to process these events.
2) MakeWebKeyboardEventFromAuraEvent for Ozone did not process the character passed in. This would result in passing the raw character rather than processing any control keys (such as shift).
BUG=315392
Review URL: https://codereview.chromium.org/92693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237851 0039d316-1c4b-4281-b951-d872f2087c98
|