| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=164095
Review URL: https://chromiumcodereview.appspot.com/11567054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is very similar to base::JSONReader::Read() except that it allows
trailing commas and EXPECT-fails with a good message when the json is
malformed.
I migrated two tests to use this as a demonstration that it's widely
useful and makes things more readable.
Review URL: https://chromiumcodereview.appspot.com/11567027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=104704
Review URL: https://chromiumcodereview.appspot.com/11576028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit ceb4a0908420fc4ce217e96795d682128f22c3c8.
https://chromiumcodereview.appspot.com/11316342/
The fix should land when WebKit rolls, so this workaround won't be
necessary anymore.
BUG=165436
TBR=jamesr
Review URL: https://chromiumcodereview.appspot.com/11575048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the bulk of message handling in BrowserPluginmanager to BrowserPlugin.
This is not just code simplification. This change will enable a more extensible
BrowserPlugin by allowing observers to intercept messages on specific instances
of BrowserPlugin and perform custom behavior or simply add more behavior
to specific instances of BrowserPlugin.
BUG=166165
Review URL: https://codereview.chromium.org/11565024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/11565050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- crash when calling exit(), _exit() and ExitProcess() in Pepper Flash process.
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/11565026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This necessitated the relocation of the previous chrome::GrabWindowSnapshot code
to ui/snapshot, which has been turned into it's own component to avoid circular dependencies with aura.
A new variant of GrabWindowSnapshot, GrabViewSnapshot, has been added as well to facilitate easier usage by views. chrome::GrabWindowSnapshotForUser was left in place to accomodate existing calls
to the API, but now calls up to the ui/snapshot code.
This is a subset of the prior CL 11362023, which has been broken apart to facilitate easier reviews
BUG=157479
Review URL: https://chromiumcodereview.appspot.com/11399002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
__Now__ renderer side mixing is enabled on Mac :-/
BUG=162768
TEST=audio works, tests pass.
TBR=sky
Review URL: https://codereview.chromium.org/11411189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Previously if you made a new Graphics2D, bound it, and deleted the previous one, the first one would blindly unbind the current graphics 2D context in its destructor, which leaves you with a blank page.
BUG=164302
Review URL: https://codereview.chromium.org/11571016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Sync Ime and Keyboard events.
>
> Adding code to sync ime and keyboard events to make sure they arrive to
> renderer in correct order. Ime events will be queued in the input_event_filter
> if the message_ queue is not empty (Compositor is handling those events). If
> the queue is empty, then the message will not be accepted and just forwared
> directly to renderer.
>
> BUG=164470
>
>
> Review URL: https://chromiumcodereview.appspot.com/11490017
TBR=aurimas@chromium.org
BUG=166175
Review URL: https://codereview.chromium.org/11577024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Overview:
=========
This patch ensures that a user can add a local media stream to an audio/video element and render the captured audio locally (in loopback).
Details:
========
Our current architecture is a bit hairy but I've done my best to add the new code in a structured way. I have an issue in crbug assigned to myself to refactor the code in this area since we really must improve and make it less complex to work with.
One more client now implements the webkit_media::MediaStreamAudioRenderer and this client is
called WebRtcLocalAudioRenderer (WLAR).
The WLAR is created by the WebMediaPlayer when a local media stream is generated and this will ensure that the controls for a media element becomes visible.
The main action takes place in WebRtcLocalAudioRenderer::Start() where I have gathered all the main stuff. This method is the best starting point for understanding the new data flow.
A reference to an existing WebRtcAudioCapturer (WAC) (owned by the WebRTC ADM) is given to the WLAR at construction. Calling Start =>
- WLAR connects itself to the WAC using the WAC pointer from construction
- render audio parameter are copied from the capture side (since output does resampling etc.)
- creates and inits a new AudioOutputDevice (AOD)
- starts the capturer and the new AOD
Media flow:
-----------
Data is recorded and fed to the WAC which knows that it is in "loopback mode". The WAC then stores recorded data in a FIFO. The WLAR consumes audio from the FIFO when the AOD needs data to render. The WLAR reads data from the FIFO using a callback.
Testing procedure:
==================
Main testing was done using a new WebRCT demo at https://www.corp.google.com/~henrika/webrtc/gum4.html.
I also tried all other demos at https://webrtc-demos.appspot.com/ and the htp://apprtc.appspot.com demo.
For all cases, debug filters were used to track things like calling sequences etc.
BUG=157142
Review URL: https://codereview.chromium.org/11450029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/11533004/)
Original description:
Add a flag that controls if RTCDataChannels can be created or not;
as well as basic usage of it.
BUG=165426
Review URL: https://codereview.chromium.org/11570025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal is to display an infobar for the user when when the NaCl
manifest does not have an entry for nexe usable on the user's
architecture (e.g. if the user is on arm but only x86 nexes have
been built).
This CL is the plumbing from the NaCl plugin (which actually
checks the manifest) into the browser process UI thread, which
can actually do the UI.
R=
sehr@chromium.org/jvoung@chromium.org (plugin, nacl_host)
brettw@chromium.org (ppapi/, chrome/renderer/pepper, chrome/browser/renderer_host)
jschuh@chromium.org (chrome/common)
BUG=154121
Review URL: https://chromiumcodereview.appspot.com/11446081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=159688
TEST=Click back soon after going from NTP to Chrome Web Store in debug build.
Review URL: https://chromiumcodereview.appspot.com/11555040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=157357
TEST=RenderViewImpl tests pass on bots.
Review URL: https://chromiumcodereview.appspot.com/11550029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is extracted from a larger CL created by scherkus@: https://codereview.chromium.org/11468033/
BUG=none
TEST=media_unittests pass
Review URL: https://chromiumcodereview.appspot.com/11564007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is an existing serializer/deserializer for WebInputEvent (used
for plugins). Use that everywhere else, instead of reading/writing
directly into the IPC message.
BUG=164682
Review URL: https://codereview.chromium.org/11471022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=143155
TEST=See repro steps in 165124.
Review URL: https://chromiumcodereview.appspot.com/11550028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Refactor 4 PPB_Flash functions to the new PPAPI resource model.
>
> The functions being refactored are:
> -SetInstanceAlwaysOnTop
> -DrawGlyphs
> -GetProxyForURL
> -Navigate
>
> Each of these functions was manually tested with a Flash movie that uses it.
>
> Review URL: https://chromiumcodereview.appspot.com/11510008
TBR=raymes@chromium.org
Review URL: https://codereview.chromium.org/11576016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
navigation entry, which is correct if the redirect happens while the page is still loading but incorrect if the page has already finished loading. For each cross-site navigation, we further check whether the redirection happens before or after page finishes loading.
BUG=164419
Review URL: https://chromiumcodereview.appspot.com/11446070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: This cl is dependent on a libjingle roll and an updated WebKit version.
WebRtc issue http://code.google.com/p/webrtc/issues/detail?id=876
BUG= 165426
TEST= manual test with the test page in https://codereview.chromium.org/11316187/
Review URL: https://chromiumcodereview.appspot.com/11411195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The functions being refactored are:
-SetInstanceAlwaysOnTop
-DrawGlyphs
-GetProxyForURL
-Navigate
Each of these functions was manually tested with a Flash movie that uses it.
Review URL: https://chromiumcodereview.appspot.com/11510008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=165698
Test=Manual, see repro steps in bug
Review URL: https://chromiumcodereview.appspot.com/11547017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser process on Windows.
The browser process IO thread can be busy at startup time. This saves about 20ms to allocate the first command buffer.
Refactored so PepperPluginDelegateImpl and PrintWebViewHelper use the same function to allocate shared memory.
BUG=163215
Review URL: https://codereview.chromium.org/11469015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=111316
TEST=http/tests/inspector/appcache passes
R=marja@chromium.org,jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11442050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=140205
Review URL: https://codereview.chromium.org/11545003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
passwords during account creation. Note that for the entire feature to work we also need to ignore autocomplete=off when autofill manager is autofilling the generated passwords during log-in, which will be addressed in later CLs.
BUG=120779
Review URL: https://chromiumcodereview.appspot.com/11446028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason, this pathway broke recently on Android; it was previously
broken on ChromeOS. Comment out the line while the real cause is tracked
down.
This has the side effect of causing all pages to be zoomed in and scrolled to
the top of the page after flipping user agents, but at least the page is
usable.
BUG=165436
Review URL: https://chromiumcodereview.appspot.com/11316342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The new version adds support for data channel in WebRTC.
Review URL: https://codereview.chromium.org/11549003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=111316
TEST=all gamepad/ layout tests pass
R=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11280314
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Credit: Thanks to sadrul@ for pointing out this change to plugins to me.
BUG=164975, 164667
Test=Manually, turned on threaded-compositing.
Review URL: https://chromiumcodereview.appspot.com/11534018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ensureBackbuffer rename
Fix for r171908
BUG=
Review URL: https://codereview.chromium.org/11530017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows the getStats call in webkit to be relayed to the getStats call
in libjingle.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11308167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding code to sync ime and keyboard events to make sure they arrive to
renderer in correct order. Ime events will be queued in the input_event_filter
if the message_ queue is not empty (Compositor is handling those events). If
the queue is empty, then the message will not be accepted and just forwared
directly to renderer.
BUG=164470
Review URL: https://chromiumcodereview.appspot.com/11490017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and replacing it with a setSharedWorkerRepository() function that is
called once at initialization.
Review URL: https://chromiumcodereview.appspot.com/10990121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add MonitorDeviceChange().
- Change EnumerateDevices() to use PP_ArrayOutput.
- Update the video_capture manual test.
TEST=None
BUG=137799
Review URL: https://chromiumcodereview.appspot.com/11437036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flash sometimes needs to synchronously know if it can launch the broker, otherwise it will try to launch the broker when it shouldn't, and end up popping an infobar. This adds an IsAllowed function to synchronously test whether the broker is allowed to launch without popping the infobar.
Note that the document URL of the plugin instance is needed in order to check the broker permissions in the browser process. This is only available in the renderer process. In order to avoid an extra hop to the renderer process just to get this URL, it is sent to the browser (with the render view ID) upon initialization of the instance when the instance is registered with the browser process.
BUG=163248
Review URL: https://chromiumcodereview.appspot.com/11316316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we're dumping histograms from the page cyclers, we don't want to deal with
customized histograms
BUG=none
R=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11446073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Settings.
Steps to reproduce the problem:
1. Chromium has been updated after https://bugs.webkit.org/show_bug.cgi?id=101192 has been fixed that changes the WebKit-Chromium public API.
2. Activate the CSS Regions experimental WebKit feature.
3. Open a page that contains CSS Regions.
What is the expected behavior?
The CSS Regions code should be enabled.
What went wrong?
The CSS Regions code is not enabled.
BUG=164162
Review URL: https://chromiumcodereview.appspot.com/11444005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=164962
Review URL: https://chromiumcodereview.appspot.com/11474041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
model
The refactors PPB_Flash_File_ModuleLocal/FileRef to the new resource model. Calls for both these interfaces are now made directly to the browser. This removes the in-process implementation for these interfaces also (as they are flash-only). Tests are added for PPB_Flash_File_ModuleLocal.
Review URL: https://codereview.chromium.org/11359097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=avi@chromium.org
BUG=164614
Review URL: https://chromiumcodereview.appspot.com/11472003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves:
- WebKit::WebCompositorOutputSurface to cc::OutputSurface
- WebKit::WebCompositorOutputSurfaceClient to cc::OutputSurfaceClient
- Webkit::WebCompositorSoftwareOutputDevice to cc::SoftwareOutputDevice
They become new files in cc/ so they are chromified style. This affects
the various call-sites. This allows us to pass cc::CompositorFrame
directly, without any need for WebCompositorFrame.
BUG=146080
Depends on: https://bugs.webkit.org/show_bug.cgi?id=103967
Review URL: https://codereview.chromium.org/11348371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderThread::Get()->Send() fails if the tab is about to be closed and the IPC
channel was shut down.
BUG=158457
Review URL: https://chromiumcodereview.appspot.com/11473015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux/WebRenderTheme.h. Hopefully the last.
BUG=none
TEST=none
R=tony@chromium.org
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11468009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
WebContentsViewAura::WindowObserver::SendScreenRects. I'll make a larger change to get rid of RenderviewHostView caching in WebContentsView implementations later.
BUG=162981
Review URL: https://codereview.chromium.org/11476010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, if the guest is unresponsive, we kill the guest and return control back to the embedder.
This approach switches to asynchronous input events. The guest always swallows input events.
This CL also introduces 'unresponsive' and 'responsive' events.
BUG=149063, 153542
Test=BrowserPluginHostTest.GuestHung
Review URL: https://chromiumcodereview.appspot.com/11400002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=163876
Review URL: https://chromiumcodereview.appspot.com/11416315
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
causing renderer crashes on WinXP.
BUG=164506
TBR=scherkus
TEST=content_unittests --gtest_filter='MediaDispatcherTest.*'
Review URL: https://chromiumcodereview.appspot.com/11446037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171581 0039d316-1c4b-4281-b951-d872f2087c98
|