| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
Test=BrowserPluginHostTest.*, BrowserPluginTest.*, BrowserTagTest.*
Review URL: https://codereview.chromium.org/11234003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
loadCommit notifies that a load has committed with event properties "url" and "isTopLevel".
loadStop notifies that all loads in the tag (including all subframes) have completed, such that any progress indicator can complete, with no event properties.
BUG=154125, 153537
Review URL: https://chromiumcodereview.appspot.com/11035067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change removes a svn:executable property from a file added by r162643 <http://crrev.com/162643>.
TBR=shadi
BUG=none
TEST=check_perms
Review URL: https://codereview.chromium.org/11198057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
change.
BUG=156261
Review URL: https://chromiumcodereview.appspot.com/11121002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an implementation of HTML5-like postMessage support for the browser plugin.
It works as follows:
In BrowserPluginEmbedder:NavigateGuest, the browser process creates two swapped out RenderView: A swapped out RenderView for the guest in the embedder render process and a swapped out RenderView for the embedder in the guest render process.
The guest RenderView in the embedder process can be accessed via browserPlugin.contentWindow or through the MessageEvent object received from the guest, event.source.
The embedder RenderView in the guest process can be accessed through the MessageEvent object on message events, event.source.
BrowserPluginEmbedderHelper, and BrowserPluginGuestHelper intercept ViewHostMsg_RouteMessageEvent messages from the swapped out RenderViews and route them appropriately.
Note: BrowserPluginBindings now registers add/removeCustomEventListener instead of add/removeEventListener so that the default WebKit implementations are not shadowed by the custom implementations to allow for WebKit MessageEvents to be registered.
BUG=141238
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162353
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162487
Review URL: https://codereview.chromium.org/10829225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser tests.
Go with r162364. (r162563 removed it by accident).
Using dcommit to upload binary.
BUG=156261
TBR=ddorwin
Review URL: https://codereview.chromium.org/11188025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser tests.
Go with r162364. Using dcommit to upload binary.
BUG=156261
TBR=ddorwin
Review URL: https://codereview.chromium.org/11188025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The missing mapping for the recently-added DivRole was causing subtle bugs because those nodes were being ignored by VoiceOver.
The actual patch is small and trivial, it only updates enums - but this change also adds several new tests for the role mappings that were updated.
BUG=156377
Review URL: https://codereview.chromium.org/11185022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=155964
Review URL: https://codereview.chromium.org/11154025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an implementation of HTML5-like postMessage support for the browser plugin.
It works as follows:
In BrowserPluginEmbedder:NavigateGuest, the browser process creates two swapped out RenderView: A swapped out RenderView for the guest in the embedder render process and a swapped out RenderView for the embedder in the guest render process.
The guest RenderView in the embedder process can be accessed via browserPlugin.contentWindow or through the MessageEvent object received from the guest, event.source.
The embedder RenderView in the guest process can be accessed through the MessageEvent object on message events, event.source.
BrowserPluginEmbedderHelper, and BrowserPluginGuestHelper intercept ViewHostMsg_RouteMessageEvent messages from the swapped out RenderViews and route them appropriately.
Note: BrowserPluginBindings now registers add/removeCustomEventListener instead of add/removeEventListener so that the default WebKit implementations are not shadowed by the custom implementations to allow for WebKit MessageEvents to be registered.
BUG=141238
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162353
Review URL: https://codereview.chromium.org/10829225
TBR=fsamuel@chromium.org
Review URL: https://codereview.chromium.org/11185036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an implementation of HTML5-like postMessage support for the browser plugin.
It works as follows:
In BrowserPluginEmbedder:NavigateGuest, the browser process creates two swapped out RenderView: A swapped out RenderView for the guest in the embedder render process and a swapped out RenderView for the embedder in the guest render process.
The guest RenderView in the embedder process can be accessed via browserPlugin.contentWindow or through the MessageEvent object received from the guest, event.source.
The embedder RenderView in the guest process can be accessed through the MessageEvent object on message events, event.source.
BrowserPluginEmbedderHelper, and BrowserPluginGuestHelper intercept ViewHostMsg_RouteMessageEvent messages from the swapped out RenderViews and route them appropriately.
Note: BrowserPluginBindings now registers add/removeCustomEventListener instead of add/removeEventListener so that the default WebKit implementations are not shadowed by the custom implementations to allow for WebKit MessageEvents to be registered.
BUG=141238
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162353
Review URL: https://codereview.chromium.org/10829225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Browser Plugin: Add HTML5-like postMessage support
This is an implementation of HTML5-like postMessage support for the browser plugin.
It works as follows:
In BrowserPluginEmbedder:NavigateGuest, the browser process creates two swapped out RenderView: A swapped out RenderView for the guest in the embedder render process and a swapped out RenderView for the embedder in the guest render process.
The guest RenderView in the embedder process can be accessed via browserPlugin.contentWindow or through the MessageEvent object received from the guest, event.source.
The embedder RenderView in the guest process can be accessed through the MessageEvent object on message events, event.source.
BrowserPluginEmbedderHelper, and BrowserPluginGuestHelper intercept ViewHostMsg_RouteMessageEvent messages from the swapped out RenderViews and route them appropriately.
Note: BrowserPluginBindings now registers add/removeCustomEventListener instead of add/removeEventListener so that the default WebKit implementations are not shadowed by the custom implementations to allow for WebKit MessageEvents to be registered.
BUG=141238
Review URL: https://chromiumcodereview.appspot.com/10829225
TBR=fsamuel@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser tests.
BUG=156261
TBR=ddorwin
Review URL: https://chromiumcodereview.appspot.com/11188025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an implementation of HTML5-like postMessage support for the browser plugin.
It works as follows:
In BrowserPluginEmbedder:NavigateGuest, the browser process creates two swapped out RenderView: A swapped out RenderView for the guest in the embedder render process and a swapped out RenderView for the embedder in the guest render process.
The guest RenderView in the embedder process can be accessed via browserPlugin.contentWindow or through the MessageEvent object received from the guest, event.source.
The embedder RenderView in the guest process can be accessed through the MessageEvent object on message events, event.source.
BrowserPluginEmbedderHelper, and BrowserPluginGuestHelper intercept ViewHostMsg_RouteMessageEvent messages from the swapped out RenderViews and route them appropriately.
Note: BrowserPluginBindings now registers add/removeCustomEventListener instead of add/removeEventListener so that the default WebKit implementations are not shadowed by the custom implementations to allow for WebKit MessageEvents to be registered.
BUG=141238
Review URL: https://chromiumcodereview.appspot.com/10829225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=155639
TEST=All encrypted content_browsertests pass.
TBR=ddorwin
Review URL: https://codereview.chromium.org/11143004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows dragging content from within the embedder (or other windows) into
the browser-tag plugin.
BUG=120264
Review URL: https://codereview.chromium.org/11088043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=154831
Review URL: https://chromiumcodereview.appspot.com/11092023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=125390,138755
Review URL: https://codereview.chromium.org/11085008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=153536
TEST=browserTag.addEventListener('loadRedirect', f);
Review URL: https://chromiumcodereview.appspot.com/11028019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Old implementation will be togglable by a flag kEnableBrowserPluginOldImplementation.
There are two js shims to create shadow DOM for two implementations, since we need to handle src differently in new path.
This would also fix src attribute setting behavior in apps for the new path.
Pending
1. Write tests to verify set src attribute fix for apps in new implementation path.
BUG=153629,142379
TESTED=BrowserTest tests pending. Checked with platform app: a. set src initially. b. set src later via js using element.src c. set src later via js using elem.setAttribute('src', ...)
Review URL: https://chromiumcodereview.appspot.com/11052019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=153534
Review URL: https://chromiumcodereview.appspot.com/10941042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When two frames are replying to each other using event.source across processes,
after the first two replies, things break down. The root cause is that in
RenderViewImpl::GetFrameByMappedID, the lookup was incorrect. It is now
properly searching for the remote frame id and returning the local one.
BUG=153445
Review URL: https://chromiumcodereview.appspot.com/11040015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The browser process crashed because a CHECK that verifies that an existing browser_plugin_embedder_ does not yet exist fails.
This happens because CreateGuest should only be handled in WebContentsImpl on the first call to CreateGuest. On all subsequent calls, CreateGuest should be handled in BrowserPluginEmbedderHelper.
This patch makes this change.
I've also cleaned up some dead code.
I've also written a test that verifies that reloading the embedder
doesn't cause the browser plugin to misbehave.
BUG=153561
Test=BrowserPluginHostTest.ReloadEmbedder
Review URL: https://chromiumcodereview.appspot.com/11046002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The test checks baisc playback of encrypted media using webkit-org.w3.clearkey
and org.chromium.externalclearkey key systemts.
BUG=144755
Review URL: https://chromiumcodereview.appspot.com/10917202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=151143
Review URL: https://chromiumcodereview.appspot.com/10960003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=144755
TBR=ddorwin
Review URL: https://codereview.chromium.org/10986056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It enables the webgl conformace test in content_browsertests basing on
chrome/test/gpu.
BUG=149892
TEST=
Review URL: https://chromiumcodereview.appspot.com/10916334
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=avi
TEST=try bots
Review URL: https://chromiumcodereview.appspot.com/10912171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=143155
TEST=See bug, comment 19.
Review URL: https://chromiumcodereview.appspot.com/10952035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://chromiumcodereview.appspot.com/10560022, it seems I cannot upload patch to that issue (since I'm not owner), I'm creating a new one.
Split Embedder and Guest 'roles' for browser plugin, web contents can now play any or both roles, main idea is to have more readable separation between the two.
Also stop creating browser_plugin counterpart in browser/host for every web_contents, instead create them only when there's a browser_plugin element.
BUG= 141232
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157650
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157773
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10868012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://chromiumcodereview.appspot.com/10560022, it seems I cannot upload patch to that issue (since I'm not owner), I'm creating a new one.
NavigateGuest is flaky on windows (crashes at shutdown)
Split Embedder and Guest 'roles' for browser plugin, web contents can now play any or both roles, main idea is to have more readable separation between the two.
Also stop creating browser_plugin counterpart in browser/host for every web_contents, instead create them only when there's a browser_plugin element.
BUG= 141232
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157650
Review URL: https://chromiumcodereview.appspot.com/10868012
TBR=lazyboy@chromium.org
Review URL: https://codereview.chromium.org/10968015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://chromiumcodereview.appspot.com/10560022, it seems I cannot upload patch to that issue (since I'm not owner), I'm creating a new one.
Split Embedder and Guest 'roles' for browser plugin, web contents can now play any or both roles, main idea is to have more readable separation between the two.
Also stop creating browser_plugin counterpart in browser/host for every web_contents, instead create them only when there's a browser_plugin element.
BUG= 141232
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157650
Review URL: https://chromiumcodereview.appspot.com/10868012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://chromiumcodereview.appspot.com/10560022, it seems I cannot upload patch to that issue (since I'm not owner), I'm creating a new one.
Introduced too many static initializers - broke linux sizes.
Split Embedder and Guest 'roles' for browser plugin, web contents can now play any or both roles, main idea is to have more readable separation between the two.
Also stop creating browser_plugin counterpart in browser/host for every web_contents, instead create them only when there's a browser_plugin element.
BUG= 141232
Review URL: https://chromiumcodereview.appspot.com/10868012
TBR=lazyboy@chromium.org
Review URL: https://codereview.chromium.org/10946044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://chromiumcodereview.appspot.com/10560022, it seems I cannot upload patch to that issue (since I'm not owner), I'm creating a new one.
Split Embedder and Guest 'roles' for browser plugin, web contents can now play any or both roles, main idea is to have more readable separation between the two.
Also stop creating browser_plugin counterpart in browser/host for every web_contents, instead create them only when there's a browser_plugin element.
BUG= 141232
Review URL: https://chromiumcodereview.appspot.com/10868012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I mapped a spin button to a vertical slider, which causes VoiceOver to
expect the appropriate range attributes - and then gave it a role description of
"spin button" and an orientation of "vertical", so hopefully users will
be able to figure it out.
I also filled in the remaining range attributes that weren't implemented yet,
which also improves sliders, scroll bars, and progress bars.
BUG=130430
TEST=Visit a webpage with an ARIA spinbutton with VoiceOver on.
Review URL: https://chromiumcodereview.appspot.com/10911287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These roles worked before, but the code is now cleaner because
they directly correspond to a WebKit role, rather than requiring
matching on the tag name:
div, form, hr, label, p, presentational, spinbuttonpart
These roles bring new support for roles that were not previously
accessible:
canvas, spinbutton, togglebutton.
All of the interesting cases have new tests (content_browsertest target).
BUG=145346,143689
Review URL: https://chromiumcodereview.appspot.com/10919157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jam@chromium.org
R=benjhayden@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10867060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=128767
TEST=
Review URL: https://chromiumcodereview.appspot.com/10827078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The content_shell doesn't provide a prerendererclient (and chromium and DumpRenderTree do). This browsertest makes sure that encountering a prerendering element doesn't crash the content_shell.
This patch must land after https://bugs.webkit.org/show_bug.cgi?id=95036 lands and is gardened into Chromium.
R=jam@chromium.org
BUG=144556
Review URL: https://chromiumcodereview.appspot.com/10869068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=143637
Review URL: https://chromiumcodereview.appspot.com/10879018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=140919,143637
Review URL: https://chromiumcodereview.appspot.com/10828378
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
already fixed for Mac, is that the buffers can be deleted during a paint because of a resize during an NPN_Evaluate call. So keep a local reference.
BUG=139462
Review URL: https://chromiumcodereview.appspot.com/10855141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It doesn't check that the integer version was actually added
to leveldb though, which is unfortunate. It ensures that
opening a v0 database doesn't fail an assert, which is what
would happen if you opened an unmigrated database with code
that expects to find a stored integer version.
BUG=108223
Review URL: https://chromiumcodereview.appspot.com/10826159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/10826159/
TBR=jsbell
BUG=108223
Review URL: https://chromiumcodereview.appspot.com/10828191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In response to the recent media failure (http://crbug.com/133808) we need
tests which actually run over http and request enough data to trigger the
more complex behaviors of our http loader.
In this CL I've modified all the existing tests to wait for playthrough
over both file:// and http:// protocols. Additionally I've checked in a
large (~4.2MB) test file (with nsylvain's approval) for triggering the
buffering issue in the bug mentioned above.
BUG=134034
TEST=These tests. Eventually try bots.
Review URL: https://chromiumcodereview.appspot.com/10647007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This depends on: http://codereview.chromium.org/10662003/
Based on the HTML to Platform Accessibility APIs Implementation Guide
(http://www.w3.org/TR/html-aapi/), add some new tests to assert the
correct behavior for computing the text alternative for a
checkbox, button, and text field, then fix the implementation to
match the test.
BUG=124314
TBR=dtseng
Review URL: https://chromiumcodereview.appspot.com/10823073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:31955
TEST=Played on linux CrOS build.
Review URL: https://chromiumcodereview.appspot.com/10835028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
attributes to check.
Rolled this out in hopes of stopping some crashes, but it didn't help, so relanding.
With this change, a DumpAccessibilityTree test can specify filters to
control which attributes are printed. This keeps each test expectation file
small and readable, while making it easy to test for all sorts of attributes,
including obscure ones.
Each platform will have a few attributes that print by default, like the
role and name. HTML files add rules of this form to override the defaults:
@MAC-DENY:subrole*
@MAC-DENY:value*
@MAC-ALLOW:description*
You can also specify @MAC-ALLOW:* or @WIN-ALLOW:* if you want to dump everything - helpful
during development sometimes.
BUG=124314
Review URL: https://chromiumcodereview.appspot.com/10662003
TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837065
TBR=pkasting@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
attributes to check.
This may have caused the Win 7 WebKit canary bot to begin crashing; see
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=accessibility%2Floading-iframe-updates-axtree.html
If rolling this out does not fix the bot, I will put it back in later tonight.
With this change, a DumpAccessibilityTree test can specify filters to
control which attributes are printed. This keeps each test expectation file
small and readable, while making it easy to test for all sorts of attributes,
including obscure ones.
Each platform will have a few attributes that print by default, like the
role and name. HTML files add rules of this form to override the defaults:
@MAC-DENY:subrole*
@MAC-DENY:value*
@MAC-ALLOW:description*
You can also specify @MAC-ALLOW:* or @WIN-ALLOW:* if you want to dump everything - helpful
during development sometimes.
BUG=124314
Review URL: https://chromiumcodereview.appspot.com/10662003
TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, a DumpAccessibilityTree test can specify filters to
control which attributes are printed. This keeps each test expectation file
small and readable, while making it easy to test for all sorts of attributes,
including obscure ones.
Each platform will have a few attributes that print by default, like the
role and name. HTML files add rules of this form to override the defaults:
@MAC-DENY:subrole*
@MAC-DENY:value*
@MAC-ALLOW:description*
You can also specify @MAC-ALLOW:* or @WIN-ALLOW:* if you want to dump everything - helpful
during development sometimes.
BUG=124314
Review URL: https://chromiumcodereview.appspot.com/10662003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149510 0039d316-1c4b-4281-b951-d872f2087c98
|