| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 928413313366792564237aac159abd2c05cb35af.
Seems to break lots of plugin tests:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/14561
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Fplugins%2Fwebplugin-alpha.html
TBR=nasko@chromium.org
BUG=245126
Review URL: https://codereview.chromium.org/19929003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is the first step of moving frame specific code away from RenderView into RenderFrame. The CL moves all methods that don't change any state and leaves the state in the RenderView object.
BUG=245126
Review URL: https://chromiumcodereview.appspot.com/16418003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This CL implements injection of a mock WebDeviceMotionData into the Platform for testing purposes. Once the mock WebDeviceMotionData is set it will be returned as a one-shot event once Blink registers its DeviceMotionListener through the platform using setDeviceMotionListener method.
BUG=135804
Review URL: https://chromiumcodereview.appspot.com/5222955109842944
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ContentRendererClient::OverrideCreateMediaStreamClient() is replaced with UseMockMediaStreams() for overriding MediaStreamClient when running layout tests with content_shell. Doing so permits migration of MediaStream-related code from webkit/ to content/ without widening content's public API solely for test purposes.
BUG=251306
R=jam@chromium.org, jochen@chromium.org
Review URL: https://codereview.chromium.org/18590002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The content renderer APIs introduced in r209797 are now used for layout test purposes.
BUG=239826
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/18584004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(for now).
This is reland of https://codereview.chromium.org/17114006/, which was reverted due to bug in WebFrameTestProxy. I've fixed the issue in https://codereview.chromium.org/18031013/.
BUG=245126
Review URL: https://chromiumcodereview.appspot.com/18178006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL updates the #includes for the TestRunner library to their new path in
Blink.
TBR=jochen
BUG=239545
Review URL: https://chromiumcodereview.appspot.com/17575007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderView (for now)." (r207825).
Many failures on layout tests, e.g., fast/animation/request-animation-frame-during-modal.html
BUG=245126
TBR=nasko
Review URL: https://codereview.chromium.org/17068011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(for now).
This is continuation of the original CL (https://codereview.chromium.org/16223006/), which didn't account for Blink tests using WebTestProxy.
BUG=245126
Review URL: https://chromiumcodereview.appspot.com/17114006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unlike normal operation, in layout tests the renderer can request a synchronous
change of its size. The renderer and the browser therefore often run out of
sync. However, it's important that the renderer always acks a resize request
from the browser.
Previously, I tried to track the size the browser expects the renderer to have
in the renderer, however, this turns out to not work when the compositor is in
hidpi mode. Instead of trying to fix this up somehow, just ignore whether or
not the browser is expecting resize acks during layout tests
BUG=244369
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/15878016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reduces the number of threads created per media element by one.
TBR=jamesr,jochen
BUG=61293
Review URL: https://chromiumcodereview.appspot.com/15993018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Don't track whether a resize ack is pending during layout tests
>
> Unlike normal operation, in layout tests the renderer can request a synchronous
> change of its size. The renderer and the browser therefore often run out of
> sync. However, it's important that the renderer always acks a resize request
> from the browser.
>
> Previously, I tried to track the size the browser expects the renderer to have
> in the renderer, however, this turns out to not work when the compositor is in
> hidpi mode. Instead of trying to fix this up somehow, just ignore whether or
> not the browser is expecting resize acks during layout tests
>
> BUG=244369
>
> Review URL: https://chromiumcodereview.appspot.com/16285005
Breaks fast/hidpi on windows
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/16326004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unlike normal operation, in layout tests the renderer can request a synchronous
change of its size. The renderer and the browser therefore often run out of
sync. However, it's important that the renderer always acks a resize request
from the browser.
Previously, I tried to track the size the browser expects the renderer to have
in the renderer, however, this turns out to not work when the compositor is in
hidpi mode. Instead of trying to fix this up somehow, just ignore whether or
not the browser is expecting resize acks during layout tests
BUG=244369
Review URL: https://chromiumcodereview.appspot.com/16285005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Reland: Use a shared thread for media operations.
>
> This reduces the number of threads created per media element by one.
>
> BUG=61293
> TBR=acolwell, jamesr, jochen
>
> Review URL: https://codereview.chromium.org/15649017
It's still causing some memory corruption.
TBR=scherkus@chromium.org
Review URL: https://codereview.chromium.org/16266006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reduces the number of threads created per media element by one.
BUG=61293
TBR=acolwell, jamesr, jochen
Review URL: https://codereview.chromium.org/15649017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These headers have moved from Source/Platform/chromium/public to
public/platform. This CL updates content's references to the old location to
point to the new location. After this CL lands, I'll remove the forwarding
headers that are letting these references still work.
TBR=jamesr@chromium.org
BUG=239545
Review URL: https://chromiumcodereview.appspot.com/15822010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
flags on and off
BUG=111316
R=piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16026006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=111316
R=mkwst@chromium.org, piman@chromium.org
Review URL: https://codereview.chromium.org/14859017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Possibly causing mem-corruption on webkit layout tests, thus crashes.
> Use a shared thread for media operations.
>
> This reduces the number of threads created per media element by one.
>
> BUG=61293
> R=acolwell@chromium.org, jamesr@chromium.org, jochen@chromium.org
>
> Review URL: https://codereview.chromium.org/15005005
TBR=scherkus@chromium.org
Review URL: https://codereview.chromium.org/14690019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reduces the number of threads created per media element by one.
BUG=61293
R=acolwell@chromium.org, jamesr@chromium.org, jochen@chromium.org
Review URL: https://codereview.chromium.org/15005005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The layout test will take care itself of closing the popup, so it's safe to just
do nothing.
BUG=111316
TEST=the test following fast/forms/select/menulist-popup-crash.html doesn't time out
R=avi@chromium.org
Review URL: https://codereview.chromium.org/14864013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This method will block until at least the mouse enters the window, and so most
layout tests that rely on drag & drop just time out.
BUG=111316
R=sky@chromium.org
TEST=e.g. fast/events/clear-drag-state.html passes
Review URL: https://chromiumcodereview.appspot.com/13843007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
device scale factor during layout tests
BUG=111316
R=jamesr@chromium.org
TEST=virtual/gpu/fast/hidpi tests pass on content_shell
Review URL: https://codereview.chromium.org/12917015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=111316
R=piman@chromium.org
TEST=http/tests/loading/bad-server-subframe.html passes
Review URL: https://chromiumcodereview.appspot.com/12751007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
suppress focus IPCs
Now that content shell handles the focus for layout tests, we don't want to browser to interfere with the tests
BUG=111316
R=piman@chromium.org
Review URL: https://codereview.chromium.org/12427003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=111316
R=piman@chromium.org
TEST=fast/dom/Window/window-resize-contents.html and fast/autoresize/turn-off-autoresize.html passes
Review URL: https://chromiumcodereview.appspot.com/12449003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The majority of layout tests expects the focus to be changed instantly, so going
via the browser process doesn't work.
BUG=111316
R=piman@chromium.org
TEST=fast/dom/Window/window-onFocus.html passes
Review URL: https://codereview.chromium.org/12391061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the navigation history
In layout tests that dump the back/forward history, the state of the latest
navigation entry (which is kept in the browser browser) does not reliably
reflect the current state. This is because updates to the state are only send
when a new navigation starts or else at regular intervals.
Therefore, we force a sync of the session history state when running layout
tests that dump the back/forward history.
BUG=111316
R=brettw@chromium.org
TEST=remaining http/tests/navigation tests pass
Review URL: https://codereview.chromium.org/12330099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
layout tests
Many layout tests assume that e.g. window.focus() will change the focus instantly. This
is not the case, and those tests will need to be updated.
BUG=111316
TEST=layout tests that change the focus and listen to focus events work.
R=piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12317133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit's layout tests require running with osmesa to get reliable pixel results.
Since content shell drt spins up a full gpu process, an image transport
implementation is needed for osmesa. content shell drt reads pixel baselines
off the renderer, so the implementation doesn't have to do much.
To make sure it doesn't get picked accidentally, put it behind a off-by-default
flag that's only toggled on in content shell drt.
BUG=111316
TEST=
`webkit/tools/layout_tests/run_webkit_tests.sh --driver-name 'Content Shell' --additional-drt-flag --dump-render-tree webgl/conformance/attribs/gl-disabled-vertex-attrib.html` passes
`webkit/tools/layout_tests/run_webkit_tests.sh --driver-name 'Content Shell' --additional-drt-flag --dump-render-tree animations/3d/change-transform-in-end-event.html` has only minor text antialiasing pixel differences
Note: Running `out/Release/Content\ Shell.app/Contents/MacOS/Content\ Shell third_party/WebKit/LayoutTests/animations/3d/change-transform-in-end-event.html --dump-render-tree` won't update the drt window correctly due to this being a dummy transport bitmap. Eventually --dump-render-tree will hide the window, so that should be ok. (And without --dump-render-tree, the test renders fine.)
Review URL: https://codereview.chromium.org/12315103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We need this information to implement the WebTestDelegate interface.
BUG=111316
R=creis@chromium.org
Review URL: https://codereview.chromium.org/12319014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=111316
R=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12039060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=111316
TEST=http/tests/inspector/appcache passes
R=marja@chromium.org,jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11442050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=111316
TEST=all gamepad/ layout tests pass
R=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11280314
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=marja@chromium.org
Review URL: https://codereview.chromium.org/11536002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old code would sometimes crash. The reason is that we need to know which is
the main render view when the first render view is created. The old code,
however, would only pick the main view after it was created.
Individual changes:
- move sending the fake cwd from RenderViewReady to RenderViewCreated so that we can guarantee it's available on time
- Don't guess which WebKitTestRunner belongs to a RenderView, but explictely pass the RenderView with the WebTestProxy creation callback
- instead of having the browser set the main render view, the renderer picks the first RenderView and declares it the main view
BUG=111316
TEST=Running editing/pasteboard/data-transfer-items-drag-drop-string.html doesn't crash
TBR=tsepez@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11416177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a hook to the content renderer client to allow embedders to override the
creation of RenderViewImpls. To simplify this, I consolidate the parameters
passed to RVI's constructor into a struct.
- Add a content_layouttest_support library that provides a method for creating
a modified RenderViewImpl suitable for running layout tests.
- Use above library from the content_shell.
BUG=111316
TEST=almost all accessibility tests pass.
Original review: https://chromiumcodereview.appspot.com/11293237
Review URL: https://codereview.chromium.org/11275277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a hook to the content renderer client to allow embedders to override the
creation of RenderViewImpls. To simplify this, I consolidate the parameters
passed to RVI's constructor into a struct.
- Add a content_layouttest_support library that provides a method for creating
a modified RenderViewImpl suitable for running layout tests.
- Use above library from the content_shell.
BUG=111316
TEST=almost all accessibility tests pass.
Review URL: https://codereview.chromium.org/11362161
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/11275276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
- Add a hook to the content renderer client to allow embedders to override the
creation of RenderViewImpls. To simplify this, I consolidate the parameters
passed to RVI's constructor into a struct.
- Add a content_layouttest_support library that provides a method for creating
a modified RenderViewImpl suitable for running layout tests.
- Use above library from the content_shell.
BUG=111316
TEST=almost all accessibility tests pass.
Review URL: https://codereview.chromium.org/11362161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167341 0039d316-1c4b-4281-b951-d872f2087c98
|