summaryrefslogtreecommitdiffstats
path: root/content/test/test_web_contents_view.cc
Commit message (Collapse)AuthorAgeFilesLines
* Fix the crash that could occur when the window is closed while web contents ↵jianli@chromium.org2012-09-281-7/+0
| | | | | | | | | | | | | | | | | drag is in progress. We now check if the contents view window is gone after system drag-and-drop returns. Bail out immediately if so. With this fix, we do not need the delay-close-at-drag workaround any more. This fix applies towards to both Windows and Aura. We do not have problem on GTK since it does not run nested message loop. On Mac, the system drag-and-drop is invoked from the Cocoa view that could outlive the WebContentsViewMac due to Cocoa retains count (see comment in WebContentsViewMac::~WebContentsViewMac). However, we do need to ensure that WebDragSource stops using web contents when it is gone. BUG=145363 TEST=Manual test by following the steps in the bug Review URL: https://chromiumcodereview.appspot.com/10966023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159366 0039d316-1c4b-4281-b951-d872f2087c98
* We do not pass enums by conts references. This CL fixes style errors introducedvarunjain@chromium.org2012-09-171-1/+1
| | | | | | | | | | | in a previous CL. BUG=none Review URL: https://chromiumcodereview.appspot.com/10915304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157205 0039d316-1c4b-4281-b951-d872f2087c98
* Context menus should appear above the touch point if invoked by long press.varunjain@chromium.org2012-09-071-1/+2
| | | | | | | | | | | | | | | This CL does this for content area context menus only. I will send out another CL for same functionality on views controls. We acheive this as follows: We remember in render_widget_host, which kind of event is currently in process. When we get a request for showing context menu, in render_view_host, we check if currently we are processing a gesture event, and if so, we display the context menu appropriately. BUG=142015 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10917102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155306 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple ImageSkia implicit conversion bugs.pkotwicz@chromium.org2012-07-091-1/+1
| | | | | | | | | | | | | Change RenderViewHostDelegateView::StartDragging to pass around an ImageSkia instead of an SkBitmap Bug=133281 Test=Manual R=varunjain, ben TBR=jam Review URL: https://chromiumcodereview.appspot.com/10689124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145734 0039d316-1c4b-4281-b951-d872f2087c98
* content: Make GetViewBounds() return a rect rather than using an out param.tfarina@chromium.org2012-06-131-1/+2
| | | | | | | | | | | | NOTE: This was a TODO for @ben. BUG=98716 R=jam@chromium.org TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10534106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141995 0039d316-1c4b-4281-b951-d872f2087c98
* Multi-select <select> in 'external popup window'aruslan@chromium.org2012-05-261-0/+9
| | | | | | | | | | | | | | We use an 'external popup window' for both single and multi selection <select> tag popups. This also supports <optgroup> and disabled <option> items and multiple selections. On all other chrome platforms a multi-select <select> tag is rendered in page, so this CL adds a bit of plumbing and IPC stuff to get the multi-select popups working as well. WebKit side of this CL is at http://trac.webkit.org/changeset/94600 Review URL: https://chromiumcodereview.appspot.com/10436010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139169 0039d316-1c4b-4281-b951-d872f2087c98
* Move the create/show window/widget calls from RenderViewHostDelegate::View ↵jam@chromium.org2012-05-231-25/+0
| | | | | | | | | | | | | to RenderViewHostDelegate. The reasons for this are: -we don't have to duplicate all the code that calls WebContentsViewHelper in each different WebContentsView implementation -other embedders of content who provide their own WebContentsView implementation shouldn't have to do this work, or use WebContentsViewHelper which isn't public BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10426008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138648 0039d316-1c4b-4281-b951-d872f2087c98
* Make RenderViewHost show the mac popupmenu itself instead of going through RVHD.jam@chromium.org2012-05-231-8/+0
| | | | | | | BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10421040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138560 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 135525 - Add a first-class off-store install UI to chrome://extensions/.aa@chromium.org2012-05-051-0/+4
| | | | | | | | | BUG=55584 TBR=estade@chromium.org Review URL: https://chromiumcodereview.appspot.com/10378026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135557 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 135525 - Add a first-class off-store install UI to chrome://extensions/.aa@chromium.org2012-05-051-4/+0
| | | | | | | | | | | | | This patch implements GTK only. Other ports will be separate CLs. BUG=55584 Review URL: https://chromiumcodereview.appspot.com/10270031 TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10382025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135528 0039d316-1c4b-4281-b951-d872f2087c98
* Add a first-class off-store install UI to chrome://extensions/.aa@chromium.org2012-05-051-0/+4
| | | | | | | | | | This patch implements GTK only. Other ports will be separate CLs. BUG=55584 Review URL: https://chromiumcodereview.appspot.com/10270031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135525 0039d316-1c4b-4281-b951-d872f2087c98
* Move Render(View|Widget)Host and associated classes to content namespace.joi@chromium.org2012-03-071-1/+1
| | | | | | | | | TBR=jam@chromium.org BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9600036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125388 0039d316-1c4b-4281-b951-d872f2087c98
* Move overlay stuff out of content. It's only used by sad tab, which is a ↵jam@chromium.org2012-03-051-6/+0
| | | | | | | | | | | Chrome feature. More pragmatically, the Views implementation looks like it needs Views code to install/remove it, and that won't be possible once Chrome is switched to TabContentsViewWin. The code in chrome temporarily casts to TabContentsViewGtk and TabContentsViewViews. In followup changes, I will fix this once I have a clean way of getting to the chrome side delegate of TabContentsView, which will have access to the necessary objects. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9594025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125013 0039d316-1c4b-4281-b951-d872f2087c98
* Move ContextMenuParams struct from webkit/glue to content/public/common. The ↵jam@chromium.org2012-02-121-1/+2
| | | | | | | | | | | | | reasons are: -this struct wasn't used at all in webkit layer, so no need to have it there -we can avoid exposing content layer's serialization of SSLInfo to embedders -avoid mentioning routing_ids in the webkit layer BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9382037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121673 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContentsView to WebContentsView and move to content/public.joi@chromium.org2012-01-181-0/+138
Also rename TestTabContentsView to TestWebContentsView. Add content namespace to both. TBR=owners (trivial updates) BUG=98716 Review URL: http://codereview.chromium.org/9241011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118134 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-09-15 13:49:53 +0000