| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PluginService to content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead.
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Review URL: http://codereview.chromium.org/9150016
TBR=jam@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=93804, 95573
TEST=no visible change
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117067
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=117074
Review URL: http://codereview.chromium.org/9008079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes history problems that could arise with the previous approach.
BUG=109417
TEST=See bug for repro steps.
Review URL: http://codereview.chromium.org/9125016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead.
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Review URL: http://codereview.chromium.org/9150016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=79098
Review URL: http://codereview.chromium.org/9085027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=93804, 95573
TEST=no visible change
Review URL: http://codereview.chromium.org/9008079
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/9168015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79722
TEST=compiles
First Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116956
Review URL: http://codereview.chromium.org/9151007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=93804, 95573
TEST=no visible change
Review URL: http://codereview.chromium.org/9008079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR since this is just removing debugging code.
BUG=107172
TEST=none
R=ben@chromium.org,avi@chromium.org
TBR=ben@chromium.org,avi@chromium.org
Review URL: http://codereview.chromium.org/9147035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
threads that are used in many places. In cases where a specific feature/class needs a thread, it should just create it directly. Add a comment about this in BrowserThread.
Review URL: http://codereview.chromium.org/9146007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9110043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ERR_ABORTED error code is very general and for this particular case
we already have a corresponding net:: error case.
BUG=105653
TEST=browser_tests,content_unittests
Review URL: http://codereview.chromium.org/8895002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=acolwell
BUG=none
TEST=chrome builds again
Review URL: http://codereview.chromium.org/9108039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=109402
Review URL: http://codereview.chromium.org/9148017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pass() was announced in
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/RTd7rNxHjqk/discussion
This CL replaces comments about ownership transfer (in all files whose paths
contain media/) with the explicit passing of the appropriate scoper.
The exceptions that are not touched by this CL:
- scoped_refptr<> doesn't support Pass() and so is untouched.
- media/audio code defines its own callback machinery, mimicking the old-style
callbacks (pass by pointer, explicit deletes). I think that whole pile needs
to be replaced with new-style (Bind) callbacks, so left it alone for now.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/9015015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and setting the ticks members of the webkit events correctly.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9156002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=79722
TEST=compiles
Review URL: http://codereview.chromium.org/9151007
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/9167002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79722
TEST=compiles
Review URL: http://codereview.chromium.org/9151007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WebSharedWorkerStub.
BUG=105482
Review URL: http://codereview.chromium.org/9154003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Contributed by simon.hong81@gmail.com
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/9095003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended to fix the various leaks involving the DownloadManager;
if the classes destruction is tied to the UI thread and the class is
destroyed at Profile destruction (which it is) it will be leaked
because the UI thread no longer exists at profile destruction.
BUG=100146
BUG=58449
BUG=102255
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116385
Review URL: http://codereview.chromium.org/8907002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This can help catch breakages where the clipboard is accidentally overwritten
by nested ScopedClipboardWriters. There is also some minor logic consolidation
in ScopedClipboardWriterGlue.
BUG=108293
TEST=browser_tests --gtest_filter=ExtensionApiTest.BookmarkManager
Review URL: http://codereview.chromium.org/9125019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9109040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
download_manager_impl.cc.
Don't disable them until after the next dev cycle, when we should have some more debugging information. Disabling them will probably move them somewhere else, hopefully both yielding even more debugging information and preventing unnecessary crashes on stable/beta.
Review URL: http://codereview.chromium.org/8965004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
CID=102785
TEST=none
Review URL: http://codereview.chromium.org/9007035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also disable libudev on *BSD because it's not available.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9147003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an alternative fix for the race between destroying a dead host and
looking up a host that may lead to unnecessary spawning of new GPU processes.
BUG=chromium-os:107491
TEST=see issue
Review URL: http://codereview.chromium.org/9030021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
associated ResourceDispatcherHostRequestInfo, which triggers
ResourceHandler::OnRequestClosed notifications. This way we
avoid re-entering a ResourceHandler that is calling CancelRequest.
Review URL: http://codereview.chromium.org/9127014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds support for coercing to Java arrays when passing JavaScript
objects to the methods of Java objects injected using the Java Bridge.
- Modify JavaType to store the type of the array elements when the type of the
value is TypeArray.
- Add logic to create Java arrays and to interrogate JavaScript objects for
their length property and array elements.
- Modify existing CoerceJavaScriptXXXToJavaValue() methods to take an
additional coerce_to_string argument. This is required because we require
slightly different behaviour when coercing to Java strings, depending on
whether or not the value is an array element.
- Modify JavaBridgeChannel to override
NPChannelBase::OnControlMessageReceived() to avoid DCHECK().
Also fix a potential overflow when converting JavaScript numbers to Java
strings.
BUG=105547
Review URL: http://codereview.chromium.org/9006025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This does some refactoring of the static data in the browser thread so we only have one global object instead of a bunch fo separate arrays.
It also hooks up the visited link master's I/O to use this new system as a proof of concept.
Review URL: http://codereview.chromium.org/9065009
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/9122022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This does some refactoring of the static data in the browser thread so we only have one global object instead of a bunch fo separate arrays.
It also hooks up the visited link master's I/O to use this new system as a proof of concept.
Review URL: http://codereview.chromium.org/9065009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
instead of TabContents. Update all callers accordingly.
I also got rid of WebUIFactory::Get. It was only called in a few places, and as part of the Content API we want to avoid cc files in the public directory.
BUG=98716
Review URL: http://codereview.chromium.org/9097005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=102442,102443
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8956037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(take 2)
RenderAudioSourceProvider implements WebKit::WebAudioSourceProvider using AudioRendererImpl
BUG=none
TEST=none
(tested locally)
Original Code Review: http://codereview.chromium.org/8980008/
Review URL: http://codereview.chromium.org/9122009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79050
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116724
Review URL: http://codereview.chromium.org/8899017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are seeing some latent crashes that I believe are a consequence of this earlier failure. So this change should help clarify what is happening.
A next step would be to determine the particular platform error that caused thread creation to fail.
(However base::PlatformThread doesn't currently expose that).
BUG=109302
Review URL: http://codereview.chromium.org/9122010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Over 341 CLs, in ~3 months, touching 3251 unique files!
Top 5 most CLs:
(121) jhawkins
( 45) dcheng
( 24) achuith
( 23) csilv
( 12) tfarina
( 12) groby
~1000 files touched:
(918) jhawkins
100+ files touched:
(486) ajwong
(385) willchan
(372) dcheng
(126) csilv
(123) fischman
(112) sergeyu
49+ files touched:
(65) tfarina
(57) acolwell
(52) adamk
(49) tzik
BUG=35223
TEST=existing
Review URL: http://codereview.chromium.org/9114020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=102857, 102858
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9108024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is temporary, and like the other toolkit properties it's only used in chrome. Taking it out of ChromeWebUI allows us to remove that class in a followup cl.
Review URL: http://codereview.chromium.org/9121009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GpuMsg_VisibilityChanged was meant to one day be used for context eviction (according to a todo), but was not completed.
The GPU is already informed of visibility changes via GpuCommandBufferMsg_SetSurfaceVisible.
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/9135001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke ASAN builder:
http://build.chromium.org/p/chromium.memory/builders/ASAN%20Builder/builds/8480/steps/update/logs/stdio
BUG=79050
Review URL: http://codereview.chromium.org/8899017
TBR=scottmg@google.com
Review URL: http://codereview.chromium.org/9110039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=79050
Review URL: http://codereview.chromium.org/8899017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PtsStream is overkill and given the needs of this decoder, so replaced it with a
simple lookup structure.
Also fixed a seek bug (running out of textures during pre-roll) and improved error handling.
BUG=107036
TEST=manual
Review URL: http://codereview.chromium.org/9116025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9131002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I've switched RenderViewHostTestHarness::controller() to return the interface instead of the concrete class. Only two tests needed NavigationControllerImpl, so it's much easier to switch those to cast, and to leave the interface object as the return value as many tests in chrome use it and RVHTH will have to be exposed to chrome.
BUG=98716
Review URL: http://codereview.chromium.org/9123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To enable this on Mac OS, we also enable plug-in directory watching there. There shouldn't be any false positives causing unnecessary disk hits anymore.
BUG=62079
TEST=go to http://www.corp.google.com/~bauerb/no_crawl/test/install_plugin.html, install the missing plug-in. It should automatically load.
Review URL: http://codereview.chromium.org/9015025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST="existing tests"
Review URL: http://codereview.chromium.org/8921001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ResourceHandler subclasses that just delegate to the next handler.
Review URL: http://codereview.chromium.org/9113032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MediaElementAudioSourceNode
RenderAudioSourceProvider implements WebKit::WebAudioSourceProvider using AudioRendererImpl
BUG=none
TEST=none
(tested locally)
Review URL: http://codereview.chromium.org/8980008
TBR=crogers@google.com
Review URL: http://codereview.chromium.org/9121001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116647 0039d316-1c4b-4281-b951-d872f2087c98
|