| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should enable us to see PPAPI plugin crashes in the plugin crashes column
on the stability dashboard. Note that each plugin (PPAPI or regular) is included
separately in the metrics log and aggregated at the server side. This allows us
to slice and dice the data later, if necessary.
Also:
- Remove a couple of obsolete FRIEND_TEST declarations.
- Use base file name as plugin name when the name of the PPAPI plugin to be
launched is empty. This is mostly so that the OutOfProcessPPAPITests can pass
but also matches the logic in PepperPluginInfo::ToWebPluginInfo().
BUG=chromium-os:22465
TEST=git try, unit tests, kill -SEGV ppapi process, check that it's counted in
the plugin prefs and transmitted in the metrics log:
<pluginstability filename="nfGm7uk2q0xBpC3X5CA95A==" launchcount="3"
instancecount="1" crashcount="2"/>
Review URL: http://codereview.chromium.org/8501005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These two extensions allow a partial swap: just pushing part of the backbuffer to the front buffer. This will allow the WK compositor to push a partial update to the screen instead of a full frame update (https://bugs.webkit.org/show_bug.cgi?id=70533).
We should be able to do something similar for TOUCHUI ImageTransportSurfaces (hence the hooks into GLSurface and the glPostSubBufferCHROMIUM command).
Review URL: http://codereview.chromium.org/8512005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8539013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8478030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=henrika
Review URL: http://codereview.chromium.org/8463010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=96703
Review URL: http://codereview.chromium.org/8525016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8341125
TBR=jschuh@chromium.org
Review URL: http://codereview.chromium.org/8537005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8341125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dsolomov@chromium.org
Review URL: http://codereview.chromium.org/8539002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Clean up the code a bit.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/8525018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for a coming webkit patch that will
use these functions.
TEST=none
BUG=none
R=kbr@chromium.org
Review URL: http://codereview.chromium.org/8523001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=102408
TEST=More data in OnTempCrashWithData dumps.
Review URL: http://codereview.chromium.org/8527014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dsolomov@chromium.org
Review URL: http://codereview.chromium.org/8533003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8511044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=90442
TEST=the win shared debug builder compiles
Review URL: http://codereview.chromium.org/8501025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also creates MockPluginService for use in tests.
BUG=103788,chromium-os:22447
TEST=none
Review URL: http://codereview.chromium.org/8493019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=101996
TBR=dsolomov@chormium.org
Review URL: http://codereview.chromium.org/8526011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- When cleaning up after a renderer process, don't invalidate iterators inside a loop. This allows the iterators to be cached for the duration of the loop, rather than requiring a new search after each pass of the loop.
- When searching for both lower_bound and upper_bound, use equal_range instead.
R=wtc@chromium.org
BUG=none
Review URL: http://codereview.chromium.org/8416060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of duplicating it.
The Issue:
After broker creates the render-broker channel, the original code will dup() the client file descriptor (fd) and send the duplicate to the render. As a result, there are two copies of the same client fd. One is in the broker process; the other one is sent over the IPC channel and will be owned by the browser and finally by the render. Normally, when connection establishes correctly, the render will send a HelloMessage to the broker, so that the broker is notified and has a chance to call IPC::Channel::ChannelImpl::ProcessIncomingMessages(), which will call CloseClientFileDescriptor() and close its copy of the client fd in the broker. After this, there will be only one copy of the client fd in the render. Whenever the render closes this fd, the broker will get notified with an event.
However, if before the connection establishes, something goes wrong (e.g. the render crashed), closing the cliend fd in the browser or render will not work. The broker will keep its server fd and never get notified. The reason is as follows. Since the connection is not established, the HelloMessage never comes. So the broker will never call CloseClientFileDescriptor() to close its copy of the client fd. When there are two copies of the client fd open, closing one of them (e.g. the one owned by the render or browser) won't generate an event in the broker. The broker will keep waiting and never get notified.
The Fix:
Do not duplicate the client fd. Thus whenever/whereever the client fd is closed, the broker will get notified with an event.
BUG=82176
TEST=Tested with ui broker test and normal usage. Also crashed render before connection established and verified that the broker released the render-broker IPC channel.
Review URL: http://codereview.chromium.org/8497026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=101996
TBR=dsolomov@chromium.org
Review URL: http://codereview.chromium.org/8526007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this change, we get two copies of the factory methods and
setting the mock factories in the unit tests doesn't work correctly.
R=jknotten@chromium.org
BUG=90442
TEST=content_unittests runs successfully on linux w/ a component build of content
Review URL: http://codereview.chromium.org/8508038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=scherkus@chromium.org
BUG=90442
TEST=
Review URL: http://codereview.chromium.org/8508046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=22900
BUG=100529
Review URL: http://codereview.chromium.org/8494015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Some minor cleanup to remove BUFFER_DRAG as well, which is not used anywhere.
BUG=73478
TEST=compiles
Review URL: http://codereview.chromium.org/8511042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for the improved SafeBrowsing download protection later.
BUG=102540
TEST=No visible change. Run DownloadItemTest, DownloadManagerTest
Review URL: http://codereview.chromium.org/8511020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=99700,98716
Review URL: http://codereview.chromium.org/8439021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
After the device is opened, any following Open() call will get the opened device.
The device will be closed only when all users have called Close().
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/8467032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
event.
Since all events (including error events) are identified by label, it's important that MediaStreamManager's requester (i.e., MediaStreamDispatcherHost) should have the label before it receives any event.
This can be done by calling device_settings_->RequestCaptureDeviceUsage asynchronously.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/8495026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/102933.
BUG=102933
R=benjhayden@chromium.org
Review URL: http://codereview.chromium.org/8485003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plumbing.
This depends on WebKit change: https://bugs.webkit.org/show_bug.cgi?id=71842
Also, sprinkle OVERRIDE all over devtools_client.h.
BUG=44350
TEST=Open DevTools in undocked mode on the Mac. Drag the window by the empty space in the toolbar. The window should move.
Review URL: http://codereview.chromium.org/8503022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
enable two tests now that webrtc has been updated (see r109241).
Review URL: http://codereview.chromium.org/8509010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This method did previously call directly into media/audio.
BUG=none
TEST=WebAudio demo in multi-process mode
Review URL: http://codereview.chromium.org/8497014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixed a DCHECK that gets triggered in the same case (audio renderer is
destroyed without ever having been created, so DCHECK_NE(stream_id_, 0) was
failing).
BUG=103552
TEST=failing video stops crashing renderer
Review URL: http://codereview.chromium.org/8510017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8499042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm making the fullscreen RenderWidgetHostViewAura be a
"normal" window rather than a popup.
Note that the fullscreen window still remains black when I
put a Pepper Flash plugin into fullscreen mode. This looks
like it may be due to an issue with accelerated compositing
under Aura; the problem goes away when I disable creation of
the 3D context.
BUG=101848
TEST=manual: fullscreen window is visible again now
Review URL: http://codereview.chromium.org/8457001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7864015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Note that, though the PP_Flash_NetAddress struct is being renamed, binary
compatibility is being maintained. It's also safe to just rename the
PPB_Flash_NetAddress interface without maintaining backwards compatibility since
Pepper Flash isn't using it yet.
Review URL: http://codereview.chromium.org/8511032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
features.
The general idea is to use jbates's newly added tracing: if a feature is blacklisted, we check the tracing data to make sure gpu process hasn't launched.
BUG=101222
TEST=browser_tests
Review URL: http://codereview.chromium.org/8497034
TBR=zmo@google.com
Review URL: http://codereview.chromium.org/8510030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
basictypes.h.
The header file currently doesn't compile on Windows (unless a definition for
uint32_t is picked up from elsewhere, coincidentally).
Review URL: http://codereview.chromium.org/8511034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The general idea is to use jbates's newly added tracing: if a feature is blacklisted, we check the tracing data to make sure gpu process hasn't launched.
BUG=101222
TEST=browser_tests
Review URL: http://codereview.chromium.org/8497034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Rename DesktopDelegate to StackingClient.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8508020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=None
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/8507011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=101541
Review URL: http://codereview.chromium.org/8341028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
passing --trace-startup puts the tracing system into record mode immediately saving the result to chrometrace.log or a file specified by --trace-startup-file
BUG=None
TEST=start chrome with --trace-startup, wait 5 secs, see chrometrace.log in current dir. open it in chrome://tracing/
Review URL: http://codereview.chromium.org/7887013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
+ Set the cursor in the desktop's event filter.
+ Add the ui::EF_IS_NON_CLIENT flag to mouse events when needed, so views doesn't override the cursor.
+ Move views/window/hit_test.h to ui/base/hit_test.h and remove the extra copy in ui/aura.
BUG=103298
TEST=move cursor over desktop, window edges, window client area
Review URL: http://codereview.chromium.org/8501018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had hoped to just turn this on globally after fixing all instances, but people
add these fairly often. So enable the warning for clean targets incrementally.
BUG=10600
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/8495043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=10600
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/8510019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the GLX case, when resizing the image transport surface, we immediately have a usable destination surface, without having to wait for an ACK from the browser. However, we don't want to release the old surface (that is still usable) until we have the new bits, so delay the notification until the swap.
BUG=58782
TEST=Aura browser on stumpy, observe that resizing frames leads to content being updated about once every 3 UI frames instead of about 6.
Review URL: http://codereview.chromium.org/8490028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WebKit side is: https://bugs.webkit.org/show_bug.cgi?id=62284
BUG=92038
Review URL: http://codereview.chromium.org/8417055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=all existing passing tests still pass
Review URL: http://codereview.chromium.org/8497023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109253 0039d316-1c4b-4281-b951-d872f2087c98
|