| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Metro mode requires a GPU process but there are a few
tablets and other devices that don't have a GPU. Currently
we don't expose the menu option for Metro mode on these
devices. This CL exposes the Metro mode option for all
Windows 8+ machines, and if a GPU isn't normally available
it turns on WARP support for Metro mode only.
BUG=314954
Review URL: https://codereview.chromium.org/435383002
Cr-Commit-Position: refs/heads/master@{#293267}
|
|
|
|
|
|
|
|
|
|
|
| |
The method declaration in the header file was left over in e2ea518 when
EME related code was moved to EncryptedMediaSupportImpl.
TBR=acolwell
Review URL: https://codereview.chromium.org/537193002
Cr-Commit-Position: refs/heads/master@{#293264}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Until we can rework the guts of HTMLMediaElement and its interaction
with WebMediaPlayer, have WebMediaPlayerImpl track an ended state so it
can return the duration HTMLMediaElement expects to fire the ended
event.
This makes it easier to change how Pipeline's audio/video time is
implemented without worrying about the pecularities of HTMLMediaElement.
BUG=349543,370634
Review URL: https://codereview.chromium.org/526443003
Cr-Commit-Position: refs/heads/master@{#293263}
|
|
|
|
|
|
|
|
|
|
|
| |
system font folder. Also adding UMA to measure font load times.
R=scottmg,cpu,ananta
BUG=408393
Review URL: https://codereview.chromium.org/541543002
Cr-Commit-Position: refs/heads/master@{#293261}
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/536783003
Cr-Commit-Position: refs/heads/master@{#293260}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:160001 of https://codereview.chromium.org/479873002/)
Reason for revert:
Causing check_licenses to fail on android_clang_dbg_recipe trybot:
The following files are whitelisted unnecessarily. You must remove the following files from the whitelist.
content/browser/renderer_host/web_input_event_aurax11.cc
The following files are whitelisted, but do not exist.
content/browser/renderer_host/web_input_event_aurax11.cc
Original issue's description:
> Removing uses of X11 native key events.
>
> BUG=380349
>
> Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822
TBR=sadrul@chromium.org,sky@chromium.org,erg@chromium.org,jamesr@chromium.org,kpschoedel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=380349
Review URL: https://codereview.chromium.org/536313002
Cr-Commit-Position: refs/heads/master@{#293254}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This callback implies that the resources are gone (because LTH
was deleted). What ends up happening is that the resources get
deleted while LTH still tries to call GetBitmap() on them.
This still needs some working invalidation mechanism for Thumbnails,
which don't have a persistent Bitmap they return from GetBitmap().
BUG=406879
NOTRY=True
TBR=dtrainor@chromium.org
Review URL: https://codereview.chromium.org/543543002
Cr-Commit-Position: refs/heads/master@{#293252}
|
|
|
|
|
|
|
|
|
|
|
| |
This is an instrumented version of the patch that will be reverted in a few days. This is meant to catch crashes in edge cases and log enough for us to repro them.
BUG=407376
TEST=this may crash for a few people
Review URL: https://codereview.chromium.org/537703003
Cr-Commit-Position: refs/heads/master@{#293229}
|
|
|
|
|
|
|
|
|
|
|
| |
redirect headers
BUG=338338
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/524983002
Cr-Commit-Position: refs/heads/master@{#293228}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently there is not enough unit test cases available to cover
the functionality of Paste Popup menu behavior. This patch covers
essential unit test cases for the same.
BUG=
Review URL: https://codereview.chromium.org/534343002
Cr-Commit-Position: refs/heads/master@{#293222}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apart from the places which expect a SyncLoadResult, it's only read in
RedirectToFileResourceHandler. In that case, it's always net::OK;
ResourceLoader checks request_->status().is_success() first in
OnResponseStarted before calling CompleteResponseStarted().
BUG=none
Review URL: https://codereview.chromium.org/517853004
Cr-Commit-Position: refs/heads/master@{#293216}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Trying to initialize it causes content_shell --enable-browser-side-navigation
to crash on startup.
It corresponds to ResourceRequestInfo::GetVisibilityState, but that's only used
for categorizing requests made from prerender which needs a different bit
(WebPageVisiblityStatePrerender vs. others), so we'll need to revisit it
anyway.
BUG=376014
Review URL: https://codereview.chromium.org/534393002
Cr-Commit-Position: refs/heads/master@{#293211}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This callback has the reentrance issue as calling MediaPlayerBridge::Release() will call into function.
The worst case happens when BrowserMediaPlayerManager dtor is called. In that case, this function will be called on each player, while BMPM is in a partially destroyed state.
Since BMPM controls the lifetime of the players, it can call OnMediaResourcesReleased() when it calls Release() on a player.
For MSE case, we also simplified the situation here since we can check MSP::IsSurfaceInUse(). This CL also fixes that call.
BUG=410096
Review URL: https://codereview.chromium.org/534063002
Cr-Commit-Position: refs/heads/master@{#293207}
|
|
|
|
|
|
|
|
|
|
|
| |
These were failing on Android Builder (dbg) FYI bot.
BUG=409152
TBR=qinmin@chromium.org
Review URL: https://codereview.chromium.org/522943003
Cr-Commit-Position: refs/heads/master@{#293206}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes the passed parameter of device_scale_factor and in BrowserPlugin::UpdateDeviceScaleFactor since it's not used.
This CL also removes GetSizeParams because it's only used once.
Repaints are now set whenever the device scale factor changes.
Also remove all calls to .get() on scoped_ptrs which are unnecessary.
BUG=none
TBR=creis@chromium.org for trivial render_view_impl change.
Review URL: https://codereview.chromium.org/528383003
Cr-Commit-Position: refs/heads/master@{#293197}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are removing the corresponding runtime flag in Blink, as it currently
has no effect. This patch removes its usage in Chromium side.
Blink side: https://codereview.chromium.org/535463002/
BUG=None
Review URL: https://codereview.chromium.org/530353002
Cr-Commit-Position: refs/heads/master@{#293195}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes sure that the renderer is initialized before being used to handle
a navigation that has just committed.
BUG=376082
Review URL: https://codereview.chromium.org/536473002
Cr-Commit-Position: refs/heads/master@{#293191}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
key of BT keyboard
Browser should go back to video page(having inline video) through
escape key of BT keyboard instead of goig back to main page.
BUG=396996
Review URL: https://codereview.chromium.org/439433004
Cr-Commit-Position: refs/heads/master@{#293181}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:240001 of https://codereview.chromium.org/490393002/)
Reason for revert:
crbug.com/410360 (Browser crashing on IOSurfaceLayer release in tab_switching.typical_25)
Original issue's description:
> Simplify IOSurface CoreAnimation code: Part 2
>
> It isn't necessary to mess around with sharing CGLContextObjs anymore,
> they were necessary only to share data between the frame subscriber
> and the RenderWidgetHostViewMac. Just give each IOSurfaceLayer its
> own CGLContextObj, and draw using immediate mode (using shaders
> resulted in an increase in startup time).
>
> BUG=314190
> TBR=pfeldman@chromium.org
> R=kbr@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/a83898264f64ad83bb98139e5e0dcb2c77db1997
TBR=kbr@chromium.org,ccameron@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=314190
Review URL: https://codereview.chromium.org/528403002
Cr-Commit-Position: refs/heads/master@{#293174}
|
|
|
|
|
|
|
|
| |
BUG=380349
Review URL: https://codereview.chromium.org/479873002
Cr-Commit-Position: refs/heads/master@{#293166}
|
|
|
|
|
|
|
|
|
|
|
| |
also remove some useless buffer size uma stat code.
BUG=410258
TEST=content_unittests --gtest_filter="*WebRtcAudioRenderer*"
Review URL: https://codereview.chromium.org/539453003
Cr-Commit-Position: refs/heads/master@{#293162}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
3) Rename methods to use CamelCase style.
4) Rename file name to test_plugin.
BUG=331299
Review URL: https://codereview.chromium.org/469943003
Cr-Commit-Position: refs/heads/master@{#293160}
|
|
|
|
|
|
|
|
|
| |
BUG=110610
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/532833003
Cr-Commit-Position: refs/heads/master@{#293159}
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceWorkerRegistration::unregister to boolean (4/4)
BUG=390894
TEST=N/A
Review URL: https://codereview.chromium.org/509283003
Cr-Commit-Position: refs/heads/master@{#293154}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The unit test framework brings up blink, so we have an initialized
isolate we can just use.
BUG=none
R=andrewhayden@chromium.org,dmichael@chromium.org
Review URL: https://codereview.chromium.org/537543002
Cr-Commit-Position: refs/heads/master@{#293133}
|
|
|
|
|
|
|
|
|
|
| |
UserMediaClientImpl's purpose is to implement blink::WebUserMediaClient and does not implement a MediaStream. Thus the class is renamed to reflect this.
BUG=409560
Review URL: https://codereview.chromium.org/524363003
Cr-Commit-Position: refs/heads/master@{#293132}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
glitches".
Original patch can be found at https://codereview.chromium.org/534533002
TBR=tommi
BUG=NONE
Review URL: https://codereview.chromium.org/535033003
Cr-Commit-Position: refs/heads/master@{#293124}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a modified due to the regression caused by
https://codereview.chromium.org/415343003/. The test case now checks the
number of items in the menu list to not include items with "display: none"
[1] https://codereview.chromium.org/475723002/ patch that fixes the regression.
BUG=398051,403299
R=tkent
Review URL: https://codereview.chromium.org/475733002
Cr-Commit-Position: refs/heads/master@{#293119}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need, for example, to test that ServiceWorkers can't be registered on
unauthenticated origins[1]. This patch allows '*.test' as a valid URL
for tests, and teaches content shell how to resolve them if (and only
if) the '--dump-render-tree' flag is set.
'.test' is a reserved gTLD[3], and is also used by the W3C's Web Platform
Tests[3]; it seems like the best choice of suffix for layout tests.
[1]: http://w3c.github.io/webappsec/specs/mixedcontent/#authenticated-origin
[2]: http://newgtlds.icann.org/applicants/agb
[3]: https://github.com/w3c/web-platform-tests#running-the-tests
BUG=410190
Review URL: https://codereview.chromium.org/529403002
Cr-Commit-Position: refs/heads/master@{#293106}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It isn't necessary to mess around with sharing CGLContextObjs anymore,
they were necessary only to share data between the frame subscriber
and the RenderWidgetHostViewMac. Just give each IOSurfaceLayer its
own CGLContextObj, and draw using immediate mode (using shaders
resulted in an increase in startup time).
BUG=314190
TBR=pfeldman@chromium.org
R=kbr@chromium.org
Review URL: https://codereview.chromium.org/490393002
Cr-Commit-Position: refs/heads/master@{#293103}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
glitches."
This reverts commit 03573630c9619e21c299eef4fd41c8704421d2a6 for
breaking Android build.
TBR=henrika@chromium.org
Review URL: https://codereview.chromium.org/538443002
Cr-Commit-Position: refs/heads/master@{#293102}
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Manual test of WebRTC clients under heavy load.
R=asvitkine@chromium.org, tommi@chromium.org
Review URL: https://codereview.chromium.org/534533002
Cr-Commit-Position: refs/heads/master@{#293099}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceWorkerRegistration::unregister to boolean
1. [Blink] https://codereview.chromium.org/515083002/
2. [Chromium] This patch
3. [Blink] https://codereview.chromium.org/512163002/
4. [Chromium] https://codereview.chromium.org/509283003/
BUG=390894
TEST=N/A
Review URL: https://codereview.chromium.org/516823003
Cr-Commit-Position: refs/heads/master@{#293083}
|
|
|
|
|
|
|
|
|
| |
BUG=410126
TEST=content_unittests
Review URL: https://codereview.chromium.org/536453007
Cr-Commit-Position: refs/heads/master@{#293082}
|
|
|
|
|
|
|
|
|
|
|
| |
The Related CL:
https://codereview.chromium.org/515843002/
BUG=282040
Review URL: https://codereview.chromium.org/512603003
Cr-Commit-Position: refs/heads/master@{#293081}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/459553003/)
Reason for revert:
Causing a bunch of top crashes:
go/crash/c383c0c43c093ea1
go/crash/576a27ecf5f32094
go/crash/08fc74881d1819ac
go/crash/a6a00150ba55c0bf
Original issue's description:
> Replace NPObject usage in ppapi with gin
>
> This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.
>
> There are 4 major parts to this CL:
> 1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
> 2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
> 3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
> 4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.
>
>
> BUG=351636
>
> Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ee49e63baf57e503bd71dfe61c8a80df63eac9aa
>
> Committed: https://chromium.googlesource.com/chromium/src/+/e06bc5d896e494b9ec556f0e89dcc523778a1432
TBR=jochen@chromium.org,dmichael@chromium.org,kolczyk@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=351636
Review URL: https://codereview.chromium.org/537483002
Cr-Commit-Position: refs/heads/master@{#293079}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The hang monitor is supposed to wait for 30 seconds of inactivity before
deciding that a renderer is not responsive. This CL makes sure that when
waiting for multiple input events, receiving an ack is correctly interpreted
as a responsive renderer (for that moment)
BUG=336198
Review URL: https://codereview.chromium.org/535653002
Cr-Commit-Position: refs/heads/master@{#293060}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added UMAs for:
1) The % of fullscreen video that is opened in portrait mode
2) The % of the video is suited for portrait mode
3) How long does a video play before user rotate the screen to landscape mode
4) How long video plays after user rotate the screen to landscape mode
5) How long does a video play before user rotate to portrait mode
6) The % of a video that the user switched from portrait to landscape mode
BUG=326572
Review URL: https://codereview.chromium.org/297773004
Cr-Commit-Position: refs/heads/master@{#293045}
|
|
|
|
|
|
|
|
| |
BUG=378975
Review URL: https://codereview.chromium.org/508493003
Cr-Commit-Position: refs/heads/master@{#293029}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Proguard strips these methods if they are not annotated because they
are only used in tests.
TBR=brettw
BUG=163393
Review URL: https://codereview.chromium.org/528963003
Cr-Commit-Position: refs/heads/master@{#293009}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add usrsctp. Make Windows version configurable for this in the build.
direct_dependent_configs for libsrtp.
R=hclam@chromium.org
Review URL: https://codereview.chromium.org/534713003
Cr-Commit-Position: refs/heads/master@{#293004}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android's vsync listener will now only dispatch a BeginFrame message if
such was requested. This exposed a hole in our BeginFrame request
pipeline, where short-circuited touch forwarding would bypass the vsync
request. Instead, always request the BeginFrame if a touch event was
received from the platform, potentially reducing the first frame's
latency when the page lacks a touch handler.
latency.
BUG=408377
Review URL: https://codereview.chromium.org/535453002
Cr-Commit-Position: refs/heads/master@{#292992}
|
|
|
|
|
|
|
|
|
|
| |
This fixes all non-RTC-related linker errors for Chrome.
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/533743004
Cr-Commit-Position: refs/heads/master@{#292978}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently there is not enough unit test cases available to cover
the functionality of Text Selection Action Bar. In this patch covering
essentail unit test cases for the same.
BUG=
Review URL: https://codereview.chromium.org/521583003
Cr-Commit-Position: refs/heads/master@{#292971}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/477973002/)
Reason for revert:
Failing on content_unittests
EmptyKeys_1
TwoKeys_1
TwoKeysThenOne_1
on Linux ASAN LSAN
Original issue's description:
> Add Keys() function to ServiceWorkerCache.
>
> Other changes:
> * Introduced a ReadHeaders helper function which reads headers from a cache entry into a protobuf. This is used by Match() and Keys().
>
>
> BUG=392621
>
> Committed: https://chromium.googlesource.com/chromium/src/+/02812f0a3edcacca1f7e05ea0a47cb3d8c6025e1
TBR=michaeln@chromium.org,gavinp@chromium.org,jkarlin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392621
Review URL: https://codereview.chromium.org/534683002
Cr-Commit-Position: refs/heads/master@{#292970}
|
|
|
|
|
|
|
|
|
|
| |
-Stop all media playback on an undoable tab close
BUG=388600
Review URL: https://codereview.chromium.org/493253002
Cr-Commit-Position: refs/heads/master@{#292959}
|
|
|
|
|
|
|
|
|
| |
BUG=349211
TEST=All existing tests pass.
Review URL: https://codereview.chromium.org/416393003
Cr-Commit-Position: refs/heads/master@{#292958}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently this code was being hit on Android. This CL implements the scroll
offset the same way it's implemented on other platforms.
BUG=409792
NOTRY=true
TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/533483004
Cr-Commit-Position: refs/heads/master@{#292956}
|
|
|
|
|
|
|
|
|
|
|
| |
Maps folks have confirmed that it is public data, the same you'd get by
visiting the site.
BUG=
Review URL: https://codereview.chromium.org/526833003
Cr-Commit-Position: refs/heads/master@{#292954}
|
|
|
|
|
|
|
|
|
|
|
| |
Other changes:
* Introduced a ReadHeaders helper function which reads headers from a cache entry into a protobuf. This is used by Match() and Keys().
BUG=392621
Review URL: https://codereview.chromium.org/477973002
Cr-Commit-Position: refs/heads/master@{#292945}
|