| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
OriginBoundCertService::GetOriginBoundCert takes a vector of requested cert
types in order of preferrence and will return or generate one of an acceptable
type.
BUG=88782
TEST=net_unittests, unit_tests
Review URL: http://codereview.chromium.org/8662036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=105220
Review URL: http://codereview.chromium.org/8727014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=88782
TEST=X509UtilNSSTest
Review URL: http://codereview.chromium.org/8537025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
certs.
BUG=88782
TEST=X509UtilNSSTest
Review URL: http://codereview.chromium.org/8537025
TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/8764017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=88782
TEST=X509UtilNSSTest
Review URL: http://codereview.chromium.org/8537025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1, meaning that the without-'\0' string is non-empty. This replaces the conditional code added recently that makes this case return NULL. It's easier to understand if it's simply an error to call WriteInto() in this case at all.
Add DCHECK()s or conditionals as appropriate to callers in order to ensure this assertion holds.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8418034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this patch also adds a comment that describes why
EAI_NODATA is disabled on FreeBSD
BUG=
TEST=
TBR=wtc
Review URL: http://codereview.chromium.org/8598010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=crypto_unittests
Review URL: http://codereview.chromium.org/8499032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8429034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These will be used to resume hash generation when a download is interrupted and later resumed.
BUG=None.
TEST=SecureHashTest.TestSerialization
Review URL: http://codereview.chromium.org/8588057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is part of a larger effort to replace opencryptoki as the PKCS #11 layer in Chrome OS. In this first phase, libchaps.so forwards requests to a daemon (chapsd) which loads opencryptoki to service the requests. You can find the Chaps design doc here: https://docs.google.com/a/google.com/document/d/1TQFc6GABKa1JgwUx2hIcxAHQ329fkd03yYlGxhfHQlQ/edit
Change-Id: I42962c4703413039641b6ede40caaf0c97ab900e
BUG=chromium-os:21005
TEST=* Ensure previously existing certs still exist.
* Import new cert and private key from PKCS12 file.
Review URL: http://codereview.chromium.org/8527006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "Fix leak in X509UtilNSSTest VerifyCertificateSignature."
BUG=88782
TEST=none
TBR=cpu@chromium.org
Review URL: http://codereview.chromium.org/8587018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=88782
TEST=X509UtilNSSTest
Review URL: http://codereview.chromium.org/8537025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)
BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/8491043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=unittests
Review URL: http://codereview.chromium.org/8533028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When trying to include the real NSS headers from other files under
crypto/third_party/nss, the local versions would get used on the MSVS
build.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8538025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The implementation uses NSS on all platforms unless USE_OPENSSL is defined
(which is only stubbed out in this CL).
BUG=88782
TEST=ECPrivateKeyUnitTest
Review URL: http://codereview.chromium.org/8413024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(Landed in r108866, reverted in r108869 due to shared library build issues.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended to be the underlying group for an EKE implementation for
Remoting.
BUG=none
TEST=crypto_unittests
Review URL: http://codereview.chromium.org/8431007
TBR=agl@chromium.org
Review URL: http://codereview.chromium.org/8467016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended to be the underlying group for an EKE implementation for
Remoting.
BUG=none
TEST=crypto_unittests
Review URL: http://codereview.chromium.org/8431007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It will import any certificates in an ONC file into the certificate
database. It does not yet associate the given GUID for the
certificate with the certificate added to the database. That will
happen in an upcoming CL.
This also adds test cases for importing each type of certificate.
BUG=chromium-os:19404,chromium-os:19406
TEST=Ran new unit test cases. Imported ONC file with a certificate
and saw that it appeared in the certificate manager.
Review URL: http://codereview.chromium.org/8403007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=wtc@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8396003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
instead of TPM slots.
BUG=chromium-os:21633
TEST=make sure that user signin works properly on Alex - we should not show Gaia signin screen on second login after system resote
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106881
Review URL: http://codereview.chromium.org/8373022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instead of TPM slots.
BUG=chromium-os:21633
TEST=make sure that user signin works properly on Alex - we should not show Gaia signin screen on second login after system resote
Review URL: http://codereview.chromium.org/8373022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net/base/host_resolver_proc.cc:
- define AI_ADDRCONFIG as 0
net/base/listen_socket.cc:
- Shuffle and add missing headers since the order
of including these matters.
net/base/net_util.h:
- Missing header for all POSIX platforms. Needed on
OpenBSD and it won't hurt others.
net/dns/dns_config_service_posix.h:
- Missing header for OpenBSD. The order matters here too
net/dns/dns_config_service_posix.cc:
- Use res_init() on OpenBSD and disable RES_ROTATE
if it is not defined
net/net.gyp:
- Do not use libresolv on OpenBSD since it's not there,
the resolver is in libc.
- Include base/platform_mime_util_linux.cc in the OpenBSD builds.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8336024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
because we thought it might be the cause of crashes
when getting SPDY certs. http://crosbug.com/21693
We've tested that, and it doesn't appear to be the cause.
So, I'm resubmitting the code from review 8212003
TBR=gauravsh@chromium.org
BUG=chromium-os:21693, chromium-os:20933
TEST=Built with and without change, and tested SPDY proxy setup on an alex.
Review URL: http://codereview.chromium.org/8349020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The platform RSAPrivateKey is used to generate the private key, which is then imported into NSS to generate the certificate.
X509Certificate::CreateOriginBound is moved to x509_util::CreateOriginBoundCert so it can be shared by those platforms, and removes the unnecessary X509Certificate generation step.
BUG=88782
TEST=X509UtilNSSTest.CreateOriginBoundCert & manual testing: try on win or mac, check if generated cert has the OBC extension.
Review URL: http://codereview.chromium.org/8296014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
** Because of crash bug http://crosbug.com/21693, I'm going to revert
this until gaurav or I can take a look **
Original Review URL: http://codereview.chromium.org/8212003
BUG=chromium-os:20933,chromium-os:21693
TBR=gauravsh@chromium.org
Review URL: http://codereview.chromium.org/8289019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current TPM token setup logic attempts initialization once after
the user logs in. Asynchronous attempts for TPM token setup are not
triggered unless the user opens the VPN or WiFi config panel (attempt
retries are triggered via a call to CertLibraryImpl::RequestCertificates()).
This means that if the first attempt fails and the user never opens
up the WiFi config or VPN config panel, the TPM token will stay
uninitialized. This breaks the certificate manager (list of certs is
empty), the SPDY proxy extension, amongst other things.
Essentially, any part of the network subsystem that depends on the
private hardware NSS slot (via crypto::GetPrivateNSSKeySlot) stays
broken if the first attempt fails. (So, this is not just an issue with
the list of certs not being displayed correctly).
This CL changes that so that retry logic for TPM token init is
triggered right after the user logs in.
BUG=chromium-os:20933
TEST=Log in, verify from logs that TPM initialization attempts start
immediately after. Verify that the missing certificates issue
no longer happens.
Change-Id: I9c609bdb198a88db8ceb2019cc92c19d1983bc05
Review URL: http://codereview.chromium.org/8212003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8124011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=99053,91962
TEST=Manual
Review URL: http://codereview.chromium.org/8143012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build with component=shared_library use_openssl=1
Review URL: http://codereview.chromium.org/8166003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(I didn't try and understand or fix why kSHA1Length is in base:: while kSHA256Length is in crypto::.)
BUG=92247
TEST=compiles
Review URL: http://codereview.chromium.org/7972024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This defines the constant where it's declared to preserve the existing readability.
Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that. Will be watching the trybots...
The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but in general naming enums used to declare constants like this is bizarre ("enum Constants { ... }"?).
BUG=92247
TEST=Compiles
Review URL: http://codereview.chromium.org/7823004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Birth/Death tracking of tasks has been moved out-of-band into MessageLoop's PendingTask structure.
Thus, Task no longer needs to inherit from Tracked. Since Task was the only child of Tracked, delete the Tracked class and move Location to its own file.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/7879006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:18633
TEST=none
Review URL: http://codereview.chromium.org/7756025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=87171
TEST=none
Review URL: http://codereview.chromium.org/7776025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7670016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the project files.
BUG=92102
Review URL: http://codereview.chromium.org/7528010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=rvargas@chromium.org
Review URL: http://codereview.chromium.org/7491061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7522014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=crypto_unittests --gtest_filter=HMACTest.*
Review URL: http://codereview.chromium.org/7532020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=90078
TEST=none
Review URL: http://codereview.chromium.org/7532023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
building component DLLs, it doesn't hurt to always define them, and it makes
the GYP files a bit simpler.
R=rvargas@chromium.org
Review URL: http://codereview.chromium.org/7457016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Follow up to http://codereview.chromium.org/7342047/
stl_util.h seems out of favor, so calling stl method directly as required.
BUG=None
TEST=Greeness on http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Redux/
Review URL: http://codereview.chromium.org/7457021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removed unused/irrelevant functions
removed irrelevant comments
Moved stl_util-inl.h => stl_util.h
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7342047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=crypto_unittests
Review URL: http://codereview.chromium.org/7277024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids the need to define FOO_DLL macros for each project that we wish to
optionally build as a DLL (when component=="shared_library"). This in turn
means that we do not need direct_dependent_settings to define FOO_DLL, and that
means that we don't need to update projects to convert transitive dependencies
into explicit dependencies. This makes the component build more consistent
with the static build.
An alternative would be to use all_dependent_settings, but I feel that the
global approach is simpler as it creates less repetition in each target
definition for components.
A side-effect of this change is that I needed to make base_nacl_win64 be a
shared_library in the component build.
R=rvargas,bradnelson,evan
Review URL: http://codereview.chromium.org/7344022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=component build works for chromeos
Review URL: http://codereview.chromium.org/7342033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change broke compilation on Linux Builder (dbg)(shared):
http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29%28shared%29/builds/3365/steps/compile/logs/stdio
TBR=darin
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7352014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92329 0039d316-1c4b-4281-b951-d872f2087c98
|