summaryrefslogtreecommitdiffstats
path: root/dbus
Commit message (Collapse)AuthorAgeFilesLines
* [Cleanup] Remove StringPrintf from global namespacegroby@chromium.org2013-03-181-14/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | use of StringPrintf now requires prefixing with base:: or a per-scope using directive TBR'd: abodenha: chrome/service brettw: content, third_party, webkit darin: base, chrome/browser, chrome/renderer dgarret: courgette enne: cc fischmann: media gbillock: sql joi: google_apis,components rsleevi: net, crypto sky: chrome/test thestig: printing, chrome/common, tsepez: ipc wez: remoting yfriedman: testing/android NOTRY=true R=brettw@chromium.org TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org BUG= Review URL: https://codereview.chromium.org/12767006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188857 0039d316-1c4b-4281-b951-d872f2087c98
* Connect SparseHistogram with the rest of stats systemkaiwang@chromium.org2013-03-011-1/+1
| | | | | | | | | | | | | With this CL, SparseHistogram is usable with SparseHistogram::FactoryGet. Next step is to implement a Histogram like macro and implement WriteHTMLGraph and WriteAscii to have a nice output. BUG=139612 Review URL: https://chromiumcodereview.appspot.com/12207058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185451 0039d316-1c4b-4281-b951-d872f2087c98
* DBus: Use TaskRunners instead of MessageLoopProxies.thestig@chromium.org2013-02-2011-78/+74
| | | | | | Review URL: https://chromiumcodereview.appspot.com/12255043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183362 0039d316-1c4b-4281-b951-d872f2087c98
* Supporting callback for Disconnected signal.nona@chromium.org2013-02-153-4/+47
| | | | | | | | | | | | | If the connection with dbus-daemon is closed, callback function set with SetDisconnectedCallback will be called. BUG=None TEST=ran dbus_unittests Review URL: https://chromiumcodereview.appspot.com/12224139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182736 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary condition.nona@chromium.org2013-02-131-5/+0
| | | | | | | | | | | | | ShutdownAndBlock function can be called multiple times safely. So checking |shutdown_completed_| in OnDisonnected function is not necessary. BUG=174431 TEST=Checked no crash at sing out. Review URL: https://chromiumcodereview.appspot.com/12212133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182161 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove deprecated base::Value methods from dbus. Use base::Value too.thestig@chromium.org2013-02-122-71/+76
| | | | | | Review URL: https://chromiumcodereview.appspot.com/12207091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181989 0039d316-1c4b-4281-b951-d872f2087c98
* Call get_dispatch_status function to handle Disconnected signal.nona@chromium.org2013-02-082-7/+64
| | | | | | | | | | | | | It turns out that dbus_connection_get_dispatch_status should be called even if the connection is lost, otherwise we miss "Disconnected" signal. BUG=174431 TEST=Manually done on alex and ran dbus_unittests. Review URL: https://chromiumcodereview.appspot.com/12211022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181479 0039d316-1c4b-4281-b951-d872f2087c98
* Code cleaning: Uses scoped_ptr<> to express ownership rather than writing ↵yuki@chromium.org2013-02-079-103/+107
| | | | | | | | | | | | | | ownership in comments. Replaces Response* with scoped_ptr<Response> in dbus code and its related code. BUG=163231 TEST=no regression / no behavior changes Review URL: https://chromiumcodereview.appspot.com/12092061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181266 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTTF: Add missing virtual destructors."phajdan.jr@chromium.org2013-02-061-1/+0
| | | | | | | | | | | | | | It turned out this is not necessary, we have a better warning already enabled in clang (-Wdelete-non-virtual-dtor, part of -Wall). TBR=darin,satorux,fischman,jamesr,jar,sky BUG=45135 Review URL: https://codereview.chromium.org/12224027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180971 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Add missing virtual destructors.phajdan.jr@chromium.org2013-02-051-0/+1
| | | | | | | | | | | R=jar TBR=darin,satorux,fischman,jamesr,sky BUG=45135 Review URL: https://codereview.chromium.org/12086018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180669 0039d316-1c4b-4281-b951-d872f2087c98
* DBus: Bus::AddMatch and RemoveMatch support repeated rules.deymo@chromium.org2013-01-314-12/+68
| | | | | | | | | | | | | | This fix counts the number of times the same rule is added to a dbus::Bus and removes the rule from the real DBus connection when all the copies of the same match rule have been removed. BUG=chromium:173054 TEST=BusTest.DoubleAddAndRemoveMatch passes. Review URL: https://chromiumcodereview.appspot.com/12088068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179809 0039d316-1c4b-4281-b951-d872f2087c98
* D-Bus: ObjectProxy remove function for Bus object.deymo@chromium.org2013-01-293-16/+142
| | | | | | | | | | | | | | | | This implements a remove function for an ObjectProxy owned by a bus object. Although the Bus object removes all the objects at shutdown, this functions permits to reduce the memory usage for objects no longer needed and reduce the number of dbus matching rules used in the bus connection. BUG=chromium:170182 TEST=BusTest.RemoveObjectProxy (run out/Debug/dbus_unittests) Review URL: https://chromiumcodereview.appspot.com/12022004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179400 0039d316-1c4b-4281-b951-d872f2087c98
* DBus: Fixes a flaky test case.deymo@chromium.org2013-01-241-3/+11
| | | | | | | | | | | | | | | | | | In the UnregisterExportedObject test, an ExportedObject is created, destroyed and created again as a new object. The test assumes the new object is different from the first one just comparing the memory pointers to those objects. Nevertheless, the memory manager could possibly alloc the same memory address for the second object since the first one was already destroyed. This fixes this situation preventing the first object from being destroyed incrementing its reference count. BUG=chromium:137846 TEST=test enabled. Review URL: https://chromiumcodereview.appspot.com/12039033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178450 0039d316-1c4b-4281-b951-d872f2087c98
* Make DBusStatistics only run on the main thread and add additional CHECKs to ↵stevenjb@chromium.org2013-01-092-1/+17
| | | | | | | | | | | | | ensure thread safety. Calls from other threads will be ignored. Currently the only DBus calls from other threads are for Geolocation. Supporting statistics gathering across multiple threads is unnecessary overhead that we don't currently need. BUG=168134 Review URL: https://chromiumcodereview.appspot.com/11761015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175706 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: No more FLAKY_ .phajdan.jr@chromium.org2012-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | Please note that FLAKY_ tests have been ignored anyway. When tests started crashing, people just flipped that to DISABLED_ . Why not go straight to DISABLED_ then, so that we avoid wasting time on stupid test prefix games? With DISABLED_ it is clear to everyone that there is no coverage from given test. FLAKY_ creates an illusion of coverage, while in fact the test is still ignored. If a FLAKY_ test fails and nobody notices, does it still make a sound? ;-) Finally, note that gtest has a --gtest_also_run_disabled_tests if you need to run tests manually. TBR=jam BUG=none Review URL: https://codereview.chromium.org/11664013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174472 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Add comments about object ownershipsatorux@chromium.org2012-11-291-14/+21
| | | | | | | | | BUG=163231 TEST=none Review URL: https://codereview.chromium.org/11416252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170117 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SignalSenderVerificationTest.TestMultipleObjectskeybuk@chromium.org2012-11-271-1/+2
| | | | | | | | TBR=gauravsh@chromium.org BUG=chromium-os:36486 Review URL: https://codereview.chromium.org/11421086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169546 0039d316-1c4b-4281-b951-d872f2087c98
* Allow multiple object proxies to handle NameOwnerChangedkeybuk@chromium.org2012-11-272-7/+75
| | | | | | | | | | | | | | | | Multiple object proxies may be registered for any single D-Bus service, one per interface. Returning "handled" means only the first interface object proxy gets to handle the signal, others never see it. Change to always return "not yet handled", while this means D-Bus never knows we actually handled the NameOwnerChanged signal, that's quite ok and is actually what all other bindings do for all signals. Submitted as -r169164 but reverted in -r169170; resubmitted with change to run message loop three times if necessary. BUG=chromium-os:36486 TEST=dbus_unittests TBR=gauravsh@chromium.org Review URL: https://codereview.chromium.org/11280073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169538 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 169164 - Allow multiple object proxies to handle NameOwnerChangedlambroslambrou@google.com2012-11-222-78/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Failed on Linux ChromiumOS Tests: SignalSenderVerificationTest.TestMultipleObjects: [4218:4244:1121/160846:447516037:ERROR:object_proxy.cc(624)] Failed to get name owner. Got org.freedesktop.DBus.Error.NameHasNoOwner: Could not get owner of name 'org.chromium.TestService': no such name [4218:4244:1121/160846:447531010:ERROR:bus.cc(444)] Failed to get the ownership of org.chromium.TestService: [4218:4248:1121/160846:447531228:ERROR:test_service.cc(134)] Failed to own: org.chromium.TestService dbus/signal_sender_verification_unittest.cc:302: Failure Value of: on_name_owner_changed_called_ Actual: false Expected: true [4218:4244:1121/160846:447535382:ERROR:bus.cc(604)] Requested to remove an unknown match rule: type='signal',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',sender='org.freedesktop.DBus',arg0='org.chromium.TestService' http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/12886/steps/dbus_unittests/logs/TestMultipleObjects Multiple object proxies may be registered for any single D-Bus service, one per interface. Returning "handled" means only the first interface object proxy gets to handle the signal, others never see it. Change to always return "not yet handled", while this means D-Bus never knows we actually handled the NameOwnerChanged signal, that's quite ok and is actually what all other bindings do for all signals. BUG=chromium-os:36486 TEST=dbus_unittests Review URL: https://chromiumcodereview.appspot.com/11280073 TBR=keybuk@chromium.org Review URL: https://codereview.chromium.org/11299149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169170 0039d316-1c4b-4281-b951-d872f2087c98
* Allow multiple object proxies to handle NameOwnerChangedkeybuk@chromium.org2012-11-212-7/+78
| | | | | | | | | | | | | Multiple object proxies may be registered for any single D-Bus service, one per interface. Returning "handled" means only the first interface object proxy gets to handle the signal, others never see it. Change to always return "not yet handled", while this means D-Bus never knows we actually handled the NameOwnerChanged signal, that's quite ok and is actually what all other bindings do for all signals. BUG=chromium-os:36486 TEST=dbus_unittests Review URL: https://chromiumcodereview.appspot.com/11280073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169164 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix header includes for system protobuf.phajdan.jr@chromium.org2012-11-211-0/+5
| | | | | | | | | BUG=157155 Review URL: https://chromiumcodereview.appspot.com/11418102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168945 0039d316-1c4b-4281-b951-d872f2087c98
* Add DBusStatistics and DBusLogSource to log and show dbus statsstevenjb@chromium.org2012-11-145-2/+543
| | | | | | | | | | | | | | | The intention of this is to provide low overhead detailed logging to ensure that dbus call counts remain reasonable as we migrate NetworkLibrary and other systtems from src/chrome to src/chromeos. We already have UMA stats which provide high level numbers that we can watch, but this will make detailed debugging available for advanced users and in feedback reports. BUG=159635 For chrome/chrome_browser_chromeos.gypi: TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11363173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167742 0039d316-1c4b-4281-b951-d872f2087c98
* Move eintr_wrapper.h from base to base/posixbrettw@chromium.org2012-11-141-1/+1
| | | | | | Review URL: https://codereview.chromium.org/11366229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167739 0039d316-1c4b-4281-b951-d872f2087c98
* Make SignalSenderVerificationTest more robustharuki@chromium.org2012-11-145-33/+153
| | | | | | | | | | | | | | | Add more assertions and a callback to check the result of RequestOwnership. Original test can hang when test_service2_ tries to acquire the ownership before D-Bus recognizes test_service_'s disconnection. In that situation, test_service2_ cannot own the name and cannot send a message. BUG=158689 TEST=unittests Review URL: https://chromiumcodereview.appspot.com/11358111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167649 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: change protobuf default option to allow building"nyquist@chromium.org2012-11-121-1/+3
| | | | | | | | | | | | | | | | | This reverts commit baefae90f294a981c973bffbdd3eccabfe796b6a. The change broke Chrome for Android because non-vanilla protobuf-lite Java files were generated. Original review: https://codereview.chromium.org/11228038/ TBR=phajdan.jr BUG=160256 Review URL: https://codereview.chromium.org/11359146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167242 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: change protobuf default option to allow buildingphajdan.jr@chromium.org2012-11-071-3/+1
| | | | | | | | | | | | | | | | | | with unpatched system protobuf. This is a preparation for landing https://codereview.chromium.org/11231046/ and a solution chosen because our custom protobuf changes will not be accepted upstream. Setting defaults to optimize for lite runtime and retain unknown fields makes it possible to use the same .proto files with system protobuf. BUG=157155 TEST=none Review URL: https://codereview.chromium.org/11228038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166534 0039d316-1c4b-4281-b951-d872f2087c98
* disable flaky dbus_unittests SignalSenderVerificationTest.TestOwnerChangescottmg@chromium.org2012-11-061-1/+1
| | | | | | | | | | TBR=haruki@chromium.org BUG=159639 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11374002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166234 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Make it possible to build as shared_library.tfarina@chromium.org2012-11-0511-22/+83
| | | | | | | | | | BUG=158887 R=satorux@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11364033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165893 0039d316-1c4b-4281-b951-d872f2087c98
* Call dbus_bus_register at the beginning of connection.nona@chromium.org2012-11-021-0/+13
| | | | | | | | | | | | | | | According to dbus specification in "Message Bus Messages" section (http://dbus.freedesktop.org/doc/dbus-specification.html), "Before an application is able to send messages to other applications it must send the org.freedesktop.DBus.Hello message to the message bus to obtain a unique name. " To meets this specification, we should call dbus_bus_register function which call org.freedesktop.DBus.Hello. For the dbus session or system bus, this function is called in dbus_bus_get function. BUG=159088 TEST=ran dbus_unittests Review URL: https://chromiumcodereview.appspot.com/11312036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165641 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Everybody can include from src/base/.tfarina@chromium.org2012-10-311-2/+1
| | | | | | | | | R=satorux@chromium.org NOTRY=True Review URL: https://chromiumcodereview.appspot.com/11343022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165178 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Reuse is_set() function from ScopedDBusError API.tfarina@chromium.org2012-10-292-3/+3
| | | | | | | | | R=satorux@chromium.org TEST=dbus_unittests Review URL: https://codereview.chromium.org/11266020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164651 0039d316-1c4b-4281-b951-d872f2087c98
* Add sender verification of D-Bus signals.haruki@chromium.org2012-10-296-17/+365
| | | | | | | | | | | | | | | | | | The CL does the following: - Add a match rule for NameOwnerChanged signal from org.freedesktop.DBus. - Update the owner of the well-known bus name when a NameOwnerChanged comes. - Call GetNameOwner method to update the latest if ObjectProxy instance does not know the owner. - Verify the sender of the signal and reject the unknown senders. - Add UMA_HISTOGRAM_COUNTS "DBus.RejectedSignalCount" for rejected signals. and a unittest. BUG=140938 TEST=manual, unittests Review URL: https://chromiumcodereview.appspot.com/11199007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164597 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all the "set noparent" directivesdpranke@chromium.org2012-10-191-1/+0
| | | | | | | | | | | | | Now that OWNERS supports per-file owners, we can limit the scope of the top-level wildcard to just DEPS, and make darin and ben owners for everything else and remove the broad use of "set noparent". R=ben@chromium.org, darin@chromium.org BUG=88315 Review URL: https://codereview.chromium.org/11191038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163069 0039d316-1c4b-4281-b951-d872f2087c98
* DBus: declare property specializationskeybuk@chromium.org2012-09-211-0/+60
| | | | | | | | | | | | | Without declaring the property specializations in the header file, the compiler can sometimes generate default constructors that don't initialize the variables correctly. BUG=none TEST=unit_tests pass Review URL: https://chromiumcodereview.appspot.com/10963037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158105 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Fix clang warnings about missing virtual and OVERRIDE annotations.tfarina@chromium.org2012-08-301-3/+3
| | | | | | | | | BUG=115047 TBR=satorux@chromium.org Review URL: https://chromiumcodereview.appspot.com/10900041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154116 0039d316-1c4b-4281-b951-d872f2087c98
* bluetooth: Create stub manager, adapter and device.keybuk@chromium.org2012-08-152-5/+20
| | | | | | | | | | | | | | | | | | | | These stub classes are used when building Chrome on Linux with chromeos=1. They allow sufficient UI to work to show a Bluetooth adapter, enable and disable it, and show an unconnected fake device associated with it. This can be trivially extended to provide all manner of fake Bluetooth information for UI development. BUG=chromium-os:28555 TEST=out/Debug/chrome Change-Id: I7af28be76355fad735389aaf2fa499d0a8dfd76b Review URL: https://chromiumcodereview.appspot.com/10823301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151621 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2012-07-251-1/+1
| | | | | | | | | | | | | | CID_COUNT=12 CID=104349,104361,104373,104374,104399,104420,104421,104422,104466,104476, 104532,104538 BUG=none TEST=none R=groby TBR=brettw,satorux,mnissler Review URL: https://chromiumcodereview.appspot.com/10833006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148430 0039d316-1c4b-4281-b951-d872f2087c98
* Expose functionality to tests.davemoore@chromium.org2012-07-253-14/+22
| | | | | | | | | | | Second try of https://chromiumcodereview.appspot.com/10815083 BUG=None TEST=None TBR=satorux Review URL: https://chromiumcodereview.appspot.com/10833011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148382 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 148351 - Make dbus file descriptor check dynamicdavemoore@chromium.org2012-07-252-19/+13
| | | | | | | | | | | | | | | Without this change cros builds from outside the chroot can't run tracing code. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10815083 TBR=davemoore@chromium.org Review URL: https://chromiumcodereview.appspot.com/10822016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148353 0039d316-1c4b-4281-b951-d872f2087c98
* Make dbus file descriptor check dynamicdavemoore@chromium.org2012-07-252-13/+19
| | | | | | | | | | | | Without this change cros builds from outside the chroot can't run tracing code. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10815083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148351 0039d316-1c4b-4281-b951-d872f2087c98
* Marking BusTest.UnregisterExportedObject as flakyjochen@chromium.org2012-07-181-1/+2
| | | | | | | | | | BUG=137846 TEST=none TBR=keybuk@chromium.org Review URL: https://chromiumcodereview.appspot.com/10797009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147234 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-1114-14/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to TimeDelta interface for TestTimeouts in dbus code.tedvessenes@gmail.com2012-07-091-3/+1
| | | | | | | | | | R=keybuk@chromium.org BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10735022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145714 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: move logic from Property<> to PropertySetkeybuk@chromium.org2012-06-282-149/+147
| | | | | | | | | | | | | | | | | | | | | | Rather than implement Get() and Set() in dbus::Property<> move the code into dbus::PropertySet and pass a pointer to the property to operate on from the wrapper call. The advange of this way of doing things is that it's much easier to make subclasses, since you only need to subclass dbus::PropertySet; and ths makes it possible to mock. BUG=chromium-os:28555 TEST=dbus_unittests Change-Id: I760ca608d1e0a17422c11e0115c053d98be33fe0 R=satorux@chromium.org Review URL: https://chromiumcodereview.appspot.com/10698027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144756 0039d316-1c4b-4281-b951-d872f2087c98
* Add a CONNECT_REQUESTED state to Network ConnectionState.stevenjb@google.com2012-06-191-0/+1
| | | | | | | | | | | | | | | | | | | | When a connection request is made, Chrome now sets the state to CONNECT_REQUESTED and ignores "Idle" state updates while in that state. This informs the UI to show "connecting" icons / text until the connection attempt succeeds or fails. Also: Don't update the network icon while scanning. Also: includes a bunch of logging changes for improved debugging. This alos fixes the mock expectations so that browser_tests should pass. Original CL: https://chromiumcodereview.appspot.com/10554013 BUG=125121 TEST=See issue, test connecting between networks, UI should behave correctly. For chrome/browser/chromeos/gdata: TBR=gspencer@chromium.org, tbarzic@chromium.org Review URL: https://chromiumcodereview.appspot.com/10579022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143072 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 142847 - Add a CONNECT_REQUESTED state to Network ConnectionState.kkania@chromium.org2012-06-191-1/+0
| | | | | | | | | | | | | | | | | | | When a connection request is made, Chrome now sets the state to CONNECT_REQUESTED and ignores "Idle" state updates while in that state. This informs the UI to show "connecting" icons / text until the connection attempt succeeds or fails. Also: Don't update the network icon while scanning. Also: includes a bunch of logging changes for improved debugging. BUG=125121 TEST=See issue, test connecting between networks, UI should behave correctly. For chrome/browser/chromeos/gdata: TBR=tbarzic@chromium.org Review URL: https://chromiumcodereview.appspot.com/10554013 TBR=stevenjb@google.com Review URL: https://chromiumcodereview.appspot.com/10536197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142889 0039d316-1c4b-4281-b951-d872f2087c98
* Add a CONNECT_REQUESTED state to Network ConnectionState.stevenjb@google.com2012-06-181-0/+1
| | | | | | | | | | | | | | | | When a connection request is made, Chrome now sets the state to CONNECT_REQUESTED and ignores "Idle" state updates while in that state. This informs the UI to show "connecting" icons / text until the connection attempt succeeds or fails. Also: Don't update the network icon while scanning. Also: includes a bunch of logging changes for improved debugging. BUG=125121 TEST=See issue, test connecting between networks, UI should behave correctly. For chrome/browser/chromeos/gdata: TBR=tbarzic@chromium.org Review URL: https://chromiumcodereview.appspot.com/10554013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142847 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Add test_server.cc used for manual testing.satorux@chromium.org2012-06-072-0/+46
| | | | | | | | | | | | | | The server was used for investigating crbug.com/126217. end_to_end_async_unittest.cc runs both the server and the client in the same process. It's useful to have a server program that runs as a separate process. BUG=none TEST=out/Debug/dbus_test_server; (from another terminal) dbus-send --print-reply --type=method_call --dest=org.chromium.TestService /org/chromium/TestObject org.chromium.TestInterface.SlowEcho string:hello Review URL: https://chromiumcodereview.appspot.com/10540032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141023 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Truncate strings in dbus::Message::ToString() if too longsatorux@chromium.org2012-06-073-2/+28
| | | | | | | | | | | To prevent long strings from polluting logs. BUG=131261 TEST=added a unit test Review URL: https://chromiumcodereview.appspot.com/10537033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141021 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly CHECK arguments in dbus::MessageWriter::AppendString/ObjectPathhashimoto@chromium.org2012-06-057-0/+109
| | | | | | | | | | | | Add dbus::IsStringValidObjectPath() and dbus::ObjectPath::IsValid() BUG=129335 TEST=dbus_unittests Review URL: https://chromiumcodereview.appspot.com/10502011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140489 0039d316-1c4b-4281-b951-d872f2087c98