summaryrefslogtreecommitdiffstats
path: root/dbus
Commit message (Collapse)AuthorAgeFilesLines
* dbus: Add comments about the right way to expose methodssatorux@chromium.org2014-01-094-12/+27
| | | | | | | | | | | Along the way, fix the order in the test service used in unit tests. BUG=332120 TEST=dbus_unittests pass as before Review URL: https://codereview.chromium.org/125673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243770 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Always return "not yet handled" for signalshashimoto@chromium.org2013-12-171-1/+3
| | | | | | | | BUG=327172 Review URL: https://codereview.chromium.org/115173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241222 0039d316-1c4b-4281-b951-d872f2087c98
* Run dbus_unittests serially.phajdan.jr@chromium.org2013-12-062-1/+31
| | | | | | | | | | | Also fix a bug that prevented that from actually working. BUG=236893 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/108563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239269 0039d316-1c4b-4281-b951-d872f2087c98
* Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to ↵brettw@chromium.org2013-12-031-1/+1
| | | | | | | | | | | base namespace. BUG= R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/102843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238465 0039d316-1c4b-4281-b951-d872f2087c98
* Track active references in ShillClientHelper (Take 3)stevenjb@chromium.org2013-10-072-3/+5
| | | | | | | | | | | | | | To prevent Shill Service DBus ObjectProxy instances from accumulating, remove them when the service becomes inactive. Hopefully includes ASAN fixes. BUG=223483 TBR=hashimoto@chromium.org Review URL: https://codereview.chromium.org/26289002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227371 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 227100 "Track active references in ShillClientHelper (Tak..."stevenjb@chromium.org2013-10-041-2/+0
| | | | | | | | | | | | | | | | | | | | | | > Track active references in ShillClientHelper (Take 2) > To prevent Shill Service DBus ObjectProxy instances from accumulating, > remove them when the service becomes inactive. > > Original CL: https://codereview.chromium.org/23658053/ > > BUG=223483 > TBR=hashimoto@chromium.org > > Review URL: https://codereview.chromium.org/24558004 Failure: http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28amd64%29%20ASAN/builds/6931 TBR=stevenjb@chromium.org Review URL: https://codereview.chromium.org/26075002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227139 0039d316-1c4b-4281-b951-d872f2087c98
* Track active references in ShillClientHelper (Take 2)stevenjb@chromium.org2013-10-041-0/+2
| | | | | | | | | | | | | | To prevent Shill Service DBus ObjectProxy instances from accumulating, remove them when the service becomes inactive. Original CL: https://codereview.chromium.org/23658053/ BUG=223483 TBR=hashimoto@chromium.org Review URL: https://codereview.chromium.org/24558004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227100 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Add ObjectProxy::WaitForServiceToBeAvailable()hashimoto@chromium.org2013-10-024-14/+170
| | | | | | | | | | | | | | Split ConnectToNameOwnerChangedSignal() from ConnectToSignalInternal(). Add WaitForServiceToBeAvailable() Add test. BUG=141009 TEST=dbus_unittests R=satorux@chromium.org Review URL: https://codereview.chromium.org/25488002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226428 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Stop accessing ObjectProxy::name_owner_changed_callback_ on the D-Bus ↵hashimoto@chromium.org2013-09-273-27/+32
| | | | | | | | | | | | | | | thread Accessing the callback on the D-Bus thread while changing its value may result in a race condition. Change the type of SetNameOwnerChangedCallback's argument from Signal to strings to stop worrying about on which thread the Signal gets released. BUG=298747 TEST=dbus_unittests R=satorux@chromium.org Review URL: https://codereview.chromium.org/24673006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225675 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Rewrite ObjectProxy::ConnectToSignal with PostTaskAndReplyWithResulthashimoto@chromium.org2013-09-262-76/+51
| | | | | | | | | | BUG=None TEST=dbus_unittests R=satorux@chromium.org Review URL: https://codereview.chromium.org/24557002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225362 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Replace PostTaskTo*Thread methods with Get*TaskRunnerhashimoto@chromium.org2013-09-266-178/+115
| | | | | | | | | | | | | By exposing TaskRunners, we'll be able to use utility functions like base::PostTaskAndReplyWithResult BUG=None TEST=git cl try R=satorux@chromium.org Review URL: https://codereview.chromium.org/24554002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 224179 "Track active references in ShillClientHelper"kkania@chromium.org2013-09-191-2/+0
| | | | | | | | | | | | | | | | | | Use after free on ASAN chromiumos. > Track active references in ShillClientHelper > To prevent Shill Service DBus ObjectProxy instances from accumulating, > remove them when the service becomes inactive. > > BUG=223483 > > Review URL: https://chromiumcodereview.appspot.com/23658053 TBR=stevenjb@chromium.org Review URL: https://codereview.chromium.org/24293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224204 0039d316-1c4b-4281-b951-d872f2087c98
* Track active references in ShillClientHelperstevenjb@chromium.org2013-09-191-0/+2
| | | | | | | | | | | To prevent Shill Service DBus ObjectProxy instances from accumulating, remove them when the service becomes inactive. BUG=223483 Review URL: https://chromiumcodereview.appspot.com/23658053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224179 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Suppress NameHasNoOwner errors when connecting to signalssatorux@chromium.org2013-08-161-1/+5
| | | | | | | | | | | | | | | | | The NameHasNoOwner errors are emitted as Chrome tries to get the identity of the service when connecting to signals for sender verification (crbug.com/140938), but the service may not yet be running, which is all right, hence the NameHasNoOwner errors here should be just supressed. BUG=273829 TEST=out/Debug/dbus_unittests --gtest_filter=SignalSenderVerificationTest.TestSignalAccepted; confirm that NameHasNoOwner is no longre emitted. Previously, an error message like below was emited: [12721:12722:0816/144031:3991948732792:ERROR:bus.cc(892)] Failed to get name owner. Got org.freedesktop.DBus.Error.NameHasNoOwner: Could not get owner of name 'org.chromium.TestService': no such name Review URL: https://chromiumcodereview.appspot.com/23143004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217980 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Chromium's DBus service ownership to be stealablecmasone@chromium.org2013-07-317-11/+115
| | | | | | | | | | | | | | | | | | | | | | | | We've seen some cases in tests where a Chromium process winds up in a temporarily unkillable state, causing the dbus-daemon to believe that it still actively owns org.chromium.LibCrosService. This makes attempts to restart the UI fail, as the browser dies when it cannot take ownership of this service name. The reason it can't is because Chromium currently doesn't allow other processes to steal ownership -- and the unkillable process is holding onto the token. This can be remedied by providing certain options when ownership of the service name is taken, options that allow other processes to seize ownership if they so choose. The ramifications of this are discussed further in the bug. BUG=chromium:261381 TEST=new unit test in dbus_unittest TEST=run the following as chronos on a device: "gdbus call --system --dest org.freedesktop.DBus --object-path /org/freedesktop/DBus --method org.freedesktop.DBus.RequestName org.chromium.LibCrosService 7" TEST=This should return (uint32 1,) Review URL: https://chromiumcodereview.appspot.com/20555003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214589 0039d316-1c4b-4281-b951-d872f2087c98
* c++11 ud suffix fixes for cros dbus filesthakis@chromium.org2013-07-311-1/+1
| | | | | | | | | | | No behavior change. BUG=263960 R=satorux@chromium.org Review URL: https://codereview.chromium.org/21131003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214521 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in dbus/, device/, ↵avi@chromium.org2013-07-179-10/+10
| | | | | | | | | | | | extensions/, google_apis/, gpu/, ipc/, jingle/. BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19607005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212157 0039d316-1c4b-4281-b951-d872f2087c98
* Make "Ignoring DBusStatistics::AddStat" a DVLOG instead of DLOG(WARNING)posciak@chromium.org2013-07-111-2/+2
| | | | | | | | | BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/18083039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211070 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in courgette/, crypto/, dbus/, device/, ↵avi@chromium.org2013-06-285-5/+5
| | | | | | | | | | | | google_apis/, gpu/, ipc/, jingle/. BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/18156002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209149 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers, delete some strings forwarding headers.avi@chromium.org2013-06-201-1/+1
| | | | | | | | | | BUG=247723 TEST=everything compiles OK TBR=ben@chromium.org Review URL: https://codereview.chromium.org/17390010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207507 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Put DBus unit tests in the dbus namespace, so one does not need to ↵thestig@chromium.org2013-06-1314-590/+610
| | | | | | | | write dbus:: everywhere. Remove some other dbus:: usages in the dbus namespace. Review URL: https://chromiumcodereview.appspot.com/16012018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206010 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in crypto/, dbus/, device/.avi@chromium.org2013-06-114-5/+5
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16123026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205457 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/CrOS: Listen for mtpd service owner change events and communicate with ↵thestig@chromium.org2013-06-103-3/+354
| | | | | | | | | | | | | the new service owner. The mtpd dbus service may not start right away. Any attempts to use it may be racy due to the lack of a service owner. Listening for service owner changes fixes this race. BUG=241302 TEST=Manual, see bug for repro case. Review URL: https://chromiumcodereview.appspot.com/15741025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205331 0039d316-1c4b-4281-b951-d872f2087c98
* Update includes of message_loop_proxy.brettw@chromium.org2013-06-101-1/+1
| | | | | | | | | | | This keeps the forwarding header, just updates all current callers. BUG= R=avi@chromium.org Review URL: https://codereview.chromium.org/16514006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205306 0039d316-1c4b-4281-b951-d872f2087c98
* Update dbus/ to use scoped_refptr<T>::get() rather than implicit "operator T*"rsleevi@chromium.org2013-06-022-12/+10
| | | | | | | | | | | Linux fixes BUG=110610 TBR=darin Review URL: https://chromiumcodereview.appspot.com/15939006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203634 0039d316-1c4b-4281-b951-d872f2087c98
* DBus: Reverse error suppression logic from r198328.thestig@chromium.org2013-05-082-2/+2
| | | | | | | | BUG=181064 Review URL: https://chromiumcodereview.appspot.com/14660017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198987 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: adding PostTaskToDBusThreadAndReplyharuki@chromium.org2013-05-082-0/+25
| | | | | | | | | | | | This CL only adds a util method. BUG=172821 TEST=unittests R=satorux@chromium.org Review URL: https://codereview.chromium.org/14985008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198876 0039d316-1c4b-4281-b951-d872f2087c98
* Add a method to check if a D-Bus service has an owner. Use it for mtpd.thestig@chromium.org2013-05-043-52/+118
| | | | | | | | BUG=181064 Review URL: https://chromiumcodereview.appspot.com/14568005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198328 0039d316-1c4b-4281-b951-d872f2087c98
* Warn on missing OVERRIDE/virtual everywhere, not just in header files.rsleevi@chromium.org2013-05-021-4/+4
| | | | | | | | | | This is only enabled for Linux (so far). BUG=115047 Review URL: https://chromiumcodereview.appspot.com/14696007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197788 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Use base::MessageLoop.xhwang@chromium.org2013-05-0110-30/+26
| | | | | | | | | BUG=236029 R=keybuk@chromium.org Review URL: https://chromiumcodereview.appspot.com/14386016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197629 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r196352 "dbus: Add FakeBus"oshima@chromium.org2013-04-253-44/+2
| | | | | | | | | | | | | > dbus: Add FakeBus > BUG=234078 > TEST=trybots TBR=haruki@chromium.org BUG=234078 Review URL: https://codereview.chromium.org/14392017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196410 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Add FakeBusharuki@chromium.org2013-04-253-2/+44
| | | | | | | | | BUG=234078 TEST=trybots Review URL: https://chromiumcodereview.appspot.com/14493004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196352 0039d316-1c4b-4281-b951-d872f2087c98
* D-Bus: notify properties changed from fakeskeybuk@chromium.org2013-04-241-2/+8
| | | | | | | | | | | | | | | | | Call the property changed callback when fakes use ReplaceValue() or ReplaceValueWithSetValue(), since the actual implementation will always call the callback. This avoids issues with property changed notifications being missing when properties structures are built within fakes. BUG=none TEST=dbus_unittests, device_unittests R=satorux@chromium.org, youngki@chromium.org Review URL: https://codereview.chromium.org/14443003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195977 0039d316-1c4b-4281-b951-d872f2087c98
* D-Bus: allow multiple signal handlers for a signalkeybuk@chromium.org2013-04-243-27/+33
| | | | | | | | | | | | | | | | | | | | | | | | For the org.freedesktop.DBus.Properties.PropertyChanged signal, all relevant clients will share a single ObjectProxy since they share the same path and interface; the actual destination client for the signal is determined by its arguments. This means that we must support multiple signal handlers for a single object proxy, the previous fix of replacing with the latest was not sufficient for this case. Due to issue 223483, this is not a complete fix. Property objects coming and going will leave signal handlers in the ObjectProxy with NULLd weak pointer references - they will be harmless, but use up memory. BUG=234380 TEST=dbus_unittests R=satorux@chromium.org Review URL: https://codereview.chromium.org/14333009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195953 0039d316-1c4b-4281-b951-d872f2087c98
* Update the remaining include paths of base/string_piece.h to its new location.tfarina@chromium.org2013-04-172-2/+2
| | | | | | | | | | | string_piece.h was moved into base/strings/ in r191206 - https://chromiumcodereview.appspot.com/12982018/ TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14272007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194693 0039d316-1c4b-4281-b951-d872f2087c98
* Adding PrintTo of ObjectPath.pneubeck@chromium.org2013-04-122-0/+10
| | | | | | | | | | | PrintTo is used by gtest/gmock for pretty printing. This change makes debugging tests easier. BUG=NONE Review URL: https://chromiumcodereview.appspot.com/13942004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193920 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-095-10/+10
| | | | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Rewrite std::string("") to std::string(), Linux edition."dcheng@chromium.org2013-04-095-10/+10
| | | | | | | | | | | | | | This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6. Revert "Fix build after r193020." This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a. Revert "Really fix build after r193020." This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-095-10/+10
| | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
* Support D-Bus Object Managerkeybuk@chromium.org2013-03-2512-54/+1310
| | | | | | | | | | | | | | | | | Object Manager is a new standard D-Bus interface, closely related to the Properties interface. It is used by BlueZ 5.x thus the need to implement it now. The intended use is that Chrome D-Bus Client singletons set up a link to an object manager in their constructor and register themselves to handle their particular interface. BUG=220951 TEST=dbus_unittests Review URL: https://codereview.chromium.org/12491014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190440 0039d316-1c4b-4281-b951-d872f2087c98
* [Cleanup] Remove StringPrintf from global namespacegroby@chromium.org2013-03-181-14/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | use of StringPrintf now requires prefixing with base:: or a per-scope using directive TBR'd: abodenha: chrome/service brettw: content, third_party, webkit darin: base, chrome/browser, chrome/renderer dgarret: courgette enne: cc fischmann: media gbillock: sql joi: google_apis,components rsleevi: net, crypto sky: chrome/test thestig: printing, chrome/common, tsepez: ipc wez: remoting yfriedman: testing/android NOTRY=true R=brettw@chromium.org TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org BUG= Review URL: https://codereview.chromium.org/12767006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188857 0039d316-1c4b-4281-b951-d872f2087c98
* Connect SparseHistogram with the rest of stats systemkaiwang@chromium.org2013-03-011-1/+1
| | | | | | | | | | | | | With this CL, SparseHistogram is usable with SparseHistogram::FactoryGet. Next step is to implement a Histogram like macro and implement WriteHTMLGraph and WriteAscii to have a nice output. BUG=139612 Review URL: https://chromiumcodereview.appspot.com/12207058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185451 0039d316-1c4b-4281-b951-d872f2087c98
* DBus: Use TaskRunners instead of MessageLoopProxies.thestig@chromium.org2013-02-2011-78/+74
| | | | | | Review URL: https://chromiumcodereview.appspot.com/12255043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183362 0039d316-1c4b-4281-b951-d872f2087c98
* Supporting callback for Disconnected signal.nona@chromium.org2013-02-153-4/+47
| | | | | | | | | | | | | If the connection with dbus-daemon is closed, callback function set with SetDisconnectedCallback will be called. BUG=None TEST=ran dbus_unittests Review URL: https://chromiumcodereview.appspot.com/12224139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182736 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary condition.nona@chromium.org2013-02-131-5/+0
| | | | | | | | | | | | | ShutdownAndBlock function can be called multiple times safely. So checking |shutdown_completed_| in OnDisonnected function is not necessary. BUG=174431 TEST=Checked no crash at sing out. Review URL: https://chromiumcodereview.appspot.com/12212133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182161 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove deprecated base::Value methods from dbus. Use base::Value too.thestig@chromium.org2013-02-122-71/+76
| | | | | | Review URL: https://chromiumcodereview.appspot.com/12207091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181989 0039d316-1c4b-4281-b951-d872f2087c98
* Call get_dispatch_status function to handle Disconnected signal.nona@chromium.org2013-02-082-7/+64
| | | | | | | | | | | | | It turns out that dbus_connection_get_dispatch_status should be called even if the connection is lost, otherwise we miss "Disconnected" signal. BUG=174431 TEST=Manually done on alex and ran dbus_unittests. Review URL: https://chromiumcodereview.appspot.com/12211022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181479 0039d316-1c4b-4281-b951-d872f2087c98
* Code cleaning: Uses scoped_ptr<> to express ownership rather than writing ↵yuki@chromium.org2013-02-079-103/+107
| | | | | | | | | | | | | | ownership in comments. Replaces Response* with scoped_ptr<Response> in dbus code and its related code. BUG=163231 TEST=no regression / no behavior changes Review URL: https://chromiumcodereview.appspot.com/12092061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181266 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTTF: Add missing virtual destructors."phajdan.jr@chromium.org2013-02-061-1/+0
| | | | | | | | | | | | | | It turned out this is not necessary, we have a better warning already enabled in clang (-Wdelete-non-virtual-dtor, part of -Wall). TBR=darin,satorux,fischman,jamesr,jar,sky BUG=45135 Review URL: https://codereview.chromium.org/12224027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180971 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Add missing virtual destructors.phajdan.jr@chromium.org2013-02-051-0/+1
| | | | | | | | | | | R=jar TBR=darin,satorux,fischman,jamesr,sky BUG=45135 Review URL: https://codereview.chromium.org/12086018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180669 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 20:03:03 +0000