summaryrefslogtreecommitdiffstats
path: root/device
Commit message (Collapse)AuthorAgeFilesLines
* Add device dependency GN's header checker found.brettw2015-02-211-0/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/944153002 Cr-Commit-Position: refs/heads/master@{#317455}
* Add more targets to GN check.brettw2015-02-208-3/+28
| | | | | | | | | | | | | Fix errors. Most of the problems were in net. Moves CreateAndConnectStreamForTesting's declaration to the header corresponding to the file it's implemented in. Adds the other directories that don't pass yet to the list commented out so it's easier to see what's still left. TBR=armansito@chromium.org Review URL: https://codereview.chromium.org/936953004 Cr-Commit-Position: refs/heads/master@{#317425}
* Pad HID output reports on Windows to the maximum output report size.reillyg2015-02-202-2/+19
| | | | | | | | | | | | | The Windows HID library requires output report buffers to be exactly the maximum length specified in the OutputReportByteLength field of HIDP_CAPS. This patch automatically pads output reports to this length with zeros and rejects reports longer than this length. BUG=439775 Review URL: https://codereview.chromium.org/943783003 Cr-Commit-Position: refs/heads/master@{#317393}
* [Android L] Add (dis)chargingTime support for the Battery Status API.timvolodine2015-02-202-12/+153
| | | | | | | | | | | | | This patch implements the estimation of (dis)chargingTime on devices running Android L (and above). Android L supports new properties in BatteryManager which can be used to provide such estimates. BUG=401553 TEST=http://jsbin.com/battery-status-test Review URL: https://codereview.chromium.org/874713003 Cr-Commit-Position: refs/heads/master@{#317372}
* bluetooth: Modify DCHECK to conditionals in several BluetoothAdapterChromeOS ↵scheib2015-02-203-515/+555
| | | | | | | | | | | | | | methods. Initial patch in https://codereview.chromium.org/848613003 used DCHECK in too many methods that should function even when the adapter is not present. BUG=452705 Review URL: https://codereview.chromium.org/933823003 Cr-Commit-Position: refs/heads/master@{#317332}
* Set unregistered handles to NULL in BatteryStatusObserver::Stopmarcing2015-02-201-2/+6
| | | | | | | | | | | BatteryStatusObserver::Stop can be called twice from BatteryStatusService::Shutdown, so power_handle_ and batter_change_handle_ should be set to NULL on the first call, otherwise the second call will pass invalid handles to UnregisterNotification. Review URL: https://codereview.chromium.org/924193006 Cr-Commit-Position: refs/heads/master@{#317321}
* Revert of Add more targets to "gn check" (patchset #3 id:40001 of ↵rdevlin.cronin2015-02-208-32/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/940613002/) Reason for revert: This broken win8 gn bots because of an illegal include. ERROR at //device/usb/usb_service_impl.cc:21:11: Include not allowed. #include "device/core/device_monitor_win.h" e.g. https://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4896/steps/gn%20check/logs/stdio Original issue's description: > Add more targets to "gn check" > > R=dpranke > TBR=armansito@chromium.org (bluetooth) > > Committed: https://crrev.com/8cac5f9d9c3847657b57783d30f861adb6c29cac > Cr-Commit-Position: refs/heads/master@{#317160} TBR=dpranke@chromium.org,armansito@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/941893002 Cr-Commit-Position: refs/heads/master@{#317204}
* Add more targets to "gn check"brettw2015-02-198-3/+32
| | | | | | | | | R=dpranke TBR=armansito@chromium.org (bluetooth) Review URL: https://codereview.chromium.org/940613002 Cr-Commit-Position: refs/heads/master@{#317160}
* Enumerate HID devices asynchronously on Windows.reillyg2015-02-193-15/+74
| | | | | | | | | | | | | | Avoid possibly long blocking times in the Windows SetupDi function calls made to enumerate devices by offloading to the FILE thread. Now that we can be sure that a stray request to the device won't block the UI additional calls to get the device's product and serial number strings can be made. BUG=457899 Review URL: https://codereview.chromium.org/936603003 Cr-Commit-Position: refs/heads/master@{#316939}
* device/bluetooth:Implement BluetoothMediaEndpointServiceProvider delegate ↵mcchou2015-02-183-77/+372
| | | | | | | | | | | | | | | | | | | | | and media-related overrides. This CL implements delegate overrides for BluetoothMediaEndpointServiceProvider and observer overrides for BluetoothMediaClient and BluetoothMediaTransportClient. These overrides will be called once a remote device connects to a local A2DP audio sink, and the state of the audio sink should become idle. The behaviors of FakeBluetoothMediaTransportClient, FakeBluetoothMediaEndpointServiceProvider and FakeMediaEndpointServiceProvider are also defined for connection-related tests in this CL. BUG=441581 TEST=device_unittests --gtest_filter=*AudioSink* Review URL: https://codereview.chromium.org/910023002 Cr-Commit-Position: refs/heads/master@{#316709}
* Obj-C 2.0 allows to declare ivars in @implementation section.dvh2015-02-131-5/+5
| | | | | | | | Obj-C 1.0 only allows to declare ivars in @interface section. Review URL: https://codereview.chromium.org/917063004 Cr-Commit-Position: refs/heads/master@{#316236}
* Revert of device: Add GN version of the device_unittests target. (patchset ↵fgorski2015-02-122-126/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #13 id:230001 of https://codereview.chromium.org/912083003/) Reason for revert: Mac GN build fails on buildbot: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/4172/steps/compile/logs/stdio Original issue's description: > device: Add GN version of the device_unittests target. > > Tested with the following command lines: > > $ gn gen out_gn/Debug > $ ninja -C out_gn/Debug device_unittests > $ out_gn/Debug/device_unittests > > BUG=None > TEST=see above > R=rockot@chromium.org > > Committed: https://crrev.com/e16ab4ff264bc3f6c2a850d820b5f5c79fe59d05 > Cr-Commit-Position: refs/heads/master@{#316058} TBR=rockot@chromium.org,jam@chromium.org,tfarina@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.chromium.org/924613004 Cr-Commit-Position: refs/heads/master@{#316072}
* device: Add GN version of the device_unittests target.tfarina2015-02-122-10/+126
| | | | | | | | | | | | | | | | Tested with the following command lines: $ gn gen out_gn/Debug $ ninja -C out_gn/Debug device_unittests $ out_gn/Debug/device_unittests BUG=None TEST=see above R=rockot@chromium.org Review URL: https://codereview.chromium.org/912083003 Cr-Commit-Position: refs/heads/master@{#316058}
* Added bluetooth LE support on Mac platformdvh2015-02-127-0/+632
| | | | | | Review URL: https://codereview.chromium.org/911343002 Cr-Commit-Position: refs/heads/master@{#315911}
* Use the JS stash client from the JS serial service.sammc2015-02-101-1/+1
| | | | | | | | | | | This allows persistent serial connections to be supported on the mojo-service-backed serial implementation. BUG=389016 Review URL: https://codereview.chromium.org/908153002 Cr-Commit-Position: refs/heads/master@{#315514}
* Fix crash on second failed connect to a paired devicejamuraa2015-02-094-20/+52
| | | | | | | | | | | | | | When failing to connect to a previously-paired device, the profile would not be cleared. This sets adapter_ in RegisterProfile() so that it will be set correctly for profile release later. Also includes unit tests, adding a paired but non-connectable device. BUG=455868 Review URL: https://codereview.chromium.org/910433002 Cr-Commit-Position: refs/heads/master@{#315394}
* Revert of Added bluetooth LE support on Mac platform (patchset #13 id:340001 ↵ccameron2015-02-077-630/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/791763005/) Reason for revert: Breaks compile: http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/17750 ../../device/bluetooth/bluetooth_low_energy_discovery_manager_mac.mm:119:30: error: class method '+UUIDWithString:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access] CBUUID* uuid = [CBUUID UUIDWithString:uuidString]; ^~~~~~~~~~~~~~ ../../device/bluetooth/bluetooth_low_energy_device_mac.mm:82:39: error: use of undeclared identifier 'CBAdvertisementDataIsConnectable' [advertisementData objectForKey:CBAdvertisementDataIsConnectable]; ^ ../../device/bluetooth/bluetooth_low_energy_device_mac.mm:85:39: error: use of undeclared identifier 'CBAdvertisementDataServiceDataKey' [advertisementData objectForKey:CBAdvertisementDataServiceDataKey]; ^ 2 errors generated. Original issue's description: > Added bluetooth LE support on Mac platform > > BUG=449682 > > Committed: https://crrev.com/42f79f8b08a99190627f3a67e86a378987104a4a > Cr-Commit-Position: refs/heads/master@{#315190} TBR=armansito@chromium.org,avi@chromium.org,groby@chromium.org,dvh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=449682 Review URL: https://codereview.chromium.org/871843009 Cr-Commit-Position: refs/heads/master@{#315191}
* Added bluetooth LE support on Mac platformdvh2015-02-077-0/+630
| | | | | | | | BUG=449682 Review URL: https://codereview.chromium.org/791763005 Cr-Commit-Position: refs/heads/master@{#315190}
* chromeos/dbus: Update Bluetooth GATT API clients to upstream definitionarmansito2015-02-067-104/+83
| | | | | | | | | | | | This CL ports the GATT API bindings from the D-Bus API in our Chrome OS fork to the API definition in doc/gatt-api.txt in BlueZ upstream. TBR=keybuk@chromium.org BUG=440968 Review URL: https://codereview.chromium.org/788193004 Cr-Commit-Position: refs/heads/master@{#315095}
* Update {virtual,override,final} to follow C++11 style in device.Daniel Cheng2015-02-061-1/+1
| | | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=timvolodine@chromium.org Review URL: https://codereview.chromium.org/902973002 Cr-Commit-Position: refs/heads/master@{#315079}
* Add a UsbService::Observer function for cleanup actions.reillyg2015-02-062-0/+8
| | | | | | | | | | | | | | | | | | This patch adds an additional function to the UsbService::Observer interface that should be used to perform cleanup operations when a USB device is disconnected. This is separate from the OnDeviceRemoved function so that implementations of that function, which may depend on other subsystems' knowledge of a connected device, can run before any cleanup actions have taken place. A browsertest for the chrome.usb.getUserSelectedDevices is included which demonstrates the need for this 2-phase event handling. BUG=452298 Review URL: https://codereview.chromium.org/891853002 Cr-Commit-Position: refs/heads/master@{#314973}
* Adding instrumentation to locate the source of jankiness.Peter Kasting2015-02-051-1/+2
| | | | | | | | | | | | | | | | | | | | | | Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. This also updates the existing instrumentation for bug 418183 to include the bug number everywhere. BUG=418183,455423,455434,455469 TEST=none R=vadimt@chromium.org TBR=jochen, mmenke, rockot, thestig Review URL: https://codereview.chromium.org/901773002 Cr-Commit-Position: refs/heads/master@{#314885}
* Remove Client= from device/serial/data_stream.mojom.sammc2015-02-0521-318/+237
| | | | | | | | | | | BUG=451321 Committed: https://crrev.com/bc78a2320b50eba4fe397f1f838a82ad30b16cd6 Cr-Commit-Position: refs/heads/master@{#314231} Review URL: https://codereview.chromium.org/889283002 Cr-Commit-Position: refs/heads/master@{#314773}
* Revert of Remove Client= from device/serial/data_stream.mojom. (patchset #1 ↵sammc2015-02-0421-161/+91
| | | | | | | | | | | | | | | | | | | | | | | | | id:20001 of https://codereview.chromium.org/889283002/) Reason for revert: Switching to two pipes broke FIFO assumption, causing DataSinkTest.CancelDuringError and SerialConnectionTest.Cancel to become flaky Original issue's description: > Remove Client= from device/serial/data_stream.mojom. > > BUG=451321 > > Committed: https://crrev.com/bc78a2320b50eba4fe397f1f838a82ad30b16cd6 > Cr-Commit-Position: refs/heads/master@{#314231} TBR=rockot@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451321 Review URL: https://codereview.chromium.org/873293006 Cr-Commit-Position: refs/heads/master@{#314524}
* device/bluetooth:Implement Register() for BluetoothAudioSinkChromeOS.mcchou2015-02-037-51/+377
| | | | | | | | | | | | | | | This CL implements Register function for BluetoothAudioSinkChromeOS and comes up with the corresponding tests. For the tests, FakeBluetoothMediaClient is changed to simulate the behavior of the real D-Bus APIs. BUG=441581 TEST=device_unittests --gtest_filter=*AudioSink* Review URL: https://codereview.chromium.org/876153002 Cr-Commit-Position: refs/heads/master@{#314244}
* Remove Client= from device/serial/data_stream.mojom.sammc2015-02-0321-91/+161
| | | | | | | | BUG=451321 Review URL: https://codereview.chromium.org/889283002 Cr-Commit-Position: refs/heads/master@{#314231}
* Manage profiles in BluetoothAdapter on ChromeOSjamuraa2015-01-3012-164/+837
| | | | | | | | | | | | | | | | | | Profiles in bluez are not specific to a device. When client code tries to connect to two different devices, only one profile is created, managed by BluetoothAdapterChromeOS. dbus messages are multiplexed based on the device desired using new class BluetoothAdapterProfileChromeOS. This is a resubmit with bugfixes after https://codereview.chromium.org/851123002/ was reverted by https://codereview.chromium.org/868753006/ BUG=421207 Review URL: https://codereview.chromium.org/888913002 Cr-Commit-Position: refs/heads/master@{#314030}
* bluetooth: Provide more device attributes in requestDevice reply.scheib2015-01-301-1/+2
| | | | | | | | | | | | | | | | | | | BluetoothDispatcherHost is extended to supply all the attributes of the BluetoothDevice web API. Also, add device::BluetoothDevice::VENDOR_ID_MAX_VALUE for use in the IPC message. Depends on https://codereview.chromium.org/882223002/ to define new attributes on WebBluetoothDevice, and will not be visible to script until https://codereview.chromium.org/876623003/ BUG=438305 Review URL: https://codereview.chromium.org/885723002 Cr-Commit-Position: refs/heads/master@{#313999}
* Revert of Manage profiles in BluetoothAdapter on ChromeOS (patchset #5 ↵perkj2015-01-3012-833/+164
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:80001 of https://codereview.chromium.org/851123002/) Reason for revert: This causes a leak on Chrome Os ASan. https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6306/steps/device_unittests/logs/Connect Original issue's description: > Manage profiles in BluetoothAdapter on ChromeOS > > Profiles in bluez are not specific to a device. > When client code tries to connect to two different devices, only > one profile is created, managed by BluetoothAdapterChromeOS. > > dbus messages are multiplexed based on the device desired using new > class BluetoothAdapterProfileChromeOS. > > BUG=chromium:421207 > > Committed: https://crrev.com/c56186ac2901c99349cbb4b4a6b8aa0ff8088c4d > Cr-Commit-Position: refs/heads/master@{#313837} TBR=armansito@chromium.org,keybuk@chromium.org,rpaquay@chromium.org,jamuraa@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:421207 Review URL: https://codereview.chromium.org/868753006 Cr-Commit-Position: refs/heads/master@{#313883}
* Manage profiles in BluetoothAdapter on ChromeOSjamuraa2015-01-3012-164/+833
| | | | | | | | | | | | | | | Profiles in bluez are not specific to a device. When client code tries to connect to two different devices, only one profile is created, managed by BluetoothAdapterChromeOS. dbus messages are multiplexed based on the device desired using new class BluetoothAdapterProfileChromeOS. BUG=chromium:421207 Review URL: https://codereview.chromium.org/851123002 Cr-Commit-Position: refs/heads/master@{#313837}
* device: Add armansito@ to OWNERS.Arman Uguray2015-01-291-0/+1
| | | | | | | | | | | | armansito@ is already an owner of device/bluetooth and device/nfc, so make him and OWNER for the occasional unit test additions to device_tests.gyp. BUG=none R=rpaquay@chromium.org Review URL: https://codereview.chromium.org/886443003 Cr-Commit-Position: refs/heads/master@{#313823}
* Set serial connection parameters immediately on connect.reillyg2015-01-2810-159/+230
| | | | | | | | | | | | | | | | | | | This change merges the initial call to SetCommState/tcsetattr with the call to ConfigurePort so that parameters such as baud rate are configured immediately when the port is opened. Default values for these parameters are now always applied. This works around an issue with some serial adapter drivers on Windows that report an invalid baud rate through GetCommState. Having the intended baud rate available for the first call to SetCommState allows an application to provide a valid value so that Chrome does not have to guess. BUG=448407 Review URL: https://codereview.chromium.org/873903002 Cr-Commit-Position: refs/heads/master@{#313604}
* Remove iterator typedefs for USB descriptor types.reillyg2015-01-231-4/+0
| | | | | | | | | | | | C++11 range-based for loops make it a lot easier to iterate over an STL container without incredibly long type names. The last users of these typedefs have been updated and so they are no longer necessary. BUG= Review URL: https://codereview.chromium.org/869063004 Cr-Commit-Position: refs/heads/master@{#312949}
* Include Mojo SDK/EDK via fully-qualified paths in Chromium code.blundell2015-01-2316-22/+22
| | | | | | | | | | | | As a followup to the move of the Mojo SDK and EDK to live under //third_party, this CL updates Chromium code to include SDK/EDK headers via fully-qualified paths instead of relying on include_dirs that are exported by the Mojo targets. This CL also includes mechanical updates to DEPS files to satisfy checkdeps. Review URL: https://codereview.chromium.org/846443006 Cr-Commit-Position: refs/heads/master@{#312858}
* Changes for Windows GN build, fixes in device/bluetooth.vchigrin2015-01-231-0/+4
| | | | | | Review URL: https://codereview.chromium.org/837303003 Cr-Commit-Position: refs/heads/master@{#312811}
* Fix Android USB debugging through DevTools.reillyg2015-01-231-2/+7
| | | | | | | | | | | | | | | | | | | | | | | First, change 13cf2cfcb5325ecfff98ee8ccde723f22e606d22 introduced a logic error into AndroidUsbDevice::EnumerateOnFileThread that caused enumerations to never complete because the BarrierClosure was not called the correct number of times. Second, this change may have also exposed an issue (investigated before) where a libusb_transfer can be cancelled twice, once in ReleaseInterface and again in CloseInternal. The second cancellation occurs after the interface has been released and so an invalid handle is passed to AbortPipe. A cancelled_ member has been added to Transfer to prevent this from happening. Some conversions to C++11 range loops (added during debugging to make the loops clearer) are preserved in this change. BUG=450007 Review URL: https://codereview.chromium.org/864183002 Cr-Commit-Position: refs/heads/master@{#312796}
* device/bluetooth: Add BluetoothAudioSinkChromeOS.mcchou2015-01-224-0/+318
| | | | | | | | | | | | | This CL implements Bluetooth Audio Sink API for ChromeOS platform, where user applications can register/unregister a BT audio sink via BlueAdapter interface. This API acts as a middle layer hiding the components of BlueZ/D-Bus. BUG=441581 Review URL: https://codereview.chromium.org/787743002 Cr-Commit-Position: refs/heads/master@{#312562}
* Add browser tests for USB device add/remove events.reillyg2015-01-226-148/+198
| | | | | | | | | | | | | | | These tests are essentially copies of the HID device add and remove event tests. In order to reconcile issues with the MockUsbService lifetime it is now tracked by a MessageLoop::DestructionObserver at the generic UsbService level. This is similar to the pattern used by the HidService until it was moved to the UI thread and could use a LazyInstance. BUG=411715 Review URL: https://codereview.chromium.org/800963005 Cr-Commit-Position: refs/heads/master@{#312538}
* device/bluetooth: BluetoothAudioSink: Rename ERRORCODE_* to ERROR_armansito2015-01-214-6/+6
| | | | | | | | | | | Renamed the enum members declared as ERRORCODE_* to ERROR_* to be consistent with the rest of the code. BUG=none Review URL: https://codereview.chromium.org/839573003 Cr-Commit-Position: refs/heads/master@{#312446}
* GN: Add -Wl,-z defs on linux and fix errorsjamesr2015-01-211-0/+2
| | | | | | | | | | | | This tells the linker to resolve symbols for shared libraries at build time, not run time. This alerts developers much earlier that their dependencies are underspecified. BUG=371125 Review URL: https://codereview.chromium.org/843583006 Cr-Commit-Position: refs/heads/master@{#312317}
* Enable find-missing-symbols-at-link-time for chromeos builds too.Nico Weber2015-01-202-1/+5
| | | | | | | | | | | | | | Add missing dependencies that caused build failures with this flag. (I did similar changes in the BUILD.gn files too, but blindly.) BUG=371125 R=derat@chromium.org, thestig@chromium.org TBR=antrim, bshe, thestig, timvolodine Review URL: https://codereview.chromium.org/857353004 Cr-Commit-Position: refs/heads/master@{#312280}
* bluetooth: Use BluetoothAdapter in BluetoothDispatcherHost.scheib2015-01-203-3/+3
| | | | | | | | | | | | | | Previously only simple mock responses were supported in BluetoothDispatcherHost. This change adds use of an actual adapter, and enables the first actual bluetooth.requestDevices responses to function in the browser (with the experimental-web-platform-features flag). BUG=420284 Review URL: https://codereview.chromium.org/787953004 Cr-Commit-Position: refs/heads/master@{#312241}
* Move //mojo/{public, edk} underneath //third_partyblundell2015-01-198-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | This CL move //mojo/public and //mojo/edk to live in the following locations: - //third_party/mojo/src/mojo/public - //third_party/mojo/src/mojo/edk It moves the related gypfiles from //mojo to //third_party/mojo and updates them as necessary to account for the file moves. It also updates clients of the mojo SDK and EDK targets in both GYP and GN. (Note that for GN, the mojo SDK and EDK build systems are maintained in the Mojo repo and designed to be flexible wrt the location of the SDK/EDK in a client repo, so no changes are needed. This CL does not update include paths to the code being moved to limit the number of moving parts, instead relying on the include_dirs that the SDK and EDK targets supply to their direct dependents to ensure that include paths continue to resolve correctly. NOPRESUBMIT=true Review URL: https://codereview.chromium.org/814543006 Cr-Commit-Position: refs/heads/master@{#312129}
* Added API to BluetoothDevice to be able to access service data informationdvh2015-01-172-2/+57
| | | | | | | | | | from the generic profile of a bluetooth low energy device. BUG=449678 Review URL: https://codereview.chromium.org/851323004 Cr-Commit-Position: refs/heads/master@{#312000}
* bluetooth: Shutdown BluetoothAdapter before DBus on ChromeOS.scheib2015-01-179-14/+182
| | | | | | | | | | | | | The BluetoothAdapter is a lazy instance that may live due to references until the shutdown of the browser. On ChromeOS the adapter and related classes must release references to the DBusThreadManager before it is shutdown. This patch adds an explicit call for that shutdown. BUG=447387 Review URL: https://codereview.chromium.org/848613003 Cr-Commit-Position: refs/heads/master@{#311986}
* Update {virtual,override,final} to follow C++11 style in device.dcheng2015-01-1618-347/+297
| | | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=reillyg@chromium.org Review URL: https://codereview.chromium.org/799933008 Cr-Commit-Position: refs/heads/master@{#311826}
* device/bluetooth: Add RegisterAudioSink method to Bluetooth adapter.mcchou2015-01-1510-20/+95
| | | | | | | | | | | | | | This CL adds RegisterAudioSink method to Bluetooth adapter abstraction class and its subclasses.For ChromeOS, the implementation will be in the following CL. As for Mac and Windows, there is no implementation for now. This CL also adds BluetoothAudioSink::ErrorCode and BluetoothAudioSink::Unregister. BUG=441581 Review URL: https://codereview.chromium.org/782293004 Cr-Commit-Position: refs/heads/master@{#311724}
* Include raw HID report descriptor in HID device info.reillyg2015-01-1316-536/+598
| | | | | | | | | | | | | | | | This change includes the raw HID report descriptor in the HidDeviceInfo class and exposes it to apps and extensions using the chrome.hid API. For simplicity on OS X the platform APIs for collecting information from the report descriptor are no longer used and instead the parsing code from Linux is used. On Windows the raw HID report descriptor is not available because Windows exposes HID devices on a per-top-level collection basis. BUG=442818 Review URL: https://codereview.chromium.org/801833003 Cr-Commit-Position: refs/heads/master@{#311192}
* Mark UsbServiceImpl::UIThreadHelper as final.reillyg2015-01-131-1/+2
| | | | | | | | | | | Silence -Wdelete-non-virtual-dtor warnings on this class by marking it final and inheriting from DeviceMonitorWin::Observe privately. BUG= Review URL: https://codereview.chromium.org/850563002 Cr-Commit-Position: refs/heads/master@{#311188}
* Rename HidServiceLinux and HidConnectionLinux helper classes.reillyg2015-01-124-23/+27
| | | | | | | | | | | | This change documents that these helper classes live on the FILE thread by naming them HidServiceLinux::FileThreadHelper and HidConnectionLinux::FileThreadHelper. BUG= Review URL: https://codereview.chromium.org/851543002 Cr-Commit-Position: refs/heads/master@{#311120}
generated by cgit v1.1 at 2025-03-18 05:16:53 +0000