| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
R=yoz@chromium.org
BUG=329295
Review URL: https://codereview.chromium.org/107803004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the option to inspect a resource or render view in the error console,
opening the developer tools for that resource/view.
Goes with: https://codereview.chromium.org/23816005
BUG=21734
TBR=yoshiki@chromium.org (task_manager)
TBR=ben@chromium.org (ui [refactor only])
Review URL: https://codereview.chromium.org/23459008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This issue was found by a linter.
R=rdevlin.cronin@chromium.org, yoz@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/23503045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This issue was found by a linter.
R=yoz@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/23717041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add UI elements for extension runtime (javascript) errors on the chrome:extensions page. Include a stack trace and, if possible, links to the source code.
TBR=finnur@chromium.org
BUG=21734
Review URL: https://chromiumcodereview.appspot.com/23624002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Include two of our internal scripts (event_bindings and schemaUtil) as sources
for runtime errors. Add tests for same.
BUG=21734
Review URL: https://chromiumcodereview.appspot.com/23923003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(hidden behind the error console switch).
Snazzy Images: http://imgur.com/a/7QnMo#0 (updated 9/3)
BUG=21734
Review URL: https://chromiumcodereview.appspot.com/22938005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add backend support for catching manifest install warnings with the ErrorConsole. Forked from https://codereview.chromium.org/22938005 in order to reduce size and separate backend and frontend CLs.
BUG=21734
Review URL: https://chromiumcodereview.appspot.com/23684015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw@chromium.org
(moving DEPS file from extensions/common/matcher to extensions/common).
BUG=21734
Review URL: https://chromiumcodereview.appspot.com/23007021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add in a command-line switch for ErrorConsole ('enable-error-console').
Add in duplicate-error detection, so that multiple copies of the same error aren't both stored.
Add in a check so that the ErrorConsole only stores errors if the user is in Developer Mode.
Rename ManifestParsingError to ManifestError, JavascriptRuntimeError to RuntimeError
BUG=21734
Review URL: https://chromiumcodereview.appspot.com/23311011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added in a fix for the memory leak.
Move ExtensionError class to extensions/browser/, since it doesn't need to be in chrome/.
Limit the number of errors stored per extension to 100.
Store errors in a map, keyed by Extension ID, since that is how we will likely be accessing them.
BUG=21734
Review URL: https://chromiumcodereview.appspot.com/22647007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It leaks memory:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/24926/steps/memory%20test%3A%20unit/logs/stdio
Leak_DefinitelyLost
663 (264 direct, 399 indirect) bytes in 3 blocks are definitely lost in loss record 33,024 of 38,445
operator new(unsigned long) (m_replacemalloc/vg_replace_malloc.c:1140)
extensions::(anonymous namespace)::CreateNewRuntimeError(bool, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > const&) (chrome/browser/extensions/error_console/error_console_unittest.cc:51)
extensions::ErrorConsoleUnitTest_AddAndRemoveErrors_Test::TestBody() (chrome/browser/extensions/error_console/error_console_unittest.cc:80)
> Move ExtensionError to extensions/, add error limits
>
> Move ExtensionError class to extensions/browser/, since it doesn't need to be in chrome/.
> Limit the number of errors stored per extension to 100.
> Store errors in a map, keyed by Extension ID, since that is how we will likely be accessing them.
>
> BUG=21734
>
> Review URL: https://chromiumcodereview.appspot.com/21609003
TBR=rdevlin.cronin@chromium.org
Review URL: https://codereview.chromium.org/22585003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Move ExtensionError class to extensions/browser/, since it doesn't need to be in chrome/.
Limit the number of errors stored per extension to 100.
Store errors in a map, keyed by Extension ID, since that is how we will likely be accessing them.
BUG=21734
Review URL: https://chromiumcodereview.appspot.com/21609003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216345 0039d316-1c4b-4281-b951-d872f2087c98
|