summaryrefslogtreecommitdiffstats
path: root/extensions/browser/process_manager.cc
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: Style fixes in extensions/browserlauren.yeun.kim@gmail.com2014-06-031-1/+1
| | | | | | | | | | | | | 1) Fix Namespace comment in admin_policy.h 2) Mark explicit to single-argument constructors in file_highlighter.h and test_extensions_browser_client.h 3) Use CHECK_GT instead of CHECK in process_manager.cc BUG= Review URL: https://codereview.chromium.org/308913006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274475 0039d316-1c4b-4281-b951-d872f2087c98
* Unload all apps / extensions immediately when deleting a profile.scheib@chromium.org2014-05-221-1/+4
| | | | | | | | | | | | | | | | | | | | | Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile. Relanding patch: ShutdownStartupCycle failed in build [49353], this patch was speculatively reverted in r269383 [49355], but ShutdownStartupCycle failed again in [49362] after the revert had landed. [49353] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49353 [49355] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49355 [49362] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49362 BUG=368684, 374683 TEST=Manual testing as described on http://crbug.com/368684#c1 and http://crbug.com/374683#c7 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269343 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270890 Review URL: https://codereview.chromium.org/266343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272090 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Unload all apps / extensions when deleting a profile. ↵scheib@chromium.org2014-05-211-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/266343002/) Reason for revert: Caused crash in official builds when deleting profiles while the chrome:chrome-signin tab is open BUG=374683 TBR=kalman, sky Original issue's description: > Unload all apps / extensions immediately when deleting a profile. > > Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile. > > Relanding patch: ShutdownStartupCycle failed in build [49353], this patch was speculatively reverted in r269383 [49355], but ShutdownStartupCycle failed again in [49362] after the revert had landed. > > [49353] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49353 > [49355] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49355 > [49362] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49362 > > BUG=368684 > TEST=Manual testing as described on http://crbug.com/368684#c1 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269343 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270890 Review URL: https://codereview.chromium.org/289283013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271926 0039d316-1c4b-4281-b951-d872f2087c98
* Unload all apps / extensions immediately when deleting a profile.scheib@chromium.org2014-05-161-1/+4
| | | | | | | | | | | | | | | | | | | Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile. Relanding patch: ShutdownStartupCycle failed in build [49353], this patch was speculatively reverted in r269383 [49355], but ShutdownStartupCycle failed again in [49362] after the revert had landed. [49353] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49353 [49355] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49355 [49362] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49362 BUG=368684 TEST=Manual testing as described on http://crbug.com/368684#c1 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269343 Review URL: https://codereview.chromium.org/266343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270890 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 269343 "Unload all apps / extensions immediately when del..."rlp@chromium.org2014-05-091-4/+1
| | | | | | | | | | | | | | | | | | | Tentatively reverting to see if it fixes the browser_tests ShutdownStartupCycle failure. > Unload all apps / extensions immediately when deleting a profile. > > Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile. > > BUG=368684 > TEST=Manual testing as described on http://crbug.com/368684#c1 > > Review URL: https://codereview.chromium.org/266343002 TBR=scheib@chromium.org Review URL: https://codereview.chromium.org/278093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269383 0039d316-1c4b-4281-b951-d872f2087c98
* Unload all apps / extensions immediately when deleting a profile.scheib@chromium.org2014-05-091-1/+4
| | | | | | | | | | | Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile. BUG=368684 TEST=Manual testing as described on http://crbug.com/368684#c1 Review URL: https://codereview.chromium.org/266343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269343 0039d316-1c4b-4281-b951-d872f2087c98
* Replace NOTIFICATION_EXTENSION_LOADED to ↵limasdf@gmail.com2014-04-201-2/+3
| | | | | | | | | | | | | | | | NOTIFICATION_EXTENSION_LOADED_DEPRECATED to have bidirect with NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED. This CL is the result of below script, and 'git cl format'. find -regex '.*/.*\.\(mm\|cc\|h\)$' | xargs sed -i s/NOTIFICATION_EXTENSION_LOADED/NOTIFICATION_EXTENSION_LOADED_DEPRECATED/g BUG=354367 Review URL: https://codereview.chromium.org/242613004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264939 0039d316-1c4b-4281-b951-d872f2087c98
* Check the scheme of a RenderViewHost before assuming it contains an extension.jyasskin@chromium.org2014-04-031-3/+12
| | | | | | | | | | Thanks to ncarter for the test! BUG=357382 Review URL: https://codereview.chromium.org/216113007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261496 0039d316-1c4b-4281-b951-d872f2087c98
* Break extensions ProcessManager dependency on Runtime APIjamescook@chromium.org2014-03-311-3/+12
| | | | | | | | | | | | | * Introduce a ProcessManagerObserver * Make the Chrome extension RuntimeAPI implementation use it to send onStartup events. BUG=354552 TEST=browser_tests *Extension* Review URL: https://codereview.chromium.org/212603020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260478 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Extract RuntimeEventRouter from extensions Runtime API ↵jamescook@chromium.org2014-03-271-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/206613005/) Reason for revert: After talking to yoz@ and rockot@ I don't think we want to extract the runtime implementation to src/extensions. It's got too much Chrome-specific stuff, and for app_shell we really need app_runtime and not runtime. Original issue's description: > Extract RuntimeEventRouter from extensions Runtime API > > Another step toward moving the runtime API to src/extensions so it can be > used by app_shell. > > BUG=354552 > TEST=browser_tests ExtensionApi*:*Runtime* > TBR=xiyuan@chromium.org for header file move touching chrome/browser/chromeos/app_mode > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259477 TBR=yoz@chromium.org NOTREECHECKS=true NOTRY=true BUG=354552 Review URL: https://codereview.chromium.org/213313007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259755 0039d316-1c4b-4281-b951-d872f2087c98
* Extract RuntimeEventRouter from extensions Runtime APIjamescook@chromium.org2014-03-261-1/+4
| | | | | | | | | | | | | Another step toward moving the runtime API to src/extensions so it can be used by app_shell. BUG=354552 TEST=browser_tests ExtensionApi*:*Runtime* TBR=xiyuan@chromium.org for header file move touching chrome/browser/chromeos/app_mode Review URL: https://codereview.chromium.org/206613005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259477 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtensionHost from src/chrome to src/extensionsjamescook@chromium.org2014-03-211-1/+1
| | | | | | | | | | | | | | | | | | | This breaks another src/extensions -> src/chrome dependency. * Mechanical file move. * Clean up DEPS. * Move pinch-to-zoom handling to ExtensionViewHost as it only applies to visible extension content. No functional changes. BUG=321341 TEST=browser_tests *Extension* TBR=sky@chromium.org for header file rename across chrome/browser Review URL: https://codereview.chromium.org/198703006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258494 0039d316-1c4b-4281-b951-d872f2087c98
* Rename NOTIFICATION_EXTENSION_UNLOADED tokalman@chromium.org2014-03-191-2/+2
| | | | | | | | | | | | | NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED since ExtensionRegistry::AddObserver replaces it. BUG=354046 R=rockot@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/204703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258071 0039d316-1c4b-4281-b951-d872f2087c98
* Move extension_messages.h to extensions/common.derat@chromium.org2014-03-131-1/+1
| | | | | | | | | | | | | | | Move most of chrome/common/extensions/extension_messages.h into a new extensions/common/extension_messages.h file. WebApplicationInfo-related IPC definitions are now in chrome/common/extensions/chrome_extension_messages.h. BUG=335159 TBR=sky@chromium.org,cdn@chromium.org Review URL: https://codereview.chromium.org/194333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256831 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ExtensionService reference from extensions ProcessManagerjamescook@chromium.org2014-03-121-7/+5
| | | | | | | | | | | | | | Use ExtensionSystem to check if the extensions system is ready instead. Long ago Chrome OS did not create an ExtensionService at the login screen. This is no longer true, so this code is equivalent to the old behavior. BUG=351152 TEST=manual, Chrome OS boots and loads extensions like AdBlock Review URL: https://codereview.chromium.org/195493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256440 0039d316-1c4b-4281-b951-d872f2087c98
* Add TestExtensionsBrowserClient, move ProcessManagerTest to //extensionsjamescook@chromium.org2014-03-101-5/+20
| | | | | | | | | | | | | Rewrite ProcessManagerTest to eliminate the TestingProfile dependency and switch to TestBrowserContext. This requires an ExtensionsBrowserClient that knows how to associate an incognito context with a non-incognito context. I added this in hopes it would be useful for converting other tests away from TestingProfile. BUG=315855 TEST=unit_tests ProcessManager* Review URL: https://codereview.chromium.org/189683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255990 0039d316-1c4b-4281-b951-d872f2087c98
* Makes text input extensions available in guest session on CrOS.yukishiino@chromium.org2014-03-031-2/+12
| | | | | | | | | | | | | | | The behavioral changes are: 1) Creates background pages of extensions in guest session even if the extension is not "split" mode. Since the guest session has only the off-the-record context and does not have a regular context, we should treat the off-the-record context like the default regular context. Even if the extension is "spanning" mode, creates a background page for the off-the-record context in guest session. Otherwise, extensions in guest session cannot have a background page. 2) Passs key events, etc. to the off-the-record context regardless of whether extensions are enabled in incognito mode or not. The reason is the same. We should treat the off-the-record context as the default regular context in guest session. BUG=339318 TEST=Done manually. 1) Log in as guest, 2) Add Japanese language and enable Google Japanese Input, 3) Activate one of Japanese input method, 4) Type something. Review URL: https://codereview.chromium.org/177533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254481 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid returning an object from CreateBackgroundHost, since no callers use it.jyasskin@chromium.org2014-02-271-11/+11
| | | | | | | | | | | This makes it easier for CreateBackgroundHost to use a different type for the hosts of some extensions, which may be useful for the Service Worker backend. BUG=347328 Review URL: https://codereview.chromium.org/177043006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253771 0039d316-1c4b-4281-b951-d872f2087c98
* Removing unnecessary creation of RenderViewHostDestructionObserver for all ↵ckulakowski@opera.com2014-02-181-4/+6
| | | | | | | | | | | | | | WebContents ProcessManager creates RenderViewHostDestructionObserver for all WebContents. It's not necessary as ProcessManager keeps information about WebContents only related to extensions (extension's background page, extension's popup). BUG=344297 Review URL: https://codereview.chromium.org/169413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251765 0039d316-1c4b-4281-b951-d872f2087c98
* Make ExtensionsBrowserClient wrap some utility functions.derat@chromium.org2014-02-071-2/+2
| | | | | | | | | | | | | Add IsExtensionIncognitoEnabled() and CanExtensionCrossIncognito() to ExtensionsBrowserClient to break extensions/browser's dependency on chrome/browser/extensions/extension_util.h. BUG=315853 Review URL: https://codereview.chromium.org/152513010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249563 0039d316-1c4b-4281-b951-d872f2087c98
* Split ExtensionSystem interface from ExtensionSystemImpl implementation, part 1.yoz@chromium.org2014-01-301-7/+6
| | | | | | | | | | | | | This moves ExtensionSystem to extensions/browser. It also moves setting the channel for Features to ChromeExtensionsBrowserClient. It also removes the duplicate ExtensionSystem::GetForBrowserContext. BUG=337707 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/147923005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247788 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up extension_util.h.derat@chromium.org2014-01-241-11/+1
| | | | | | | | | | | | | Make utility functions take BrowserContexts instead of ExtensionServices. Also move them from the extension_util namespace to extensions::util. BUG=315853,332985 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/145263009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246929 0039d316-1c4b-4281-b951-d872f2087c98
* Clear testing callbacks in AppBackgrounPageNaclTest reentrantly.scheib@chromium.org2014-01-101-4/+10
| | | | | | | | | | | | Addresses a flaky ASAN failure where I believe callbacks from ImpulseCallbackCounter with an unretained reference were being held too long by ProcessManager. This clears the callbacks immediately when the impulse count is reached, and does not call the quit closure repeatedly. BUG=332440 Review URL: https://codereview.chromium.org/129243003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244247 0039d316-1c4b-4281-b951-d872f2087c98
* Allow app_shell to run past extension manifest parsingjamescook@chromium.org2014-01-071-3/+3
| | | | | | | | | | | | | | | | | | * Extracted non-Chrome-specific manifest handler registration into src/extensions/common/common_manfiest_handlers.cc * Moved app_shell app load/launch code into ShellExtensionSystem so it can signal that the system is ready * Refactored more of runtime API to use browser context instead of Profile * Cleaned up or removed some uses of ExtensionService This allows app_shell to get into the background page loading code before it crashes. BUG=162530,288226,309909 TEST=existing browser_tests of extension system Review URL: https://codereview.chromium.org/101203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243343 0039d316-1c4b-4281-b951-d872f2087c98
* Test Keeping NaCl plugins used in app background pages alive when active.scheib@chromium.org2014-01-071-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | (Re-landing with fixes from https://codereview.chromium.org/112663007/ ) Activity in Native Client plugins results in IPC messages sent to the BrowserPpapiHostImpl and routed to call extensions::ProcessManager::KeepaliveImpulse. Testing patch, builds on implementation: https://codereview.chromium.org/61063003/ Design doc: https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit# BUG=298339 No change to mseaborn owned file since last LGTM: R=yzshen@chromium.org TBR=mseaborn@chromium.org Review URL: https://codereview.chromium.org/125353006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243326 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://codereview.chromium.org/112663007/ckocagil@chromium.org2014-01-041-17/+1
| | | | | | | | | | | | | Reason for revert: Broke XP bots: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/32520 TBR=yzshen@chromium.org,scheib@chromium.org NOTREECHECKS=true NOTRY=true BUG=298339 Review URL: https://codereview.chromium.org/124313005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243034 0039d316-1c4b-4281-b951-d872f2087c98
* Test Keeping NaCl plugins used in app background pages alive when active.scheib@chromium.org2014-01-041-1/+17
| | | | | | | | | | | | | | | | | | | | | | | (Re-landing with fixes from https://codereview.chromium.org/111563006/ ) Activity in Native Client plugins results in IPC messages sent to the BrowserPpapiHostImpl and routed to call extensions::ProcessManager::KeepaliveImpulse. Testing patch, builds on implementation: https://codereview.chromium.org/61063003/ Design doc: https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit# BUG=298339 No change to mseaborn owned file since last LGTM: TBR=mseaborn@chromium.org Review URL: https://codereview.chromium.org/112663007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243021 0039d316-1c4b-4281-b951-d872f2087c98
* Replace the GetAssociatedRenderView call with GetAssociatedRenderFrame in ↵jam@chromium.org2013-12-301-6/+25
| | | | | | | | | | | ChromeNetworkDelegate. BUG=304341 R=koz@chromium.org Review URL: https://codereview.chromium.org/102643010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242739 0039d316-1c4b-4281-b951-d872f2087c98
* Convert ExtensionRegistry to a BrowserContextKeyedServicejamescook@chromium.org2013-12-271-13/+13
| | | | | | | | | | | | | | | | | | This removes dependencies on ExtensionService, which does not exist for app_shell. * Convert all of src/extensions to use ExtensionRegistry's extension sets. * Remove ExtensionService::blacklisted_extensions() and convert all callers to use ExtensionRegistry. BUG=none TEST=existing unit_tests, browser_tests R=miket@chromium.org TBR=phajden.jr@chromium.org for adding dependency on components/browser_context_keyed_service Review URL: https://codereview.chromium.org/120863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242624 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent creating background pages for non-incognito profile in Guest modedpolukhin@chromium.org2013-12-211-2/+8
| | | | | | | | | BUG=329498 TEST=manually Review URL: https://codereview.chromium.org/101413011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242271 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 242061 "Test Keeping NaCl plugins used in app background ..."dbeam@chromium.org2013-12-201-17/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Broke this test Mac ASAN 64 Tests (1): http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%2064%20Tests%20%281%29/builds/402 AppBackgroundPageNaClTest.BackgroundKeepaliveActive (run #1): [ RUN ] AppBackgroundPageNaClTest.BackgroundKeepaliveActive [6102,475938816:04:26:31.429668] Native Client module will be loaded at base address 0x000066c200000000 [6104,475938816:04:26:32.535943] Native Client module will be loaded at base address 0x00003d5a00000000 ASAN:SIGSEGV ================================================================= ==6095==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000050 (pc 0x000106384d7b sp 0x7fff5d44fde0 bp 0x7fff5d450000 T0) #0 0x106384d7a (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103bdbd7a) #1 0x106384a31 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103bdba31) #2 0x11296475a (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1101bb75a) #3 0x112964905 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1101bb905) #4 0x1061f4e33 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a4be33) #5 0x1061f45af (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a4b5af) #6 0x1049070ec (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x10215e0ec) #7 0x104902b5b (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x102159b5b) #8 0x109457b06 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x106caeb06) #9 0x109ca6d33 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1074fdd33) #10 0x109453876 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x106caa876) #11 0x10945e99e (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x106cb599e) #12 0x10944b514 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x106ca2514) #13 0x112896341 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1100ed341) #14 0x1061f1486 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a48486) #15 0x106f2bac3 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x104782ac3) #16 0x106f2e6f0 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1047856f0) #17 0x106f2f63e (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x10478663e) #18 0x106f438e8 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x10479a8e8) #19 0x106f42939 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x104799939) #20 0x10645d4e5 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103cb44e5) #21 0x1061ecafe (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a43afe) #22 0x11295833d (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1101af33d) #23 0x1061ec995 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a43995) #24 0x1027ab5c3 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1000025c3) #25 0xe AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV ??:0 ?? ==6095==ABORTING > Test Keeping NaCl plugins used in app background pages alive when active. > > Activity in Native Client plugins results in IPC messages > sent to the BrowserPpapiHostImpl and routed to call > extensions::ProcessManager::KeepaliveImpulse. > > Testing patch, builds on implementation. See: > https://codereview.chromium.org/61063003/ Implementation. > https://codereview.chromium.org/105873003/ Cumulative patch. > > Design doc: > https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit# > > BUG=298339 > > Review URL: https://codereview.chromium.org/111563006 TBR=scheib@chromium.org Review URL: https://codereview.chromium.org/118533004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242120 0039d316-1c4b-4281-b951-d872f2087c98
* Test Keeping NaCl plugins used in app background pages alive when active.scheib@chromium.org2013-12-201-1/+17
| | | | | | | | | | | | | | | | | | | Activity in Native Client plugins results in IPC messages sent to the BrowserPpapiHostImpl and routed to call extensions::ProcessManager::KeepaliveImpulse. Testing patch, builds on implementation. See: https://codereview.chromium.org/61063003/ Implementation. https://codereview.chromium.org/105873003/ Cumulative patch. Design doc: https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit# BUG=298339 Review URL: https://codereview.chromium.org/111563006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242061 0039d316-1c4b-4281-b951-d872f2087c98
* Keep NaCl plugins used in app background pages alive when active.scheib@chromium.org2013-12-181-0/+2
| | | | | | | | | | | | | | | | | | | Activity in Native Client plugins results in IPC messages sent to the BrowserPpapiHostImpl and routed to call extensions::ProcessManager::KeepaliveImpulse. Implementation patch, to be followed by tests. See: https://codereview.chromium.org/111563006/ Tests. https://codereview.chromium.org/105873003/ Cumulative patch. Design doc: https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit# BUG=298339 Review URL: https://codereview.chromium.org/61063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241702 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DeferBackgroundExtensionCreation field trial and supporting code.tapted@chromium.org2013-12-111-22/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is mostly just "Revert 221621 This defers starting background extension page RenderViews..." on trunk after resolving conflicts. r221621 assumes a browser is always created with StartupBrowserCreatorImpl. However, this is not true for incognito browsers, some command line switch options, nor some launch flows via the App Launcher. This meant that background extensions were sometimes never created. The field trial setup also needs to be revised, since it went out to 50x the users that is normal for a field trial on stable channel. Field trial is now disabled server-side in m31-33, but there should be enough data collected in m31 to make a call on whether to attempt this again with fixes. This reverts commit 736f456664be5e47df88bf8f936f40ddee299bd1. > This defers starting background extension page RenderViews > until after session restore has completed. > > This is mainly to help login/startup times so that Chrome is useful to > the user earlier. To make sure that this is actually helping, this CL > includes a Finch experiment that will only enable the deferral on 50% > of the clients. > > It is also expected that deferring these will help with some problems > we've seen when extensions attempt to do GAIA authentication. > > BUG=279427,259791 > TEST=Ran performance tests on ChromeOS and Linux > > Review URL: https://chromiumcodereview.appspot.com/23618014 Some conflicts. Most due to c/b/e/chrome/browser/extensions/extension_process_manager.* moving to extensions/browser/process_manager.*, and some minor ones elsewhere. BUG=320787,288259,304453 R=mpcomplete@chromium.org, gspencer@chromium.org TBR=sky@chromium.org, rlp@chromium.org Review URL: https://codereview.chromium.org/111253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240061 0039d316-1c4b-4281-b951-d872f2087c98
* Add KeepaliveImpulse to extension process manager.scheib@chromium.org2013-12-031-19/+75
| | | | | | | | | | | | | | | | | | | Impulses are an efficient way to handle certain types of activity from extensions. E.g. the work in progress to keep NaCl plugins in background pages alive. An Increment / Decrement approach would require extensive and fragile instrumentation of all APIs. Impulses can be sent upon any api activity and act as an implicit increment with a timed out decrement. See design doc: https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit# BUG=298339 Review URL: https://codereview.chromium.org/60613004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238261 0039d316-1c4b-4281-b951-d872f2087c98
* Extract UI dependencies from ExtensionHost, part 1jamescook@chromium.org2013-11-261-12/+0
| | | | | | | | | | | | | | | | | | | app_shell needs to support background pages in order to load apps, but doesn't have the usual UI surfaces for Chrome extensions (popups, infobars, etc.). * Extract functionality touching platform-specific views to ExtensionViewHost * Remove references to panels, which don't use ExtensionHost Reupload of LGTM'd change https://codereview.chromium.org/82163002 because AppEngine is misbehaving. BUG=321341 TEST=browser_tests, interactive_ui_tests TBR=yoz@chromium.org Review URL: https://codereview.chromium.org/86363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237190 0039d316-1c4b-4281-b951-d872f2087c98
* Move Extension and PermissionsData to extensions/common.yoz@chromium.org2013-11-151-1/+1
| | | | | | | | | | BUG=298586 R=cdn@chromium.org, miket@chromium.org, sky@chromium.org TBR=cdn@chromium.org Review URL: https://codereview.chromium.org/15239002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235462 0039d316-1c4b-4281-b951-d872f2087c98
* Split extensions::MenuManager instance out from ExtensionService.benwells@chromium.org2013-11-141-10/+1
| | | | | | | | | | | | This is now its own BCKS. There was no need for it to be in ExtensionService. TBR=sky@chromium.org BUG=162530 Review URL: https://codereview.chromium.org/64953004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235120 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Move ExtensionProcessManager to src/extensions, part 4jamescook@chromium.org2013-11-101-0/+836
| | | | | | | | | | | | | | | | | Reland of https://codereview.chromium.org/62713003/ - the original patch broke the Google Chrome OS official builder due to a missing dependency on the extensions api target in extensions/extensions.gyp. * Move c/b/extensions/extension_process_manager.h to extensions/browser/process_manager.h * Rename ExtensionsProcessManager to ProcessManager * Place it in the "extensions" namespace BUG=313481 TEST=browser_tests, unit_tests TBR=miket@chromium.org Review URL: https://codereview.chromium.org/67253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234149 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 233956 "Move ExtensionProcessManager to src/extensions, p..."rockot@google.com2013-11-081-836/+0
| | | | | | | | | | | | | | | | | | | | | | | | Compile error, runtime.h has moved? > Move ExtensionProcessManager to src/extensions, part 4 > > * Move c/b/extensions/extension_process_manager.h to > extensions/browser/process_manager.h > * Rename ExtensionsProcessManager to ProcessManager > * Place it in the "extensions" namespace > > BUG=313481 > TEST=browser_tests, unit_tests > R=miket@chromium.org > TBR=sky@chromium.org for mechanical header file move affecting chrome/browser/ > > Review URL: https://codereview.chromium.org/62713003 TBR=jamescook@chromium.org Review URL: https://codereview.chromium.org/66213006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233959 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtensionProcessManager to src/extensions, part 4jamescook@chromium.org2013-11-081-0/+836
* Move c/b/extensions/extension_process_manager.h to extensions/browser/process_manager.h * Rename ExtensionsProcessManager to ProcessManager * Place it in the "extensions" namespace BUG=313481 TEST=browser_tests, unit_tests R=miket@chromium.org TBR=sky@chromium.org for mechanical header file move affecting chrome/browser/ Review URL: https://codereview.chromium.org/62713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233956 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-04-03 02:57:26 +0000