summaryrefslogtreecommitdiffstats
path: root/extensions/browser
Commit message (Collapse)AuthorAgeFilesLines
* Rename NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED tokalman@chromium.org2014-07-011-2/+2
| | | | | | | | | | | | | NOTIFICATION_EXTENSION_WILL_BE_INSTALLED_DEPRECATED, which more accurately reflects what it does, and matches the corresponding event in ExtensionRegistryObserver. R=rdevlin.cronin@chromium.org TBR=pkotwicz@chromium.org,sky@chromium.org,dconnelly@chromium.org Review URL: https://codereview.chromium.org/361833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280887 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash during shutdown caused by content verification codeasargent@chromium.org2014-07-011-0/+3
| | | | | | | | | | | | | | | | | | | Inside ContentVerifier::CreateJobFor(), we were accessing the ExtensionRegistry even though shutdown may be in progress and it is being torn down. The quick fix here is to avoid doing that by early-returning if the fetcher or delegate is null (the entire feature is turned off by default and the fetcher object is only created when the feature is turned on, so this should stop the crash). Looking closely at this code made me realize we are also accidentally accessing the ExtensionRegistry from a non-UI thread, so in a follow-up patch I will fix that as well. BUG=389217 Review URL: https://codereview.chromium.org/358693008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280709 0039d316-1c4b-4281-b951-d872f2087c98
* bluetoothLowEnergy: Add functions to start/stop characteristic notifications.armansito@chromium.org2014-06-281-0/+2
| | | | | | | | | | | | | | | | | | | This CL adds the startCharacteristicNotifications and stopCharacteristicNotifications functions to the chrome.bluetoothLowEnergy API. These changes the API behavior from automatically getting characteristic value notifications to explicitly having to enable them by calling the new API method. Internally an API resource is created for each app on a per-characteristic basis, managing the life-time of a device::BluetoothGattNotifySession object. Notifications are physically enabled/disabled and shared among apps using session objects. BUG=387989 TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.* Review URL: https://codereview.chromium.org/351123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280477 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some more problems with windows paths in content verificationasargent@chromium.org2014-06-284-6/+69
| | | | | | | | | | | | | | | | | It turns out that the relative path we generate inside the network stack when requesting chrome://extension urls uses '/' path separators for relative paths, but the in-memory representation of computed_hashes.json and verified_contents.json files ended up with '\' path separators on windows. So we ended up not finding any paths with a subdirectory at request time. I've fixed this by just standardizing on '/' path separators everywhere. BUG=382638 Review URL: https://codereview.chromium.org/361523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280473 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test helper class for ExtensionRegistry.limasdf@gmail.com2014-06-272-0/+163
| | | | | | | | | | | | And use it from c/e/b/extensions/. BUG=354046 R=yoz@chromium.org, thestig@chromium.org, kalman@chromium.org TEST=browser_tests Review URL: https://codereview.chromium.org/334083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280415 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: Split extensions utility IPC messages into its own file.thestig@chromium.org2014-06-271-4/+0
| | | | | | | | | | Disable extensions code on Android so they do not use these messages. BUG=349436 Review URL: https://codereview.chromium.org/345693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280242 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r279748: Rename webview API related files to web_view_internal.lazyboy@chromium.org2014-06-261-21/+42
| | | | | | | | | | | | | | | | | | webview.json -> web_view_internal.json Broke compile on clobber builds, was not caught on trybot incremental builds. Fixed the #include header in web_view_internal_api.cc Requires NOTRY for (false) histograms.xml presubmit failure. NOTRY=true TBR=kalman@chromium.org, fsamuel@chromium.org, thestig@chromium.org, asvitkine@chromium.org BUG=388380 Test=Internal cleanup, no visible change. Review URL: https://codereview.chromium.org/356793004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280091 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in ContentVerifier::ShouldVerifyAnyPaths when deleagte_ is NULLdpolukhin@chromium.org2014-06-261-1/+1
| | | | | | | | | | | | | My previous patch removed this check because I thought that all code paths have such check but it is not the case so I returned this check. BUG=388797 TBR= asargent@chromium.org TEST=N/A Review URL: https://codereview.chromium.org/352633008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279992 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 279748 "Rename webview API related files to web_view_inte..."lazyboy@chromium.org2014-06-251-42/+21
| | | | | | | | | | | | | | | | | > Rename webview API related files to web_view_internal. > webview.json -> web_view_internal.json > > NOTRY=True > BUG=388380 > Test=Internal cleanup, no visible change. > > Review URL: https://codereview.chromium.org/347143004 TBR=lazyboy@chromium.org Review URL: https://codereview.chromium.org/351033006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279755 0039d316-1c4b-4281-b951-d872f2087c98
* Rename webview API related files to web_view_internal.lazyboy@chromium.org2014-06-251-21/+42
| | | | | | | | | | | | webview.json -> web_view_internal.json NOTRY=True BUG=388380 Test=Internal cleanup, no visible change. Review URL: https://codereview.chromium.org/347143004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279748 0039d316-1c4b-4281-b951-d872f2087c98
* Move /c/b/extensions/StateStore to /extension/browserlimasdf@gmail.com2014-06-252-0/+291
| | | | | | | | | | | | | Since it's a key part of the extensions system. And remove Profile dependency from StateStore. R=yoz@chromium.org, thestig@chromium.org BUG=159265 Review URL: https://codereview.chromium.org/348103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279640 0039d316-1c4b-4281-b951-d872f2087c98
* Fully installed apps should not have the ephemeral_app flag set in extension ↵tmdiep@chromium.org2014-06-251-6/+22
| | | | | | | | | | | | | | prefs The "ephemeral_app" flag is only written to extension prefs for ephemeral apps and removed when the app is fully installed. BUG=None TEST=browser_tests (EphemeralAppBrowserTest.*) Review URL: https://codereview.chromium.org/342593004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279616 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 279293 "Extensions: Add some CHECKs to help track down a ..."thestig@chromium.org2014-06-241-2/+0
| | | | | | | | | | | | | | > Extensions: Add some CHECKs to help track down a flaky TestAdblockExtensionCrash. > > BUG=387866 > > Review URL: https://codereview.chromium.org/354493003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/352693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279506 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: Add some CHECKs to help track down a flaky ↵thestig@chromium.org2014-06-241-0/+2
| | | | | | | | | | TestAdblockExtensionCrash. BUG=387866 Review URL: https://codereview.chromium.org/354493003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279293 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the known_disabled feature as it is now superseeded by settings ↵gab@chromium.org2014-06-233-17/+6
| | | | | | | | | | protection. BUG=312883 Review URL: https://codereview.chromium.org/340093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279171 0039d316-1c4b-4281-b951-d872f2087c98
* Performance histograms for extension content verificationasargent@chromium.org2014-06-235-3/+46
| | | | | | | | | BUG=387158 TBR=rockot@chromium.org Review URL: https://codereview.chromium.org/341263003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279166 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GuestWebContentsCreatedfsamuel@chromium.org2014-06-231-1/+2
| | | | | | | | | | | | | | | | | | | | | This CL introduces GuestViewInternal.createGuest which replaces GuestViewInternal.allocateInstanceId. This new internal API does the following: 1. Allocates an instance ID. 2. Creates a new guest delegate of the specified and guest WebContents, without navigating the new WebContents. 3. On attachment, the new WebContents is navigated. In this CL, the particular GuestView type decides how to create the WebContents. Thus <webview> can create WebContents with SiteInstances of the form chrome-guest:// whereas <appview> can create guests with the SiteInstances matching the app they are hosting. BrowserPluginGuestDelegate (e.g. WebViewGuest) is now passed in to the constructor of BrowserPluginGuest. Now, we can assume a delegate always exists. I added a DCHECK to the constructor. With this patch, BrowserPluginGuestDelegate outlives BrowserPluginGuest too so we can always assume delegate_ is safe to access. BUG=364141 NOTRY=true Review URL: https://codereview.chromium.org/336283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279140 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce content verification for shared extensions on Chrome OSdpolukhin@chromium.org2014-06-234-107/+46
| | | | | | | | | BUG=235263 TEST=manual Review URL: https://codereview.chromium.org/313513003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279070 0039d316-1c4b-4281-b951-d872f2087c98
* [fsp] Cleanup success callbacks for CloseFile and OpenFile.mtomasz@chromium.org2014-06-231-2/+3
| | | | | | | | | | | | | | | | | Both callbacks were exactly the same, so this patch merges them to one generic OperationRequestSuccess, which will be used in the future also by other operations. Secondly, since now, we pass the Value arguments passed from JS, since they are going to contain some performance information. NOTRY=true TEST=unit_tests, browser_tests: *FileSystemProvider* BUG=373165, 384201 Review URL: https://codereview.chromium.org/331363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279037 0039d316-1c4b-4281-b951-d872f2087c98
* [fsp] [reland] Cleanup handling errors for operation requests.mtomasz@chromium.org2014-06-231-6/+7
| | | | | | | | | | | | | | | | | | | | | | This is a reland of https://codereview.chromium.org/335753004/, after reverting because of breaking ASAN bots. Includes a trivial fix. The original description is below. This CL removes redundant internal functions which are identical, and replaces them with one. Moreover, the new general purpose error API function, passes now the entire value to the request manager. This is because, very soon, we are going to pass extra information with every error and success responses and we want to have access to them in the RequestManager. TBR=benwells@chromium.org, isherman@chromium.org, kinaba@chromium.org TEST=unit_tests, browser_tests: *FileSystemProvider* BUG=373165, 384201 Review URL: https://codereview.chromium.org/342893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279023 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: Move app.runtime API from apps to extensions.derat@chromium.org2014-06-224-0/+212
| | | | | | | | | | | Also move GrantedFileEntry into extensions. BUG=373821 TBR=miket@chromium.org,brettw@chromium.org Review URL: https://codereview.chromium.org/348453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278994 0039d316-1c4b-4281-b951-d872f2087c98
* Added webstorePrivate API functions for launching ephemeral appstmdiep@chromium.org2014-06-211-0/+2
| | | | | | | | | | | | | Implements: - webstorePrivate.launchEphemeralApp() - webstorePrivate.getEphemeralAppsEnabled() BUG=380980 TEST=browser_tests (EphemeralAppWebstorePrivateApiTest*) Review URL: https://codereview.chromium.org/342433003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278945 0039d316-1c4b-4281-b951-d872f2087c98
* chrome.bluetoothLowEnergy: Introduce connect and disconnect methods.armansito@chromium.org2014-06-201-0/+2
| | | | | | | | | | | | | | | This CL introduces the connect and disconnect methods to the bluetoothLowEnergy API, which allow an app to initiate and hold on to the connection to a low energy device. The API calls internally manage the allocation of an API resource corresponding to a per app, per device device::BluetoothGattConnection object. BUG=381305 TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.* Review URL: https://codereview.chromium.org/349433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278669 0039d316-1c4b-4281-b951-d872f2087c98
* Add FileSystemID parameter to IsolatedContext::RegisterFileSystemForPath.kinaba@chromium.org2014-06-201-1/+1
| | | | | | | | | | | | | With this change, nested filesystems mounted onto isolated context can remember its original filesystem id, that unblocks the issue 370782 of drag-and-drop support in chromeos::FileSystemBackend. BUG=370782, 386062 TBR=kaznacheev, benwells, dmichael, sky Review URL: https://codereview.chromium.org/341043008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278666 0039d316-1c4b-4281-b951-d872f2087c98
* Moves extension_icon_image and image_loader to extensions/browsermukai@chromium.org2014-06-2013-0/+1867
| | | | | | | | | | | | | | Now extension_icon_image and image_loader are safe to be used outside of Chrome, like AppShell/Athena. BUG=159265, 380421 R=yoz@chromium.org, jamescook@chromium.org TBR=sky@chromium.org, fmalita@chromium.org TEST=unit_tests, compile succeeds Review URL: https://codereview.chromium.org/334053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278601 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome.virtualKeyboardPrivate.openSettings api to open settings pagebshe@chromium.org2014-06-191-0/+1
| | | | | | | | | | This will open chrome://settings/languages page after called. BUG= Review URL: https://codereview.chromium.org/342573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278439 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 277929 "[fsp] Cleanup handling errors for operation reque..."oshima@chromium.org2014-06-181-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | > [fsp] Cleanup handling errors for operation requests. > > This CL removes redundant internal functions which are identical, and replaces > them with one. > > Moreover, the new general purpose error API function, passes now the entire > value to the request manager. This is because, very soon, we are going to > pass extra information with every error and success responses and we want to > have access to them in the RequestManager. > > NOTRY=true > TEST=unit_tests, browser_tests: *FileSystemProvider* > BUG=373165, 384201 > > Review URL: https://codereview.chromium.org/335753004 TBR=mtomasz@chromium.org Review URL: https://codereview.chromium.org/342003004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278186 0039d316-1c4b-4281-b951-d872f2087c98
* Fix several problems with the content verification codeasargent@chromium.org2014-06-189-95/+301
| | | | | | | | | | | | | | | | | | -While we're doing the initial scan of files to build up computed_hashes.json, if we notice a mismatch, report that right away. This also fixes problems where if you modify/delete computed_hashes.json, enforcement would never work. -Avoid an infinite loop in ContentVerifyJob by making sure we stop checking newly read bytes after we've already reported a failure (we were stuck failing to advance to the next block after reporting a failure) BUG=375992,375953 Review URL: https://codereview.chromium.org/329303007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278071 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the ability to retain local data of evicted ephemeral appstmdiep@chromium.org2014-06-182-89/+3
| | | | | | | | | | This is effectively a revert of http://crrev.com/202763005 BUG=339004 Review URL: https://codereview.chromium.org/337323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277972 0039d316-1c4b-4281-b951-d872f2087c98
* [fsp] Cleanup handling errors for operation requests.mtomasz@chromium.org2014-06-181-6/+7
| | | | | | | | | | | | | | | | | | This CL removes redundant internal functions which are identical, and replaces them with one. Moreover, the new general purpose error API function, passes now the entire value to the request manager. This is because, very soon, we are going to pass extra information with every error and success responses and we want to have access to them in the RequestManager. NOTRY=true TEST=unit_tests, browser_tests: *FileSystemProvider* BUG=373165, 384201 Review URL: https://codereview.chromium.org/335753004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277929 0039d316-1c4b-4281-b951-d872f2087c98
* Remove media_galleries_handlers - not used.vandebo@chromium.org2014-06-171-1/+1
| | | | | | | | | | | According to crbug.com/307827 - the code that used media_galleries_handlers has been removed. BUG=NONE NOTRY=true Review URL: https://codereview.chromium.org/338473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277773 0039d316-1c4b-4281-b951-d872f2087c98
* Identity API: add chrome.identity.getProfileUserInfocourage@chromium.org2014-06-171-0/+1
| | | | | | | | | | | | | | getProfileUserInfo returns the email address and obfuscated gaia id of the user signed into a profile. If the user is not signed in, empty strings are returned. This API is different from identity.getAccounts in two ways. The information returned is available offline, and it only applies to the primary account for the profile (even when multiple login is enabled). BUG=368343 Review URL: https://codereview.chromium.org/327403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277724 0039d316-1c4b-4281-b951-d872f2087c98
* Log error in ValueStore if JSON serialization during writing fails.pneubeck@chromium.org2014-06-162-3/+9
| | | | | | | | | | For example, this error occurs if one tries to store a base::BinaryValue. BUG=NONE Review URL: https://codereview.chromium.org/326393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277413 0039d316-1c4b-4281-b951-d872f2087c98
* Add a do_not_sync pref to ExtensionPrefs.xiyuan@chromium.org2014-06-143-3/+27
| | | | | | | | | | | | | | | Split from https://codereview.chromium.org/308003005/ for extensions system changes that allows to install a none syncable Extension. - Add a do_not_sync pref to ExtensionPrefs; - Add a kInstallFlagDoNotSync that CrxInstaller uses to initialize the pref; - Update util::ShouldSyncApp and add ShouldSyncExtension to use the pref to skip sync in ExtensionSyncService; BUG=358791 Review URL: https://codereview.chromium.org/323843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277269 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extension-specific page load time histogram support for webrequestvabr@chromium.org2014-06-132-2/+0
| | | | | | | | | | | | This CL removes the code responsible for providing PLT histogram data for specific extensions using the WebRequest API. Code providing such data not bound to specific extensions is kept. BUG=100411 Review URL: https://codereview.chromium.org/335573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277096 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Make ExtensionService:: and ExtensionPrefs::OnExtensionInstalledkalman@chromium.org2014-06-133-20/+61
| | | | | | | | | | | | | | take a bitmask instead of 4 boolean values (soon to be 5). As part of that, change the default-true flag "wait for idle" to a default-false flag "install immediately". R=asargent@chromium.org TBR=estade@chromium.org, atwilson@chromium.org, dimich@chromium.org Review URL: https://codereview.chromium.org/322893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276999 0039d316-1c4b-4281-b951-d872f2087c98
* Send an onInstalled event for shared module updateelijahtaylor@chromium.org2014-06-132-0/+34
| | | | | | | | BUG=276723 Review URL: https://codereview.chromium.org/317993003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276871 0039d316-1c4b-4281-b951-d872f2087c98
* Invoke callback from WebstoreInstaller when installation is fully completetmdiep@chromium.org2014-06-123-1/+18
| | | | | | | | | | | | | | | | | | ExtensionRegistry observers will be notified when an extension install is fully complete, i.e. after the extension has been loaded or added to one of the registry extension sets. This allows the WebstoreInstaller completion to be delayed until the extension has been loaded. Workarounds in EphemeralAppLauncher for launching an app can now be cleaned up since we are now assured that the app has been loaded. BUG=None TEST=browser_tests Review URL: https://codereview.chromium.org/326213004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276666 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtensionServiceTestBase into its own header/cc filerdevlin.cronin@chromium.org2014-06-121-2/+4
| | | | | | | | | | | | | | | | | | This is the first step in refactoring the (overly-gigantic) extension_service_unittest.cc BUG=381251 TBR=atwilson@chromium.org (c/b/background/) TBR=bauerb@chromium.org (c/b/managed_mode/) TBR=battre@chromium.org (c/b/profile_resetter/) TBR=pkotwicz@chromium.org (c/b/themes) TBR=koz@chromium.org (c/b/ui/app_list) All TBRs are for simple mechanical changes (primarily namespace move). Review URL: https://codereview.chromium.org/318863008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276587 0039d316-1c4b-4281-b951-d872f2087c98
* Adds IME switching private APIs.shuchen@chromium.org2014-06-121-0/+3
| | | | | | | | | BUG=372291 TEST=None Review URL: https://codereview.chromium.org/305533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276570 0039d316-1c4b-4281-b951-d872f2087c98
* Fix content verifier handling of paths with subdirectories on windowsasargent@chromium.org2014-06-102-4/+10
| | | | | | | | | | | Any path with a subdirectory was failing on windows because we weren't translating to use windows path separators. BUG=382638 Review URL: https://codereview.chromium.org/321893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275989 0039d316-1c4b-4281-b951-d872f2087c98
* Move allocate instance id to chrome/.lazyboy@chromium.org2014-06-071-0/+2
| | | | | | | | | BUG=364141 Test=No visible change. Review URL: https://codereview.chromium.org/299753011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275674 0039d316-1c4b-4281-b951-d872f2087c98
* Add an extension override bubble and warning box for proxy extensions. (2nd ↵finnur@chromium.org2014-06-072-0/+21
| | | | | | | | | | | | | | | | attempt, this time with two one-liner test fixes) Also use the browser action highlighting for extensions that have a browser action icon. NOTE: This CL was already green-lighted here: https://codereview.chromium.org/288923004/ BUG=381291 TBR=sky, devlin, dbeam Review URL: https://codereview.chromium.org/320633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275577 0039d316-1c4b-4281-b951-d872f2087c98
* Move c/b/e/api/api_resource_manager_unittest.cc tolimasdf@gmail.com2014-06-071-0/+63
| | | | | | | | | | | src/extensions/browser/api/ Make it compiled and fix typo. BUG=381706 Review URL: https://codereview.chromium.org/319543006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275571 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated permissions functions from Extensionrdevlin.cronin@chromium.org2014-06-066-11/+28
| | | | | | | | | | | | | | | | | | | | The methods GetActivePermission() and HasAPIPermission() have been deprecated for more than a year. Finally remove them. Also clean up some includes in extension.h, and fix transitive includes. BUG=379356 TBR=atwilson@chromium.org (c/b/background) TBR=yurys@chromium.org (c/b/devtools) TBR=bauerb@chromium.org (c/b/managed_mode) TBR=dalecurtis@chromium.org (c/b/media) TBR=dewittj@chromium.org (c/b/notifications) TBR=msw@chromium.org (c/b/ui) All TBRs are for strictly mechanical changes - no functional difference. Review URL: https://codereview.chromium.org/314113010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275531 0039d316-1c4b-4281-b951-d872f2087c98
* Remove InstallTracker's extension load, unload observer.limasdf@gmail.com2014-06-063-2/+11
| | | | | | | | | | | Since ExtensionRegistry provide canonical way, use ExtensionRegistry instead. BUG=374353 TEST=unit_tests Review URL: https://codereview.chromium.org/298023009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275434 0039d316-1c4b-4281-b951-d872f2087c98
* Remove PermissionsData::ForExtension() completelyrdevlin.cronin@chromium.org2014-06-062-20/+20
| | | | | | | | | | | | | | | There's no reason to have this. It was originally because PermissionsData didn't really belong on Extension (and was to be taken off), but now that PermissionsData is refactored to only include active permissions, it belongs on the extension object. TBR=ben@chromium.org (c/b/ui - simple refactor, no functional changes) TBR=thestig@chromium.org (c/b/media_galleries - simple refactor, no functional changes) BUG=379356 Review URL: https://codereview.chromium.org/315573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275332 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 275229 "Add an extension override bubble and warning box ..."finnur@chromium.org2014-06-052-21/+0
| | | | | | | | | | | | | | | | | > Add an extension override bubble and warning box for proxy extensions. > > Also use the browser action highlighting for extensions that have a browser action icon. > > BUG=381291 > R=dbeam@chromium.org, rdevlin.cronin@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/288923004 TBR=finnur@chromium.org Review URL: https://codereview.chromium.org/312403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275255 0039d316-1c4b-4281-b951-d872f2087c98
* Add an extension override bubble and warning box for proxy extensions.finnur@chromium.org2014-06-052-0/+21
| | | | | | | | | | | Also use the browser action highlighting for extensions that have a browser action icon. BUG=381291 R=dbeam@chromium.org, rdevlin.cronin@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/288923004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275229 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor PermissionsData pt1rdevlin.cronin@chromium.org2014-06-052-20/+20
| | | | | | | | | | | | | | | | | | In this CL, we: - Make PermissionsData not-so-static. Only methods which either don't rely on knowledge of specific permissions or methods to get/create the object are static. - Separate runtime permissions knowledge from manifest parsing (PermissionsData vs PermissionsParser) - Move required/optional permissions access into PermissionsParser. - Handle the locking issues. BUG=379356 TBR=sky@chromium.org (for c/b/ui/, no functional changes) Review URL: https://codereview.chromium.org/309533007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275142 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 15:18:10 +0000