| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.
BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
Cr-Commit-Position: refs/heads/master@{#378859}
Review URL: https://codereview.chromium.org/1722773002
Cr-Commit-Position: refs/heads/master@{#379122}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/1722773002/ )
Reason for revert:
Broke compile on iOS_Simulator_GN_(dbg): https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_GN_%28dbg%29/builds/1777
Original issue's description:
> Move GURL ParamTraits to url/ipc
>
> As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on
> content/. One such dependency is GURL. As per discussion here:
> https://codereview.chromium.org/1703163002/, the plan of record is to move
> GURL ParamTraits out of content/ and into url/.
>
> BUG=586368
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
> Cr-Commit-Position: refs/heads/master@{#378859}
TBR=fsamuel@chromium.org,piman@chromium.org,brettw@chromium.org,tsepez@chromium.org,thakis@chromium.org,markdittmer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=586368
Review URL: https://codereview.chromium.org/1755363003
Cr-Commit-Position: refs/heads/master@{#378869}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.
BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1722773002
Cr-Commit-Position: refs/heads/master@{#378859}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WDS library implements a Wi-Fi Display dialect of RTSP
that includes the parser, actual negotiation logic for sink
and source, and the related data structures.
This patch contains initial implementation of WDS library
embedder interfaces.
BUG=242107
Review URL: https://codereview.chromium.org/1698473004
Cr-Commit-Position: refs/heads/master@{#378182}
|
|
|
|
|
|
|
|
|
|
|
| |
All users are on the new EDK now. This wipes out third_party/mojo,
updates all dependencies, and removes the use-new-edk flag.
BUG=None
Review URL: https://codereview.chromium.org/1676913002
Cr-Commit-Position: refs/heads/master@{#374631}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is the minimal move change. It does not update namespaces or includes. Forwarding headers and targets exist to map to the new location. The namespaces, include guards, and references to these files will be updated in follow-ups.
The GYP build has been updated to point to the new location because the forwarding headers generated a .gyp file cycle. Avoiding a cycle with libaddressinput is why prefs is a separate .gyp from most of the rest of the components. The GN build uses forwarding targets to keep the change smaller.
The json pref store unit tests had to be updated because of the way that they used histograms conflicted with the hsitogram setup of the components unittests. Fortunately, there's a HistogramTester helper for this case, so this patch uses it in for the moved test in place of manually checking histogram counts.
json_pref_store_unittests.cc also depended on the files il base/test/data/prefs. Rather than worry about updating all the isolates and such, this just adds the data inline and avoids having separate test files.
Reland of http://crrev.com/1648403002 with iOS fix
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1653693002
Cr-Commit-Position: refs/heads/master@{#372536}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1648403002/ )
Reason for revert:
Reverting due to failure on iOS builder:
https://build.chromium.org/p/chromium.mac/builders/iOS_Device_%28ninja%29/builds/38425/steps/steps/logs/stdio
Original issue's description:
> Move base/prefs to components/prefs
>
> This change is the minimal move change. It does not update namespaces or includes. Forwarding headers and targets exist to map to the new location. The namespaces, include guards, and references to these files will be updated in follow-ups.
>
> The GYP build has been updated to point to the new location because the forwarding headers generated a .gyp file cycle. Avoiding a cycle with libaddressinput is why prefs is a separate .gyp from most of the rest of the components. The GN build uses forwarding targets to keep the change smaller.
>
> The json pref store unit tests had to be updated because of the way that they used histograms conflicted with the hsitogram setup of the components unittests. Fortunately, there's a HistogramTester helper for this case, so this patch uses it in for the moved test in place of manually checking histogram counts.
>
> json_pref_store_unittests.cc also depended on the files il base/test/data/prefs. Rather than worry about updating all the isolates and such, this just adds the data inline and avoids having separate test files.
>
> BUG=
>
> Committed: https://crrev.com/deb824cd36c02a93854537d70e1853cb9f1c55b9
> Cr-Commit-Position: refs/heads/master@{#372494}
TBR=jam@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1645073005
Cr-Commit-Position: refs/heads/master@{#372499}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is the minimal move change. It does not update namespaces or includes. Forwarding headers and targets exist to map to the new location. The namespaces, include guards, and references to these files will be updated in follow-ups.
The GYP build has been updated to point to the new location because the forwarding headers generated a .gyp file cycle. Avoiding a cycle with libaddressinput is why prefs is a separate .gyp from most of the rest of the components. The GN build uses forwarding targets to keep the change smaller.
The json pref store unit tests had to be updated because of the way that they used histograms conflicted with the hsitogram setup of the components unittests. Fortunately, there's a HistogramTester helper for this case, so this patch uses it in for the moved test in place of manually checking histogram counts.
json_pref_store_unittests.cc also depended on the files il base/test/data/prefs. Rather than worry about updating all the isolates and such, this just adds the data inline and avoids having separate test files.
BUG=
Review URL: https://codereview.chromium.org/1648403002
Cr-Commit-Position: refs/heads/master@{#372494}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch introduces a WiFi Display session class
skeleton and mojo service which provides network
access for the render-hosted session.
The introduced code is compiled only if a newly added
'enable_wifi_display' build option is set.
Besides, some minor changes were applied to the
DisplaySourceConnectionDelegate interface in order
to better define its methods behavior.
BUG=242107
Review URL: https://codereview.chromium.org/1540563002
Cr-Commit-Position: refs/heads/master@{#369415}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is another piece of work towards implementing differential
extensions update and share autoupdate code with the chrome components
system. It adds code to the extensions/browser directory that makes use
of the common autoupdate code via the update_client::UpdateClient class
to send update checks to the server, download a full .crx or
differential update, and hand back an unpacked directory with the
contents of the new extension version.
This CL does not yet add any code in chrome/ that actually uses these
new capabilities; that will be in a forthcoming CL.
BUG=490418
Review URL: https://codereview.chromium.org/1362043005
Cr-Commit-Position: refs/heads/master@{#354370}
|
|
|
|
|
|
|
|
|
|
|
| |
All platforms with extensions may assume OpenSSL. This removes the
three-argument form of VerificationResult as it's no longer used.
BUG=519504
Review URL: https://codereview.chromium.org/1365733004
Cr-Commit-Position: refs/heads/master@{#352054}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
API. Implementation on the renderer side
Please, see
Original CL: https://codereview.chromium.org/1208993011/
Reverted: https://codereview.chromium.org/1244343002/
Temp CL we used to figure out deps: https://codereview.chromium.org/1268813004/
Initial patch for detectLanguage API implementation
BUG=517628
Review URL: https://codereview.chromium.org/1273903002
Cr-Commit-Position: refs/heads/master@{#345134}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes a block to (re)landing https://codereview.chromium.org/1289483002
BUG=skia:4190
TBR=gene@chromium.org
Review URL: https://codereview.chromium.org/1274953007
Cr-Commit-Position: refs/heads/master@{#342956}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adopt and customize a ICU message format wrapper used at Google to meet
Chromium's need.
This will enable formatting of 'complex messages' requiring plural and/or
selector (e.g. gender or 'single vs multiple') support with more than one
parameters.
Besides, l10n_util::GetPluralStringF* is rewritten to use this API.
I'm also planning to use this API to add a similar support to Chromium's
JavaScript-based UI and extensions.
References:
MessageFormat specs:
http://icu-project.org/apiref/icu4j/com/ibm/icu/text/MessageFormat.html
http://icu-project.org/apiref/icu4c/classicu_1_1DecimalFormat.html#details
Examples:
http://userguide.icu-project.org/formatparse/messages
message_formatter_unittest.cc
go/plurals inside Google.
BUG=481734
TEST=base_unittests --gtest_filter="MessageFormat*"
Review URL: https://codereview.chromium.org/1140153005
Cr-Commit-Position: refs/heads/master@{#342327}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This bug was found by Control Flow Integrity check, see
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity
There's a number of tests which initialize prefs registry with PrefRegistrySimple,
which then could be incorrectly casted to its subclass PrefRegistrySyncable. The solution is to initialize prefs registry with PrefRegistrySyncable.
See more details in http://crbug.com/513816
BUG=chromium:513816,chromium:457523
Review URL: https://codereview.chromium.org/1252873008
Cr-Commit-Position: refs/heads/master@{#340740}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tree is closed because of this.
http://build.chromium.org/p/chromium/builders/Win/builds/32969/
In file included from ../../extensions/utility/unpacker.cc:20:
In file included from ../../content/public/common/common_param_traits.h:21:
In file included from ../../content/public/common/common_param_traits_macros.h:25:
../../ui/accessibility/ax_node_data.h:14:10: fatal error: 'ui/accessibility/ax_enums.h' file not found
content_common.gypi has export_dependent_settings for ax_gen, but
extensions/utility's dependency on content_common was missing.
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1192783002
Cr-Commit-Position: refs/heads/master@{#335222}
|
|
|
|
|
|
|
|
| |
BUG=444869
Review URL: https://codereview.chromium.org/1129173007
Cr-Commit-Position: refs/heads/master@{#331796}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In addition to moving the browser-side of the GuestView layer into components, this CL also:
1. Replaces some loops to the top level web contents with GuestViewBase::GetTopLevelWebContents.
2. Installs the ExtensionsGuestViewMessageFilter in appshell.
3. Move some files out of extensions/common/guest_view to components/guest_view/common
BUG=444869
Review URL: https://codereview.chromium.org/1102173002
Cr-Commit-Position: refs/heads/master@{#328243}
|
|
|
|
|
|
|
|
|
|
|
| |
since browsing_data/ is now under components/
BUG=471287
Test=None, internal only change without visible side effects.
Review URL: https://codereview.chromium.org/1056793002
Cr-Commit-Position: refs/heads/master@{#326985}
|
|
|
|
|
|
|
|
|
| |
R=asvitkine@chromium.org
BUG=477445
Review URL: https://codereview.chromium.org/1064573004
Cr-Commit-Position: refs/heads/master@{#325880}
|
|
|
|
|
|
|
|
|
|
|
| |
This makes chrome usage of blink images refer to the new IDR2_*s in the
blink_image_resource paks, and removes references to blink_resource_100_percent.pak.
BUG=471609, 467176
Review URL: https://codereview.chromium.org/1055593002
Cr-Commit-Position: refs/heads/master@{#323765}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the image resources that blink depends on are in the blink
repository, we depend on the blink resources directly, delete the ones
in the chrome tree, and use these resources in the html_viewer.
[This reland also contains a fix to the generate_blink_resource_map.py
file so that its generated code uses unsigned chars, which should
hopefully fix the Win8 gn bot.]
BUG=467176
First Review URL: https://codereview.chromium.org/1033733004
Review URL: https://codereview.chromium.org/1038723002
Cr-Commit-Position: refs/heads/master@{#322427}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
blink."
This reverts committ: https://crrev.com/ebbf3c1bf5f41b0133657515302e3b110abedee1
Broke on the Win8 gn bot which doesn't appear to be in the CQ and treats
signedness of characters differently than all other configurations.
BUG=467176
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1012773009
Cr-Commit-Position: refs/heads/master@{#322210}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the image resources that blink depends on are in the blink
repository, we depend on the blink resources directly, delete the ones
in the chrome tree, and use these resources in the html_viewer.
BUG=467176
Review URL: https://codereview.chromium.org/1033733004
Cr-Commit-Position: refs/heads/master@{#322201}
|
|
|
|
|
|
|
|
|
|
| |
OnLevelChanged event: This is fired when the level of an active audio device changes(volume for output, gain for inout), node id and new value of level are passed as arguments of the event.
BUG=429312
Review URL: https://codereview.chromium.org/945103002
Cr-Commit-Position: refs/heads/master@{#321679}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ICU 54.1 upgrade added a call to uloc_getDefault() to
base/test/test_suite.cc, but did not add a libicuuc dependency
to the corresponding gyp/gn targets. This makes it possible to
mix system and bundled ICU headers (and will fail to build if
they differ in version).
BUG=428145
Review URL: https://codereview.chromium.org/943233002
Cr-Commit-Position: refs/heads/master@{#317616}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is device code in Chrome on non-Chrome OS platforms that would
benefit from a user-visible log dashboard like chrome://device-log. This
change moves the code for managing the device log into a component and
enables chrome://device-log on all versions of Chrome.
BUG=452609
Review URL: https://codereview.chromium.org/919183002
Cr-Commit-Position: refs/heads/master@{#317406}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This eliminates source list duplication between GYP
and GN builds by merging all source lists into
unified gypis.
BUG=457404
Review URL: https://codereview.chromium.org/908333004
Cr-Commit-Position: refs/heads/master@{#315871}
|
|
|
|
|
|
|
|
| |
Uses the ChromeExtensionViewGuestDelegate to create a ChromeExtensionWebContentsObserver to handle communication between ExtensionViewGuest and the browser.
Review URL: https://codereview.chromium.org/908983003
Cr-Commit-Position: refs/heads/master@{#315807}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This filename conflicts with extensions/common test_util, which
can be a problem for some linkers linking extensions test_support.
BUG=457368
R=jamescook@chromium.org,kmarshall@chromium.org
Review URL: https://codereview.chromium.org/911213002
Cr-Commit-Position: refs/heads/master@{#315678}
|
|
|
|
|
|
|
|
|
|
| |
The UI thread part is shut down together with the keyed services it depends on, via a new KeyedServiceShutdownNotifier class.
BUG=395391
Review URL: https://codereview.chromium.org/901573003
Cr-Commit-Position: refs/heads/master@{#315631}
|
|
|
|
|
|
|
|
|
|
| |
Move the chrome.documentScan extension API from chrome/ to extensions/.
BUG=455695
Review URL: https://codereview.chromium.org/899523004
Cr-Commit-Position: refs/heads/master@{#315293}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let extensions with active tab use XHR in background pages to any hosts that
they have active tab on.
Also move tab_finder to //extensions.
BUG=452688
Review URL: https://codereview.chromium.org/890083002
Cr-Commit-Position: refs/heads/master@{#315147}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix dependency issues in //extensions
* Make protobuf library add the "src" directory to the compiler's include
directory list, otherwise it tries to use /usr/include/google/protobuf
which has incompatible headers.
BUG=455919
TEST=compiles and links in both component and non-component builds
Review URL: https://codereview.chromium.org/889253004
Cr-Commit-Position: refs/heads/master@{#315067}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
injection System" [browser side] (patchset #2 id:270001 of https://codereview.chromium.org/899983002/)
Reason for revert:
It turns out that the crash wasn't caused by this CL.
Original issue's description:
> Revert of Introduce HostID and de-couple Extensions from "script injection System" [browser side] (patchset #20 id:760001 of https://codereview.chromium.org/822453002/)
>
> Reason for revert:
> It might cause the crash https://code.google.com/p/chromium/issues/detail?id=454917.
>
> Original issue's description:
> > Introduce HostID and de-couple Extensions from "script injection System" [browser side]
> >
> > The major refactor includes:
> > - Introduce HostID (a pair of |id, type|) to replace extension_id in browser
> > side.
> > - Abstract UserScriptLoader to be a base class, and introduces
> > a derived class ExtensionUserScriptLoader which is
> > responsible for loading user scripts for extensions.
> > - In DeclarativeUserScriptManager, a master is created per
> > extension/webUI.
> > - DeclarativeUserScriptManager becomes an
> > ExtensionRegistryObserver and is responsible for clearing scripts
> > for master objects when receive OnExensionUnloaded event.
> >
> > BUG=437566
> >
> > Committed: https://crrev.com/b88fe3dc1072501bdd105fd95a8b3bc453fd2aa7
> > Cr-Commit-Position: refs/heads/master@{#313402}
>
> TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=437566
>
> Committed: https://crrev.com/5eb894ea21637241e9a78fb9c2737d40d6dbf575
> Cr-Commit-Position: refs/heads/master@{#314631}
TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437566
Review URL: https://codereview.chromium.org/903743002
Cr-Commit-Position: refs/heads/master@{#314807}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
System" [browser side] (patchset #20 id:760001 of https://codereview.chromium.org/822453002/)
Reason for revert:
It might cause the crash https://code.google.com/p/chromium/issues/detail?id=454917.
Original issue's description:
> Introduce HostID and de-couple Extensions from "script injection System" [browser side]
>
> The major refactor includes:
> - Introduce HostID (a pair of |id, type|) to replace extension_id in browser
> side.
> - Abstract UserScriptLoader to be a base class, and introduces
> a derived class ExtensionUserScriptLoader which is
> responsible for loading user scripts for extensions.
> - In DeclarativeUserScriptManager, a master is created per
> extension/webUI.
> - DeclarativeUserScriptManager becomes an
> ExtensionRegistryObserver and is responsible for clearing scripts
> for master objects when receive OnExensionUnloaded event.
>
> BUG=437566
>
> Committed: https://crrev.com/b88fe3dc1072501bdd105fd95a8b3bc453fd2aa7
> Cr-Commit-Position: refs/heads/master@{#313402}
TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437566
Review URL: https://codereview.chromium.org/899983002
Cr-Commit-Position: refs/heads/master@{#314631}
|
|
|
|
|
|
|
|
| |
BUG=338837
Review URL: https://codereview.chromium.org/829583002
Cr-Commit-Position: refs/heads/master@{#314547}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since there are no plans to use this API at least for 1H 2015, there is no
point leaving this code in Chrome. Removing this API to reduce code bloat.
We can revisit adding this API again when this work gets prioritized.
R=isherman@chromium.org, kalman@chromium.org, xiyuan@chromium.org
BUG=452562
This flag is specified since we're deleting an enum from histgrams. This currently breaks the presubmit.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/895783002
Cr-Commit-Position: refs/heads/master@{#314412}
|
|
|
|
|
|
|
|
|
|
|
| |
Move the chrome.diagnostics extension API from chrome/ to
extensions/.
BUG=395240
Review URL: https://codereview.chromium.org/883703004
Cr-Commit-Position: refs/heads/master@{#314338}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implementation of the NetworkingConfigService and boiler plate code for the
networking.config API.
Reviewers:
Please see
1) https://docs.google.com/document/d/1V8YGouKC477iC11L4PL8H_HU1Ru3R5kMhXppuoIVNeo for the design document.
2) https://docs.google.com/drawings/d/12Hai1LdaPzwtkrQUdCjSpt1s7InRNNBDeWiW5ujfIRg for a flow diagram.
Review URL: https://codereview.chromium.org/880073002
Cr-Commit-Position: refs/heads/master@{#314303}
|
|
|
|
|
|
|
|
| |
BUG=444869
Review URL: https://codereview.chromium.org/892923002
Cr-Commit-Position: refs/heads/master@{#314233}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Phase 2 of lucid sleep involves allowing GCM-enabled apps and extensions
to wake up the system to process push messages. This brings up the
problem of knowing when those apps/extensions are done processing the
event so that the system can go back to sleep.
This CL introduces a new class whose responsibility is to monitor
GCM-enabled apps and extensions and delay the system suspend while they
are processing push messages. Additionally, network requests that are
started while the app/extension is processing a push message are
considered related to that message and can further delay the system
suspend even after the push message itself has been acked by the
extension.
BUG=397328
Review URL: https://codereview.chromium.org/823703004
Cr-Commit-Position: refs/heads/master@{#314219}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL allows app_shell to use chrome.alarms.
Also it includes the following changes related to unit tests:
- Moved chrome.alarms tests to extensions/
- Moved a helper function CreateEmptyExtensionWithLocation()
from extension_function_test_utils.h to api_test_utils.h.
- Moved CreateBackgroundPage() from extension_api_unittest.h to
api_unittest.h.
- Creates WebContents for the extension that can be used to associate
a RenderViewHost in extension unit tests.
BUG=443622
Review URL: https://codereview.chromium.org/789643004
Cr-Commit-Position: refs/heads/master@{#314040}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This...
- Wires up ExtensionView. Can apply src for navigation via inline and js call.
- Adds permission for manifests.
- Add browser tests for navigation and adding ExtensionViews to DOM.
Some code is duplicated from existing GuestViews (e.g. *ViewAttribute and some GuestViewBase implementations). Based on how GuestView code will be refactored, some of this can be consolidated.
This...
- Does not run in a detached state. (Refers to CR 845363004)
- Will have more functionality and restrictions implemented in the future.
Review URL: https://codereview.chromium.org/873933002
Cr-Commit-Position: refs/heads/master@{#313781}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The major re-factoring for this has been done, this is mostly just
moving the files, with a small addition to ExtensionsBrowserClient.
For extensions/browser/api/networking_private/DEPS:
TBR=jamescook@chromium.org
BUG=363776
Review URL: https://codereview.chromium.org/870163002
Cr-Commit-Position: refs/heads/master@{#313537}
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/880123002
Cr-Commit-Position: refs/heads/master@{#313454}
|
|
|
|
|
|
|
|
|
|
|
| |
This is a mostly mechanical change to move these files over, and
make corresponding changes to strings, build files, and include paths.
BUG=447014
Review URL: https://codereview.chromium.org/864093002
Cr-Commit-Position: refs/heads/master@{#313404}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[browser side]
The major refactor includes:
- Introduce HostID (a pair of |id, type|) to replace extension_id in browser
side.
- Abstract UserScriptLoader to be a base class, and introduces
a derived class ExtensionUserScriptLoader which is
responsible for loading user scripts for extensions.
- In DeclarativeUserScriptManager, a master is created per
extension/webUI.
- DeclarativeUserScriptManager becomes an
ExtensionRegistryObserver and is responsible for clearing scripts
for master objects when receive OnExensionUnloaded event.
BUG=437566
Review URL: https://codereview.chromium.org/822453002
Cr-Commit-Position: refs/heads/master@{#313402}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has been causing occasional build breakage on the bots,
depending on whether we got unlucky in build ordering. Because
extensions_common and extensions_browser both cause
extensions_strings to run, I didn't notice this error before.
BUG=451442
Review URL: https://codereview.chromium.org/869743004
Cr-Commit-Position: refs/heads/master@{#312957}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the mimeHandler extension API, which is a simplified version
of the streamsPrivateApi. Unlike the streamsPrivateApi, mimeHandler only
allows access to streams from RenderFrames within MimeHandlerViewGuests,
and in particular only allows access to the stream being handled by that
MimeHandlerViewGuest instance. This removes the need for an event to be
dispatched to the background page and a user-exposed view_id.
BUG=439867
Review URL: https://codereview.chromium.org/797183005
Cr-Commit-Position: refs/heads/master@{#312728}
|