| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ScriptContexts. (patchset #2 id:20001 of https://codereview.chromium.org/853283002/)
Reason for revert:
No longer needed.
Original issue's description:
> Debugging patch to help track down skipped cleanup of ScriptContexts.
>
> The current theory is that cleanup for some ScriptContexts is getting
> skipped, due to willReleaseScriptContext() notifications not being sent.
> Alias a few things into the debug crash dump to try to narrow down what
> could be causing this.
>
> BUG=441968
>
> Committed: https://crrev.com/5b90a749fb1904c55d0707deae43928d48320f75
> Cr-Commit-Position: refs/heads/master@{#311996}
TBR=kalman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=441968
Review URL: https://codereview.chromium.org/830453006
Cr-Commit-Position: refs/heads/master@{#312227}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current theory is that cleanup for some ScriptContexts is getting
skipped, due to willReleaseScriptContext() notifications not being sent.
Alias a few things into the debug crash dump to try to narrow down what
could be causing this.
BUG=441968
Review URL: https://codereview.chromium.org/853283002
Cr-Commit-Position: refs/heads/master@{#311996}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ScriptContexts. (patchset #3 id:40001 of https://codereview.chromium.org/853793002/)
Reason for revert:
Causing dom_perf to crash in perf bots.
BUG=449415
Original issue's description:
> Debugging patch to help track down skipped cleanup of ScriptContexts.
>
> The current theory is that cleanup for some ScriptContexts is getting
> skipped, due to willReleaseScriptContext() notifications not being sent.
> Alias a few things into the debug crash dump to try to narrow down what
> could be causing this.
>
> BUG=441968
>
> Committed: https://crrev.com/b97e8b25a46aeeecd26cba5ebba9a8b5ecf4a4e7
> Cr-Commit-Position: refs/heads/master@{#311802}
TBR=kalman@chromium.org,dcheng@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=441968
Review URL: https://codereview.chromium.org/858493002
Cr-Commit-Position: refs/heads/master@{#311844}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current theory is that cleanup for some ScriptContexts is getting
skipped, due to willReleaseScriptContext() notifications not being sent.
Alias a few things into the debug crash dump to try to narrow down what
could be causing this.
BUG=441968
Review URL: https://codereview.chromium.org/853793002
Cr-Commit-Position: refs/heads/master@{#311802}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The gin::Runner should be destroyed when the JS context is so that its
weak pointers are invalidated and any outstanding callbacks that
interact with the JS context can detect its destruction. Currently,
ScriptContext implements gin::Runner but is not immediately destroyed
when the JS context is. This CL moves this gin::Runner implementation
into a separate class which is destroyed when the ScriptContext is
invalidated.
Review URL: https://codereview.chromium.org/831423005
Cr-Commit-Position: refs/heads/master@{#311358}
|
|
|
|
|
|
|
|
|
|
| |
R=jochen@chromium.org
TBR=kalman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/753523002
Cr-Commit-Position: refs/heads/master@{#305209}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.
BUG=417463
TBR=yoz@chromium.org
Review URL: https://codereview.chromium.org/664933004
Cr-Commit-Position: refs/heads/master@{#300475}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/622343002
Cr-Commit-Position: refs/heads/master@{#298042}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change:
- Adds running the GC until the v8 heap size reaches steady state during
ModuleSystemTest::TearDown. This is necessary to ensure that
gin::Wrappable objects are freed, as finalizers for JS objects aren't
run during isolate shut down.
- Removes a racy check that failed under valgrind.
BUG=389016,406487
Review URL: https://codereview.chromium.org/502893002
Cr-Commit-Position: refs/heads/master@{#294779}
|
|
|
|
|
|
|
|
| |
extensions/
Review URL: https://codereview.chromium.org/558833002
Cr-Commit-Position: refs/heads/master@{#294136}
|
|
|
|
|
|
|
|
|
|
| |
Added an extra "effective extension" property to ScriptContext for this to still work correctly in about:blank iframes inside extension pages.
BUG=395376
Review URL: https://codereview.chromium.org/498513002
Cr-Commit-Position: refs/heads/master@{#293818}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds the infrastructure for unit testing the JS parts of
apps and extensions APIs implemented on top of Mojo services. The test
environment provides a partial implementation of the JS test API
provided to browser tests. A TestServiceProvider implementation is
used to provide test implementations of the appropriate Mojo services to
the JS code.
BUG=389016
Review URL: https://codereview.chromium.org/399363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This isn't necessary because the test environment set up includes Blink
creating an isolate holder.
Review URL: https://codereview.chromium.org/402553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Review URL: https://codereview.chromium.org/375243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283580 0039d316-1c4b-4281-b951-d872f2087c98
|