| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This lets it run a little further when attempting to run an app.
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/106033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the Chrome-specific LaunchContainer enum out of
extensions/common/constants.h and into
chrome/common/extensions/extension_constants.h (it can't
live under chrome/browser/extensions since it's used by
AppLaunchInfo). For consistency, also move the LaunchType
enum to extension_constants.h.
Rename LaunchContainer's values from LAUNCH_* to
LAUNCH_CONTAINER_*, and also rename the LAUNCH_TYPE_* values
in AppContextMenu to USE_LAUNCH_TYPE_* to avoid confusion
with the LaunchType enum.
BUG=180083
TBR=sky@chromium.org,jar@chromium.org
Review URL: https://codereview.chromium.org/106713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reinstate the "alwaysOnTopWindows" permission. This feature is
available only in the Dev channel, but is whitelisted for two first-party
apps in Stable.
Apps that wish to enable the alwaysOnTop property for app windows must
now declare the "alwaysOnTopWindows" permission in their manifest.
This permission does not generate a warning in install prompts.
BUG=326361
TESTS=browser_tests (PlatformAppBrowserTest.WindowsApiAlwaysOnTop*)
Manual test: Create an app which does not specify this permission and
attempts to create a new window with the option enabled or calls
setAlwaysOnTop(true) on an existing window. The window should not be
always on top. The option should work for apps which do declare the
permission.
Review URL: https://codereview.chromium.org/61073004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the LaunchType enum and associated LaunchType and
LaunchContainer helper methods out of the ExtensionPrefs
class and into a new launch_util.h file. This pulls more
Chrome-specific code out of ExtensionPrefs so it can
someday be moved to the toplevel extensions/ directory.
BUG=180083,313284
TBR=benwells@chromium.org,xiyuan@chromium.org
Review URL: https://codereview.chromium.org/105733003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/100573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/99923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is no functional change in this patch. This change only does
renaming.
Extensions API namespaces:
webrtc.castSendTransport -> cast.streaming.rtpStream
webrtc.castUdpTransport -> cast.streaming.udpTransport
Class renaming:
WebRtcNativeHandler -> CastStreamingNativeHandler
CastSendTransport -> CastRtpStream
Tests and related files are also renamed to get rid of the webrtc
label.
BUG=301920
Review URL: https://codereview.chromium.org/90083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Impulses are an efficient way to handle certain types
of activity from extensions. E.g. the work in progress
to keep NaCl plugins in background pages alive. An
Increment / Decrement approach would require extensive
and fragile instrumentation of all APIs. Impulses
can be sent upon any api activity and act as an
implicit increment with a timed out decrement.
See design doc:
https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit#
BUG=298339
Review URL: https://codereview.chromium.org/60613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are separate chrome.webrtc.castSendTransport.create and
chrome.webrtc.castUdpTransport.create methods. However these objects
are never used alone. They require a session to operate and having them
separate is confusing.
Instead unify the session creation in one factory method:
chrome.cast.streaming.session.create(
WebMediaStreamTrack audioTrack,
WebMediaStreamTrack videoTrack,
CreateCallback);
The above method will construct a session and create objects for
the RTP streams and the UDP transport. These streams can then be
configured by existing APIs.
Another change is the new cast.streaming namespace. Eventually
everything in chrome.webrtc will be moved there so we have a mix for
now. But we'll unify all the namespaces to cast.streaming in a couple
patches.
To summarize:
The following two APIs are removed:
1. chrome.webrtc.castSendTransport.create
2. chorme.webrtc.castUdpTransport.create
The following API is new:
1. chrome.cast.streaming.session.create
BUG=301920
Review URL: https://codereview.chromium.org/83043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the code that checks whether the command-line flag or
pref to disable extensions is set into
ExtensionsBrowserClient, and make ExtensionPrefFactory work
with a BrowserContext instead of requiring a Profile.
BUG=313284
Review URL: https://codereview.chromium.org/89253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves EmptyString*, kWhitespace*, and the UTF 8 Byte Order Marker to the base:: namespace.
Many of them just got changed to a default-constructed string when a reference was not required.
I qualified some string16s with base:: when I was changing adjacent code. I need to do another pass to finish these up.
BUG=
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/89243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None, no functional changes.
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/97683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=321746
TEST=manually
TBR=dgozman,jochen
Review URL: https://codereview.chromium.org/95243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=derat
BUG=298537
Review URL: https://codereview.chromium.org/93473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change also removed a few includes from extension_service.cc that
were not in use.
Dependencies moved in this CL:
pending_extension_info
pending_extension_manager
TBR=sky
BUG=298537
Review URL: https://codereview.chromium.org/93703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is done by introducing a function on the generic extensions browser
client to determine if the system is running in forced app mode.
BUG=298537
Review URL: https://codereview.chromium.org/93783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few things might need to be discussed like the ability for an app to prevent
the default behaviour and letting the user know about the ability to leave the
fullscreen mode using ESC.
BUG=320487
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237393
Review URL: https://codereview.chromium.org/62763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=rvargas@chromium.org
Review URL: https://codereview.chromium.org/89523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move ManifestHandlers for:
- CSP
- Kiosk Mode
- Offline Enabled
- Requirements
- Sandboxed Page
to top-level extensions/common/manifest_handlers.
Rename all handlers to be foo_info.h/cc, if necessary.
TBR=davemoore@chromium.org (c/b/chromeos/app_mode/startup_app_launcher.cc)
TBR=finnur@chromium.org (c/b/ui/webui/extensions/extension_basic_info.cc)
BUG=159265
Review URL: https://codereview.chromium.org/83843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: This CL broke interactive tests on mac: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%20%281%29&number=46945
TBR=koz@chromium.org,mlamouri@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/89183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few things might need to be discussed like the ability for an app to prevent
the default behaviour and letting the user know about the ability to leave the
fullscreen mode using ESC.
BUG=320487
Review URL: https://codereview.chromium.org/62763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files do not have any dependencies to the rest of chrome so can
move down immediately.
TBR=miket, sky
BUG=298537
Review URL: https://codereview.chromium.org/82773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=321393
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/68173031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
app_shell needs to support background pages in order to load apps, but doesn't
have the usual UI surfaces for Chrome extensions (popups, infobars, etc.).
* Extract functionality touching platform-specific views to ExtensionViewHost
* Remove references to panels, which don't use ExtensionHost
Reupload of LGTM'd change https://codereview.chromium.org/82163002 because
AppEngine is misbehaving.
BUG=321341
TEST=browser_tests, interactive_ui_tests
TBR=yoz@chromium.org
Review URL: https://codereview.chromium.org/86363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added an IS_EPHEMERAL flag for extensions to identify ephemeral apps.
Ephemeral apps are integrated into the extension system, but we use
the flag to hide them from UI such as the app launcher, NTP and
extension management page.
Garbage collection of unused ephemeral apps will be implemented in a
future patch.
This feature is hidden behind the "enable-ephemeral-apps" switch.
BUG=312460
Review URL: https://codereview.chromium.org/75323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of having ExtensionPrefs construct a
ChromeAppSorting object directly, make ExtensionPrefsFactory
pass an AppSorting object to it.
BUG=313284
Review URL: https://codereview.chromium.org/83023010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Contains gcm.json and updates to relevant files defining the APIs, stub implementation for the functions, updates to GYP file.
BUG=316683
Review URL: https://codereview.chromium.org/26669003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that its dependencies on Profile, ActivityLog, RuntimeAPI and
WebRequestAPI have been removed it can move into the extensions module.
This is part of the AppShell extensions refactoring project.
BUG=316367
TEST=compiles
R=yoz@chromium.org
TBR=mukai@chromium.org for mechanical file move in c/b/notifications, dmazzoni@chromium.org for mechanical file move in accessibility code
Review URL: https://codereview.chromium.org/78483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create an AppSorting interface in extensions/browser/ and
make ChromeAppSorting (formerly ExtensionSorting) implement
it.
BUG=313284
Review URL: https://codereview.chromium.org/74613003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a dependency of EventRouter, which is almost ready to move.
Also convert the unit test to use BrowserContext instead of Profile.
BUG=316367
TEST=unit_tests
Review URL: https://codereview.chromium.org/59823011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the last missing function from socket.idl.
BUG=165273
BUG=173241
Review URL: https://codereview.chromium.org/59713008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
URLs under 'chrome_settings_overrides.search_provider'.
BUG=
Review URL: https://codereview.chromium.org/71303009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of the AppShell extensions refactor project.
BUG=316367
TEST=unit_tests, browser_tests
TBR=dmazzoni@chromium.org for trivial fix to tts_extension_loader_chromeos.h
Review URL: https://codereview.chromium.org/69883007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This limit matches that applied by the web store to prevent surprises when uploading apps.
This change also adds manifest tests for file_handlers, which were absent.
BUG=315210
Review URL: https://codereview.chromium.org/72343003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ScreenLocker.
https://docs.google.com/document/d/1kSxngeyBPZIB7kK-QfDXgpzrDBvnVBcJfbK3HMFQIZg/edit
The live version of the whitelisted app uses the chrome.usb API to execute a challenge-response protocol with an experimental device that has received a provisional green light from Google Security Team for unlocking.
Review URL: https://codereview.chromium.org/60583003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=298586
R=cdn@chromium.org, miket@chromium.org, sky@chromium.org
TBR=cdn@chromium.org
Review URL: https://codereview.chromium.org/15239002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=293755,247857
Review URL: https://codereview.chromium.org/51433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Added permission for chrome.app.window alwaysOnTop property
>
> Apps that wish to enable the alwaysOnTop property for app windows must
> now declare the "alwaysOnTopWindows" permission in their manifest.
> This permission does not appear in install prompts.
>
> BUG=314260, 171597
> TEST=browser_tests (PlatformAppBrowserTest.WindowsApiAlwaysOnTop*).
> Manual test: Create an app which does not specify this permission and
> attempts to create a new window with the option enabled or calls
> setAlwaysOnTop(true) on an existing window. The window should not be
> always on top. The option should work for apps which do declare the
> permission.
>
> Review URL: https://codereview.chromium.org/68423003
This could not be merged into M32. We need to limit the always on top feature
more, which will not merge into M32 with this change, so this is being
reverted temporarily.
TBR=tmdiep@chromium.org
Review URL: https://codereview.chromium.org/62803005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is now its own BCKS. There was no need for it to be in
ExtensionService.
TBR=sky@chromium.org
BUG=162530
Review URL: https://codereview.chromium.org/64953004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=isherman@chromium.org
BUG=162530
Review URL: https://codereview.chromium.org/68113008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apps that wish to enable the alwaysOnTop property for app windows must
now declare the "alwaysOnTopWindows" permission in their manifest.
This permission does not appear in install prompts.
BUG=314260, 171597
TEST=browser_tests (PlatformAppBrowserTest.WindowsApiAlwaysOnTop*).
Manual test: Create an app which does not specify this permission and
attempts to create a new window with the option enabled or calls
setAlwaysOnTop(true) on an existing window. The window should not be
always on top. The option should work for apps which do declare the
permission.
Review URL: https://codereview.chromium.org/68423003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Over time, this function (which is called on the IO thread) was updated
to use DesktopNotificationService. While the methods in that service
were enforced to run on the correct thread, it's not possible to get
the notification service from the ProfileIOData safely. This removes the
dependency on DesktopNotificationService from the IO-thread notification
functions.
BUG=256638
Review URL: https://codereview.chromium.org/61323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move that to ExtensionsClient::IsScriptableURL.
BUG=298586
Review URL: https://codereview.chromium.org/58853013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of the AppShell extensions refactor project.
BUG=316367
TEST=browser_tests, unit_tests
TBR=dmazzoni@chromium.org for file renames in chrome/browser/speech
Review URL: https://codereview.chromium.org/66583003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL exposes the declarative WebRequest API to <webview>s.
This CL isolates rules registries on a per-<profile, embedder_process_id, webview_instance_id> tuple. For extensions, the pair <embedder_process_id, webview_instance_id> == <0, 0>.
Rules registries are now created on-demand rather than on creation of the RulesRegistryService. This is so that we only create rules registries for webviews if the webview adds rules. This also allows rules to be installed prior to initial navigation of a webview.
Sample code:
var webview = document.querySelector('webview');
var rule = {
conditions: [
new chrome.webViewRequest.RequestMatcher({ url: { hostSuffix: 'slashdot.org' } })
],
actions: [
new chrome.webViewRequest.CancelRequest()
]
};
webview.request.onRequest.addRules([rule])
BUG=273855
Review URL: https://codereview.chromium.org/28273006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=162530
Review URL: https://codereview.chromium.org/64273006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
input method engine. This cl doesn't include the code to use 'input_view' url. Later cl's will use it to create input view window.
BUG=chromium:316524
TEST=Locally verified and no breakage.
Review URL: https://codereview.chromium.org/66253003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/62713003/ - the original patch broke the Google Chrome OS official builder due to a missing dependency on the extensions api target in extensions/extensions.gyp.
* Move c/b/extensions/extension_process_manager.h to
extensions/browser/process_manager.h
* Rename ExtensionsProcessManager to ProcessManager
* Place it in the "extensions" namespace
BUG=313481
TEST=browser_tests, unit_tests
TBR=miket@chromium.org
Review URL: https://codereview.chromium.org/67253003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the move these classes became extensions::InfoMap and
extensions::QuotaService.
TBR=sky
BUG=162530
Review URL: https://codereview.chromium.org/63933003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With disable_nacl=1 defined a clean build would fail because
grit/generated_resources.h was not generated. The file including
this was extensions/browser/admin_policy.cc.
This change makes extensions.gyp:extensions_browser depend
on chrome_resources.gyp:chrome_strings. The compile bug can be
reproduced by doing:
export GYP_DEFINES="$GYP_DEFINES disable_nacl=1"
./build/gyp_chromium
ninja -C out/Debug chromium
TEST=Successful compile
BUG=
Review URL: https://codereview.chromium.org/67173003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234099 0039d316-1c4b-4281-b951-d872f2087c98
|