| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to simplify code that needs to run after something has happened, and
start using it for the ExtensionService's READY notification.
This change doesn't, in itself replace any uses of NOTIFICATION_EXTENSIONS_READY, but it paves the way for doing so.
BUG=240968
R=atwilson@chromium.org, kalman@chromium.org, mpcomplete@chromium.org
Review URL: https://codereview.chromium.org/14757022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since last time: Fixes leaks in TestExtensionSystem.
BUG=178218
TBR=asargent@chromium.org,thestig@chromium.org,rlp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15111003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Multiple leaks on both heapcheck bots.
> Make ExtensionPrefs a ProfileKeyedService.
>
> BUG=178218
> TBR=asargent@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/14999009
TBR=yoz@chromium.org
Review URL: https://codereview.chromium.org/14772045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a 2nd attempt to reland https://codereview.chromium.org/14780003/ which was reverted as https://codereview.chromium.org/15045002/, relanded as https://codereview.chromium.org/15059003 and reverted again as https://codereview.chromium.org/15027007/.
Patch set 1 here is identical with p.s. 2 in https://codereview.chromium.org/15059003.
This time it failed on Win XP debug bot's unit_tests, throwing assertions related to sorting patterns in the SubstringSetMatcher:
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\algorithm(3657) : Assertion failed: invalid operator<
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xstring(78) : Assertion failed: string iterator not dereferencable
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xstring(79) : Assertion failed: "Standard C++ Libraries Out of Range" && 0
Affected unit tests: SubstringSetMatcherTest.TestMatcher and WebRequestRulesRegistryTest.GetMatchesCheckFulfilled
History of previous descriptions:
This is an attempt to reland https://codereview.chromium.org/14780003/ which was reverted as https://codereview.chromium.org/15045002/.
Patch set 1 here is identical with p.s. 7 in https://codereview.chromium.org/14780003/. The failing buildbot was linux compile (dbg), so trying it here explicitly.
Original description:
The main one is coputing the Aho-Corasick tree size in advance.
Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations.
This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%.
BUG=236368
Review URL: https://chromiumcodereview.appspot.com/15027008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=178218
TBR=asargent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14999009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Win debug trybots fire assertions on SubstringSetMatcherTest.TestMatcher and WebRequestRulesRegistryTest.GetMatchesCheckFulfilled
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\algorithm(3657) : Assertion failed: invalid operator<
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xstring(78) : Assertion failed: string iterator not dereferencable
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xstring(79) : Assertion failed: "Standard C++ Libraries Out of Range" && 0
> Speed improvements to SubstringSetMatcher
>
> This is an attempt to reland https://codereview.chromium.org/14780003/ which was reverted as https://codereview.chromium.org/15045002/.
> Patch set 1 here is identical with p.s. 7 in https://codereview.chromium.org/14780003/. The failing buildbot was linux compile (dbg), so trying it here explicitly.
>
> Original description:
>
> The main one is coputing the Aho-Corasick tree size in advance.
>
> Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations.
>
> This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%.
>
> BUG=236368
> TBR=battre
>
> Review URL: https://codereview.chromium.org/15059003
TBR=battre@chromium.org
Review URL: https://codereview.chromium.org/15027007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an attempt to reland https://codereview.chromium.org/14780003/ which was reverted as https://codereview.chromium.org/15045002/.
Patch set 1 here is identical with p.s. 7 in https://codereview.chromium.org/14780003/. The failing buildbot was linux compile (dbg), so trying it here explicitly.
Original description:
The main one is coputing the Aho-Corasick tree size in advance.
Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations.
This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%.
BUG=236368
TBR=battre
Review URL: https://codereview.chromium.org/15059003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Speed improvements to SubstringSetMatcher
>
> The main one is coputing the Aho-Corasick tree size in advance.
>
> Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations.
>
> This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%.
>
> BUG=236368
>
> Review URL: https://chromiumcodereview.appspot.com/14780003
TBR=vabr@chromium.org
Review URL: https://codereview.chromium.org/15045002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The main one is coputing the Aho-Corasick tree size in advance.
Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations.
This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%.
BUG=236368
Review URL: https://chromiumcodereview.appspot.com/14780003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=236029
R=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14061023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like this was missed in
https://chromiumcodereview.appspot.com/13699007/.
There are two "url" filter attributes for Declarative Web Request which use regular expressions: kURLMatchesKey and kOriginAndPathMatchesKey. The former had a RE2 validity check in place, whereas the other did not. Fixing this.
BUG=228852
R=battre@chromium.org
Review URL: https://codereview.chromium.org/14031037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string_piece.h was moved into base/strings/ in r191206 -
https://chromiumcodereview.appspot.com/12982018/
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/14272007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EnsureEndsWithSeparator used to check whether the file existed. This seems bad and unnecessary so I removed it.
I removed file_util::ContainsPath and used the existing file_util::IsParent instead. The functions descriptions are the same but the implementations do slightly different things, which is worrying. The only non-test use of this function to worry about is content/browser/storage_partition_impl_map.cc. As far as I see, the requirements for this seem OK, but I'm not very familiar with this.
After some discussion with akalin, I changed sync/internal_api/sync_manager_impl.cc to be a DCHECK that the path is absolute rather than make it absolute. The old code relied on the behavior of the old function that the argument would be unchanged if the file didn't exist, and this (possibly relative) path would be used later. This behavior doesn't make a lot of sense, and it looks like now that the path is always absolute, so I replaced this call with a DCHECK.
BUG=
Review URL: https://codereview.chromium.org/13196006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
query against a RegEx
If you look for URLs that contain example[1-9].com you do not want to trigger
actions for http://foobar.com?url=example1.com. For this reason the CL
introduces a new mechanism to evaluate RegEx only on the URL without the query
string.
BUG=228852
Review URL: https://chromiumcodereview.appspot.com/13699007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=162611
Review URL: https://chromiumcodereview.appspot.com/13408004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6.
Revert "Fix build after r193020."
This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a.
Revert "Really fix build after r193020."
This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=162530
Review URL: https://codereview.chromium.org/13375017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This adds a "using" to the header to avoid having to update everything at once. However, all forward declares and the locations that use the forward declares need to be updated (since they don't see the using in message_loop.h).
BUG=
Review URL: https://codereview.chromium.org/13243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
directory for extensions.
BUG=159265
Review URL: https://codereview.chromium.org/13198003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also move ExtensionResource to extensions namespace.
Also clean up the GenerateId and ShouldLocalizeManfest interfaces.
BUG=159265
Review URL: https://chromiumcodereview.appspot.com/12578008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
explicitly requested in the manifest.
BUG=174183
Review URL: https://chromiumcodereview.appspot.com/12792005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=175186
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12473004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
but by the pattern
BUG=171814
TEST=unittest
Review URL: https://chromiumcodereview.appspot.com/12321051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/12217145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=158004
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12209094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
classes to extensions/common/
TBR=ben@chromium.org
BUG=162530
Review URL: https://chromiumcodereview.appspot.com/12208078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions/common/matcher/
Preparation for moving c/c/extensions/event_* to extensions/common/.
BUG=162530
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12092096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=162530
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12088089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to its own file.
Reverses the dependency between Extension and Manifest.
Part 1 of moving Manifest to top-level extensions.
BUG=162530
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12093036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
top-level extensions dir.
BUG=159265
TBR=ben@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/11312228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This doesn't create an extensions gyp target, or a module with a public API.
It does set of DEPS rules and seems like it will make it easier for people to
write correctly layered code today, while we are in transition.
BUG=159265
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11410015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167454 0039d316-1c4b-4281-b951-d872f2087c98
|