| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UserScriptSlave was responsible for too much, and the logic was getting
cluttered (which also made changes in, e.g.
https://codereview.chromium.org/288053002/ difficult to read, write, and
review). Refactor the logic to inject the scripts into a new class, so that
UserScriptSlave is pretty much just responsible for containing them.
BUG=373961
Review URL: https://codereview.chromium.org/284153006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Design Doc and Proposal here:
https://docs.google.com/a/google.com/document/d/1QWIzDvf_-iZJW8CINvhxzIERwwKeg72302hNUw0ZrSM/edit
This CL depends on https://codereview.chromium.org/275543005/
BUG=371966
Review URL: https://codereview.chromium.org/280023003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the mean time, I've also renamed identityPrivate.getResources to
identityPrivate.getStrings to be more consistent with the fileBrowserPrivate,
wallpaperPrivate, bookmarkManagerPrivate and feedbackPrivate.
BUG=372318
NOTRY=true
Review URL: https://codereview.chromium.org/272173004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
their child processes.
R=avi@chromium.org
Review URL: https://codereview.chromium.org/292443004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a split of https://codereview.chromium.org/287673004/, to avoid
merging issues.
It is almost impossible to land a CL adding histograms via CQ, without
a merging conflict.
TBR=isherman@chromium.org
TEST=Just histograms, no actual changes.
BUG=248427
Review URL: https://codereview.chromium.org/289063006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-The real guts of content_hash_fetcher.cc, which fetches the
verified_contents.json file from the webstore if needed and also runs
tasks to compute and cache the block-level hashes of all files in an
extension.
-The real guts of content_hash_reader.cc, which uses the work done by
the content_hash_fetcher during validation of extension file content as
it's read off of disk at time of use.
-Code to avoid verifying transcoded files (images used in browser
process, and message catalogs).
-Don't allow downgrade of mode via kForceFieldTrials command line switch
-Various bits of plumbing to support all of the above
This is a re-land with fixes; original review was:
https://codereview.chromium.org/289533003
BUG=369895,373854
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/288273004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
his is a simplified version of api_test/stubs. It touches all the parts
of each chrome.foo.bar.baz API path and ensures they are defined. This
catches cases where a developer adding an API to _api_features.json but
did not provide a schema for them.
(Original CL https://codereview.chromium.org/264923009/. It was reverted
because it leaked an "about" file in the source checkout. The underlying
issues in platform app launch and chrome startup have been fixed.)
TBUG=369318
TEST=added browser_tests ExtensionApiTest.StubsApp
Review URL: https://codereview.chromium.org/283363004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To enable this support, the following things are changed:
* ExtensionSyncData, and the ExtensionSpecifics protobuf have a new
remote_install field, to mark a remotely installed extension.
* A new DISABLE_REMOTE_INSTALL reason is added to track this state
locally.
* CrxInstaller::allow_silent_install is changed from a bool to a
three-state enum, where the options are:
- install after showing a permission prompt,
- install and grant all permissions without a prompt and
- install without a prompt and don't grant any permissions
* AddExtensionDisabledError is modified to keep track of the disable
reasons, and change the text that is displayed accordingly.
* ExtensionInstallPrompt has a new prompt type with different text
for remotely installed extensions.
BUG=365737
Review URL: https://codereview.chromium.org/264763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile.
Relanding patch: ShutdownStartupCycle failed in build [49353], this patch was speculatively reverted in r269383 [49355], but ShutdownStartupCycle failed again in [49362] after the revert had landed.
[49353] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49353
[49355] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49355
[49362] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49362
BUG=368684
TEST=Manual testing as described on http://crbug.com/368684#c1
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269343
Review URL: https://codereview.chromium.org/266343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/286113005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the updates to the blink side have been pushed through, we can use
ActivityLog with previous values for setters and for hrefs of anchor tags.
Add the logic to do so and update tests.
BUG=357204
Review URL: https://codereview.chromium.org/270623005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> A bunch of remaining parts of extension content verification
>
> -The real guts of content_hash_fetcher.cc, which fetches the
> verified_contents.json file from the webstore if needed and also runs
> tasks to compute and cache the block-level hashes of all files in an
> extension.
>
> -The real guts of content_hash_reader.cc, which uses the work done by
> the content_hash_fetcher during validation of extension file content as
> it's read off of disk at time of use.
>
> -Code to avoid verifying transcoded files (images used in browser
> process, and message catalogs).
>
> -Don't allow downgrade of mode via kForceFieldTrials command line switch
>
> -Various bits of plumbing to support all of the above
>
> BUG=369895
> R=rockot@chromium.org
>
> Review URL: https://codereview.chromium.org/289533003
TBR=asargent@chromium.org
Review URL: https://codereview.chromium.org/284223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reason for doing this is that user_prefs depends on content_browser,
which brings a lot of extra dependencies that takes a lot of time to build
(yeah, I'm looking at you Blink and V8) and bookmarks is one of the targets
that should not depend on content.
BUG=359565
TEST=green trybots
R=blundell@chromium.org, sky@chromium.org, yoz@chromium.org
Review URL: https://codereview.chromium.org/271793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
local file system.
Entries passed via FileHandler are contained in the isolated file system, so we
cannot obtain their parent directory or other entries in the same directory.
This CL adds an API to resolve isolated file system to a file entry in the local
file system.
BUG=358698
TEST=manually
Review URL: https://codereview.chromium.org/279163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-The real guts of content_hash_fetcher.cc, which fetches the
verified_contents.json file from the webstore if needed and also runs
tasks to compute and cache the block-level hashes of all files in an
extension.
-The real guts of content_hash_reader.cc, which uses the work done by
the content_hash_fetcher during validation of extension file content as
it's read off of disk at time of use.
-Code to avoid verifying transcoded files (images used in browser
process, and message catalogs).
-Don't allow downgrade of mode via kForceFieldTrials command line switch
-Various bits of plumbing to support all of the above
BUG=369895
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/289533003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a new key content_scripts[*].match_about_blank and
InjectionDetails.matchAboutBlank.
If true, content scripts will also be inserted in about:* frames
provided that its origin matches a pattern in the extension permissions.
BUG=76429,55084,146789
TEST=browser_tests: ExtensionApiTest.ContentScriptAboutBlank*:ScriptContextTest.GetEffectiveDocumentURL
Review URL: https://codereview.chromium.org/226663003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
MultipleArguments disagree with the result set from SetResult or result_.
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/277653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Switch from hexencoding to base64url encoding for the
treehash root hashes, because it saves a few bytes for each file
listed.
-To accomodate future improvements in the format, we're wrapping
the old format with a list plus outer dictionary. E.g. moving from
{ "payload": " ... ", "signatures": [ ... ] }
to
[
{
"description": " ... ",
"signed_content": { "payload": " ... ", "signatures": [ ... ] }
}
]
This way the server can offer signatures in both new and old formats, and
old clients will just use the old format and ignore anything else.
BUG=373063
Review URL: https://codereview.chromium.org/282753008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This new API returns a list of accounts signed in to the profile. The
first element of the list is always the primary account. Other accounts
are returned after, sorted by obfuscated gaia ID.
The API is currently available in dev channel. If the flag
--extensions-multi-account (or --new-profile-management) is enabled,
getAccounts will return all accounts. Otherwise only the primary account
is returned.
BUG=258515
Review URL: https://codereview.chromium.org/274853002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=rockot@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/287673003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=372243
BUG=362353
Review URL: https://codereview.chromium.org/288453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add the option to force extensions to request permission before running a script
(iff they requested all urls) to chrome:flags.
BUG=372244
BUG=362353
Review URL: https://codereview.chromium.org/275863004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
API is not implemented, just setting up the bindings.
Try jobs were run but constantly getting merge failures with histograms.xml, so adding no try flag.
NOTRY=true
BUG=372556
Review URL: https://codereview.chromium.org/267863005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=369895
Review URL: https://codereview.chromium.org/274243004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds an Extensions.LoadCreationFlags UMA histogram which logs an
aggregate of a user's extension's flags.
BUG=None
Review URL: https://codereview.chromium.org/240613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a split of https://codereview.chromium.org/279213002/, to avoid
merging issues.
It is almost impossible to land a CL adding histograms via CQ, without
a merging conflict.
TBR=isherman@chromium.org
TEST=Just histograms, no actual changes.
BUG=248427
Review URL: https://codereview.chromium.org/280783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a split of https://codereview.chromium.org/284443002/, to avoid
merging issues.
It is almost impossible to land a CL adding histograms via CQ, without
a merging conflict.
TBR=isherman@chromium.org
TEST=Just histograms, no actual changes.
BUG=248427
Review URL: https://codereview.chromium.org/288483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=isherman@chromium.org, kalman@chromium.org
BUG=346488
Review URL: https://codereview.chromium.org/232183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=367094
Review URL: https://codereview.chromium.org/278633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as interfaces.
BUG=367094
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/270323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ActiveScriptController tracks all running active scripts (content scripts and
scripts injected via tabs.executeScript), and, if the flag is enabled, ensures
an ExtensionAction is displayed in the location bar.
Next step: Require permission before executing scripts.
TBR=sky@chromium.org (mechanical, no-impact changes to c/b/ui)
BUG=362353
Review URL: https://codereview.chromium.org/270153004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Added classes for fetching/reading file hashes (.cc details are still
mostly stubs in this CL though)
-Added a delegate class for ContentVerifier to rework how clients interact
with it
-Added code in ContentVerifyJob that uses the hash reader class
BUG=369895
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/280013003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add an explicit check for whitelisting pepper/nacl
permissions based on importing a shared module, so a shared
module can potentially limit allowing import of its resources
and permissions its allowed.
You can still use nonsfi mode for Linux or ChromeOS by
passing in --enable-nacl-nonsfi-mode, but it is on for a
whitelisted set of extensions for ChromeOS without flags.
BUG=355141
TEST=deploy_chrome to daisy, test app which includes whitelisted module
Review URL: https://codereview.chromium.org/264923011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
read.
BUG=371897
R=rockot@chromium.org
TEST=ran UsbApiTest.TransferEvent under Dr. Memory
Review URL: https://codereview.chromium.org/275993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I accidentally got the base64 <-> base64url conversion stuff wrong
in https://codereview.chromium.org/278593005/.
BUG=369895
TBR=rockot@chromium.org
Review URL: https://codereview.chromium.org/273093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch enables WebContentsObserver::OnMessageReceived to receive
a reference to RenderFrameHost that received the message.
This allows passing of JavaBridgeDispatcherHostManager ownership from
WebContentsImpl to ContentViewCore and removing of some redundant
initialization code in JavaBridgeDispatcherHostManager, fixing
a long-standing TODO.
This patch also includes a fix for "Search Google for this image"
discovered shorly after the original patch has been landed.
BUG=371296
TBR=jam@chromium.org,benm@chromium.org,yoz@chromium.org,bauerb@chromium.org,fsamuel@chromium.org
Review URL: https://codereview.chromium.org/275873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for an optional |authuser| integer property
in the |details| object passed to beginInstallWithManifest3.
This value is propagated down to the WebstoreInstaller and used
to augment the CRX download request with a standard-ish
|authuser| query parameter corresponding to the index of the
installing user within a multi-login session.
BUG=371100
R=asargent@chromium.org
Review URL: https://codereview.chromium.org/270793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tentatively reverting to see if it fixes the browser_tests ShutdownStartupCycle failure.
> Unload all apps / extensions immediately when deleting a profile.
>
> Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile.
>
> BUG=368684
> TEST=Manual testing as described on http://crbug.com/368684#c1
>
> Review URL: https://codereview.chromium.org/266343002
TBR=scheib@chromium.org
Review URL: https://codereview.chromium.org/278093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile.
BUG=368684
TEST=Manual testing as described on http://crbug.com/368684#c1
Review URL: https://codereview.chromium.org/266343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The webstore will be vending a "verified_contents.json" file for
extensions hosted there that contains a signed list of expected
block hashes for the files contained in an extension.
This new class handles parsing/validation of that data.
BUG=369895
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/278593005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The only difference from the original change is a fix to manifest_guest.json
to prevent ChromeVox from breaking in guest mode. (I also added a new test to
cover that scenario and prevent future regressions.)
Original code review: https://codereview.chromium.org/106973003
BUG=278540,362442
TBR=thakis
Review URL: https://codereview.chromium.org/268823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
during a callback or event handler. The only reason this catches failures at
the moment is because such tests end up timing out.
BUG=370897
R=yoz@chromium.org
TBR=thakis@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/265843014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EXTENSION_FUNCTION_VALIDATE_TYPESAFE; make the former return a
"ValidationFailure" type with an operator for each required type, and delete
the latter.
BUG=365732
R=jyasskin@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/269153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This simplifies the template a bit by removing the
(now implied) hard_dep values and using the new
get_target_outputs function in lieu of
process_file_template.
BUG=None
TBR=yoz
Review URL: https://codereview.chromium.org/271613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is a part of a bigger CL:
https://codereview.chromium.org/246913003/
in order to avoid reoccuring conflicts while committing via CQ.
NOTRY=True
R=isherman@chromium.org
TBR=isherman@chromium.org
TEST=None
BUG=248427
Review URL: https://codereview.chromium.org/273683004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The basic idea is that the webstore will provide signed expected hashes
of file content that can be checked during runtime in the browser to
detect corruption due to disk errors or malware.
This CL has a lot of the high-level pieces, with several of the details
left out for subsequent CLs to make this one more easily digestible.
The design is that there is a ContentVerifier for each BrowserContext
which can be used anywhere we read from files inside an extension. It
vends out ContentVerifyJob's, which need to be informed of the bytes
read from each file, and will know how to check those against a set of
expected block hashes. If the job detects contents that don't match what
was expected, it will notify the verifier.
BUG=369895
R=rvargas@chromium.org, yoz@chromium.org
Review URL: https://codereview.chromium.org/266963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=361662
TEST=manually
R=asargent@chromium.org, asvitkine@chromium.org, rlp@chromium.org, xiyuan@chromium.org
TBR=asvitkine@chromium.org, jered@chromium.org
Review URL: https://codereview.chromium.org/267653005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Win and linux bots are failing. See crbug.com/371030 for more details.
Reverting to see if this CL is part of the cause.
> Pass RenderFrameHost to WebContentObservers' message handlers
>
> This patch enables WebContentsObserver::OnMessageReceived to receive
> a reference to RenderFrameHost that received the message.
>
> This allows passing of JavaBridgeDispatcherHostManager ownership from
> WebContentsImpl to ContentViewCore and removing of some redundant
> initialization code in JavaBridgeDispatcherHostManager, fixing
> a long-standing TODO.
>
> Review URL: https://codereview.chromium.org/253013002
TBR=mnaganov@chromium.org
Review URL: https://codereview.chromium.org/271863005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's suspected for breaking other browser tests. For more information,
see the failing win_chromium_rel try jobs in the code review!
> Add browser_test for extension app API with missing schema
>
> This is a simplified version of api_test/stubs. It touches all the parts
> of each chrome.foo.bar.baz API path and ensures they are defined. This
> catches cases where a developer adding an API to _api_features.json but
> did not provide a schema for them.
>
> BUG=369318
> TEST=added browser_tests ExtensionApiTest.StubsApp
> R=kalman@chromium.org
>
> Review URL: https://codereview.chromium.org/264923009
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/274803005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This completes the initial implementation of the desktop portion of the automation API. It hooks up the javascript side bindings and js side backing objects.
BUG=309681
NOTRY=true
Review URL: https://codereview.chromium.org/260593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269036 0039d316-1c4b-4281-b951-d872f2087c98
|