summaryrefslogtreecommitdiffstats
path: root/gfx
Commit message (Collapse)AuthorAgeFilesLines
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-311-4/+4
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* file_util: Get rid of file_util::AppendToPath in icon_util_unittest.cctfarina@chromium.org2010-07-303-46/+50
| | | | | | | | | | | | | | Use AppendASCII from FilePath API instead of the deprecated AppendToPath function. BUG=24672 TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3046020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54311 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to reland code reverted in r52599, to take another look at the page ↵pkasting@chromium.org2010-07-301-12/+3
| | | | | | | | | | | cycler data. There was a lot of noise in the previous data, and since the current page cycler t and t_ref times are close, I'm hoping to see something more conclusive. TBR=jar BUG=47227 TEST=none Review URL: http://codereview.chromium.org/3026032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54236 0039d316-1c4b-4281-b951-d872f2087c98
* Implement more rendering methods on Canvas.ben@chromium.org2010-07-294-32/+143
| | | | | | | | | | Translation in TileImageInt is still wonky. BUG=none TEST=see unittests Review URL: http://codereview.chromium.org/3014043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54220 0039d316-1c4b-4281-b951-d872f2087c98
* add gfx_resources.h to DEPSben@chromium.org2010-07-291-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54164 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage by adding forgotten fileben@chromium.org2010-07-291-0/+18
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54150 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for Radial Gradient Brush and Bitmap Brush to gfx::Canvas.ben@chromium.org2010-07-297-18/+274
| | | | | | | | | BUG=none TEST=see unittest Review URL: http://codereview.chromium.org/3058012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54148 0039d316-1c4b-4281-b951-d872f2087c98
* Add images for forthcoming brushes change so that the change will work on ↵ben@chromium.org2010-07-281-0/+0
| | | | | | | | | | the trybots. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54010 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2629-0/+29
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Use FRIEND_TEST_ALL_PREFIXES some more.phajdan.jr@chromium.org2010-07-261-3/+3
| | | | | | | | | TEST=compile BUG=44549 Review URL: http://codereview.chromium.org/3032025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53706 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for brushes to gfx::Canvas... right now just LinearGradientBrush.ben@chromium.org2010-07-238-1/+232
| | | | | | | | | | | A native brush is created by gfx::Canvas::CreateLinearGradientBrush wrapped in a gfx::Brush. When gfx::Brush is deleted the platform wrapper frees the native brush. BUG=none TEST=see unittest. Review URL: http://codereview.chromium.org/3038019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53534 0039d316-1c4b-4281-b951-d872f2087c98
* Fix transforms to be preconcat like skia so multiple transforms are ↵ben@chromium.org2010-07-212-4/+35
| | | | | | | | | | | accumulated with each call to TranslateInt/ScaleInt. BUG=none TEST=see unittest Review URL: http://codereview.chromium.org/3025010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53232 0039d316-1c4b-4281-b951-d872f2087c98
* Implement initial ClipRect.ben@chromium.org2010-07-216-53/+106
| | | | | | | | | | | Move IntersectsClipRectInt and GetClipRect functions to CanvasSkia private, since they are only used internally. BUG=none TEST=see unittest. Review URL: http://codereview.chromium.org/2959014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53218 0039d316-1c4b-4281-b951-d872f2087c98
* Remove <iostream> where possible.erg@google.com2010-07-204-5/+3
| | | | | | | | | | | | | <iostream> creates a static initializer. Most people don't need <iostream> anyway--they really need <ostream> for operator<< overloads. <iostream> should *never* be included in a header file; <iosfwd> exists for that purpose. BUG=none TEST=none Review URL: http://codereview.chromium.org/3014015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53083 0039d316-1c4b-4281-b951-d872f2087c98
* Implement spin buttons for <input type=number>tkent@chromium.org2010-07-162-0/+22
| | | | | | | | BUG=42179 TEST=None; will covered by layout tests. Review URL: http://codereview.chromium.org/2813050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52611 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 46492 to repair perf regression in XP single-core Moz Page Cyclerjar@chromium.org2010-07-161-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | | Actually, this only reverts the windows specific portion of 46492. Initial revert and restore (see revisions 52456 and 52441) seemed to show that this was indeed the cause of the regression. There was some problem with the perf bot, so I'm landing again to confirm that this removes the regression. As pointed out by pkasting, this is all browser side computation, but on a single core (as noted by Darin), browser processing becomes critical path (and can impact perf). My suspicioun is that the original code did some caching of its font metrics, and this was not (to the same extent??) being done in the replacement (centralized) code. If this does not provide the perf fix I'm expecting, I'll revert it. BUG=47227 TBR=pkasting Review URL: http://codereview.chromium.org/3023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52599 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Fix opacity of drag images.thakis@chromium.org2010-07-153-0/+54
| | | | | | | | | BUG=XXX TEST=Go to google.com, drag logo around. Preview image should now look nice. Review URL: http://codereview.chromium.org/2963009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52484 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52441 - Revert Win specific elements of 46492 to look for perf impactjar@chromium.org2010-07-151-12/+3
| | | | | | | | | | | | | | | | | | | | There was a regression in the moz page cycler around when landed. This was ONLY a single core regression, which suggests it was time spent in the browser becoming critical path. This change involved font layout in the browser, and so it MIGHT be related. I'll land this, let the per bots start their run, and then revert. TBR=pkasting Review URL: http://codereview.chromium.org/2895017 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/3018001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52456 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeOS build by putting back define from previous patch (triedbrettw@chromium.org2010-07-151-1/+1
| | | | | | | | | | incorrectly to clean this up). TEST=none BUG=none Review URL: http://codereview.chromium.org/2858054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52445 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function to scroll a platform canvas. This uses the platform scrollbrettw@chromium.org2010-07-155-8/+252
| | | | | | | | | | | functions when available, and on Linux implements a simple manual scroll function since Cairo/Skia doesn't provide one. BUG=none TEST=included unit test Review URL: http://codereview.chromium.org/2967008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52442 0039d316-1c4b-4281-b951-d872f2087c98
* Revert Win specific elements of 46492 to look for perf impactjar@chromium.org2010-07-151-3/+12
| | | | | | | | | | | | | | | | | There was a regression in the moz page cycler around when landed. This was ONLY a single core regression, which suggests it was time spent in the browser becoming critical path. This change involved font layout in the browser, and so it MIGHT be related. I'll land this, let the per bots start their run, and then revert. TBR=pkasting Review URL: http://codereview.chromium.org/2895017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52441 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some style issues in Rect I noticed.brettw@chromium.org2010-07-152-10/+3
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/2987005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52440 0039d316-1c4b-4281-b951-d872f2087c98
* Added XP specific path to NativeTheme::PaintProgressBar(). tkent@chromium.org2010-07-141-16/+62
| | | | | | | | | BUG=47734 TEST=none Patch by morrita@g Original code review: http://codereview.chromium.org/2984003/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52282 0039d316-1c4b-4281-b951-d872f2087c98
* Disablging failing ui tests: RestoreWindow and RestoreWindowAndTaboshima@chromium.org2010-07-131-2/+2
| | | | | | | | | | TBR=sky@chromium.org BUG=48911 TEST=none Review URL: http://codereview.chromium.org/2895012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52157 0039d316-1c4b-4281-b951-d872f2087c98
* Start implementing Direct2D Canvas. Implements Save/Restore methods, ↵ben@chromium.org2010-07-097-7/+483
| | | | | | | | FillRectInt and BeginPlatformPaint/EndPlatformPaint.http://crbug.com/48583TEST=see unittest Review URL: http://codereview.chromium.org/2939001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51996 0039d316-1c4b-4281-b951-d872f2087c98
* Makes menu draw disabled arrow the correct color for classic windows.sky@chromium.org2010-07-072-15/+37
| | | | | | | | | BUG=48099 TEST=see bug Review URL: http://codereview.chromium.org/2835033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51721 0039d316-1c4b-4281-b951-d872f2087c98
* Display warning banner in Win preferences dialog for managed options.mnissler@chromium.org2010-07-063-0/+11
| | | | | | | | | BUG=43423 TEST=box_layout_unittest.cc, manual UI tests. Review URL: http://codereview.chromium.org/2738002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51655 0039d316-1c4b-4281-b951-d872f2087c98
* Move WindowImpl to gfx so I can use it there for canvas unit tests.ben@chromium.org2010-07-023-0/+345
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2813042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51554 0039d316-1c4b-4281-b951-d872f2087c98
* Moves gtk accelerator processing functions to base/gtk_util so I cansky@chromium.org2010-07-011-31/+2
| | | | | | | | | | | | | use them from views and gfx. Sorry for the new patch on this and not an update. Not sure what happened. BUG=none TEST=none Review URL: http://codereview.chromium.org/2809047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51409 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring phase 4b:ben@chromium.org2010-06-303-0/+18
| | | | | | | | | | | Add BeginPlatformPaint/EndPlatformPaint calls to gfx::Canvas. BeginPlatformPaint() returns a gfx::NativeDrawingContext. BUG=none TEST=none Review URL: http://codereview.chromium.org/2840029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51297 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring Phase 4a:ben@chromium.org2010-06-293-0/+44
| | | | | | | | | | | Move Save, SaveLayerAlpha and Restore onto gfx::Canvas. BUG=none TEST=none Review URL: http://codereview.chromium.org/2846035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51179 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in showing accelerators where on views/gtk where we wouldsky@chromium.org2010-06-291-1/+35
| | | | | | | | | | | | incorrectly show the ampersand character in some situations, and in others show the underline when we shouldn't have. BUG=none TEST=none Review URL: http://codereview.chromium.org/2870032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51176 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: add more syncronization to GtkNativeViewIdManager to avoid a crash.estade@chromium.org2010-06-252-4/+13
| | | | | | | | | BUG=46197 TEST=manual (see bug) Review URL: http://codereview.chromium.org/2860024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50886 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 3.ben@chromium.org2010-06-2512-250/+230
| | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50854 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50784 - Canvas refactoring part 3.ben@chromium.org2010-06-2412-230/+250
| | | | | | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/2811032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50790 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50788 - fix linux bustageben@chromium.org2010-06-242-5/+3
| | | | | | | TBR=ben@chromium.org Review URL: http://codereview.chromium.org/2860023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50789 0039d316-1c4b-4281-b951-d872f2087c98
* fix linux bustageben@chromium.org2010-06-242-3/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50788 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 3.ben@chromium.org2010-06-2412-250/+230
| | | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50784 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 2.ben@chromium.org2010-06-238-210/+243
| | | | | | | | | | | | - Rename Canvas to CanvasSkia. - Create a subclass Canvas that inherits from CanvasSkia for compatibility. BUG=none TEST=none Review URL: http://codereview.chromium.org/2862025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50664 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 1.ben@chromium.org2010-06-224-167/+313
| | | | | | | | | | | - Introduce a new Canvas2 interface. This will become the way that everyone talks to Canvas. It is populated primarily with the cross-platform methods from Canvas. - Make Canvas implement this interface. - Hook it up to the Windows RootView. Review URL: http://codereview.chromium.org/2866010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50543 0039d316-1c4b-4281-b951-d872f2087c98
* Add const to two methods.jam@chromium.org2010-06-171-2/+2
| | | | | | Review URL: http://codereview.chromium.org/2867009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50111 0039d316-1c4b-4281-b951-d872f2087c98
* TTF: Enable disabled tests: ↵vandebo@chromium.org2010-06-161-3/+3
| | | | | | | | | | | | | FontTest.DeriveFont{ResizesIfSizeTooSmall,KeepsOriginalSizeIfHeightOk} Is there a reason these are disabled? It looks like they were just forgotten. TEST=none BUG=disabled tests Review URL: http://codereview.chromium.org/2839003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50055 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of DISALLOW_EVIL_CONSTRUCTORS macro usage in our code base.tfarina@chromium.org2010-06-071-1/+1
| | | | | | | | | | | TODO: Fix the remaining usages in third_party libraries and get rid of the macro in question. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2657005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49032 0039d316-1c4b-4281-b951-d872f2087c98
* Implement most of the ridealong fixes/cleanups I suggested during review for ↵pkasting@chromium.org2010-06-012-95/+59
| | | | | | | | | | enabling warn-on-signed-versus-unsigned-equality-comparisions on Windows. BUG=none TEST=none Review URL: http://codereview.chromium.org/2395001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48666 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will make mbelshe@chromium.org2010-05-271-3/+3
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2222002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Another dependency the bbot missed!!!"rafaelw@chromium.org2010-05-261-3/+3
| | | | | | | | | | | | | | | | | | This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98. Revert "Missed a file as part of checkin for r48186" This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b. Revert "Enable warning 4389 as an error on windows builds. This will make" This reverts commit c78936bcfc65b98edf288191d927a495b0364621. TBR=mbelshe Review URL: http://codereview.chromium.org/2253001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48238 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will makembelshe@chromium.org2010-05-251-3/+3
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
* - Draw glossy animation effect for determinate progress bartkent@chromium.org2010-05-192-32/+57
| | | | | | | | | | | | | | | | | | - Moved animation code for indeterminate bar from WebKit because adding change above makes webkit-side too complicated. Note: - This change depends https://webkit.org/b/39269 - Appearance of indeterminate bar remains incorrect. I filed it to http://crbug.com/44433. Patch by Hajime Morita <morrita@g> Original code review: http://codereview.chromium.org/2131008/show BUG=44430 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47618 0039d316-1c4b-4281-b951-d872f2087c98
* - Fix style issuetkent@chromium.org2010-05-171-12/+13
| | | | | | | | | | | - Rename ScopedRegionClipping to ScopedClipRegion TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/2083009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47393 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for HTML5 progress element. tkent@chromium.org2010-05-142-2/+62
| | | | | | | | | | | | | WebKit side of this change is on http://webkit.org/b/37308 . continued from http://codereview.chromium.org/1596018 Patch by Hajime Morita <morrita@g> Original code review: http://codereview.chromium.org/1988012/show BUG=none TEST=Covered by WebKit LayoutTests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47247 0039d316-1c4b-4281-b951-d872f2087c98